thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-12 17:32:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
99,873 Commits 9,328 Branches 1,783 Tags 2.1 GiB
c82bb1128f
Commit Graph

99873 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
f18ac40be5 Fix clang-tidy cert-dcl58-cpp in gtest_DecimalFunctions 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-23 07:44:37 +02:00
Alexey Milovidov
ebf330ca1a
Merge pull request #42573 from ClickHouse/remove-trash-6 
Remove trash
 2022-10-23 01:31:10 +02:00
Alexey Milovidov
6c69bdd34d
Merge pull request #42574 from ClickHouse/strange-date-monotonicity 
Fix strange code in date monotonicity
 2022-10-23 01:30:52 +02:00
Azat Khuzhin
3e5a90478e Fix clang-tidy issue in gtest_DecimalFunctions 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-22 23:32:27 +02:00
Azat Khuzhin
a63dee2763 Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32 2022-10-22 23:32:15 +02:00
Yakov Olkhovskiy
ab39fb88b1
Merge pull request #42550 from ClickHouse/cmake-llvm-libfuzzer 
add lib_fuzzer and lib_fuzzer_no_main to llvm-project build
 2022-10-22 16:57:35 -04:00
Azat Khuzhin
9a9bbac19b tests: avoid model overlap for obfuscator 
In case of stress tests it is possible, and there is LOGICAL_ERROR in
case of error, which will create core dump.

Actually on CI [1] there error was likely this:

    stress_test_run_17.txt:/usr/share/clickhouse-test/queries/1_stateful/00175_obfuscator_schema_inference.sh: line 18: /tmp/clickhouse-test/1_stateful/model.bin: No such file or directory

So the file had been removed by another concurrent test.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/42190/56bc85746fa0b553e43c2253250404cfcca46855/stress_test__ubsan_.html

Note, that actually it is enough just to change the name in this two
tests, however let's make them even more error-resistant.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-22 21:14:49 +02:00
Igor Nikonov
730a3ba849
Merge branch 'master' into igor/replicated_merge_tree_some_polishing 2022-10-22 19:54:09 +02:00
Robert Schulze
b746224217
Merge pull request #42554 from arenadata/ADQM-604 
Add support of Date32 arguments for dateName function
 2022-10-22 17:20:10 +02:00
Azat Khuzhin
56bc85746f Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32 
Conflicts:
- src/Interpreters/ProcessList.cpp
 2022-10-22 16:49:08 +02:00
Nikolai Kochetov
5c32cd157d
Merge pull request #42362 from ClickHouse/fix-race-condition-finish-cancel 
Fix data race in query finish/cancel
 2022-10-22 14:58:42 +02:00
Azat Khuzhin
e3e30a4457 Fix one clang-tidy issue 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-22 13:26:58 +02:00
Alexey Milovidov
7bf1f4cdfa Fix strange code in date monotonicity 2022-10-22 09:02:20 +02:00
Azat Khuzhin
dbb4f8216f Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32 
Conflicts:
- src/Functions/GregorianDate.h
 2022-10-22 08:20:05 +02:00
Alexey Milovidov
0bb91ed3b4 Add a test 2022-10-22 07:41:08 +02:00
Alexey Milovidov
7fc3cd7fb0 Fix error 2022-10-22 07:38:22 +02:00
Alexey Milovidov
cb611e698a Add tests 2022-10-22 07:38:03 +02:00
Alexey Milovidov
ef4b2b3f59 Remove trash 2022-10-22 07:25:37 +02:00
Nikolay Degterinsky
22f87e2bf9
Merge pull request #42549 from evillique/disks-better-logs 
Better logs in clickhouse-disks
 2022-10-22 04:31:44 +02:00
Alexey Milovidov
bc6762d613
Merge pull request #42565 from alexeyerm/other-functions.md-fix 
other-functions.md example fix
 2022-10-22 04:20:23 +02:00
Alexey Milovidov
acc96a5ace
Merge pull request #42464 from ClickHouse/julian_day_ubsan 
Fix UBSan report in Julian Day functions
 2022-10-22 04:15:12 +02:00
Nikolai Kochetov
80867cb1fe Add more trash. 2022-10-21 22:19:06 +00:00
Azat Khuzhin
4eeb7337ed Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32 
Conflicts:
- src/Common/intExp.h
- src/Functions/DateTimeTransforms.h
- src/Functions/FunctionsConversion.h
 2022-10-21 22:51:56 +02:00
Azat Khuzhin
bbcdedb945 Revert changes of hash functions signatures and fix callers 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 22:40:17 +02:00
Azat Khuzhin
905a95e166 Review fixes 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 22:40:13 +02:00
Alexey Milovidov
f64a48874a
Merge pull request #42197 from ClickHouse/add-test-658 
Add a test for #658
 2022-10-21 21:56:51 +02:00
Alexey Milovidov
592fbb3eaf
Merge pull request #42367 from ClickHouse/revert-40217 
Revert #40217
 2022-10-21 21:56:15 +02:00
Alexey Milovidov
3beace607b
Merge pull request #42465 from ClickHouse/decimal-asan 
Fix buffer overflow in Decimal scale
 2022-10-21 21:55:20 +02:00
Dan Roscigno
440af00c74
Merge pull request #42151 from ClickHouse/remove-misc-statements 
Docs: Remove obsolete misc page
 2022-10-21 13:48:53 -04:00
Kseniia Sumarokova
c0889e5832
Merge pull request #42418 from KinderRiven/max_cache_download_limit 
Supports limiting the size of cached data to avoid negative optimization
 2022-10-21 19:36:08 +02:00
alexeyerm
e1fccbd161
doc fix fix 2022-10-21 20:09:46 +03:00
alexeyerm
4b4d1e8a5d
doc fix fix 2022-10-21 20:09:19 +03:00
alexeyerm
9abfe76fbb
doc fix fix 2022-10-21 20:08:44 +03:00
alexeyerm
d25ecb9f0b
fix transform() example 2022-10-21 19:47:38 +03:00
alexeyerm
930c60d71e
fix transform() example 2022-10-21 19:45:37 +03:00
alexeyerm
95943dbdda
fix transform() example 2022-10-21 19:44:35 +03:00
Ilya Yatsishin
6e15b20c40
Merge pull request #42430 from qoega/llvm-15-for-gcc 2022-10-21 16:54:26 +02:00
Yakov Olkhovskiy
d285c9e7ff move libfuzzer to dedicated contrib/libfuzzer-cmake 2022-10-21 14:04:01 +00:00
Alexander Tokmakov
5ffd026261
Merge pull request #42529 from azat/tests/integration/fix-sanitizer-reports 
Fix sanitizer reports in integration tests
 2022-10-21 16:01:43 +03:00
Alexander Tokmakov
fae9d9c3ea
Merge pull request #42563 from ClickHouse/tavplubix-patch-7 
Temporarily disable flaky `test_replicated_merge_tree_hdfs_zero_copy`
 2022-10-21 16:00:35 +03:00
Alexander Tokmakov
1343f62e8f
Update test.py 2022-10-21 15:59:27 +03:00
Igor Nikonov
851f556d65 Remove unused parameter 2022-10-21 14:35:37 +02:00
Igor Nikonov
13d31eefbc Replicated merge tree polishing 
+ make read-only members const
+ reduce memory allocations
 2022-10-21 14:02:52 +02:00
Azat Khuzhin
1e739791a4 Fix type error in itoa (wrong static_cast<>) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
0365bc56aa Add backward compatiblity check for some functions 
* State of aggregate functions

This test goes though all aggregate functions that:
- has only one argument
- support string as an argument

And do a simple check by creating the aggregate state with one string.

Yes this is not covers everything (does not cover functions with
different number of arguments, types, different states in case of
multiple values - uniqCombined, but as for uniqCombined it will be
checked via uniqHLL12), but at least something.

And about type, String had been selected, since it more likely that
there will be used some hash function internally.

* Function(String)

Check every function which has only one argument, and it's type is
String.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
5094c0dd6d Fix clang-tidy performance-inefficient-vector-operation 
By some reason it appears only after static_cast<> was added [1]:

    /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp
    Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:351:21: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
    Oct 18 01:03:56                     symbols.push_back(root_node->nameAt(i));
    Oct 18 01:03:56                     ^
    Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:511:17: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
    Oct 18 01:03:56                 union_skip_fns.push_back(createSkipFn(root_node->leafAt(i)));
    Oct 18 01:03:56                 ^
    Oct 18 01:03:56 /build/src/Processors/Formats/Impl/AvroRowInputFormat.cpp:552:17: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
    Oct 18 01:03:56                 field_skip_fns.push_back(createSkipFn(root_node->leafAt(i)));
    Oct 18 01:03:56                 ^
    Oct 18 01:03:56 197965 warnings generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/42190/453d91fa3539882dcef1d5ecd5097747499572d8/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
3d400068fd tests/gtest_compressionCodec: fix UBSAN report to avoid test failure 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
2474303aef tests/gtest_compressionCodec: Fix UBSAN report about signed integer overflow 
UBSAN report:

    $ UBSAN_SYMBOLIZER_PATH=/usr/bin/llvm-symbolizer-14 UBSAN_OPTIONS=print_stacktrace=1 ./unit_tests_dbms --gtest_filter=*Gorilla*
    ../src/Compression/tests/gtest_compressionCodec.cpp:1216:47: runtime error: signed integer overflow: 23 * 100000000 cannot be represented in type 'int'
        #0 0x14f67fd1 in auto (anonymous namespace)::$_6::operator()(int) const::'lambda'(auto)::operator()<int>(auto) const build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1216:47
        #1 0x14f67fd1 in (anonymous namespace)::CodecTestSequence (anonymous namespace)::generateSeq<long, (anonymous namespace)::$_6::operator()(int) const::'lambda'(auto), int, int>((anonymous namespace)::$_6::operator()(int) const::'lambda'(auto), char const*, int, int) build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:394:36
        #2 0x14f67fd1 in auto (anonymous namespace)::GCompatibilityTestSequence<long>() build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1224:12
        #3 0x14f3c7f3 in (anonymous namespace)::gtest_GorillaCodecTestCompatibility_EvalGenerator_() build_docker/../src/Compression/tests/gtest_compressionCodec.cpp:1227:1
        #4 0x14f6bdb5 in testing::internal::ParameterizedTestSuiteInfo<(anonymous namespace)::CodecTestCompatibility>::RegisterTests() build_docker/../contrib/googletest/googletest/include/gtest/internal/gtest-param-util.h:553:45
        #5 0x27d87988 in testing::internal::ParameterizedTestSuiteRegistry::RegisterTests() build_docker/../contrib/googletest/googletest/include/gtest/internal/gtest-param-util.h:726:24
        #6 0x27d87988 in testing::internal::UnitTestImpl::RegisterParameterizedTests() build_docker/../contrib/googletest/googletest/src/gtest.cc:2805:34
        #7 0x27d87988 in testing::internal::UnitTestImpl::PostFlagParsingInit() build_docker/../contrib/googletest/googletest/src/gtest.cc:5492:5
        #8 0x27d9d002 in void testing::internal::InitGoogleTestImpl<char>(int*, char**) build_docker/../contrib/googletest/googletest/src/gtest.cc:6499:22
        #9 0x14fd5495 in main build_docker/../src/Coordination/tests/gtest_coordination.cpp:2189:5
        #10 0x7f8c29005209  (/lib/x86_64-linux-gnu/libc.so.6+0x29209) (BuildId: 71a7c7b97bc0b3e349a3d8640252655552082bf5)
        #11 0x7f8c290052bb in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x292bb) (BuildId: 71a7c7b97bc0b3e349a3d8640252655552082bf5)
        #12 0x14ce356d in _start (/work1/azat/tmp/42190/unit_tests_dbms+0x14ce356d) (BuildId: 482550e3f8d45f06e8c7f8147f427ee798c1f645)

    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/Compression/tests/gtest_compressionCodec.cpp:1216:47 in

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
784f7d988c Fix -Wshorten-64-to-32 in examples 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00
Azat Khuzhin
b8ab686561 tests/gtest_compressionCodec: fix for darwin 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:43 +02:00