Commit Graph

160861 Commits

Author SHA1 Message Date
Nikita Taranov
0b3f7d18ef fix 2024-12-11 16:46:02 +01:00
Sema Checherinda
673276ad45 fix view_level 2024-12-11 15:42:19 +01:00
János Benjamin Antal
52190355aa Do not modify original tree when flattening logical expressions 2024-12-11 14:22:13 +00:00
János Benjamin Antal
272e88d479 Use reference instead of non-nullable pointer 2024-12-11 14:21:43 +00:00
János Benjamin Antal
0fc5fe8468 Address minor review comments 2024-12-11 14:21:00 +00:00
Nikita Taranov
2bc96dc2da
Merge pull request #72993 from ClickHouse/fix_parallel_hash_with_additional_filter
Fix `parallel_hash` join with additional filters in `ON` clause
2024-12-11 14:20:14 +00:00
Nikita Taranov
fe55995e04 fix 2024-12-11 15:01:47 +01:00
Nikita Mikhaylov
34ee0f2364
Merge pull request #71870 from cwurm/patch-6
Format Settings: Better date_time_overflow_behavior
2024-12-11 13:50:24 +00:00
Pavel Kruglov
df235c39a7
Merge pull request #72808 from larry-cdn77/min-free-diskspace-bytes-to-insert-documentation-correction
Correct documentation for the min_free_disk_space settings
2024-12-11 13:38:50 +00:00
vdimir
bdefff4e3e
Lower PREWHERE log level 2024-12-11 13:27:25 +00:00
Nikita Taranov
f4d4ef9dbf impl 2024-12-11 14:24:55 +01:00
Raúl Marín
8e4bd548e4
Merge pull request #73081 from azat/mm-fix-accounting
Fix possible overestimate memory tracking
2024-12-11 13:11:11 +00:00
Raúl Marín
fb7cd9fa8b
Update src/Common/ThreadStatus.cpp 2024-12-11 14:09:56 +01:00
divanik
6a526a9d6f Resolve conflicts 2024-12-11 12:39:01 +00:00
Igor Nikonov
48a61c986b Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-11 12:29:40 +00:00
Igor Nikonov
a8c7992f60 Cleanup 2024-12-11 12:28:25 +00:00
Raúl Marín
ca2813bacf
Merge pull request #72969 from Algunenano/shared_mutex_other_os
Use absl::Mutex instead of std::shared_mutex on non-Linux OSs
2024-12-11 12:12:05 +00:00
Igor Nikonov
edb95473f8 Reduce tests output 2024-12-11 12:09:34 +00:00
Tuan Pham Anh
dc812aeb95 Reduce loop count, keeper_max_retries and keeper_retry_max_backoff_ms in test_replicated_merge_tree_s3_zero_copy::test_drop_table 2024-12-11 12:00:57 +00:00
Raúl Marín
130a2b16aa
Merge pull request #73083 from Algunenano/osx_icu
OSX: Build with ICU support
2024-12-11 11:49:36 +00:00
kssenii
4737618960 Fix 2024-12-11 12:20:56 +01:00
robot-clickhouse
170cdfdf08 Automatic style fix 2024-12-11 11:15:40 +00:00
Pavel Kruglov
06b1ef2c2d
Merge pull request #72989 from Avogar/dynamic-in-to-type-functions
Support Dynamic in functions toFloat64/touInt32/etc
2024-12-11 11:07:34 +00:00
Pavel Kruglov
33b8948a5c
Merge pull request #73043 from Avogar/fix-json-parsing-format-settings
Use default format settings during JSON parsing to avoid broken deserialization
2024-12-11 11:07:11 +00:00
Sema Checherinda
c0172f54cc fix new tests 2024-12-11 12:06:30 +01:00
Pavel Kruglov
66eecb112f
Merge pull request #73082 from Avogar/fix-tuple-duplicate-json-key
Check for duplicate JSON keys during Tuple parsing
2024-12-11 10:57:42 +00:00
Nikita Mikhaylov
88f7b53d8c
Merge pull request #72426 from ClickHouse/move-utils-to-programs
Moved utils to programs
2024-12-11 00:18:43 +00:00
Anton Popov
34b7207b76
Merge pull request #73017 from CurtizJ/add-test-for-block-number-mutation
Add tests for some mutations with enabled column `_block_number`
2024-12-10 23:18:26 +00:00
Igor Nikonov
30ec2056be Fix 03279_pr_3_way_joins_right_first 2024-12-10 22:06:13 +00:00
Igor Nikonov
020e7822a4 Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-10 22:03:23 +00:00
Igor Nikonov
072ec16067 Separated tests 2024-12-10 22:02:13 +00:00
Alexander Gololobov
bb1604d48c
Merge pull request #73049 from ClickHouse/preallocate_log_queue_buffer
Preallocate log queue buffer after flush to reduce number or (re)allocations when pushing new entires
2024-12-10 21:11:07 +00:00
Sema Checherinda
352e47ae64
Merge pull request #73080 from ClickHouse/chesema-rm-comments-2
remove commented code
2024-12-10 21:05:04 +00:00
Vitaly Baranov
e7df52d8a0
Merge pull request #72682 from vitlibar/add-retries-to-creating-replicated-table
Add retries to creating a replicated table
2024-12-10 21:04:36 +00:00
Igor Nikonov
457bb20d28 Better comment 2024-12-10 19:35:48 +00:00
Nikita Taranov
206d5153f7 add heavier test 2024-12-10 20:32:01 +01:00
avogar
1024bb9df5 Add comments 2024-12-10 19:19:09 +00:00
Igor Nikonov
2c4a0dd4c1 Reduce test 2024-12-10 19:18:19 +00:00
avogar
227346e7ae Rename method 2024-12-10 19:16:30 +00:00
avogar
7dc0811ffd Improve formatting of identifiers with JSON subcolumns 2024-12-10 19:15:57 +00:00
Igor Nikonov
25200543fc Remove test 2024-12-10 19:07:59 +00:00
Shichao Jin
098c8ac806
Merge pull request #73012 from gingerwizard/issue_2295
clarify compression options for table functions
2024-12-10 19:03:07 +00:00
kssenii
808e0395f0 Merge remote-tracking branch 'origin/master' into rest-catalog 2024-12-10 19:54:01 +01:00
kssenii
a5c5088f0c Merge remote-tracking branch 'origin/divanik/fix_bug_iceberg_json_equality_check' into rest-catalog 2024-12-10 19:53:56 +01:00
Azat Khuzhin
9072d1bd42 Fix possible overestimate memory tracking
Before this patch the untracked_memory was dumped before reseting the
current_thread which could lead to leaking some of untracked_memory in
`ThreadStatus::detachFromGroup` [1].

In particular I found that the local_data (which is 136 bytes) can be
"leaked" that way.

  [1]: 8999fdd95e/src/Interpreters/ThreadStatusExt.cpp (L292-L306)

This pops up on one of clusters where I noticed that the difference
between MemoryTracking and MemoryResident keeps growing over the time.
the difference grows ~200KiB per second - 16.5GiB per day.

That cluster has tons MVs triggered from Buffer/Distributed (i.e. now
query context), and this is indeed is the reason for leaking local_data,
since in this case there is no thread group in the query, and it is
created explicitly in `InterpreterInsertQuery::buildChain` [1].

  [1]: 20ccb638ba/src/Interpreters/InterpreterInsertQuery.cpp (L321)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-10 19:50:01 +01:00
kssenii
c2cf17c2dd Merge remote-tracking branch 'origin/master' into rest-catalog 2024-12-10 19:35:55 +01:00
kssenii
83ea4857ea Remove redundant 2024-12-10 19:26:10 +01:00
Kseniia Sumarokova
0235eed489
Merge pull request #73001 from ClickHouse/divanik/fix_bug_iceberg_json_equality_check
Make less strict assert when checking iceberg schema consistency
2024-12-10 18:24:29 +00:00
Igor Nikonov
64de1fb68f Mark the setting as obsolete 2024-12-10 18:21:23 +00:00
avogar
1d6c3629c6 Check for duplicate JSON keys during Tuple parsing 2024-12-10 16:52:07 +00:00