avogar
9291d33080
Pass const std::string_view & by value, not by reference
2022-07-14 16:11:57 +00:00
Anton Popov
d4cb2184c2
Merge branch 'master' into randomize-more-settings
2022-07-14 17:01:07 +02:00
jinjunzh
1c6d70f9b3
fixed sw job buffer missing
2022-07-13 16:12:15 -04:00
HarryLeeIBM
2caa3f8803
Fix LZ4 decompression issue for s390x
2022-07-13 11:45:58 -07:00
Wangyang Guo
f275b35bba
Dynamic dispatching for best_variant selection
2022-07-13 15:20:15 +08:00
jinjunzh
b699764bbe
unified sync implemetation with async
2022-07-12 14:32:53 -04:00
Anton Popov
3b45e6e347
fix reading of empty arrays in reverse order with uncompressed cache (addition to #36215 )
2022-07-12 03:08:12 +00:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
...
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.
As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.
In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).
(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
jinjunzh
bcba581191
fixed cosmetic issues
2022-07-11 12:08:35 -04:00
mergify[bot]
62c62a2df7
Merge branch 'master' into lz4-decompress-vbmi
2022-07-11 14:23:17 +00:00
jinjunzh
bc03e10870
make job pool static member to private
2022-07-09 17:50:57 -04:00
jinjunzh
bc775ecc5b
add assert for Illegal path
2022-07-09 17:29:47 -04:00
jinjunzh
044c14745e
make job pool name comprehensible
2022-07-09 17:17:18 -04:00
jinjunzh
eb06c66869
cosmetic issue
2022-07-09 14:57:38 -04:00
jinjunzh
816e974ca2
rename deflate to deflate_qpl
2022-07-09 14:42:01 -04:00
jinjunzh
825b7511e4
improve cosmetics
2022-07-09 14:13:12 -04:00
jinjunzh
7cb5b35bef
remove qpl from fasttest
2022-07-09 13:54:23 -04:00
jinjunzh
212f342af5
change to std random
2022-07-09 12:03:25 -04:00
jinjunzh
0fdce07cc6
add dedicated value for HW codec fail
2022-07-09 11:12:41 -04:00
jinjunzh
545e6b305c
improve log print text
2022-07-09 10:09:23 -04:00
jinjunzh
46d7d3b5c9
constant always goes to the right side
2022-07-08 15:03:10 -04:00
jinjunzh
289c6148e4
member to be LOWERCASE_UNDERSCORE
2022-07-08 12:20:24 -04:00
jinjunzh
7eb71143db
add a one-line method for resetting a job lock
2022-07-08 12:09:58 -04:00
jinjunzh
7a3c21174d
use C++17 if initializer
2022-07-08 11:55:16 -04:00
jinjunzh
6045681bb4
improve jobPoolReady
2022-07-07 17:21:51 -04:00
jinjunzh
5681e50da8
improve job pool initialization
2022-07-07 17:13:20 -04:00
jinjunzh
2c8f308bbc
improve buffer allocation
2022-07-07 16:05:52 -04:00
jinjunzh
29fee729e3
revise the way of get job size
2022-07-07 15:17:23 -04:00
jinjunzh
2765e2a259
remove unused function in deflate job pool
2022-07-07 14:44:42 -04:00
jinjunzh
f80aea9eac
Cosmetic issue and improve flush function
2022-07-07 14:14:47 -04:00
jinjunzh
ad82bb80ed
Cosmetic: Constants to be UPPERCASE_AND_UNDERSCORE
2022-07-07 12:10:06 -04:00
jinjunzh
85eae40765
remove inline due to negligible benefits
2022-07-07 10:26:57 -04:00
jinjunzh
43c5a68d14
Cosmetic work
2022-07-07 10:04:17 -04:00
jinjunzh
6fa036f6ee
remove qpl from clickhouse-keeper
2022-07-06 23:48:09 -04:00
jinjunzh
3422c0479d
add more comments for flush
2022-07-06 23:31:22 -04:00
jinjunzh
4cdc660406
change flush name to be more descriptive
2022-07-06 21:37:11 -04:00
jinjunzh
7b262b62c2
restore decompress to be const
2022-07-06 18:34:31 -04:00
jinjunzh
567f90d8a4
add CodecMode for deflate codec
2022-07-06 18:18:55 -04:00
jinjunzh
fbe3d84860
revise typo issue
2022-07-05 15:29:53 -04:00
jinjunzh
ba38969e9c
enable qpl for clickhouse-keeper build
2022-07-05 15:28:41 -04:00
jinjunzh
fe451a4317
remove compress sync interface
2022-06-28 22:52:11 -04:00
jasperzhu
b2f98fa73b
Merge branch 'master' into dev_intel_iaa_deflate
2022-06-27 10:21:21 +08:00
alesapin
50801e41c5
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-19 14:05:46 +02:00
Anton Popov
1523c9c9e5
fix filling of empty Nested + small refactoring
2022-06-17 01:10:52 +00:00
Anton Popov
92b7b9789a
try to fix fpc codec
2022-06-16 03:41:09 +02:00
jasperzhu
bca18b2caf
Merge branch 'master' into dev_intel_iaa_deflate
2022-06-16 08:56:27 +08:00
Nikolai Kochetov
2a9a63ac7b
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-15 15:35:26 +02:00
Robert Schulze
a0d936cc9f
Small follow-up for FPC codec
...
- add paper reference + doxygen
- remove endianness handling (ClickHouse assumes little endian)
- documentation
- other minor stuff
2022-06-15 14:21:28 +02:00
jinjunzh
1236d74ae7
restructure code design to be compatible both of hardware and software codec
2022-06-08 11:47:44 -04:00
jinjunzh
2b684ff40e
remove sw job pool
2022-06-08 09:28:35 -04:00
koloshmet
d5064dd5b5
so many improvements
2022-06-08 02:17:34 +03:00
Wangyang Guo
50ac01c9b8
Enable copyOverlap32Shuffle
2022-06-06 13:45:19 +08:00
Wangyang Guo
c9ff52f2e9
Add VBMI optimized copyOverlap32Shuffle
2022-06-06 13:45:01 +08:00
jinjunzh
c7ca746994
fixed build issues in clickhouse-keeper
2022-06-05 14:46:28 -04:00
jinjunzh
2170a99484
revise ENABLE_QPL_COMPRESSION build option
2022-06-03 21:06:55 -04:00
Nikolai Kochetov
89c5855d20
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-02 12:19:07 +02:00
jinjunzh
e1426c7e9d
add build option for iaa compression
2022-06-01 11:47:43 -04:00
jinjunzh
53be924537
fixed invalid case style
2022-05-31 15:40:31 -04:00
jasperzhu
fc03af2259
Merge branch 'master' into dev_intel_iaa_deflate
2022-05-30 17:49:04 +08:00
koloshmet
7e69779575
added fpc codec to float perftest
2022-05-26 22:32:56 +03:00
koloshmet
821100f145
code style fixes
2022-05-26 11:09:36 +03:00
koloshmet
1bfeb982af
fixed decoding parameters
2022-05-26 06:58:34 +03:00
koloshmet
cd3e28e3b1
fixed decoding parameters
2022-05-26 06:53:48 +03:00
koloshmet
adf888811c
fixed max size computation
2022-05-26 04:53:07 +03:00
koloshmet
0697b9ffcf
FPC codec
2022-05-25 22:04:39 +03:00
Maksim Kita
168814ed78
Merge pull request #37442 from kitaisreal/compressed-write-buffer-added-comment
...
CompressedWriteBuffer added comment
2022-05-23 23:44:33 +02:00
Maksim Kita
3a22d8ef2c
CompressedWriteBuffer added comment
2022-05-23 12:09:44 +02:00
Robert Schulze
0f6715bd91
Follow-up to PR #37300 : semicolon warnings
...
In PR #37300 , Alexej asked why we the compiler does not warn about
unnecessary semicolons, e.g.
f()
{
}; // <-- here
The answer is surprising: In C++98, above syntax was disallowed but by
most compilers accepted it regardless. C++>11 introduced "empty
declarations" which made the syntax legal.
The previous behavior can be restored using flag
-Wc++98-compat-extra-semi. This finds many useless semicolons which were
removed in this change. Unfortunately, there are also false positives
which would require #pragma-s and HAS_* logic (--> check_flags.cmake) to
suppress. In the end, -Wc++98-compat-extra-semi comes with extra effort
for little benefit. Therefore, this change only fixes some semicolons
but does not enable the flag.
2022-05-20 15:06:34 +02:00
Maksim Kita
495e04d2c3
Merge pull request #37242 from jinjunzh/insert_improve_jsp
...
Improve CompressedWriteBuffer to avoid unnecessary memcpy
2022-05-19 10:59:35 +02:00
jinjunzh
f413b49364
fixed logger header file path
2022-05-16 14:59:16 -04:00
Maksim Kita
fd28c19c1c
Update CompressedWriteBuffer.cpp
2022-05-16 20:44:22 +02:00
jinjunzh
f334cd371f
fixed code style issue
2022-05-16 17:21:20 -04:00
jinjunzh
2ae9e22248
Improve CompressedWriteBuffer to avoid unnecessary memcpy
2022-05-16 16:22:13 -04:00
jinjunzh
9309735016
remove unused job release call
2022-05-10 16:46:50 -04:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
...
Official docs:
Some headers from C library were deprecated in C++ and are no longer
welcome in C++ codebases. Some have no effect in C++. For more details
refer to the C++ 14 Standard [depr.c.headers] section. This check
replaces C standard library headers with their C++ alternatives and
removes redundant ones.
2022-05-09 08:23:33 +02:00
Nikolai Kochetov
35095191eb
Merge branch 'master' into refactor-something-in-part-volumes
2022-05-03 17:51:47 +02:00
jasperzhu
7f47e9b934
Merge branch 'master' into dev_intel_iaa_deflate
2022-05-03 15:47:57 +08:00
jasperzhu
f4b275c4ac
Improve decompression in readbig to avoid unnecessary memcpy ( #36095 )
2022-05-02 15:06:52 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
jinjunzh
8788185e82
fixed typos issue in code
2022-04-27 10:52:44 -04:00
Nikolai Kochetov
e44af67fee
Merge branch 'master' into refactor-something-in-part-volumes
2022-04-26 21:08:00 +02:00
jasperzhu
05769b4a9c
Merge branch 'master' into dev_intel_iaa_deflate
2022-04-26 16:30:27 +08:00
jinjunzh
68a7e4b9b5
preliminary patch for iaa deflate solution
2022-04-26 14:14:09 -04:00
Nikolai Kochetov
8c00692844
Part 8
2022-04-22 16:58:09 +00:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
...
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Anton Popov
0595b5c22b
fix reading of empty arrays in reverse order
2022-04-13 21:50:57 +00:00
Nikolai Kochetov
5a1392a8e3
Try refactor something (1)
2022-04-05 19:12:48 +00:00
alesapin
77e700b1cf
Update src/Compression/CompressionFactory.cpp
2022-03-28 11:25:08 +02:00
alesapin
a4ab73619f
Fix UBSan build
2022-03-22 15:05:31 +01:00
Maksim Kita
65c52298b6
Fix clang-tidy warnings in Compression, Coordination, Core folders
2022-03-14 18:17:35 +00:00
kssenii
5260822964
Merge master
2022-03-08 18:21:28 +01:00
kssenii
e231c3a3e0
Fix split build
2022-03-08 18:05:55 +01:00
Maksim Kita
b1a956c5f1
clang-tidy check performance-move-const-arg fix
2022-03-02 18:15:27 +00:00
Amos Bird
ba19c7cf44
Slightly better interface of compressed buffer
2022-02-17 14:31:22 +08:00
alesapin
02a93cb852
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-08 19:42:27 +03:00
Anton Popov
1b16db72c3
fix consecutive backward seeks in seekable read buffers
2022-02-07 17:20:26 +03:00
alesapin
ba28c2c013
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-07 12:44:56 +03:00
Anton Popov
10b8684003
fix rare bug in reading of empty arrays
2022-02-06 20:45:59 +00:00
alesapin
18f08ed932
Revert "Revert "Add func tests run with s3""
2022-02-01 10:20:06 +03:00
alexey-milovidov
cbfcd45be3
Revert "Add func tests run with s3"
2022-02-01 05:46:13 +03:00
alesapin
5be3968526
Fix bug in cache compressed read buffer
2022-01-31 13:40:26 +03:00
alesapin
ea8ec87b34
Fix stupid bug
2022-01-30 21:03:12 +03:00
Azat Khuzhin
a773e7ff01
Remove unbundled libpqxx support
2022-01-20 10:01:59 +03:00
Azat Khuzhin
8485abd52b
Remove unbundled lz4 support
2022-01-20 08:47:16 +03:00
Anton Popov
54f51444c0
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-01 15:49:02 +03:00
Anton Popov
120cb79bac
Merge pull request #31826 from CurtizJ/fix-uncompressed-cache
...
Fix reading with uncompressed cache
2021-11-27 17:36:52 +03:00
alexey-milovidov
83391977f8
Merge pull request #31896 from Algunenano/parser_deps
...
Reduce the files that depend on parser headers
2021-11-27 00:18:31 +03:00
Raúl Marín
91bf938075
Reduce dependencies on ASTLiteral.h
...
590 -> 537
2021-11-26 17:54:57 +01:00
Raúl Marín
051dddd8df
Reduce dependencies on ASTIdentifier.h
...
Goes from rebuilding 483 objects to 165 when it's modified
2021-11-26 16:49:40 +01:00
Anton Popov
923159d408
fix typos
2021-11-26 17:47:40 +03:00
Anton Popov
c3f076fd84
fix reading with uncompressed cache
2021-11-25 21:20:03 +03:00
Kruglov Pavel
d9c1a0c8ec
Merge branch 'master' into fix-write-buffers
2021-11-20 17:48:24 +03:00
Vladimir Smirnov
48451182f8
Initial support for risc-v
...
Make ClickHouse compilable and runnable on risc-v 64
So far only basic functionality was tested (on real hw),
clickhouse server runs, exceptions works, client works,
simple tests works.
What doesn't work:
1. traces - they are always empty
2. system.stack_trace only have first frame
2021-11-11 19:23:34 +01:00
avogar
51831afff8
Fix tests
2021-11-11 20:27:23 +03:00
avogar
c521a9131a
Small refactoring of WriteBiffer-s
2021-11-11 02:11:18 +03:00
Anton Popov
d50137013c
Merge remote-tracking branch 'upstream/master' into HEAD
2021-11-01 16:55:53 +03:00
Anton Popov
0099dfd523
refactoring of SerializationInfo
2021-10-29 20:21:02 +03:00
Filatenkov Artur
44b5dd1161
Refactoring in codec encrypted ( #30564 )
...
* refactoring
* remove mistake in docs
2021-10-29 11:44:28 +03:00
kssenii
7e2ea97e3c
Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read
2021-10-28 18:46:21 +03:00
Alexey Milovidov
8b4a6a2416
Remove cruft
2021-10-28 02:10:39 +03:00
kssenii
52296e8b04
Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read
2021-10-25 00:22:32 +03:00
Azat Khuzhin
258b62d375
Remove one unused CompressedReadBufferFromFile ctor
2021-10-24 18:58:22 +03:00
Azat Khuzhin
93c34824c0
Fix explicit 0 size for createReadBufferFromFileBase()
2021-10-24 18:58:22 +03:00
kssenii
39b9e9c258
Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read
2021-10-22 15:40:41 +03:00
kssenii
56f0560c46
Asserts and read till end option
2021-10-21 20:54:03 +03:00
kssenii
31cd71c849
Clean up
2021-10-20 09:37:18 +03:00
kssenii
143e912e4e
Fix split build
2021-10-19 22:45:46 +03:00
kssenii
49106f407f
Fix some checks
2021-10-19 09:34:27 +03:00
kssenii
d5d4817350
Add disk proxies back, add setReadUntilPosition to ReadBuffer
2021-10-18 18:35:11 +03:00
kssenii
3995506d37
Adjust range reader for remote fs reads
2021-10-15 11:36:26 +03:00
Anton Popov
92413aed68
better interfaces for IDataType and ISerialization
2021-10-14 05:36:49 +03:00
Kseniia Sumarokova
185d58a7cc
Merge pull request #29766 from ClickHouse/remove_redundant_seeks
...
Less seeks in compressed buffers
2021-10-07 17:04:50 +03:00
alesapin
621c9884fc
Account offset in readBig call
2021-10-06 12:39:54 +03:00
Filatenkov Artur
dc657a2c5e
Add error for multiple keys without current_key_id ( #29546 )
...
* add error for multiple keys without current_key_id
* add exception if one key with non zero id is used without current_key_id
* refactoring
2021-10-05 14:37:54 +03:00
alesapin
64158c011b
Remove logging
2021-10-05 13:12:31 +03:00
alesapin
c2f34928e0
Fixup
2021-10-05 13:04:44 +03:00
alesapin
3a8126372c
Remove redundant header
2021-10-05 12:19:04 +03:00
alesapin
8186339307
Less seeks in compressed buffers
2021-10-05 12:11:25 +03:00
Denis Glazachev
ca7b69b0f3
Manipulate with -Wreserved-identifier only if HAS_RESERVED_IDENTIFIER has been detected
2021-10-03 17:42:36 +04:00
Mike Kot
65e6e211b4
Merge remote-tracking branch 'upstream/master' into improvement/fn-traits
2021-10-02 21:37:50 +02:00
Maksim Kita
395119339f
Merge branch 'master' into rename-common
2021-10-02 17:15:10 +03:00
Mike Kot
5d38930a3c
Fixing gcc build due to a bug in compiler
2021-10-02 14:27:52 +02:00
Alexey Milovidov
2ad5dbdfe8
Rename "common" to "base"
2021-10-02 11:30:38 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
alexey-milovidov
f21ea8f160
Update CompressedReadBufferBase.cpp
2021-10-02 06:13:46 +03:00
Yatsishin Ilya
2c0071bc6d
wip
2021-10-01 09:32:54 +03:00
Alexey Milovidov
cd7f9d981c
Remove ya.make
2021-09-25 04:22:54 +03:00
Nikita Mikhaylov
58f2504a56
Update ya.make
2021-09-14 12:00:32 +00:00
Nikita Mikhaylov
4b3c0a95d1
Merge pull request #28046 from syominsergey/fix-build-clang-13-2
...
[WIP] Improve support for build with clang-13
2021-09-13 12:11:38 +03:00
Filatenkov Artur
c23fe5baf6
Improve codec for encr 19896 ( #27476 )
...
* change syntax of encrypted command
* commit all encrypted changes
* correct encryption
* correct config for test
* add tests and correct code style and typos
* correct test
* fix unbundled build
* add log warning messages
* improve code according to review comments
* correct nonce
* correct errors found by fuzzing
* improve codec AES_128_GCM_SIV. Add AES_256_GCM_SIV. Add sections for last in tests. Improve documentation
* Update CompressionCodecEncrypted.h
* Update 01683_codec_encrypted.sql
* correct compression factory after changes in master
* correct behavior with wrong key in data
* correct fuzzer
* add connection for fuzzer with fix for compression_encrypted
* refactor code
* add load from config with throwing errors on server start
* fix typos and check style
* Update Server.cpp
* correct loading and reading
* refactor code. fix uninitialized value
* refactor code
* move defines from server to cpp file
* correct build
* remove repeated code
* correct namespace
* fix code style
2021-09-13 11:25:36 +03:00
