Commit Graph

7911 Commits

Author SHA1 Message Date
Arthur Passos
b6e205dcdf
Add ClickHouse setting to disable tunneling for HTTPS requests over HTTP proxy (#55033)
* initial commit. integ tests passing, need to re-run unit & my own personal tests

* partial refactoring to remove Protocol::ANY

* improve naming

* remove all usages of ProxyConfiguration::Protocol::ANY

* fix ut

* blabla

* support url functions as well

* support for HTTPS requests over HTTP proxy with tunneling off

* remove gtestabc

* fix silly mistake

* ...

* remove usages of httpclientsession::proxyconfig in src/

* got you

* remove stale comment

* it seems like I need reasonable defaults

* fix ut

* add some comments

* remove no longer needed header

* matrix out

* add https over http proxy with no tunneling

* soem docs

* partial refactoring

* rename to use_tunneling_for_https_requests_over_http_proxy

* improve docs

* use shorter version

* remove useless test

* rename the setting

* update

* fix typo

* fix setting docs typo

* move ); up

* move ) up
2023-11-04 13:47:52 -04:00
vdimir
a70d0c5203
Merge pull request #56264 from azat/rocksdb/block-based-table-options
Add ability to specify BlockBasedTableOptions for rocksdb
2023-11-03 10:15:19 +01:00
vdimir
55a1baf029
Merge pull request #56022 from ClickHouse/vdimir/check_all_tables
Add CHECK query for all the tables
2023-11-03 10:10:42 +01:00
Alexander Tokmakov
e88fa10aa2
Merge pull request #56142 from ClickHouse/make_replicated_start_more_robust
Better process broken parts on table start for replicated tables
2023-11-02 20:11:22 +01:00
Alexander Tokmakov
76e6b75ae2
Merge pull request #56214 from ClickHouse/hide-setup-plan
Improve integrations tests
2023-11-02 16:59:40 +01:00
Azat Khuzhin
decf85baca Add ability to specify BlockBasedTableOptions for rocksdb
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-02 15:36:00 +01:00
Raúl Marín
39163b4e31
Merge pull request #56175 from amosbird/fix-flaky-jbod-balancer
Fix flaky test of jbod balancer.
2023-11-02 13:19:21 +01:00
Mikhail f. Shiryaev
28463cdcd3
Do not print --setup-plan to integration tests logs 2023-11-02 08:50:03 +01:00
Alexander Sapin
abc1dfc203 Fix test 2023-11-01 20:38:09 +01:00
Amos Bird
aea0c8dddc
Add wait_until_fully_merged. 2023-11-02 01:50:09 +08:00
robot-clickhouse
2a24d15204 Automatic style fix 2023-11-01 16:06:24 +00:00
Alexander Sapin
bfcd8b7de5 Better logging and tests 2023-11-01 16:50:02 +01:00
Azat Khuzhin
c25d6cd624
Rename directory monitor concept into background INSERT (#55978)
* Limit log frequence for "Skipping send data over distributed table" message

After SYSTEM STOP DISTRIBUTED SENDS it will constantly print this
message.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename directory monitor concept into async INSERT

Rename the following query settings (with preserving backward
compatiblity, by keeping old name as an alias):
- distributed_directory_monitor_sleep_time_ms -> distributed_async_insert_sleep_time_ms
- distributed_directory_monitor_max_sleep_time_ms -> distributed_async_insert_max_sleep_time_ms
- distributed_directory_monitor_batch -> distributed_async_insert_batch_inserts
- distributed_directory_monitor_split_batch_on_failure -> distributed_async_insert_split_batch_on_failure

Rename the following table settings (with preserving backward
compatiblity, by keeping old name as an alias):
- monitor_batch_inserts -> async_insert_batch
- monitor_split_batch_on_failure -> async_insert_split_batch_on_failure
- directory_monitor_sleep_time_ms -> async_insert_sleep_time_ms
- directory_monitor_max_sleep_time_ms -> async_insert_max_sleep_time_ms

And also update all the references:

    $ gg -e directory_monitor_ -e monitor_ tests docs | cut -d: -f1 | sort -u | xargs sed -e 's/distributed_directory_monitor_sleep_time_ms/distributed_async_insert_sleep_time_ms/g' -e 's/distributed_directory_monitor_max_sleep_time_ms/distributed_async_insert_max_sleep_time_ms/g' -e 's/distributed_directory_monitor_batch_inserts/distributed_async_insert_batch/g' -e 's/distributed_directory_monitor_split_batch_on_failure/distributed_async_insert_split_batch_on_failure/g' -e 's/monitor_batch_inserts/async_insert_batch/g' -e 's/monitor_split_batch_on_failure/async_insert_split_batch_on_failure/g' -e 's/monitor_sleep_time_ms/async_insert_sleep_time_ms/g' -e 's/monitor_max_sleep_time_ms/async_insert_max_sleep_time_ms/g' -i

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename async_insert for Distributed into background_insert

This will avoid amigibuity between general async INSERT's and INSERT
into Distributed, which are indeed background, so new term express it
even better.

Mostly done with:

    $ git di HEAD^ --name-only | xargs sed -i -e 's/distributed_async_insert/distributed_background_insert/g' -e 's/async_insert_batch/background_insert_batch/g' -e 's/async_insert_split_batch_on_failure/background_insert_split_batch_on_failure/g' -e 's/async_insert_sleep_time_ms/background_insert_sleep_time_ms/g' -e 's/async_insert_max_sleep_time_ms/background_insert_max_sleep_time_ms/g'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Mark 02417_opentelemetry_insert_on_distributed_table as long

CI: https://s3.amazonaws.com/clickhouse-test-reports/55978/7a6abb03a0b507e29e999cb7e04f246a119c6f28/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-01 15:09:39 +01:00
Kruglov Pavel
5533258091
Merge pull request #55477 from Avogar/streaming-errors
Allow to save unparsed records and errors in RabbitMQ, NATS and FileLog engines
2023-11-01 14:35:35 +01:00
Amos Bird
c75cd615c3
Fix flaky test of jbod balancer. 2023-10-31 23:03:55 +08:00
Kseniia Sumarokova
b57906609c
Merge pull request #56011 from kssenii/fix-flaky-s3-queue-test
test_storage_s3_queue - add debug info
2023-10-31 11:25:02 +01:00
Kruglov Pavel
50c53fdbfd
Increase number of attempts in test 2023-10-30 20:51:03 +01:00
Raúl Marín
19c2ad5c9b
Merge pull request #56116 from azat/tests/fix-test_format_schema_on_server
Fix test_format_schema_on_server flakiness
2023-10-30 12:02:14 +01:00
Kseniia Sumarokova
41e2111534
Merge branch 'master' into fix-flaky-s3-queue-test 2023-10-30 11:24:12 +01:00
Azat Khuzhin
b87ebb2a83 Fix test_format_schema_on_server flakiness
Sometimes the requests library detect the encoding incorrectly, and
because this test compares binary data it fails.

Here is an example of successfull attempt:

    2023-10-30 07:32:37 [ 654 ] DEBUG : http://172.16.1.2:8123 "GET /?query=SELECT+%2A+FROM+test.simple+FORMAT+Protobuf+SETTINGS+format_schema%3D%27simple%3AKeyValuePair%27 HTTP/1.1" 200 None (connectionpool.py:546, _make_request)
    2023-10-30 07:32:37 [ 654 ] DEBUG : Encoding detection: utf_8 will be used as a fallback match (api.py:480, from_bytes)
    2023-10-30 07:32:37 [ 654 ] DEBUG : Encoding detection: Found utf_8 as plausible (best-candidate) for content. With 0 alternatives. (api.py:487, from_bytes)

And here is failed [1]:

    2023-10-29 18:12:56 [ 525 ] DEBUG : http://172.16.9.2:8123 "GET /?query=SELECT+%2A+FROM+test.simple+FORMAT+Protobuf+SETTINGS+format_schema%3D%27message_tmp%3AMessageTmp%27 HTTP/1.1" 200 None (connectionpool.py:547, _make_request)
    2023-10-29 18:12:56 [ 525 ] DEBUG : Encoding detection: Found utf_16_be as plausible (best-candidate) for content. With 1 alternatives. (api.py:487, from_bytes)
    E       AssertionError: assert '܈Ē͡扣܈Ȓͤ敦' == '\x07\x08\x01\x12\x03abc\x07\x08\x02\x12\x03def'
    E         - abcdef
    E         + ܈Ē͡扣܈Ȓͤ敦

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/56030/c7f392500e93863638c9ca9bd56c93b3193091f3/integration_tests__release__[3_4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-30 08:45:47 +01:00
Azat Khuzhin
c7f392500e Fix incorrect free space accounting for least_used JBOD policy
Before least_used fails to detect when the disk started to have more
space, it works only when the disk starts to have less space.

The reason for this is that it uses priority_queue, and once the disk
goes at the bottom of the queue, free space will not be updated for it
until it will be selected again.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-29 17:36:31 +01:00
Alexey Milovidov
243499aad1
Merge pull request #55796 from ClickHouse/Fix_azurite_port
Fix azurite port issue
2023-10-28 00:40:24 +02:00
vdimir
60c93cefbe
Add test for CHECK ALL TABLES 2023-10-27 15:22:11 +00:00
Kseniia Sumarokova
8984ba9c7e
Merge branch 'master' into fix-flaky-s3-queue-test 2023-10-27 14:14:24 +02:00
Konstantin Bogdanov
ecafc77e0f
Merge pull request #55521 from ClickHouse/fix-query-params-with-custom-http-handlers
Fix Query Parameters not working with custom HTTP handlers
2023-10-26 18:34:37 +02:00
kssenii
5d700605a5 Merge remote-tracking branch 'upstream/master' into fix-flaky-s3-queue-test 2023-10-26 17:18:26 +02:00
Alexander Tokmakov
fa963d60d0
Merge pull request #55641 from evillique/resubmit-cluster-groups
Resubmit #54421
2023-10-26 15:53:53 +02:00
helifu
4015176d27
A small fix (#55938) 2023-10-26 13:19:58 +02:00
robot-clickhouse
c4d498f961 Automatic style fix 2023-10-26 09:57:22 +00:00
Smita Kulkarni
ec21560a3b Added new changes to test_azure_blob_storage_zero_copy_replication 2023-10-26 11:40:44 +02:00
vdimir
1d5f75fd71
Merge pull request #53404 from ClickHouse/vdimir/check_table_improvements2
Improve CHECK TABLE system query, support checking part
2023-10-26 10:57:44 +02:00
Nikolay Degterinsky
97c99132e0 Simplify the implementation 2023-10-25 19:02:48 +00:00
Smita Kulkarni
72f6a3b029 Removed unwanted conversion 2023-10-25 17:09:58 +02:00
kssenii
de8064da6e Debug info 2023-10-25 12:31:00 +02:00
xuzifu666
010cc6918a
Add get_direct_children_number command to keeper-client (#55898) 2023-10-24 17:02:54 +02:00
Smita Kulkarni
1b52418174 Updated with master 2023-10-23 22:17:23 +02:00
Smita Kulkarni
7b1c0c471c Merge branch 'master' into Fix_azurite_port 2023-10-23 22:13:56 +02:00
vdimir
2245a4fba8
Fix test_store_cleanup/test.py after rebase 2023-10-23 12:33:35 +00:00
vdimir
7583394c9c
Support CHECK TABLE ... PART ... query 2023-10-23 12:33:35 +00:00
robot-clickhouse
35d8fa212d Automatic style fix 2023-10-23 12:28:02 +00:00
Smita Kulkarni
ad09c4a37a Updated to use f-strings 2023-10-23 14:13:14 +02:00
Kruglov Pavel
32da07b4ee
Merge pull request #55695 from Avogar/restrict-iceberg
Fixes and improvements for Iceberg storage
2023-10-23 13:58:23 +02:00
vdimir
3332f70275
upd 2023-10-23 10:56:06 +00:00
vdimir
e84fc76292
Deterministic result for CHECK TABLE in tests 2023-10-23 09:36:39 +00:00
Alexander Tokmakov
f899254e2c
Merge pull request #55430 from arthurpassos/properly_split_remote_proxy_http_https
Properly split remote proxy http https
2023-10-20 21:15:34 +02:00
Aleksei Filatov
0a1f3f205c
Add external HTTP Basic authenticator (#55199) 2023-10-20 19:24:19 +02:00
SmitaRKulkarni
4dcba9d97b
Merge pull request #54738 from ClickHouse/Fix_azure_test_by_using_unique_names
Fix azure test by using unique names
2023-10-20 15:04:01 +02:00
Raúl Marín
07e3f10958
Merge pull request #55860 from jrdi/filesystem-cache-docs
Add load_metadata_threads to the documentation
2023-10-20 14:59:47 +02:00
robot-clickhouse
68b789d7a1 Automatic style fix 2023-10-20 12:40:28 +00:00
Konstantin Bogdanov
1edf5ff981
Fix test_system_start_stop_listen 2023-10-20 14:18:44 +02:00