Commit Graph

2 Commits

Author SHA1 Message Date
Azat Khuzhin
65572a23fe Fix async nature of reload in 01036_no_superfluous_dict_reload_on_create_database*
Due to the async nature of SYSTEM RELOAD DICTIONARY/DICTIONARIES the
test can fail, if the reload will happen after the dictGet*():

    .862801 [ 36 ] {61df55ee-4a17-4bf3-8cfb-9478490393c3} <Debug> executeQuery: (from [::1]:37422) SYSTEM RELOAD DICTIONARY `foo 1234.dict`
    .863681 [ 36 ] {cd55d9f9-d176-4b19-bc97-d25575da2d15} <Debug> executeQuery: (from [::1]:37422) SELECT query_count FROM system.dictionaries WHERE (database = 'foo 1234') AND ...
    .863678 [ 54 ] {} <Debug> executeQuery: (internal) SELECT `key`, `val` FROM `foo 1234`.`dict_data`;

This is just a hotfix, long-term solution will be to make SYSTEM RELOAD
DICTIONARY syncronous (by adding another command or making already
existing).

Refs: #7916
2019-12-10 08:31:51 +03:00
Azat Khuzhin
4530adee76 Do not reload *all* dictionaries on CREATE DATABASE
This ignores any lifetime, while dictionaries can be quite big.

Fixes: c7cd911305 ("Merge pull request #7360")
Refs: https://github.com/ClickHouse/ClickHouse/pull/7360#discussion_r345207682
2019-11-26 10:33:25 +03:00