Commit Graph

5439 Commits

Author SHA1 Message Date
Azat Khuzhin
3a72e1c12a Add checksum for extra info/query in distributed sends
This extras includes:
- server revision
- query settings
- query

Otherwise the code can try to interpret data, and got for instance
std::length_error exception, which is not catched (to mark the part as
broken). Also this will protect from the corruptions on disk.

And add a simple test, since dbms/tests/integration/test_insert_into_distributed too complex.

Also simplify the code by using readStringBinary() over
readVarUInt()+b.readStrict() (this also gains additional checks that
string is not bigger then 1GB).

Refs: #4852 (8ef7f3589a)
v2: avoid ABI breakage (suggested by @vitlibar)
v3: minor code fixes (suggested by @vitlibar) and as a consequence clang-8 build fix
v4: drop DBMS_MIN_REVISION_WITH_EXTRAS_CHECKSUM_IN_DIST_BATCH and also
    revert some renames to make the patch cleaner
2019-12-04 22:54:38 +03:00
Mikhail Filimonov
34275626de Fix for https://github.com/ClickHouse/ClickHouse/issues/8003 : old producers do not write timestamp, but column still should have enough rows 2019-12-03 23:03:43 +01:00
Mikhail Filimonov
3de3ba336a Fix Native format in Kafka 2019-12-03 22:12:47 +01:00
Mikhail Filimonov
6e426592a7 Make the formats like RowBinaryWithNamesAndTypes work in Kafka & do not try to parse buffer when it at eof 2019-12-03 22:03:22 +01:00
alesapin
fa4728d44f Fix style 2019-12-03 20:57:00 +03:00
alesapin
2a43daec5c Buildable code 2019-12-03 20:15:16 +03:00
alesapin
20e4e92c49 Fix some conflicts 2019-12-03 19:32:41 +03:00
alexey-milovidov
f09c29a2b6
Merge pull request #7992 from ClickHouse/excitoon-favorites-s3auth
Merging #7623
2019-12-03 15:21:12 +03:00
alexey-milovidov
87adf355e8
Merge pull request #7935 from filimonov/kafka_perf
[wip] attempt to improve kafka parsing performance
2019-12-03 03:52:40 +03:00
alexey-milovidov
b6edda194f
Update KafkaBlockInputStream.cpp 2019-12-03 03:52:02 +03:00
Alexey Milovidov
d70b73f033 Merge branch 's3auth' of https://github.com/excitoon-favorites/ClickHouse into excitoon-favorites-s3auth 2019-12-03 03:06:01 +03:00
alexey-milovidov
fe05565cec
Update StorageS3.cpp 2019-12-03 03:03:44 +03:00
Alexey Milovidov
fc174dce6e More simple 2019-12-03 02:50:53 +03:00
Alexey Milovidov
9d099bde8e Merge branch 'master' into fix_check_table_with_empty_pk 2019-12-03 02:36:21 +03:00
alexey-milovidov
e44dc0a6c8
Merge pull request #7981 from ClickHouse/fix_number_of_streams_for_storages_with_globs
Limit number of streams for read from StorageFile and StorageHDFS
2019-12-03 02:23:10 +03:00
chertus
a179c5025f Merge branch 'master' into joins 2019-12-02 21:08:39 +03:00
chertus
5ce65546e9 semi & anti join 2019-12-02 21:08:04 +03:00
Vitaly Baranov
b2685a3710
Merge pull request #7727 from kekekekule/master
Added lifetime to system.dictionaries #6820
2019-12-02 15:15:44 +03:00
alesapin
08dfd1d1c4 Limit number of streams for read from StorageFile and StorageHDFS 2019-12-02 14:25:41 +03:00
alesapin
a4ca30b5fd Fix bug in check table for tables without primary key 2019-12-02 13:30:04 +03:00
Vladimir Chebotarev
8dbfcdb3c3 Fixed failing tests. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
ef5c4fb5a4 Remake of result_part_path. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
b23d411f84 Filling result_part_path column of system.merges during the merge. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
41c965e4ba Attempt to add is_move, source_part_paths, result_part_path columns to system.merges. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
94684c07bf Added syntax for access_key_id and secret_access_key in S3 table function and storage. 2019-12-01 10:56:11 +03:00
Артем Стрельцов
25aa2114b2 Deleted redundant empty lines 2019-12-01 03:49:11 +03:00
Nikolay Degterinsky
6b39253b71 Fixed naming 2019-11-29 17:15:12 +03:00
Nikolay Degterinsky
59002ddb91 Merge branch 'master' of https://github.com/kekekekule/ClickHouse into dict_lifetime 2019-11-29 17:06:38 +03:00
Mikhail Filimonov
ad136ec62d get rid of cloneWithColumns in internal loop and some other trash 2019-11-29 11:46:25 +01:00
Nikolai Kochetov
7a32ca057d
Merge pull request #7670 from excitoon-favorites/move_pool
Separated pool for background moves
2019-11-29 11:08:51 +03:00
hcz
dd7051bd98 Merge remote-tracking branch 'origin/master' into patch-2 2019-11-29 15:07:53 +08:00
Mikhail Filimonov
4cc0d0ca5d make virtual_columns local 2019-11-29 07:21:31 +01:00
Mikhail Filimonov
07722dfa93 more progress - cleanup internal cycles 2019-11-29 00:06:03 +01:00
alexey-milovidov
2e34f02a36
Merge pull request #7936 from ClickHouse/branch-for-slightly-improvement-of-usability-of-exception-messages
The rest of PR #7897 about improvement of exception message
2019-11-28 22:07:29 +03:00
Mikhail Filimonov
6217cb51f6 Get rid of InputStream layer for Kafka, use InputStream directly. Reopening port during reset. 2019-11-28 17:43:06 +01:00
stavrolia
295633b7ef Another try 2019-11-28 17:31:35 +03:00
Anton Popov
9fe987c8e1
Merge pull request #7920 from excitoon-favorites/datetimettl
Removed check for using `Date` or `DateTime` column from TTL expressions
2019-11-27 19:55:57 +03:00
stavrolia
f23273fa80 Fix 2019-11-27 17:29:00 +03:00
Nikolai Kochetov
bd40c9cd13
Merge pull request #7933 from azat/dist-mon-codec-errors-mark-broken
DirectoryMonitor: mark batch as broken on UNKNOWN_CODEC/CANNOT_DECOMPRESS errors
2019-11-27 16:03:44 +03:00
Vladimir Chebotarev
ecaa98e4e4 Allowed to use constant TTL expressions, updated tests. 2019-11-27 13:11:17 +03:00
Vladimir Chebotarev
c396af7c40 Removed check for using Date or DateTime column from TTL expressions. 2019-11-27 13:11:17 +03:00
stavrolia
f1e5e58480 Some rest of PR about improvement of exception message 2019-11-27 04:18:26 +03:00
Mikhail Filimonov
deec48a3e0 attempt to fix kafka parsing performance regression https://github.com/ClickHouse/ClickHouse/issues/7261 2019-11-27 00:46:19 +01:00
Azat Khuzhin
362505b129 DirectoryMonitor: mark batch as broken on UNKNOWN_CODEC/CANNOT_DECOMPRESS errors
There is no point in retrying batch after those errors (for the same
reasons as CHECKSUM_DOESNT_MATCH is there).
2019-11-26 20:21:05 +03:00
Vladimir Chebotarev
37bc15779d Better logging of BackgroundMovePool. 2019-11-26 16:09:57 +03:00
Vladimir Chebotarev
37bebd1370 Improved BackgroundProcessingPool to use with background moves task. 2019-11-26 16:09:57 +03:00
Vladimir Chebotarev
e96c24786b Separated pool for background moves. 2019-11-26 16:08:59 +03:00
Olga Khvostikova
47e499d71b
Merge pull request #7833 from excitoon-favorites/detachedparts
Added disk info to `system.detached_parts`
2019-11-26 11:56:50 +03:00
Nikolai Kochetov
c97212d132 Remove unused variable. 2019-11-25 16:35:28 +03:00
Nikolai Kochetov
d3118f0a76 Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:57:14 +03:00
Nikolai Kochetov
9b42e9341d Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:49:05 +03:00
Nikolai Kochetov
f770934e60 Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:05:29 +03:00
Nikita Mikhaylov
728ede25f9
Merge pull request #7840 from apbodrov/read_write_gzip
Gzip read/write to file/s3/url/hdfs
2019-11-22 11:48:58 +03:00
tavplubix
b75b6c294d
Merge pull request #7762 from ClickHouse/possible_segfaults_in_table_functions
Fix Storage lifetime in table functions
2019-11-22 02:29:06 +03:00
Nikita Mikhaylov
762d295ab0
Merge pull request #7780 from ClickHouse/aku/parallel-parsing
Merging parallel format parsing
2019-11-22 01:54:47 +03:00
Vladimir Chebotarev
2b4f6af736 Fixed errors with space reservation introduced in #7558 and #7602. 2019-11-21 12:09:43 +03:00
Andrei Bodrov
decdd7d476 fix typos 2019-11-20 18:40:42 +03:00
Andrei Bodrov
c2849d0864 move to helpers 2019-11-20 17:48:01 +03:00
Alexander Kuzmenkov
7e5731d64e Merge remote-tracking branch 'origin/master' into HEAD 2019-11-19 16:15:47 +03:00
Andrei Bodrov
8cbc52e711 add gzip read/write to file/s3/url/hdfs 2019-11-19 15:46:07 +03:00
Vladimir Chebotarev
5cbbcd9cdb Added disk info to system.detached_parts. 2019-11-19 09:44:10 +03:00
Alexander Tokmakov
2173bf5f4a Merge branch 'master' into possible_segfaults_in_table_functions 2019-11-17 16:48:13 +03:00
Vitaly Baranov
e40c140982 Add the ignorable flag for the settings. 2019-11-17 03:56:18 +03:00
Vitaly Baranov
f3d72b9ec1 Skip unknown settings with warnings. 2019-11-17 03:51:58 +03:00
Vitaly Baranov
ff6cba192b Replace pointer with reference in SettingsCollection<T>::MemberInfos::findStrict().
Rename SettingsCommon.h -> SettingsCollection.h for consistency.
2019-11-17 03:51:51 +03:00
Alexander Tokmakov
55f60a6bad hold shared pointers to table function Storage and Context from InterpreterSelectQuery 2019-11-15 21:42:32 +03:00
Alexander Kuzmenkov
723e02fef7
Merge pull request #7759 from CurtizJ/fix-order-by
Fix order by in case of sorting by primary key prefix and non primary key suffix.
2019-11-15 20:52:31 +03:00
CurtizJ
475356f2b7 more clarifying names to avoid mistakes 2019-11-15 17:03:42 +03:00
Артем Стрельцов
2a65b4818a Fixed bugs of last non-fictive commit 2019-11-15 11:33:27 +03:00
Артем Стрельцов
5c46a8a7a8 Empty commit to restart tests 2019-11-14 22:36:31 +03:00
Alexander Kuzmenkov
7f34c0089c Merge remote-tracking branch 'origin/master' into HEAD 2019-11-14 18:53:36 +03:00
chertus
8286bbf913 Merge branch 'master' into joins 2019-11-14 16:16:52 +03:00
Nikolai Kochetov
caad7e636e Use shared_ptr for storage in StorageFileBlockInputStream. 2019-11-13 15:28:14 +03:00
Nikolai Kochetov
943dd12a96 Use shared_ptr for storage in StorageFileBlockInputStream. 2019-11-13 15:17:31 +03:00
Артем Стрельцов
ec636e95cd Added lifetime to system.dictionaries 2019-11-12 00:34:28 +03:00
chertus
8321deefac Merge branch 'master' into joins 2019-11-11 20:54:45 +03:00
alesapin
c74538153f Fix use of destroyed variable captured in lambda 2019-11-11 11:40:00 +03:00
Mikhail Korotov
37a6ccfa49 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into url_engine_problem 2019-11-08 18:29:06 +03:00
robot-clickhouse
94c7719c73 Auto version update to [19.18.1.1] [54429] 2019-11-08 11:36:41 +03:00
millb
7a2dcf451a Merge branch 'master' into url_engine_problem 2019-11-08 02:19:09 +03:00
alexey-milovidov
7f01fd13b3
Merge pull request #7624 from azat/_shard_num
[RFC] Add _shard_num virtual column for the Distributed engine
2019-11-08 00:55:41 +03:00
alexey-milovidov
a2e79cc427
Merge pull request #7574 from ClickHouse/processors-4
Fix tests for processors
2019-11-08 00:46:30 +03:00
chertus
b8d464aa03 new consistent ANY JOIN (LEFT, INNER, RIGHT) 2019-11-08 00:32:44 +03:00
alesapin
18e59f2771 Remove some functions from mutations interpreter 2019-11-07 11:40:36 +03:00
Azat Khuzhin
0677ae048c Wrap _shard_num with toUInt32 for simpler JOIN with system.clusters.shard_num 2019-11-06 21:02:42 +03:00
Azat Khuzhin
92bd96fc0d Simplify buildWhereExpression() by using makeASTFunction() helper 2019-11-06 20:37:30 +03:00
alesapin
8c7deaa70d More safier, but still ugly mutations interpreter 2019-11-06 20:28:03 +03:00
Azat Khuzhin
81aeff2d2a Add _shard_num virtual column for the Distributed engine
With JOIN from system.clusters one can figure out from which server data
came.

TODO:
- optimization to avoid communicating with unrelated shards (for queries
  like "AND _shard_num = n")
- fix aliases (see tests with serverError expected)

v0: AddingConstColumnBlockInputStream
v2: VirtualColumnUtils::rewriteEntityInAst
v3: fix remote(Distributed) by appending _shard_num only if has been requested
2019-11-06 15:26:12 +03:00
Alexander Kuzmenkov
233212ac68
Merge pull request #7531 from amosbird/getkeymapped
Unify hash tables interface (separated for review)
2019-11-06 13:49:39 +03:00
alexey-milovidov
687be5f7af
Merge pull request #7618 from excitoon-favorites/looks-like-wrong-copy-paste
Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages
2019-11-06 02:11:38 +03:00
alexey-milovidov
56c89349d3
Merge pull request #7639 from CurtizJ/final_mark_without_primary_key
Fix final mark with empty primary key.
2019-11-05 22:53:52 +03:00
Alexey Milovidov
9ac4e4c7fb Little better #7600 2019-11-05 22:31:07 +03:00
alexey-milovidov
1bfade54c2
Merge pull request #7600 from azat/DirectoryMonitor-current_batch.txt-corruption
Write current batch for distributed send atomically (using .tmp + rename)
2019-11-05 22:24:15 +03:00
CurtizJ
3d968b0259 fix final mark with empty primary key 2019-11-05 20:42:35 +03:00
Nikolai Kochetov
055f21c9b7 Less wrappers for procesors pipeline. 2019-11-05 20:33:03 +03:00
Amos Bird
fbfbe161ec
Unify hash tables interface. 2019-11-06 00:08:04 +08:00
millb
a03f8145bb Created check for HDFS and S3 storages
:
2019-11-05 15:40:49 +03:00
millb
d62cd6efa8 Merge branch 'master' into url_engine_problem 2019-11-05 14:42:53 +03:00
hcz
e0e5e812a7
Allow relative user_files_path 2019-11-05 17:48:49 +08:00
Nikita Mikhaylov
817b52314e Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-11-05 12:32:26 +03:00