Alexander Tokmakov
fdbd59ec6c
Merge pull request #51135 from ClickHouse/fix_trash_in_disks
...
Try to fix some trash in Disks and part moves
2023-07-07 02:02:17 +03:00
alekar
757aee1109
Merge branch 'master' into fix-to-outfile
2023-07-06 14:04:42 -07:00
vdimir
c35294317d
Remove parts in order for object storage always
2023-07-06 20:38:01 +00:00
Robert Schulze
271297823a
Allow var-int encoded 64-bit integers with MSB=1
...
Resolves : #51486
Until now, it was illegal to encode 64-bit (unsigned) integers with
MSB=1, i.e. values > (1ULL<<63) - 1, as var-int. In more detail, the
var-int code used by ClickHouse server and client spent at most 9 bytes
per value such that 9 * 7 = 63 bits could be encoded. Some 3rd party
clients (e.g. Rust clickhouse-rs) had the same limitation, whereas other
clients understand the full range (Python clickhouse-driver).
PRs #47608 and #48628 added sanity checks as asserts or exceptions
during var-int encoding on the server side. This was considered okay as
such huge integers so far occurred only during testing (usually fuzzing)
but not in practice.
Issue #51486 is a new fuzzing issue where the exception thrown from the
sanity check led to a half-baked progress packet and as a result, a
logical error / server crash.
The only fix which is not another bandaid is to allow the full range in
var-int coding. Clients will have to allow the full range too, a note
will be added to the changelog. (the alternative was to create another
protocol version but as var-int is used all over the place this was
considered infeasible)
Review note: this is the relevant commit.
2023-07-06 20:23:23 +00:00
Sema Checherinda
9c12994d94
initialize SeriesRecords for LogSeriesLimiter lazy
2023-07-06 19:49:22 +02:00
robot-clickhouse-ci-2
99c64971bd
Merge pull request #51737 from ClickHouse/fix_logical_error_grace_hash_join
...
Fix: logical error in grace hash join
2023-07-06 19:27:03 +02:00
Alexander Tokmakov
58793816a7
fix paranoid check
2023-07-06 19:06:35 +02:00
Nikita Taranov
63b9c1ac06
add test
2023-07-06 18:58:13 +02:00
lcjh
7321f7e9dc
Merge branch 'master' into master
2023-07-07 00:31:47 +08:00
Feng Kaiyu
bf4dbb842d
Merge branch 'master' into master
2023-07-06 23:47:41 +08:00
Igor Nikonov
83af43b8ba
Merge pull request #51852 from ClickHouse/fix-misleading-naming-in-joins
...
Change misleading name in joins: addJoinedBlock -> addBlockToJoin
2023-07-06 17:27:26 +02:00
Igor Nikonov
7c0e50c4d5
Merge branch 'master' into fix-misleading-naming-in-joins
2023-07-06 17:26:38 +02:00
Alexander Tokmakov
abf36065b7
fix
2023-07-06 17:24:06 +02:00
Robert Schulze
3f744c1e14
Cosmetics: rename template parameter
2023-07-06 14:47:40 +00:00
Robert Schulze
7644f0b37c
Cosmetics: move code around
2023-07-06 14:44:06 +00:00
Alexey Milovidov
6d8434c702
Merge branch 'master' into many-fixes-3
2023-07-06 16:17:32 +02:00
Alexey Milovidov
1fa21700ad
Merge remote-tracking branch 'origin/less-flaky-test_start_stop_moves' into many-fixes-3
2023-07-06 16:17:13 +02:00
Nikita Taranov
aec7205636
rework pool usage
2023-07-06 14:41:09 +02:00
Nikita Taranov
c23e29d6aa
don't account session's memory in thread/user mem tracker
2023-07-06 14:41:03 +02:00
Alexander Tokmakov
52a26a6653
Merge pull request #51708 from velavokr/velavokr-issue-51292
...
#51292 added default_temporary_table_engine setting
2023-07-06 15:18:14 +03:00
Dmitry Kardymon
86fc702236
Add skipWhitespacesAndTabs()
...
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2023-07-06 15:14:18 +03:00
xiaolei565
0c3ce1f634
Merge branch 'master' into xuelei_dev
2023-07-06 19:47:07 +08:00
Yatsishin Ilya
12ebb30781
style
2023-07-06 10:34:34 +00:00
Kseniia Sumarokova
e97e107bcc
Merge branch 'master' into add-separate-access-for-use-named-collections
2023-07-06 12:16:53 +02:00
Kseniia Sumarokova
605e833576
Merge branch 'master' into minor-changes
2023-07-06 12:09:01 +02:00
Sema Checherinda
8f7381f0a2
Merge branch 'master' into less-logs-2
2023-07-06 12:07:58 +02:00
Yatsishin Ilya
24e77083b3
Commit tests
2023-07-06 09:50:44 +00:00
Dmitry Kardymon
32f5a78302
Fix setting name
2023-07-06 07:32:46 +00:00
Alexander Gololobov
1336a9ec67
Better naming
2023-07-06 09:09:55 +02:00
Dmitry Kardymon
24b5c9c204
Use one setting input_format_csv_allow_variable_number_of_colums and code in RowInput
2023-07-06 06:05:43 +00:00
alekar
f37e08a945
Merge branch 'master' into fix-to-outfile
2023-07-05 21:25:21 -07:00
Amos Bird
5af28315e2
Try to fix style issues
2023-07-06 11:48:22 +08:00
Amos Bird
06553452ed
StatusInfo will be deprecated
2023-07-06 11:48:21 +08:00
Amos Bird
d8e87f6c1d
Make common macros extendable
2023-07-06 11:48:20 +08:00
Feng Kaiyu
3db83b58b8
Merge branch 'ClickHouse:master' into master
2023-07-06 11:04:10 +08:00
Alexey Milovidov
e8718e04cb
Update
2023-07-06 05:58:05 +03:00
Alexey Milovidov
d59f68b600
Remove useless code
2023-07-06 04:55:46 +02:00
xiaolei565
0e4192f590
Merge branch 'master' into xuelei_dev
2023-07-06 10:35:22 +08:00
Alexey Milovidov
2e454ef89e
Merge branch 'master' into disks-space-improvement
2023-07-06 03:58:45 +03:00
Alexey Milovidov
376c903da9
Merge pull request #51518 from ClickHouse/qemu-chroot-fixes
...
Allow running in a stripped chroot environment
2023-07-06 03:57:04 +03:00
Alexey Milovidov
5452f2106f
Merge branch 'master' into sunny19930321-fix-attach-table-function-name-normalizer
2023-07-06 03:50:18 +03:00
Alexey Milovidov
d7782f6518
Merge branch 'fix_keyed_hash' of github.com:nickitat/ClickHouse into many-fixes-3
2023-07-06 02:47:51 +02:00
Alexey Milovidov
1a24bface0
Merge branch 'master' into clickhouse-local-default-settings
2023-07-06 03:30:11 +03:00
Alexey Milovidov
db14b2c54f
Remove useless logs
2023-07-06 02:16:38 +02:00
Yakov Olkhovskiy
8c46ce0bd4
Merge branch 'master' into fix-tsan-thread-local
2023-07-05 19:25:12 -04:00
Alexey Milovidov
b75a83d32d
Merge remote-tracking branch 'origin/vdimir/anti_join_logical_error_51312' into many-fixes-3
2023-07-06 01:21:38 +02:00
Alexey Milovidov
85e7d40755
Merge branch 'master' into add-test-43358
2023-07-06 02:20:28 +03:00
Alexey Milovidov
2c592a6a2c
Merge pull request #51805 from ClickHouse/fix_for_parallel_replicas_and_empty_header
...
Fix for parallel replicas not completely disabled by granule count threshold
2023-07-06 01:46:52 +03:00
Alexey Milovidov
b28fa1f054
Merge branch 'many-fixes-3' of github.com:ClickHouse/ClickHouse into many-fixes-3
2023-07-05 23:54:48 +02:00
Alexey Milovidov
9bcc85d60f
Merge branch 'fix-drop-column-sparse' of github.com:CurtizJ/ClickHouse into many-fixes-3
2023-07-05 23:54:27 +02:00
Alexey Milovidov
7a593ed9a5
Merge pull request #51655 from rschu1ze/re2-absl
...
Minor follow-up to re2 update to 2023-06-02 (#50949 )
2023-07-06 00:52:16 +03:00
Alexey Milovidov
d1a8d0590e
Merge branch 'master' into many-fixes-3
2023-07-06 00:46:11 +03:00
Alexey Milovidov
157ef96687
Merge branch 'master' into master
2023-07-06 00:43:07 +03:00
Kseniia Sumarokova
998e038c9d
Merge pull request #51208 from kssenii/resubmit-51149
...
Resubmit #48821
2023-07-05 23:26:20 +02:00
Alexey Milovidov
4527ffb88f
Merge pull request #49764 from ClickHouse/bgmem
...
Fix flaky tests caused by OPTIMIZE FINAL failing memory budget check
2023-07-06 00:15:55 +03:00
Sema Checherinda
41b406970e
Merge branch 'master' into write-to-finalized
2023-07-05 23:08:31 +02:00
Igor Nikonov
023df888d3
Merge branch 'master' into fix_logical_error_grace_hash_join
2023-07-05 21:38:36 +02:00
lcjh
ce8b0cae82
remove duplicate condition
2023-07-06 02:14:48 +08:00
alekar
df87b79f71
Merge branch 'master' into fix-to-outfile
2023-07-05 10:52:09 -07:00
Feng Kaiyu
f7640ff573
fix: correct exception message on policies comparison
2023-07-06 01:27:20 +08:00
Igor Nikonov
bf190381f5
addJoinedBlock -> addBlockToJoin
2023-07-05 17:03:18 +00:00
Ilya Yatsishin
f0f6515178
Merge remote-tracking branch 'origin/fix-test-object-type' into many-fixes-3
2023-07-05 17:10:11 +02:00
Ilya Yatsishin
c052f42a20
Merge remote-tracking branch 'origin/fix-tsan-transform' into many-fixes-3
2023-07-05 17:07:42 +02:00
Duc Canh Le
8f1ed5c90d
add more check + line break
2023-07-05 15:04:38 +00:00
Duc Canh Le
1a0b2d0e24
Merge branch 'master' into ch_fix_segfault
2023-07-05 22:59:13 +08:00
Duc Canh Le
1da413e64e
fix segfault when create invalid EmbeddedRocksdb table
2023-07-05 14:56:11 +00:00
Han Fei
095b75e2c7
Merge pull request #51837 from ucasfl/unused
...
remove unused code
2023-07-05 16:21:40 +02:00
flynn
e175be1f42
remove unused code
2023-07-05 12:34:58 +00:00
Alexander Gololobov
5512c307db
system.jemalloc_bins table
2023-07-05 14:34:03 +02:00
Yatsishin Ilya
fd4f738502
Merge remote-tracking branch 'origin' into per-column-pk-syntax
2023-07-05 12:30:26 +00:00
Yatsishin Ilya
e957600d5c
wip
2023-07-05 12:28:27 +00:00
Alexey Milovidov
76316f9cc8
Merge pull request #51578 from ClickHouse/remove-analyzer-setting-client
...
Remove the usage of Analyzer setting in the client
2023-07-05 14:49:39 +03:00
Dmitry Kardymon
86014a60a3
Fixed case with spaces before delimiter
2023-07-05 11:42:02 +00:00
Anton Popov
cf809c25cd
fix CLEAR COLUMN query
2023-07-05 11:24:29 +00:00
kssenii
e6422f8144
Delete comment, rename variable
2023-07-05 13:08:11 +02:00
Kseniia Sumarokova
244b30d659
Merge branch 'master' into resubmit-51149
2023-07-05 12:12:21 +02:00
Kseniia Sumarokova
dcda3576d2
Merge branch 'master' into add-separate-access-for-use-named-collections
2023-07-05 12:05:49 +02:00
Han Fei
2e5643cc41
use UTC LUT
2023-07-05 11:57:18 +02:00
李扬
bb301cfbb0
Merge branch 'master' into improve_geohash
2023-07-05 17:57:03 +08:00
Kseniia Sumarokova
f2d942fbb5
Merge branch 'master' into more-flexible-drop-cache
2023-07-05 11:43:57 +02:00
xiaolei565
c47b797515
Merge branch 'master' into xuelei_dev
2023-07-05 17:43:47 +08:00
Kseniia Sumarokova
e897207cd5
Merge pull request #51790 from kssenii/fix-assertion
...
Fix after #51000
2023-07-05 11:25:00 +02:00
Han Fei
9544c035b9
Revert "refine"
...
This reverts commit 7f1ee68c87
2023-07-05 11:15:31 +02:00
xiaolei565
2c5fc5ee13
Merge branch 'master' into xuelei_dev
2023-07-05 16:33:42 +08:00
robot-ch-test-poll
0fb6dd8f89
Merge pull request #51800 from Avogar/assert-current-thread
...
Add assert in ThreadStatus destructor for correct current_thread
2023-07-05 03:14:33 +02:00
Anton Popov
ede63a0f4e
fix drop column with enabled sparse columns
2023-07-05 00:30:28 +00:00
Alexey Milovidov
6d0e6b58f3
Merge branch 'master' into remove-analyzer-setting-client
2023-07-05 02:30:17 +03:00
Alexey Milovidov
431b53a3ae
Merge branch 'master' into add-test-43358
2023-07-05 02:29:44 +03:00
Alexey Milovidov
024248ea5e
Merge branch 'master' into vdimir/anti_join_logical_error_51312
2023-07-05 02:27:03 +03:00
Alexey Milovidov
de0592fa9a
Merge branch 'master' into fix-to-outfile
2023-07-05 02:14:47 +03:00
Alexey Milovidov
a3f201f5de
Merge branch 'master' into fix-tsan-transform
2023-07-05 02:03:09 +03:00
Alexey Milovidov
a4abb81194
Merge branch 'master' into bgmem
2023-07-05 01:54:43 +03:00
Alexey Milovidov
a06532630a
Merge branch 'master' into fix-test-object-type
2023-07-05 00:47:30 +02:00
Alexey Milovidov
4d87cf2344
Merge branch 'master' into qemu-chroot-fixes
2023-07-05 01:13:06 +03:00
Alexander Gololobov
c0629a38d1
Fix for incorrect result when parallel replicas not completely disabled
2023-07-04 23:50:19 +02:00
Alexey Milovidov
3a170c297a
Merge pull request #51392 from ClickHouse/disable-hedged-requests-under-tsan
...
Disable hedged requests under TSan
2023-07-05 00:33:17 +03:00
Alexey Milovidov
3371e038cf
Merge pull request #51498 from ClickHouse/vdimir/test_alter_moving_garbage_51342
...
Fix `test_alter_moving_garbage`: lock between getActiveContainingPart and swapActivePart in parts mover
2023-07-05 00:32:21 +03:00
Han Fei
7f1ee68c87
refine
2023-07-04 23:08:54 +02:00
Nikita Taranov
da105d4916
impl
2023-07-04 23:01:06 +02:00
Alexander Tokmakov
607a8a1c46
fix
2023-07-04 22:52:59 +02:00
Alexander Tokmakov
42222662e6
Merge branch 'master' into fix_broken_parts_handling
2023-07-04 22:46:35 +02:00
Alexey Milovidov
c76cf53391
Address review comments
2023-07-04 22:14:37 +02:00
Alexey Milovidov
4e8405cbda
Merge branch 'master' into disks-space-improvement
2023-07-04 22:00:40 +02:00
Alexey Milovidov
5a32995726
Update src/Disks/IVolume.cpp
...
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2023-07-04 22:57:39 +03:00
Alexey Milovidov
6345879cdf
Update src/Disks/VolumeJBOD.cpp
...
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2023-07-04 22:56:58 +03:00
Yakov Olkhovskiy
bb5b47cacf
do not access Exception::thread_frame_pointers if not initialized
2023-07-04 19:07:11 +00:00
Alexander Tokmakov
d987b94ed4
fix the way how broken parts are detached
2023-07-04 20:51:15 +02:00
Sema Checherinda
7b6b406af1
Merge branch 'master' into write-to-finalized
2023-07-04 20:19:51 +02:00
avogar
32ee0e7d08
Add assert in ThreadStatus destructor for correct current_thread
2023-07-04 17:35:26 +00:00
Alexey Milovidov
f0fb024ce0
Merge branch 'master' into add-test-43358
2023-07-04 20:20:59 +03:00
Alexey Milovidov
81594cc457
Merge branch 'master' into sunny19930321-fix-attach-table-function-name-normalizer
2023-07-04 20:20:14 +03:00
Alexey Milovidov
0eeb0b418b
Merge branch 'master' into qemu-chroot-fixes
2023-07-04 20:19:53 +03:00
Alexey Milovidov
35bf33c3d9
Merge branch 'master' into fix-tsan-transform
2023-07-04 20:18:43 +03:00
Dmitry Kardymon
cce06edfa7
Merge remote-tracking branch 'clickhouse/master' into ADQM-868
2023-07-04 19:18:55 +03:00
Dmitry Kardymon
825a244aea
Merge remote-tracking branch 'clickhouse/master' into ADQM-870
2023-07-04 19:16:50 +03:00
Igor Nikonov
3155f58941
Merge remote-tracking branch 'origin/master' into fix_logical_error_grace_hash_join
2023-07-04 15:47:04 +00:00
Igor Nikonov
1c2233b693
Fix style check
2023-07-04 15:46:40 +00:00
Robert Schulze
770bf8f4f3
Merge branch 'master' into re2-absl
2023-07-04 17:42:52 +02:00
Han Fei
ca6930eb11
Revert "Revert "Merge pull request #50951 from ZhiguoZh/20230607-toyear-fix""
2023-07-04 17:38:53 +02:00
Kruglov Pavel
bab423acc2
Merge branch 'master' into disable-hedged-requests-under-tsan
2023-07-04 17:37:14 +02:00
kssenii
c979113ea5
Fix
2023-07-04 16:13:33 +02:00
kssenii
6bca452924
Fix tests
2023-07-04 12:42:27 +02:00
Vitaly Baranov
c092b9974c
Merge branch 'master' into fix-race-in-context-access
2023-07-04 12:37:41 +02:00
Kseniia Sumarokova
24bb6ed566
Merge branch 'master' into min-file-segment-size
2023-07-04 12:21:41 +02:00
Igor Nikonov
30be0ab4a8
Fix: unexpected number of buckets
...
Number of buckets could become inconsistent
if exception was thrown during new buckets creation
2023-07-04 09:00:53 +00:00
Igor Nikonov
f86c5edfc4
Remove debug tracing
2023-07-04 07:55:13 +00:00
Dmitry Kardymon
ab4142eb8f
Merge remote-tracking branch 'clickhouse/master' into ADQM-870
2023-07-04 08:23:31 +03:00
Dmitry Kardymon
ed16828b70
Merge remote-tracking branch 'clickhouse/master' into ADQM-868
2023-07-04 08:18:57 +03:00
Alexey Milovidov
c25da7cbf4
Fix (benign) data rance in transform
2023-07-04 01:03:49 +02:00
Alexey Milovidov
c65ee49a37
Revert "Merge pull request #51750 from ClickHouse/revert-51296-object_column_invalid_num_of_rows"
...
This reverts commit 73d956249e4d76b538c7
2023-07-04 00:49:39 +02:00
Alexey Milovidov
03b8c28826
Merge branch 'master' into sunny19930321-fix-attach-table-function-name-normalizer
2023-07-04 01:28:05 +03:00
Alexey Milovidov
d7bb68064a
Merge branch 'master' into disable-hedged-requests-under-tsan
2023-07-04 01:14:18 +03:00
Igor Nikonov
287fe91438
Merge branch 'master' into fix_logical_error_grace_hash_join
2023-07-04 00:05:11 +02:00
alekar
2236d848b6
Merge branch 'master' into fix-to-outfile
2023-07-03 15:02:46 -07:00
Igor Nikonov
6742432fd2
Number of bucket always increased by 2, so there is no reason provide it as parameter
2023-07-03 21:58:56 +00:00
Anton Popov
fd4a14d56b
Merge branch 'master' into system.parts_column_modification_time
2023-07-03 23:28:03 +02:00
Alexey Milovidov
912fda680e
Merge branch 'master' into add-test-43358
2023-07-04 00:17:07 +03:00
Alexander Tokmakov
ec5c9a0137
Revert "Fix: Invalid number of rows in Chunk column Object"
2023-07-03 23:43:38 +03:00
velavokr
dcc0076ded
fixed comment
2023-07-03 19:10:39 +03:00
velavokr
ae87d43f88
test fixes
2023-07-03 19:10:39 +03:00
velavokr
2f85d048ae
bugfix
2023-07-03 19:10:39 +03:00
velavokr
66227ce8d3
#51292 added default_temporary_table_engine setting
2023-07-03 19:10:39 +03:00
Vitaly Baranov
8dd1b7b8b9
Merge branch 'master' into add-hex-functions-for-cityhash
2023-07-03 18:00:33 +02:00
Igor Nikonov
ccda3c3a6e
Try to fix logical error #51703
2023-07-03 15:03:40 +00:00
Anton Popov
8bd6532ca7
Merge pull request #51296 from ClickHouse/object_column_invalid_num_of_rows
...
Fix: Invalid number of rows in Chunk column Object
2023-07-03 15:40:41 +02:00
kssenii
ac77f5fe6f
Merge remote-tracking branch 'upstream/master' into add-separate-access-for-use-named-collections
2023-07-03 13:55:45 +02:00
Alexander Gololobov
eff94f5100
Merge pull request #51610 from ClickHouse/fix_move_in_to_prewhere
...
Fix for moving 'IN' conditions to PREWHERE
2023-07-03 13:55:32 +02:00
Kseniia Sumarokova
37dcc36c50
Merge branch 'master' into min-file-segment-size
2023-07-03 13:52:28 +02:00
kssenii
2feb2c0f70
Fix style check
2023-07-03 13:47:08 +02:00
Azat Khuzhin
22e44ced8a
Add column modification time into system.parts_columns
...
This can be useful to obtain at least some time for the part after
mutations, since mutations will change the modification time of all
parts.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-03 13:34:05 +02:00
