Commit Graph

2860 Commits

Author SHA1 Message Date
flynn
be0c5bf10a Use concepts to replace more std::enable_if_t
fix
2023-08-02 07:50:25 +00:00
Kseniia Sumarokova
eabca22909
Merge branch 'master' into revert-revert-drop-cache 2023-08-01 23:19:38 +02:00
Hendrik M
625b6b2b1c use own parser only for table identifiers 2023-08-01 22:33:42 +02:00
ltrk2
e869adf645 Improve function naming 2023-07-31 06:48:50 -07:00
kssenii
b683477b20 Better dynamic disk configuration 2023-07-31 14:15:22 +02:00
kssenii
5d167b4f03 Merge remote-tracking branch 'upstream/master' into system-sync-cache 2023-07-31 12:44:11 +02:00
kssenii
6ae6268ad0 Revert "Merge pull request #51917 from ClickHouse/revert-system-drop-filesystem-cache-by-key"
This reverts commit 520195f7ef, reversing
changes made to e36a638014.
2023-07-30 13:39:54 +02:00
ltrk2
6c9a1b14ef
Merge branch 'master' into feature/mergetree-checksum-big-endian-support 2023-07-28 16:18:46 -04:00
Илья Коргун
ae4406cd80 Fix named collections AST formatters (if [not] exists) 2023-07-27 22:11:32 +03:00
Al Korgun
f026ccf11e
Merge branch 'ClickHouse:master' into fix-named-collections-on-cluster-23.7 2023-07-27 10:48:25 +03:00
Илья Коргун
7c1832fcfc Fix named collections related statements #51609 2023-07-27 09:41:47 +03:00
pufit
13d9952227 add id to insertImpl 2023-07-27 00:38:51 -04:00
hendrik-m
64b2d5ca15
Allow string literals for table names 2023-07-26 23:06:23 +02:00
Nikolay Degterinsky
d89e2e6a27
Add SYSTEM STOP LISTEN query (#51016)
Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-07-26 19:58:41 +02:00
Nikita Mikhaylov
1dc9ca2c24
Merge pull request #52549 from ClickHouse/whitespace-before-comma
Check for punctuation
2023-07-25 20:30:36 +02:00
Anton Popov
4531b105ac
Merge branch 'master' into flush-async-insert-queue 2023-07-25 15:48:01 +02:00
Alexey Milovidov
21382afa2b Check for punctuation 2023-07-25 06:10:04 +02:00
Alexey Milovidov
b53baa43ac
Merge pull request #51293 from ClickHouse/sql-fetch-allow-without-offset
Allow SQL standard `FETCH` without `OFFSET`
2023-07-25 05:44:39 +03:00
Alexander Tokmakov
c3e2077449
Merge branch 'master' into comment-db 2023-07-24 20:53:46 +03:00
Alexey Milovidov
9660bc0d99 Merge branch 'master' into sql-fetch-allow-without-offset 2023-07-24 19:50:40 +02:00
pufit
393481181d Remove Trailing whitespaces 2023-07-24 13:35:07 -04:00
Nikolay Degterinsky
a69d57bad5
Merge branch 'master' into perf-huge-ast 2023-07-24 15:27:22 +02:00
Nikolay Degterinsky
40652cf2de
Merge pull request #51899 from evillique/describe-table-settings
Allow SETTINGS before FORMAT in DESCRIBE TABLE query
2023-07-24 15:24:41 +02:00
Anton Popov
347f442f84 Merge remote-tracking branch 'upstream/master' into HEAD 2023-07-24 10:55:31 +00:00
Ilya Yatsishin
7a24ed195d
Merge branch 'master' into create-index-unique-noop 2023-07-23 20:47:11 +02:00
Alexey Milovidov
4fbd667687 Merge branch 'master' into sql-fetch-allow-without-offset 2023-07-22 18:41:32 +02:00
robot-clickhouse-ci-2
0db9c79886
Merge pull request #52332 from rschu1ze/better-formatsettings
Minor: Less awkward IAST::FormatSettings
2023-07-21 14:49:58 +02:00
ltrk2
90a2c460c6
Merge branch 'master' into feature/mergetree-checksum-big-endian-support 2023-07-21 08:07:18 -04:00
pufit
2a00e2aa6a Implement MOVE query for the access entities. 2023-07-20 22:20:36 -04:00
Val Doroshchuk
d16d444943 MaterializedMySQL: Add support of double quoted comments 2023-07-20 13:59:01 +02:00
János Benjamin Antal
e74acda53e
PRQL integration (#50686)
* Added prql-lib

* Add PRQL parser

* Extend stateless tests

* Add unit tests for `ParserPRQL`

---------

Co-authored-by: Ubuntu <ubuntu@ip-172-31-37-24.eu-central-1.compute.internal>
Co-authored-by: Ubuntu <ubuntu@ip-10-10-10-195.eu-central-1.compute.internal>
Co-authored-by: Александр Нам <47687537+seshWCS@users.noreply.github.com>
2023-07-20 12:54:42 +02:00
Robert Schulze
bd761c365a
Make serializeAST() more regular 2023-07-20 10:39:26 +00:00
Robert Schulze
25ddcc256b
Make IAST::FormatSettings more regular, pt. III 2023-07-20 10:34:05 +00:00
Robert Schulze
e5ec6a1523
Make IAST::FormatSettings more regular, pt. II 2023-07-20 10:32:55 +00:00
Robert Schulze
35a4fabc2d
Make IAST::FormatSettings more regular 2023-07-20 10:32:09 +00:00
Robert Schulze
7a0de384d4
Cosmetics 2023-07-20 10:25:08 +00:00
ltrk2
a3d0335f53 Fix a build error 2023-07-19 11:20:42 -07:00
ltrk2
ba4072f049 Adapt changes around SipHash 2023-07-19 10:01:58 -07:00
ltrk2
51e2c58a53 Implement endianness-independent SipHash and MergeTree checksum serialization 2023-07-19 10:01:55 -07:00
Robert Schulze
bdaf82922a
Use formatAST() 2023-07-19 12:56:15 +00:00
Yatsishin Ilya
b9b3222c6e Add support for CREATE UNIQUE INDEX systax in parser. No UNIQUE index created. 2023-07-19 12:23:39 +00:00
Alexey Milovidov
482c8b5cde
Merge pull request #52158 from ClickHouse/fix-unexpected-ast-set
Fix unexpected AST Set
2023-07-18 22:17:51 +03:00
Ilya Yatsishin
73246b4788
Merge pull request #52056 from ClickHouse/ignore-create-index-query
Allow to ignore CREATE INDEX query for better SQL syntax compatibility
2023-07-18 14:40:38 +02:00
Alexey Milovidov
da29166f08
Merge branch 'master' into fix-unexpected-ast-set 2023-07-17 23:17:55 +03:00
Nikita Mikhaylov
9a30aaa9aa
Revert "Fixed several issues found by OSS-Fuzz" 2023-07-17 16:14:58 +02:00
robot-ch-test-poll2
7f960c2379
Merge pull request #51160 from Algunenano/async_to_query_log
Log async insert flush queries into to system.query_log and system.processes
2023-07-17 13:49:22 +02:00
Nikita Mikhaylov
d04f39370a
Merge branch 'master' into oss-fuzz-fixes 2023-07-17 13:41:54 +02:00
Yatsishin Ilya
5b853c1958 Make ASTFuzzer happy 2023-07-17 11:32:22 +00:00
Alexey Milovidov
7915ba253b Better version 2023-07-17 04:49:04 +02:00
robot-clickhouse-ci-2
ac3cc1c2ff
Merge pull request #45671 from ClibMouse/feature/interval-kql-style-formatting
Implement KQL-style formatting for Interval
2023-07-16 04:06:54 +02:00
Yatsishin Ilya
2ee7a9846f fix 2023-07-12 12:47:24 +00:00
Yatsishin Ilya
3bd9c57a8c allow to ignore CREATE INDEX query for better SQL syntax compatibility 2023-07-12 09:29:36 +00:00
Amos Bird
a33b90c648
Projection & optimize_group_by_function_keys 2023-07-11 21:11:28 +08:00
Amos Bird
1739bb306a
Projection & optimize_aggregators_of_group_by_keys
Fix projection with optimize_aggregators_of_group_by_keys = true
2023-07-11 21:11:27 +08:00
pufit
77e45e5669 Add DROP ROLE ... FROM and CREATE ROLE ... AT syntax 2023-07-10 20:23:03 -04:00
ltrk2
9a74b97184 Improve naming 2023-07-10 13:51:49 -04:00
ltrk2
522b9ebf8c Implement KQL-style formatting for Interval 2023-07-10 13:51:49 -04:00
Raúl Marín
dbdfc07790
Merge branch 'master' into async_to_query_log 2023-07-10 10:32:56 +02:00
Alexey Milovidov
5d385f5f14
Merge pull request #51881 from qoega/per-column-pk-syntax
Add support for PRIMARY KEY syntax in column definition
2023-07-08 21:52:29 +03:00
Alexey Milovidov
2a8c7d0ea2
Update src/Parsers/ParserCreateQuery.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2023-07-08 21:52:19 +03:00
Alexey Milovidov
933a92e176 Merge branch 'master' into remove-useless-system-query 2023-07-08 01:45:19 +02:00
Ilya Yatsishin
7aacc35829
Merge branch 'master' into per-column-pk-syntax 2023-07-07 14:52:15 +02:00
Alexey Milovidov
7cece62d26 Revert "Merge pull request #51547 from kssenii/more-flexible-drop-cache"
This reverts commit 2ce7bcaa3d, reversing
changes made to e897207cd5.
2023-07-07 04:07:19 +02:00
Alexey Milovidov
f0cc90a7fb Revert "Merge pull request #51822 from kssenii/minor-changes"
This reverts commit 5ac85f4fa8, reversing
changes made to 376c903da9.
2023-07-07 04:07:03 +02:00
Nikolay Degterinsky
67e2dee7e2 Allow SETTINGS before FORMAT in DESCRIBE TABLE query 2023-07-06 14:29:58 +00:00
Raúl Marín
bd779c8066
Merge branch 'master' into async_to_query_log 2023-07-06 15:46:27 +02:00
Yatsishin Ilya
12ebb30781 style 2023-07-06 10:34:34 +00:00
Yatsishin Ilya
24e77083b3 Commit tests 2023-07-06 09:50:44 +00:00
Alexey Milovidov
d59f68b600 Remove useless code 2023-07-06 04:55:46 +02:00
Yatsishin Ilya
fd4f738502 Merge remote-tracking branch 'origin' into per-column-pk-syntax 2023-07-05 12:30:26 +00:00
Yatsishin Ilya
e957600d5c wip 2023-07-05 12:28:27 +00:00
kssenii
e6422f8144 Delete comment, rename variable 2023-07-05 13:08:11 +02:00
kssenii
80dabd1346 Merge remote-tracking branch 'upstream/master' into system-sync-cache 2023-07-05 12:58:11 +02:00
Kseniia Sumarokova
f2d942fbb5
Merge branch 'master' into more-flexible-drop-cache 2023-07-05 11:43:57 +02:00
Alexey Milovidov
289d9849d4 Allow SQL standard FETCH without OFFSET 2023-07-04 20:56:17 +02:00
Nikita Mikhaylov
673c30f717
Merge branch 'master' into oss-fuzz-fixes 2023-07-04 19:52:41 +02:00
Raúl Marín
7262433068
Merge branch 'master' into async_to_query_log 2023-07-04 12:59:04 +02:00
Nikita Mikhaylov
811ba86a20 Remove garbage 2023-07-04 00:24:35 +02:00
Nikita Mikhaylov
2e245f4a43 Even better 2023-07-04 00:23:00 +02:00
Sema Checherinda
bd3d6d4976
Merge pull request #51404 from CheSema/no-finalize-WriteBufferFromOStream
no finalize in d-tor WriteBufferFromOStream
2023-07-01 19:37:54 +02:00
kssenii
72d1834bbd system sync filesystem cache 2023-06-29 18:13:54 +02:00
kssenii
39f8b92e24 Allow to add disk name for custom disk 2023-06-28 19:05:35 +02:00
kssenii
1d78bafa82 Flexible drop cache 2023-06-28 18:44:47 +02:00
frinkr
f7e20d884f
update comments 2023-06-27 16:32:19 +08:00
frinkr
014aa81e0b
improve performace for huge ast by direct-writing the column name for ASTLiteral 2023-06-27 11:56:40 +08:00
Sema Checherinda
047f656980 add explicit finalize calls 2023-06-26 15:04:50 +02:00
Raúl Marín
2d860302d9
Merge branch 'master' into async_to_query_log 2023-06-26 13:57:04 +02:00
Alexey Milovidov
533a279f6c
Merge branch 'master' into alter-table-add-comment 2023-06-26 12:01:34 +03:00
Alexey Milovidov
1745535cb1 Add support for ALTER TABLE MODIFY COMMENT 2023-06-23 03:17:45 +02:00
Nikolay Degterinsky
0d2b9fd0e5 Add VALID UNTIL clause for users 2023-06-22 02:12:12 +00:00
Raúl Marín
b1cedf0e42 Simplify handling of AsyncInsertFlush 2023-06-20 11:38:19 +02:00
Raúl Marín
cf74aee6c9 Log async query flushes to query_log 2023-06-20 11:38:19 +02:00
alekar
b70803c71b
Merge branch 'master' into improve-outfile 2023-06-16 01:08:48 -07:00
Val Doroshchuk
e7c5991b39 MaterializedMySQL: Keep parenthesises for empty table overrides
Empty table overrides are formatted without any parenthesises,
but they are required by a parser,
and it is not possible to parse empty table overrides without it.

:) CREATE DATABASE db ... TABLE OVERRIDE t1()

CREATE DATABASE db
...
TABLE OVERRIDE `t1`

This query will be saved to metadata and ClickHouse will not be able to start up, since
table overrides require ().
2023-06-14 13:37:49 +02:00
Manas Alekar
bf69755ada Address some usability issues with INTO OUTFILE usage. 2023-06-13 01:26:11 -07:00
Robert Schulze
4f39ee51ae
Update Annoy docs 2023-06-12 20:06:57 +00:00
Robert Schulze
7745f7da73
Merge branch 'master' into annoy-misc 2023-06-12 21:46:27 +02:00
Robert Schulze
42914484b3
Merge pull request #50713 from rschu1ze/show-indices
Add SHOW INDICES as alias for statement SHOW INDEX/INDEXES/KEYS
2023-06-09 00:37:29 +02:00
Robert Schulze
b8178088d0
Misc Annoy fixes 2023-06-08 15:06:17 +00:00
Robert Schulze
6fcc4158d2
Add SHOW INDICES as alias for statement SHOW INDEX/INDEXES/KEYS 2023-06-08 12:51:33 +00:00
Val Doroshchuk
c37b80593c
MaterializedMySQL: Add support of TRUNCATE db.table (#50624)
Additional to `TRUNCATE TABLE db.table`.

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-06-08 14:22:55 +03:00
Robert Schulze
c12c62a7fb
Update src/Parsers/ParserCreateIndexQuery.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2023-06-07 18:22:53 +02:00
Anton Popov
c980771c22 Merge remote-tracking branch 'upstream/master' into HEAD 2023-06-07 11:23:13 +00:00
Robert Schulze
4050b637f1
ALTER TABLE ADD INDEX: Add default GRANULARITY argument for secondary indexes
- Related to #45451, which provides a default GRANULARITY when the
  skipping index is created in CREATE TABLE.
2023-06-07 09:04:24 +00:00
Alexey Milovidov
091d6d02f7
Merge pull request #50536 from ClickHouse/fix-incorrect-constant-folding
Fix incorrect constant folding
2023-06-05 04:35:53 +03:00
Alexey Milovidov
6f01e2ad9f Fix incorrect constant folding 2023-06-04 02:49:45 +02:00
pufit
1aaac69e13
Merge branch 'master' into roles_in_config 2023-06-03 14:42:10 -04:00
Nikita Mikhaylov
362055ce60
Merge branch 'master' into 46229-repl-clickhouse-keeper 2023-06-02 23:58:07 +02:00
Alexey Milovidov
379c573db0
Merge branch 'master' into isnull-operator-priority 2023-06-01 03:20:22 +03:00
pufit
dbd3766f5f Specify roles in users.xml 2023-05-30 20:42:49 -04:00
Nikita Mikhaylov
31829f7cfc
Merge branch 'master' into 46229-repl-clickhouse-keeper 2023-05-31 02:29:08 +02:00
Nikolay Degterinsky
1a6517d4a0 Fix priority of the operators after IS NULL 2023-05-30 17:13:39 +00:00
Nikolay Degterinsky
391e61549d Fixes 2023-05-30 12:18:56 +00:00
Nikolay Degterinsky
e10f951467 Fix IS (NOT) NULL operator priority 2023-05-29 19:11:09 +00:00
Nikita Mikhaylov
0580859e6f Better 2023-05-25 14:05:44 +00:00
Nikita Mikhaylov
cf6ff7ab32 Merge branch 'master' of github.com:ClickHouse/ClickHouse into 46229-repl-clickhouse-keeper 2023-05-25 13:41:25 +00:00
Azat Khuzhin
b680697cce Initialize POD members of ASTs to make it less error-prone
The cost of initializing members is insignificant in compare to parsing,
while the cost of the error is high.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:18:55 +02:00
Azat Khuzhin
b30cfe5503 Fix UB in ASTWatchQuery for is_watch_events
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:30 +02:00
Azat Khuzhin
c053d75741 Fix formatting of INTO OUTFILE extensions (APPEND / AND STDOUT)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:30 +02:00
Azat Khuzhin
9582d9e892 Fix UB for INTO OUTFILE extensions (APPEND / AND STDOUT)
MSAn report:

==38627==WARNING: MemorySanitizer: use-of-uninitialized-value
    0 0x555599f5e114 in std::__1::__unique_if<DB::WriteBufferFromFile>::__unique_single std::__1::make_unique[abi:v15000]<> build_docker/./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714:32
    1 0x555599f5e114 in DB::ClientBase::initOutputFormat() build_docker/./src/Client/ClientBase.cpp:604:21
    2 0x555599f590a8 in DB::ClientBase::onData() build_docker/./src/Client/ClientBase.cpp:446:5
    3 0x555599f6f36e in DB::ClientBase::receiveAndProcessPacket() build_docker/./src/Client/ClientBase.cpp:1019:17
    4 0x555599f6e863 in DB::ClientBase::receiveResult() build_docker/./src/Client/ClientBase.cpp:987:18
    5 0x555599f6c05b in DB::ClientBase::processOrdinaryQuery() build_docker/./src/Client/ClientBase.cpp:905:13
    6 0x555599f67e05 in DB::ClientBase::processParsedSingleQuery() build_docker/./src/Client/ClientBase.cpp:1711:13
    7 0x555599f86fb6 in DB::ClientBase::executeMultiQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:1975:21

  Uninitialized value was created by a heap allocation
    8 0x55559bd3e038 in DB::ParserExplainQuery::parseImpl(DB::IParser::Pos&, std::__1::shared_ptr<DB::IAST>&, DB::Expected&) build_docker/./src/Parsers/ParserExplainQuery.cpp:53:26
    9 0x55559bce31f4 in DB::IParserBase::parse(DB::IParser::Pos&, std::__1::shared_ptr<DB::IAST>&, DB::Expected&)::$_0::operator()() const build_docker/./src/Parsers/IParserBase.cpp:13:20
    ..
    21 0x55559be13b5c in DB::parseQueryAndMovePosition(DB::IParser&, char const*&, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, unsigned long, unsigned long) build_docker/./src/Parsers/parseQuery.cpp:357:18
    22 0x555599f5673a in DB::ClientBase::parseQuery(char const*&, char const*, bool) const build_docker/./src/Client/ClientBase.cpp:362:15
    23 0x555599f84a4f in DB::ClientBase::analyzeMultiQueryText() build_docker/./src/Client/ClientBase.cpp:1821:24
    24 0x555599f867b3 in DB::ClientBase::executeMultiQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:1910:22
    25 0x555599f8a2fd in DB::ClientBase::processQueryText(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:2120:12
    26 0x555599f94aee in DB::ClientBase::runNonInteractive() build_docker/./src/Client/ClientBase.cpp:2403:9

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:23 +02:00
Anton Popov
69ec65ab33 Merge remote-tracking branch 'upstream/master' into HEAD 2023-05-16 10:30:47 +00:00
Vitaly Baranov
801cacc13f
Merge pull request #49831 from vitlibar/fix-setting-null-in-profile-def
Fix setting NULL in profile definition
2023-05-15 22:24:49 +02:00
Ilya Golshtein
9ef610040f row_policy_template - table * is respected 2023-05-13 22:30:02 +00:00
Ilya Golshtein
7fa6ea4ccc row policy template: tests and code cleanup, code review changes 2023-05-13 22:30:02 +00:00
Ilya Golshtein
f0d21a9100 row policy template: initial, works, restrictive rules fix 2023-05-13 22:30:02 +00:00
Alexey Milovidov
c306deb1ae
Merge pull request #49087 from Eridanus117/suffix_size
improvement(parser): size suffixes in quota creation parameters
2023-05-13 01:56:10 +03:00
Robert Schulze
b9c185af44
Merge pull request #49678 from azat/build/llvm-16
Switch to LLVM/clang 16 (16.0.3)
2023-05-12 13:47:36 +02:00
Vitaly Baranov
eb62030fa4 Fix assigning a setting to NULL in settings profile's definition. 2023-05-12 11:04:30 +02:00
Vitaly Baranov
ec011b9113
Merge branch 'master' into user-grants-from-config 2023-05-11 17:08:06 +02:00
Eridanus
990c224540 improvement(parser): add support for size suffixes in quota creation
statement parameters

This commit adds support for creating quotas with size suffixes in the
parameter list of a quota creation statement. The parser now recognizes
size suffixes such as "KB", "MB", and "GB" and correctly converts them
to their corresponding values in bytes. This feature improves the
usability of the quota creation statement and makes it more flexible.
The commit also includes additional tests to ensure that the new syntax
is parsed correctly.
Attention: we did not support string literal with double like
execute_time = '1.5'
2023-05-11 20:04:53 +08:00
Azat Khuzhin
a0cc5b7e47 Merge remote-tracking branch 'u/master' into build/llvm-16 2023-05-10 16:28:36 +02:00
Han Fei
d17aa828b3
Merge pull request #49361 from hanfei1991/hanfei/fiu
support named fault injection and add a simple test
2023-05-10 15:51:51 +02:00
vdimir
1b7f54e886
Merge pull request #46467 from bigo-sg/first_value 2023-05-10 14:56:14 +02:00
alekar
605991d4d5
Merge branch 'master' into 48716 2023-05-09 13:38:11 -07:00
Azat Khuzhin
0610865811 Fix readability-redundant-string-cstr clang-tidy warning
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:22:05 +02:00
Han Fei
64b67b9a37 Merge branch 'master' into hanfei/fiu 2023-05-09 01:14:30 +02:00
Robert Schulze
7137c8811a
Merge pull request #49158 from ClickHouse/rs/show-indexes
Implement SHOW INDEX
2023-05-06 15:30:29 +02:00
pufit
04a829b554 Fix PR issues 2023-05-05 22:41:44 -04:00
Nikolay Degterinsky
d35142ba65 Allow parameters in queries with partitions 2023-05-04 14:50:26 +00:00
Eridanus
d428c461fc
Merge branch 'master' into suffix_size 2023-05-04 17:39:27 +08:00
alesapin
89caf40840
Merge pull request #46528 from myrrc/feature/show-secrets-option
Show secrets in `SHOW` and `SELECT` queries
2023-05-04 11:21:30 +02:00
Eridanus
72b35729ae
Merge branch 'master' into suffix_size 2023-05-04 13:55:40 +08:00
alekar
af81f056b4
Merge branch 'master' into 48716 2023-05-03 18:35:54 -07:00
Alexander Tokmakov
e399903030
Merge pull request #48548 from ClickHouse/clusters_is_active_column
Add some columns to system.clusters
2023-05-03 17:42:40 +03:00
Nikolay Degterinsky
4c038ef538
Merge branch 'master' into bcrypt 2023-05-02 21:52:21 +02:00
Nikolay Degterinsky
46c86dce93 Fix bcrypt enum value 2023-05-02 14:36:48 +00:00
Robert Schulze
7e5fded3cf
A little less clutter 2023-05-02 13:16:15 +00:00
Nikolay Degterinsky
f87c418fc8
Merge pull request #49360 from evillique/alias-restricted-keywords
Allow restricted keywords if alias is quoted
2023-05-02 15:02:05 +02:00
Robert Schulze
6bdbee33ee
Incorporate review feedback 2023-05-02 12:29:56 +00:00
pufit
2964ca5c84 Specify grants for users in users.xml 2023-05-01 20:24:02 -04:00
Han Fei
d608ba41e7 try to fix 2023-05-02 00:05:36 +02:00
Han Fei
4d18a4f8d3
Merge branch 'master' into hanfei/fiu 2023-05-01 17:51:41 +02:00
Han Fei
b701293d46 support named fault injection and add a simple test 2023-05-01 17:44:37 +02:00
Nikolay Degterinsky
76a591fa5e Allow restricted keywords if alias is quoted 2023-05-01 15:16:12 +00:00
alekar
29d96afae8
Merge branch 'master' into 48716 2023-04-28 14:24:46 -07:00
Mike Kot
2d20658885
Merge branch 'master' into feature/show-secrets-option 2023-04-28 20:19:35 +03:00
Nikolay Degterinsky
54c8f63a33 Fixes 2023-04-28 15:12:06 +00:00
Alexey Milovidov
6dcfdbfaf2
Merge branch 'master' into clusters_is_active_column 2023-04-28 16:16:25 +03:00
Eridanus
d479404318 improvement(parser): size suffixes in quota creation parameters
This commit adds support for creating quotas with size suffixes in the
parameter list of a quota creation statement. The parser now recognizes
size suffixes such as "KB", "MB", and "GB" and correctly converts them
to their corresponding values in bytes. This feature improves the
usability of the quota creation statement and makes it more flexible.
The commit also includes additional tests to ensure that the new syntax
is parsed correctly.
2023-04-28 14:05:16 +08:00
Mike Kot
357cde95e9 Merge branch 'master' into feature/show-secrets-option 2023-04-27 20:19:40 +00:00
Nikolay Degterinsky
df1e56b985 Merge remote-tracking branch 'upstream/master' into bcrypt 2023-04-27 17:01:58 +00:00
Robert Schulze
c58e0e347c
Various cleanups 2023-04-26 09:46:35 +00:00
pufit
8bef8fc1de Parsing Keeper commands via ClickHouse Parser 2023-04-26 00:54:28 -04:00
Anton Popov
125e5c50b8 allow to flush async insert queue 2023-04-25 21:30:03 +00:00
Robert Schulze
c4ab1e12f1
Initial version of SHOW INDEXES 2023-04-25 20:48:11 +00:00
alekar
d717f007d7
Merge branch 'master' into 48716 2023-04-24 23:44:03 -07:00
Nikolay Degterinsky
2fe3a69ba1 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-24 18:51:32 +00:00
Nikolay Degterinsky
12ad5b710a Separate AuthenticationData and AuthenticationType, small fixes 2023-04-24 15:12:45 +00:00
pufit
1985fb785e
Merge pull request #48262 from ClickHouse/42497-inherit-grant
GRANT CURRENT GRANTS implementation
2023-04-24 11:11:10 -04:00
Alexander Tokmakov
332a736a59 Merge branch 'master' into clusters_is_active_column 2023-04-24 15:54:03 +02:00
Nikolay Degterinsky
b599d0bd01 Better 2023-04-21 22:03:56 +00:00
pufit
544972bcda Solve PR issues 2023-04-20 18:31:35 -04:00
lgbo-ustc
10daacb18f updated 2023-04-20 09:28:49 +08:00
lgbo-ustc
bd84b7a87a support syntax, respect nulls/ignore nulls 2023-04-20 09:28:49 +08:00
Manas Alekar
8cc425cd29 INTO OUTFILE enhancements 2023-04-18 00:20:55 -07:00
kssenii
0517de58d1 Simplify FileCacheFactory 2023-04-15 16:15:20 +02:00
Robert Schulze
8eabc43068
Merge pull request #48591 from ucasfl/show-table
support show table
2023-04-14 18:42:29 +02:00
Robert Schulze
adb15b7033
Merge branch 'master' into show-table 2023-04-14 09:52:56 +02:00
Dmitry Novik
5cc9b46f78 Merge remote-tracking branch 'origin/master' into optimize-compilation 2023-04-13 16:04:09 +02:00
Robert Schulze
f6b24fe058
Merge pull request #48509 from ClibMouse/feature/no-more-strlen-plz
Use std::string_view to get rid of strlen
2023-04-13 10:59:05 +02:00
pufit
aa0f3bc994 Solve pr issues 2023-04-12 20:28:17 -04:00
Robert Schulze
3f7ce60e03
Merge branch 'master' into rs/gcc-removal 2023-04-12 22:17:04 +02:00
ltrk2
c3f5da3343 Remove element that used to serve as a sentinel 2023-04-12 12:15:53 -07:00
ltrk2
65e08781a6 Use std::string_view to get rid of strlen 2023-04-12 11:33:11 -07:00
pufit
078b8f5399 Small refactor, additional tests 2023-04-11 19:55:59 -04:00
Robert Schulze
05606a8835
Clean up GCC warning pragmas 2023-04-11 18:21:08 +00:00
Alexander Tokmakov
dfff30e1a9 Merge branch 'master' into clusters_is_active_column 2023-04-11 16:32:15 +02:00
Nikolay Degterinsky
0621222737 Fix crashes with incorrect query parameters 2023-04-11 14:22:55 +00:00
robot-ch-test-poll1
028ccfdc87
Merge pull request #48438 from evillique/add-trailing-commas
Allow trailing commas in expression list of SELECT query
2023-04-11 14:21:28 +02:00
Nikolay Degterinsky
908be1e324 Fix tests 2023-04-10 22:04:10 +00:00
Nikolay Degterinsky
6f57a952d9 Improvements 2023-04-10 16:40:49 +00:00
flynn
5a8d10c0e0 fix 2023-04-10 10:46:47 +00:00
flynn
dfe9ce6ec4 fix 2023-04-10 08:27:55 +00:00
flynn
f87782b6b5 support show table 2023-04-10 06:37:47 +00:00
Nikolay Degterinsky
dbc620f7e2 Fix style 2023-04-10 02:59:42 +00:00
Nikolay Degterinsky
7957752128 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-10 02:25:46 +00:00
Nikolay Degterinsky
64dc60a8d1 Better version, introduce ASTAuthenticationData 2023-04-10 02:20:57 +00:00
Nikolay Degterinsky
10883d8af5 Allow commas with subqueries, add comments 2023-04-09 12:52:23 +00:00
Alexander Tokmakov
9ec91acef3 add some columns to system.clusters 2023-04-07 18:26:23 +02:00
pufit
144ee7aed4 Fix logic, additional tests 2023-04-05 22:52:31 -04:00
Nikolay Degterinsky
061be7c9ad Add trailing commas to expression list in SELECT query 2023-04-05 18:08:56 +00:00
Vitaly Baranov
82373890e5
Merge branch 'master' into fix-forgotten-showsecrets-in-semi-copy-ctor 2023-04-05 18:17:33 +02:00
pufit
8441b0a3e1 Fix comments, tests, docs 2023-04-04 20:43:15 -04:00
Robert Schulze
e031783ae5
More CMake fixes 2023-04-04 15:39:16 +00:00
natasha
c3acaecce6 fix style - missed tab 2023-04-04 16:04:33 +01:00
natasha
647fb63b83 rm unneeded parentheses 2023-04-04 16:01:15 +01:00
natasha
a1d3ea92b9 Merge remote-tracking branch 'origin/master' into format-hiliting-fix 2023-04-04 15:55:40 +01:00
natasha
95d77193af add comment re excessive copying in are_equal_with_hilites_removed 2023-04-04 15:54:42 +01:00
natasha
46691ef705 add check that all strings end without any hilite 2023-04-04 15:51:12 +01:00
natasha
a1d718c601 update docstring for consume_hilites 2023-04-04 15:12:52 +01:00
natasha
cba124f99c fix while in consume_hilites 2023-04-04 15:04:50 +01:00
natasha
f6db4fa466 avoid explicit check if strings are_equal_without_hilites in are_equal_with_hilites
if anyone needs it, they can call it themselves
2023-04-04 15:00:14 +01:00
natasha
0a021d3378 refactor consume_hilites to assign last_hilite to an argument, rather than return it, to avoid code duplication in are_equal_with_hilites 2023-04-04 14:58:39 +01:00
natasha
f3560a295d accept the pointer by & in consume_hilites, rather than by a pointer to the pointer 2023-04-04 14:39:03 +01:00
natasha
2e9607f9c1 Fix style 2023-04-04 14:33:50 +01:00
natasha
86edd48096 HiliteComparator: add Hilite alias for const char * representing hilites 2023-04-04 14:29:02 +01:00
natasha
2ff5d60509 change compare argument order to be expected, query (=actual) 2023-04-04 14:20:13 +01:00
natasha
ebb8899a3d restructure format hiliting tests to avoid code duplication 2023-04-04 14:19:06 +01:00
natasha
3e11c06976 extract HiliteComparator tests into an own test suit 2023-04-04 12:41:08 +01:00
natasha
3452e1927e move const var definition in HiliteComparator 2023-04-04 12:36:41 +01:00
natasha
880e44132f fix hilite comparator tests 2023-04-04 12:36:22 +01:00
natasha
779bd3bf4d move hilite comparator tests as well 2023-04-04 11:27:02 +01:00
Alexey Milovidov
de8f7a5ad6
Merge pull request #48189 from vitlibar/backup-all
Support BACKUP ALL command
2023-04-04 01:57:23 +03:00
Robert Schulze
c8ef87f984
Fix build 2023-04-03 13:57:16 +00:00
natasha
14b4fde1b4 extract hilite comparator tests 2023-04-03 13:49:43 +01:00
natasha
61cfad1f6d extract hilite comparator into a utility 2023-04-03 13:39:17 +01:00
natasha
264c129a96 fix misplaced ( in ASTCreateQuery.cpp 2023-04-03 12:54:34 +01:00
Vitaly Baranov
b6adc25895
Merge pull request #48289 from murfel/fix-alter-formatting
Fix alter formatting (minor)
2023-04-03 12:35:58 +02:00
pufit
f2790a15ff CURRENT GRANTS(...) implementation 2023-03-31 17:35:32 -04:00
Alexander Tokmakov
e39498129c
Merge branch 'master' into sync_replica_lightweight 2023-03-31 18:17:08 +03:00
Robert Schulze
e1d299640b
Small follow-up to #48017 2023-03-31 14:11:37 +00:00
Alexander Tokmakov
75ffc8451b fix 2023-03-31 16:09:00 +02:00
Robert Schulze
5d64841276
Merge pull request #48017 from ClickHouse/rs/show_columns
MySQL compatibility: Implement `SHOW COLUMNS`
2023-03-31 15:50:23 +02:00
natasha
aa78728f17 copy forgotten show_secrets in FormatSettings semi-copy-ctor 2023-03-31 14:44:26 +01:00
natasha
644d83653d only set the necessary FormatStateStacked settings 2023-03-31 14:10:16 +01:00
Alexander Tokmakov
caf00b5968 Merge branch 'master' into sync_replica_lightweight 2023-03-31 14:52:55 +02:00
natasha
6caacd41d4 fix the code, single line formatter was forgotten 2023-03-31 13:45:12 +01:00
pufit
dacdbe469e GRANT CURRENT GRANTS implementation 2023-03-30 18:15:08 -04:00
Ilya Yatsishin
baabc49f33
Update ParserKQLSort.cpp
Style
2023-03-30 11:01:51 +02:00
Vitaly Baranov
42c2ccb7cc Support BACKUP ALL command. 2023-03-30 00:11:13 +02:00
Alexander Gololobov
98b3617ce2
Merge pull request #48150 from DimasKovas/fix_stdlib_compatibility
Fix stdlib compatibility issues
2023-03-29 21:29:33 +02:00
Dmitrii Kovalkov
71a6a02e88 fix stdlib compatibility issues 2023-03-29 12:20:27 +03:00
Robert Schulze
12559236ee
Another style fix 2023-03-28 21:01:59 +00:00
Robert Schulze
6c84eabb79
Fix stylecheck 2023-03-28 20:07:26 +00:00
Robert Schulze
202f52dc3a
Implement SHOW COLUMNS
Modeled after (*)

Fixes #46437

(*) https://dev.mysql.com/doc/refman/8.0/en/show-columns.html
2023-03-28 18:04:22 +00:00
natasha
e984e221ce get rid of std::stringstream 2023-03-28 17:21:55 +01:00
natasha
d7d008c44d fix typo in hilite_none 2023-03-28 17:21:55 +01:00
natasha
ba17db5365 fix ASTCreateQuery test 2023-03-28 17:21:55 +01:00
natasha
f36ad31751 add bug: second parenthesis ) not hilited in CREATE TABLE name AS (SELECT *) COMMENT 'hello' 2023-03-28 17:21:55 +01:00
natasha
5681f2c130 remove unused compare std::stringstream overload 2023-03-28 17:21:55 +01:00
natasha
df5824a2d2 contstruct string directly without std::stringstream in tests 2023-03-28 17:21:55 +01:00
natasha
a7614b844e rename const char * it into ptr 2023-03-28 17:21:54 +01:00
natasha
36ef622853 change compare signature to accept both args as String, for symmetry 2023-03-28 17:21:54 +01:00
natasha
e14675935a remove const& from std::string_view 2023-03-28 17:21:54 +01:00
natasha
a862973f14 amend comment on hilite equality 2023-03-28 17:21:54 +01:00
natasha
cf057013ed hilite view()'s parenthesis as function as well 2023-03-28 17:21:54 +01:00
natasha
a4dfba11c5 replace std::string with String 2023-03-28 17:21:54 +01:00
natasha
ddfc72a6ca use () for c-tor, not {} 2023-03-28 17:21:53 +01:00
natasha
134ec0f6b0 remove const& from std::string_view 2023-03-28 17:21:53 +01:00
natasha
95a8905be6 split ostr writes for readability 2023-03-28 17:21:53 +01:00
natasha
9e8ad944d6 fix symmetry 2023-03-28 17:21:53 +01:00
natasha
bf4a3a23fa compare string without hilites first, for easier debug 2023-03-28 17:21:53 +01:00
natasha
ed22d0f028 fix bugs (now tests pass) 2023-03-28 17:21:53 +01:00
natasha
da5285004d add failing tests 2023-03-28 17:21:53 +01:00
natasha
086fe077c9 cleanup 2023-03-28 17:21:53 +01:00
natasha
103bb9bf03 add a hilite-aware equality comparator and a sample test 2023-03-28 17:21:53 +01:00
Alexander Tokmakov
b5fe1ada0b more options for sync replica 2023-03-28 01:39:36 +02:00
xiedeyantu
5a18e0d5a5 support undrop table 2023-03-27 22:16:36 +08:00
Dmitry Novik
3488a4d84b Improve file includes 2023-03-24 03:44:52 +01:00
robot-clickhouse
1aeba53b92
Merge pull request #47908 from evillique/fix-grant-query-formatting
Fix GRANT query formatting
2023-03-23 05:47:43 +01:00
Nikolay Degterinsky
577130a9f6 Fix GRANT query formatting 2023-03-22 19:17:47 +00:00
Robert Schulze
784b34f5d8
Merge pull request #47869 from ClickHouse/rs/bug-47530
Add REGEXP operator
2023-03-22 10:31:25 +01:00
Robert Schulze
5091bd42f0
Add REGEXP operator (Bug: 47530) 2023-03-21 21:29:19 +00:00
Kseniia Sumarokova
a9bcd022d5
Merge pull request #46241 from kssenii/named-collections-granular-access
Allow separate grants for every named collection
2023-03-21 12:27:53 +01:00
Vladimir C
ab1105a5a6
Merge pull request #47685 from ClickHouse/vdimir/issue_47533 2023-03-21 11:41:00 +01:00
flynn
7531840fd7 Support fuzz Explain query 2023-03-21 02:41:51 +00:00
kssenii
75624c52f7 Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-03-20 16:38:14 +01:00
vdimir
19fb88c2c1
Simple fix logical error in evaluate constant expression 2023-03-20 15:10:50 +00:00
Alexey Milovidov
2a077f11f6 Merge branch 'master' into fuzzer-of-data-formats 2023-03-19 01:07:31 +01:00
Alexey Milovidov
c11915d35b Merge branch 'fix-bson-2' of github.com:Avogar/ClickHouse into fuzzer-of-data-formats 2023-03-17 22:05:46 +01:00
Alexander Tokmakov
d11aee2b0c
Merge branch 'master' into fix_993 2023-03-17 21:28:23 +03:00
vdimir
4930683aa8
Revert "Fix logical error in evaluate constant expression"
This reverts commit 2958c5f0f1.
2023-03-17 17:01:40 +00:00
vdimir
2958c5f0f1
Fix logical error in evaluate constant expression 2023-03-17 15:08:16 +00:00
Alexander Tokmakov
8e36f883d3 add 'strict' mode for sync replica, fix 00993 2023-03-16 16:04:42 +01:00
alesapin
8974ba1fad
Update ASTDeleteQuery.cpp
Remove format clause because we do it in ASTQueryWithOutput::formatImpl.
2023-03-15 17:37:26 +01:00
alesapin
e3dd7d79b0 Update src/Parsers/ASTDeleteQuery.cpp 2023-03-15 16:35:56 +01:00
Nikita Mikhaylov
f0b514acae Better 2023-03-13 15:20:01 +01:00
Alexey Milovidov
2e3aa98535 Add a test, fix logical errors 2023-03-13 06:46:19 +01:00
Alexey Milovidov
4cfc040829 Fix parameterized queries 2023-03-11 20:16:06 +01:00
Alexander Tokmakov
38f9f08e1a
Merge pull request #47268 from myrrc/improvement/more-to-base-3
use std::lerp, constexpr hex.h
2023-03-08 19:07:34 +03:00
Alexey Milovidov
e2aff59a2d
Merge pull request #47106 from kssenii/allow-nested-disks-in-custom-disks
Allow nested custom disks
2023-03-08 03:00:55 +03:00
Mike Kot
9920a52c51 use std::lerp, constexpr hex.h 2023-03-07 22:50:17 +00:00
Mike Kot
1fca58b694
Merge branch 'master' into feature/show-secrets-option 2023-03-06 15:46:54 +03:00
kssenii
0c4bb3c80f Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-03-02 19:08:29 +01:00
kssenii
10610cbdf4 Fix test 2023-03-02 14:46:20 +01:00
kssenii
13d50509c0 Fix style check 2023-03-01 20:16:15 +01:00
kssenii
f3e3b916c9 Allow nested custom disks 2023-03-01 19:55:59 +01:00
Maksim Kita
d39be3ac9c Fixed tests 2023-03-01 18:05:07 +01:00
Mike Kot
c799bd094b
Merge branch 'master' into feature/show-secrets-option 2023-02-27 18:43:14 +03:00
Mike Kot
62acc7a6cf setting and some docs 2023-02-27 13:18:21 +00:00
Nikolay Degterinsky
10c04d5a38
Fix clone() for ASTColumnMatchers 2023-02-27 12:26:36 +01:00
Robert Schulze
c668ddd506
Make ASTSelectQuery::formatImpl() more robust
Fixes #45204

The problem is that ASTSelectQuery::group_by_with_grouping_sets == true
implies ASTSelectQuery::groupBy() but sometimes this wasn't the case. I
added a sanity check a few months ago but had no idea how the AST became
corrupt.

All crashes/exceptions were during AST fuzzing. Looking at
Client/QueryFuzzer.cpp, there is a very small chance to run into the
issue. In detail:

1. In QueryFuzzer::fuzz(), we find that the AST is a ASTSelectQuery and
   groupBy() returns true.

2. With small probability, we do
     select->group_by_with_grouping_sets = !select->group_by_with_grouping_sets;
   where the (default false) group_by_with_grouping_sets flips true.

3. With small probability, we change the expression type in the
   following WHERE or PREWHERE if-branches.

This situation is illegal. One possibility is changing the fuzzing code
to not generate it. The fuzzing code is however generic, and doesn't
really care about such details. Therefore, instead add an (theoretically
unnecessary) extra check to ASTSelectQuery::formatImpl() for robustness.
2023-02-25 22:28:00 +00:00
kssenii
536446d526 Remove debug logs 2023-02-24 18:09:00 +01:00
kssenii
f2a9109fe1 Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-02-24 15:20:46 +01:00
kssenii
0555ca2724 Review fixes 2023-02-24 14:44:47 +01:00
Alexander Tokmakov
f76c42348b
Merge pull request #46402 from lzydmxy/apply_move_partition_to_all_replicas
Apply `ALTER TABLE ON CLUSTER MOVE PARTITION TO DISK|VOLUME` to all replicas.
2023-02-23 19:42:54 +03:00
Alexey Milovidov
7d837eea86
Update FieldFromAST.cpp 2023-02-23 08:15:14 +03:00
kssenii
c4761d6cc6 Fix checks 2023-02-22 14:27:43 +01:00
kssenii
f0ca3ef207 Merge remote-tracking branch 'upstream/master' into named-collections-granular-access 2023-02-22 14:02:29 +01:00
kssenii
1f0ab8d427 Hide disk setting arguemtns 2023-02-21 19:24:01 +01:00
Alexey Milovidov
5ef159fa10
Merge pull request #46565 from ClickHouse/remove-pvs-studio
Remove PVS-Studio
2023-02-20 17:10:53 +03:00
Nikolay Degterinsky
f9dac6d4cf
Fix ASTAsterisk::clone() 2023-02-20 00:26:14 +01:00
Alexey Milovidov
d8cda3dbb8 Remove PVS-Studio 2023-02-19 23:30:05 +01:00
Nikolay Degterinsky
5104b2e8bf
Merge branch 'master' into parameters-rename-query 2023-02-17 17:30:37 +01:00
Nikolay Degterinsky
3b19823960
Merge branch 'master' into replace-transformer-fix-parameters 2023-02-17 02:02:54 +01:00
Alexander Tokmakov
00f9a94ddb
Merge branch 'master' into apply_move_partition_to_all_replicas 2023-02-16 20:22:35 +03:00
youennL-cs
6526c2a8ab
[RFC] Replacing merge tree new engine (#41005)
* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add new engine to ReplacingMergeTree corresponding to the ReplacingCollapsingMergeTree

* Add new test for the new ReplacingMergeTree engine

* Limit sign value to -1/1

* Replace sign column(Int8) by is_deleted(UInt8)

* Add keyword 'CLEANUP' when OPTIMIZE

* Cleanup uniquely when it's a replacingMergeTree

* Propagate CLEANUP information and change from 'with_cleanup' to 'cleanup'

* Cleanup data flagged as 'is_deleted'

* Fix merge when optimize and add a test

* Fix OPTIMIZE and INSERT + add tests

* New fix for cleanup at the merge

* Cleanup debug logs

* Add the SETTINGS option 'clean_deleted_rows' that can be 'never' or 'always'

* Fix regression bug; Now REplicatedMergeTree can be called as before without 'is_deleted'

* Add Replicated tests

* Disable tag 'long' for our test and cleanup some white spaces

* Update tests

* Fix tests and remove additional useless whitespace

* Fix replica test

* Style clean && add condition check for is_deleted values

* clean_deleted_rows settings is nom an enum

* Add valid default value to the clean_deleted_rows settings

* Update cleanup checkers to use the enum and fix typos in the test

* Fix submodule contrib/AMQP-CPP pointer

* Add missing messages in test reference and remove a print with non derterministic order

* fix replica test reference

* Fix edge case

* Fix a typo for the spell checker

* Fix reference

* Fix a condition to raise an error if is_deleted differ from 0/1 and cleanup

* Change tests file name and update number

* This should fix the ReplacingMergeTree parameter set

* Fix replicated parameters

* Disable allow_deprecated_syntax_for_merge_tree for our new column

* Fix a test

* Remove non deterministic order print in the test

* Test on replicas

* Remove a condition, when checking optional parameters, that should not be sueful since we disabled the deprected_syntaxe

* Revert "Remove a condition, when checking optional parameters, that should not be useful since we disabled the deprected_syntaxe"

This reverts commit b65d64c05e.

* Fix replica management and limit the number of argument to two maximum, due to the possiblity of deprecated table create/attach failing otherwise

* Test a fix for replicated log information error

* Try to add sync to have consistent results

* Change path of replicas that should cause one issue and add few prints in case it's not that

* Get cleanup info on replicas only if information found

* Fix style issues

* Try to avoid replication error 'cannot select parts...' and and replica read/write field order

* Cleanup according to PR reviews
 and add tests on error raised.

* Update src/Storages/MergeTree/registerStorageMergeTree.cpp

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>

* Select ... FINAL don't show rows with is_deleted = true

* Update and fix SELECT ... FINAL merge parameter

* Remove is_deleted rows only on the version inserted when merge

* Fix (master) updates issues

* Revert changes that should not be commited

* Add changes according to review

* Revert changes that should not be commited - part 2

---------

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-02-16 16:03:16 +03:00
Nikolay Degterinsky
d9ffbeb4a2 Small improvements 2023-02-16 10:51:13 +00:00
kssenii
0c53f33e6f Make code more common: add GlobalWithParameter level 2023-02-15 16:59:43 +01:00
Nikolay Degterinsky
3075656e1d Merge remote-tracking branch 'upstream/master' into HEAD 2023-02-15 10:06:44 +00:00
Nikolay Degterinsky
24bbf885db
Merge branch 'master' into parameters-rename-query 2023-02-15 10:53:44 +01:00
Nikolay Degterinsky
eb3a7f55b9 Fix parameterized queries with REPLACE transformer 2023-02-14 22:02:54 +00:00
kssenii
33572f9acd Better 2023-02-14 19:50:27 +01:00
Nikolay Degterinsky
b9d3160107 Add parameterized RENAME queries 2023-02-14 13:01:06 +00:00
lzydmxy
bbf94a2664 Apply ALTER TABLE table_name ON CLUSTER cluster MOVE PARTITION|PART partition_expr TO DISK|VOLUME 'disk_name' to all replicas.
Because `ALTER TABLE t MOVE` is not replicated.
2023-02-14 17:29:44 +08:00
Alexander Tokmakov
304b9f1a93 remove trash from MOVE PARTITION command 2023-02-13 16:10:16 +01:00
Alexey Milovidov
c6dc39f9e2
Merge pull request #46232 from aiven-sal/aiven-sal/format
ASTFunction: never rewrite tuple function as literal when formatting
2023-02-11 05:56:08 +03:00
kssenii
78c809608c Fix 2023-02-10 23:45:53 +01:00
Han Fei
2190a2a6c4
Merge pull request #46043 from ucasfl/view-syntax
Forbid wrong create view syntax
2023-02-10 21:54:57 +01:00
kssenii
6f985b8ae0 Fix unit test, cleanup code 2023-02-10 18:49:18 +01:00
flynn
45ee7c7081 fix 2023-02-10 13:56:47 +00:00
kssenii
c13b0b8a06 Fix tests 2023-02-10 14:39:09 +01:00
Salvatore Mesoraca
8f65dc4ff7
ASTFunction: avoid rewriting tuple function as literal when not safe
It is not always safe to implicitly rewrite a `tuple` function
call to a literal. Even when the tuple has more then one element
e.g.
`SELECT (tuple(1, 2, 3) AS x).1` is not equivalent to
`SELECT ((1, 2, 3) AS x).1`, the latter is interpreted as
`SELECT tuple((1, 2, 3) AS x).1`.
2023-02-10 14:01:25 +01:00
kssenii
9e04e57949 Allow to give access only to certain named collections 2023-02-09 17:22:57 +01:00
Vitaly Baranov
39bacfb9dc
Merge branch 'master' into allow-single-disk-instead-of-storage-policy 2023-02-09 13:16:55 +01:00
kssenii
6cea67d58b Cleanup 2023-02-06 18:11:33 +01:00
kssenii
cce23cee51 Fix build 2023-02-04 13:49:32 +01:00
flynn
519bb173e8 Forbid wrong create view syntax 2023-02-04 12:47:17 +00:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
kssenii
536c02ca8a Adding custom field continued 2023-02-03 21:05:18 +01:00
kssenii
5f124263a6 Revert changes with complex SettingsChanges 2023-02-03 21:04:45 +01:00
Antonio Andelic
d5117f2aa6
Define S3 client with bucket and endpoint resolution (#45783)
* Update aws

* Define S3 client with bucket and endpoint resolution

* Add defines for ErrorCodes

* Use S3Client everywhere

* Remove unused errorcode

* Add DROP S3 CLIENT CACHE query

* Add a comment

* Fix style

* Update aws

* Update reference files

* Add missing include

* Fix unit test

* Remove unneeded declarations

* Correctly use RetryStrategy

* Rename S3Client to Client

* Fix retry count

* fix clang-tidy warnings
2023-02-03 14:30:52 +01:00
Alexey Milovidov
108d1c3442
Merge pull request #45872 from ClickHouse/fix-trash-query-kind
Remove trash, add a feature and fix a bug
2023-02-03 09:58:43 +03:00
kssenii
a391de18a1 Merge remote-tracking branch 'upstream/master' into allow-single-disk-instead-of-storage-policy 2023-02-02 20:49:41 +01:00
Vitaly Baranov
b8078acce2
Merge pull request #45774 from vitlibar/wiping-sensitive-info-in-named-collection-overrides
Mask sensitive info in named collection's overrides
2023-02-02 10:06:59 +01:00
Alexey Milovidov
62bfdb349a Merge branch 'master' into fix-trash-query-kind 2023-02-02 04:26:49 +01:00
Alexey Milovidov
099532ecc5
Merge pull request #45867 from Algunenano/improve_obfuscator
Improve how the obfuscator deals with queries
2023-02-02 04:23:06 +03:00
Alexey Milovidov
8e684170fe Fix even more trash 2023-02-02 02:11:16 +01:00
Nikolay Degterinsky
542f54cf2d
Merge pull request #45829 from Algunenano/fix_qualified_asterisk_children
Fix ASTQualifiedAsterisk cloning
2023-02-01 19:20:47 +01:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
Raúl Marín
61dfebd299 Upstyle 2023-02-01 11:11:03 +01:00
Alexander Gololobov
e705f11ad1
Merge pull request #45786 from ClickHouse/delete_on_cluster
Support DELETE ON CLUSTER
2023-02-01 10:52:01 +01:00
robot-ch-test-poll2
202fa9fa37
Merge pull request #45859 from FArthur-cmd/show_engines_support
Add support for SHOW ENGINES query
2023-02-01 07:32:56 +01:00
Alexey Milovidov
5c4db119fa Fix trash around query kind, part 1 2023-02-01 03:11:54 +01:00
Raúl Marín
0b201ebff2 Improve how the obfuscator deals with queries 2023-01-31 20:19:32 +01:00
FArthur-cmd
a8e38738e9 add support for show engines query 2023-01-31 18:35:10 +03:00
Vitaly Baranov
6165625e27
Update src/Parsers/ASTFunction.cpp
Co-authored-by: SmitaRKulkarni <64093672+SmitaRKulkarni@users.noreply.github.com>
2023-01-31 14:43:48 +01:00
Vitaly Baranov
c6be69568a
Update src/Parsers/ASTFunction.cpp
Co-authored-by: SmitaRKulkarni <64093672+SmitaRKulkarni@users.noreply.github.com>
2023-01-31 14:43:30 +01:00
Raúl Marín
bacfe7ffa5 Fix ASTQualifiedAsterisk cloning 2023-01-31 14:02:46 +01:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
Reasons:

- The cache will at some point store intermediate results as opposed to
  only query results. We should change the terminology now without
  having to worry about backward compat.

- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
  cache".

- The new name is ca. 13.8% more catchy.

(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Vitaly Baranov
d95d8bcb26 Rename isCollectionNameArgument() -> isNamedCollectionName() and add comments. 2023-01-30 19:31:32 +01:00
Alexander Gololobov
de841b29c7 Support delete ON CLUSTER 2023-01-30 16:42:52 +01:00
Vitaly Baranov
6ee9971931 Mask sensitive info in named collection's overrides. 2023-01-30 11:33:21 +01:00
freedomDR
379850b6c4 add system sync file cache 2023-01-28 04:27:10 +00:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings 2023-01-27 16:03:00 +01:00
Alexander Tokmakov
c366806c3e
Merge pull request #45527 from ClickHouse/exception_message_patterns4
Better formatting for exception messages 2
2023-01-27 15:31:52 +03:00
Anton Popov
92fa39798b Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-26 13:29:23 +00:00
Vitaly Baranov
5b24094405 Remove unnecessary ifs. 2023-01-25 15:08:58 +01:00
Vitaly Baranov
9014023625 Fix wiping sensitive info in INSERT INTO FUNCTION. 2023-01-25 14:50:49 +01:00
Alexander Tokmakov
3f6594f4c6 forbid old ctor of Exception 2023-01-23 22:18:05 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages (#45449)
* save format string for NetException

* format exceptions

* format exceptions 2

* format exceptions 3

* format exceptions 4

* format exceptions 5

* format exceptions 6

* fix

* format exceptions 7

* format exceptions 8

* Update MergeTreeIndexGin.cpp

* Update AggregateFunctionMap.cpp

* Update AggregateFunctionMap.cpp

* fix
2023-01-24 00:13:58 +03:00
Anton Popov
08b2e524c7 Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-23 15:34:53 +00:00
Robert Schulze
340f406553
Merge branch 'master' into query-result-cache 2023-01-22 13:21:36 +01:00
Nikolay Degterinsky
dd7fef11a2 Add default granularity 2023-01-19 20:52:38 +00:00
Robert Schulze
4f90824347
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-17 22:49:53 +00:00
Nikolay Degterinsky
d414d4aa7a Merge remote-tracking branch 'upstream/master' into bcrypt 2023-01-16 22:14:03 +00:00
Nikolay Degterinsky
09558003c2 Make workfactor changeable 2023-01-16 22:11:15 +00:00
Anton Popov
6863cd152f
Merge pull request #42181 from CurtizJ/optimize-loading-parts
Do not load inactive parts at startup
2023-01-16 14:38:50 +01:00
Nikolay Degterinsky
88ba1b0b85
Merge pull request #42884 from evillique/better_asterisk_parser
Improve Asterisk and ColumnMatcher parsers
2023-01-16 13:29:59 +01:00
Maksim Kita
80f6a45376
Merge pull request #44641 from ClickHouse/vdimir/view_explain_2
Function viewExplain accept SELECT and settings
2023-01-16 13:39:53 +03:00
Robert Schulze
099e30ef2a
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-16 08:04:49 +00:00
Nikolay Degterinsky
36c20bf293 Merge remote-tracking branch 'upstream/master' into better_asterisk_parser 2023-01-13 19:15:55 +00:00
vdimir
f881a82417
Fix viewExplain, add testcases 2023-01-13 12:19:25 +00:00
Kseniia Sumarokova
db3e0219fc
Merge pull request #41687 from ClickHouse/40907_Parameterized_views_as_table_functions
40907 Parameterized views as table functions
2023-01-12 14:24:32 +01:00
Anton Popov
ca80240d84 Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-12 12:13:45 +00:00
vdimir
8b65ed200c
Review fixes 2023-01-11 10:53:13 +00:00
Anton Popov
6c4f53bdca Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-11 01:00:57 +00:00
Vladimir C
705c1ed232
Fix clang-tidy 2023-01-10 15:43:03 +00:00
vdimir
c0b12d51bd
Function viewExplain accept SELECT and settings 2023-01-10 15:42:59 +00:00
Robert Schulze
0c3b034887
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-10 09:02:41 +00:00
Alexey Milovidov
61ff2417e9 Remove some headers 2023-01-09 04:23:10 +01:00
Alexey Milovidov
673472cbdc Fix error 2023-01-09 04:22:13 +01:00
Alexey Milovidov
d331f0ce82 Fix buffer overflow in parser 2023-01-09 03:31:12 +01:00
Robert Schulze
45dbcf88e5
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-06 20:42:48 +00:00
kssenii
2a030c1dc0 Merge remote-tracking branch 'upstream/master' into allow-single-disk-instead-of-storage-policy 2023-01-06 15:58:27 +01:00
Anton Popov
ed00399eb6 Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-05 14:12:02 +00:00
Robert Schulze
1974e1bf8c
Merge pull request #44479 from ClickHouse/more-robust-astselectquery-formatimpl
More robust ASTSelectQuery::formatImpl()
2023-01-05 12:27:40 +01:00
Nikolay Degterinsky
3a20fbdbf6 Better 2023-01-05 02:25:25 +00:00
Nikolay Degterinsky
aa52956412 Add bcrypt authentification type 2023-01-04 15:33:16 +00:00
Smita Kulkarni
1f89db78a5 Added is_create_parameterized_view flag in ActionsVisitor, added functions for column manipulation for parameterized view in StorageView, updated tests to fix flaky test issues and addressed small review comments- 40907 Parameterized views as table functions 2023-01-03 11:00:39 +01:00