Commit Graph

12 Commits

Author SHA1 Message Date
Robert Schulze
76f69f2b44
Revert overengineering 2023-06-13 15:52:06 +00:00
Robert Schulze
3e3b8ff5f6
More robustness 2023-06-13 12:24:31 +00:00
Robert Schulze
79bc884733
Stabilize tests 2023-06-13 08:56:22 +00:00
Robert Schulze
65d83e45cb
Fix crash in snowflakeToDateTime(), follow-up to #50834 2023-06-12 16:21:49 +00:00
Robert Schulze
72b9d75a84
Add compat setting for non-const timezones
SQL function toTimezone() converts a Date or DateTime into another
timezone. The problem is that the timezone is part of the Date /
DateTime type but not part of the internal representation (value). This
led to the fact that toTimeZone() wqith non-const timezones produced
wrong and misleading results until #48471 (shipped with v23.4) enforced
a const timezone.

Unfortunately, this PR also broke existing table definitions with
non-const timezones, e.g. in ALIAS expressions. So while #48471
addressed the issue appropriately, it is really backwards-incompatible.

This PR adds a setting to toggle the behavior and makes it also part of
the compatibility profile.
2023-06-10 16:56:42 +00:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Maksim Kita
538f8cbaad Fix clang-tidy warnings in Disks, Formats, Functions folders 2022-03-14 18:17:35 +00:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
Kseniia Sumarokova
3d05014da1
Update FunctionSnowflake.h 2021-08-19 12:54:03 +03:00
ubuntu
4d4dae79f0 fix: build issue 2021-08-19 00:47:40 +08:00
jasine
aa49f76bf0 fix: style 2021-08-16 00:49:33 +08:00
jasine
b9d8ee125b feat: add conversion between snowflake id and datetime 2021-08-15 22:26:40 +08:00