Commit Graph

26 Commits

Author SHA1 Message Date
Azat Khuzhin
313747688e Ignore memory limits while logging
Otherwise there can be pretty noisy messages, like here [1]:

    Cannot add message to the log: Code: 241. DB::Exception: Memory limit (for user) exceeded: would use 42.02 MiB (attempt to allocate chunk of 2101278 bytes), maximum: 4.77 MiB. OvercommitTracker decision: Waiting timeout for memory to be freed is reached. (MEMORY_LIMIT_EXCEEDED), Stack trace (when copying this message, always include the lines below):

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/efc74e33e580b7d3ff33c3e269db86addfaa6b51/stateless_tests__msan__[2/3].html

And it should be okay to ignore server limits too, since it always
better to have a proper log message in a proper place, not stderr which
does not inspected usually.

Follow-up for: #24069
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-05 12:20:15 +02:00
Mallik Hassan
87a28c25f5 Update src/Loggers/Loggers.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-08-30 23:20:19 -03:00
root
f02f7ce99c addressed minor change requests 2022-08-30 23:20:19 -03:00
root
834ab5cd2b removed redundant initializer for base class 'OwnPatternFormatter' 2022-08-30 23:20:19 -03:00
root
790a437eb2 Addressed review requests: removed this pointer in functions and config variable in class 2022-08-30 23:20:19 -03:00
root
bb25abd0ae to resolve build error(no member named 'Util' in namespace 'Poco'), added <Poco/Util/AbstractConfiguration.h> in OwnJSONPatternFormatter.h 2022-08-30 23:20:19 -03:00
root
b8501bea06 style check correction 2022-08-30 23:20:19 -03:00
root
d5db88fa27 Structured-logging-custom-keys PR init 2022-08-30 23:20:19 -03:00
Mallik Hassan
666fb8dc42
Merge branch 'ClickHouse:master' into Structured-Logging-Support 2022-08-09 15:39:00 -03:00
root
d58ae78712 removed default color enable in OwnPatternFormatter constructor calling 2022-08-03 06:30:48 -07:00
root
0fad007220 changing OwnPatternFormatter.cpp to its original version 2022-08-02 06:42:50 -07:00
root
433b961d5c changed code for expected seg fault 2022-08-01 20:21:48 -07:00
root
bb8f7f6f0b style correction in OwnJSONPatternFormatter.cpp 2022-07-28 09:52:30 -07:00
root
bec7408a0c reflected change requests asked on July 27 2022-07-28 09:20:28 -07:00
root
6406bd998a style check correction in OwnFormattingChannel 2022-07-26 08:03:14 -07:00
root
f7dcf23404 removed pFormattterJSON pointer from OwnFormattingChannel and reformatted Loggers and BaseDaemon to look nicer 2022-07-26 06:53:06 -07:00
Mallik Hassan
968e867a0d
Update src/Loggers/Loggers.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-07-26 03:44:16 -03:00
root
f135a82141 Addressed changes requested by @evillique (Restructured OwnJSONPatternFormatter, used different version of writeJSONString() etc... 2022-07-25 19:39:13 -07:00
Mallik Hassan
b45e44b7e7
Merge branch 'ClickHouse:master' into Structured-Logging-Support 2022-07-25 12:10:41 -03:00
Nikolay Degterinsky
c4b72277df Fix logs rotation issue 2022-07-25 13:58:04 +00:00
root
877854b143 resolved build error saying - error: method 'formatExtendedJSON' can be made static 2022-07-20 05:45:04 -07:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
root
03194eaeb9 Feature - Structured Logging Support resubmit 2022-07-15 10:01:30 -07:00
Amos Bird
90fa4863f9
Text log source regexp 2022-07-13 17:52:14 +08:00
Robert Schulze
43945cea1b
Fixing some warnings 2022-05-16 20:59:27 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00