Commit Graph

107868 Commits

Author SHA1 Message Date
robot-ch-test-poll1
eb580426ab
Merge pull request #46362 from azat/tests/perf-create-errors-fix
Do not continue perf tests in case of exception in create_query/fill_query
2023-02-14 11:57:29 +01:00
Kseniia Sumarokova
0b55021c68
Merge pull request #46337 from kssenii/rabbitmq-tests-fix-2
Fix flaky test_storage_rabbitmq::test_rabbitmq_address
2023-02-14 11:44:34 +01:00
Kseniia Sumarokova
810348a613
Merge pull request #46340 from ClickHouse/kssenii-patch-6
Update cluster.py
2023-02-14 11:43:58 +01:00
Robert Schulze
aae9f4ebcd
Try to stabilize 02346_full_text_search
Failure, e.g. https://s3.amazonaws.com/clickhouse-test-reports/0/f3fa3d868cb9957eeca6b5d5fd653234f5db5b45/stateless_tests__release__databaseordinary_.html :

    "Cannot quickly remove directory /var/lib/clickhouse/data/test_ggwgonnk/tab/delete_tmp_all_1_1_0 by removing files; fallback to recursive removal. Reason: Code: 566. DB::ErrnoException: Cannot rmdir /var/lib/clickhouse/data/test_ggwgonnk/tab/delete_tmp_all_1_1_0, errno: 39, strerror: Directory not empty. (CANNOT_RMDIR) (version 23.2.1.1427 (official build))"

The issue did not reproduce in a local debug or release builds.

Then noticed that it happens only with "DatabaseOrdinary" test profiles: https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSBjaGVja19zdGFydF90aW1lID49IG5vdygpIC0gSU5URVJWQUwgOTYgSE9VUgogICAgQU5EIHB1bGxfcmVxdWVzdF9udW1iZXIgPSAwCiAgICBBTkQgdGVzdF9zdGF0dXMgIT0gJ1NLSVBQRUQnCiAgICBBTkQgdGVzdF9zdGF0dXMgTElLRSAnRiUnCiAgICBBTkQgY2hlY2tfc3RhdHVzICE9ICdzdWNjZXNzJwogICAgQU5EIHBvc2l0aW9uKHRlc3RfbmFtZSwgJzAyMzQ2X2Z1bGxfdGV4dF9zZWFyY2gnKSA+IDAKT1JERVIgQlkgY2hlY2tfc3RhcnRfdGltZQ==

"Ordinary" databases were deprecated in ca. 2020 and nowadays can no
longer be created unless a special setting is on.

There is actually a fallback path (recursive removal) so it is arguable
why this is logged as error.

For now disabling 02346_full_text_search for ordinary databases.
2023-02-14 10:33:09 +00:00
Sema Checherinda
fba7ee6332
Merge pull request #46347 from CheSema/fix-select-candite-to-check
fix candidate selection
2023-02-14 11:18:42 +01:00
mateng915
1faf09ec21
Merge branch 'master' into replicas_status_api_optimize 2023-02-14 17:55:23 +08:00
robot-ch-test-poll4
7c420f0982
Merge pull request #46350 from CurtizJ/fix-format-values
Fix `LOGICAL_ERROR` in async inserts with invalid data in format `VALUES`
2023-02-14 10:12:08 +01:00
robot-ch-test-poll3
f654174362
Merge pull request #46246 from ClickHouse/optimize-binary-builder
Optimize docker binary-builder
2023-02-14 10:06:15 +01:00
Alexey Milovidov
e1ae60e6d9
Merge pull request #46159 from ClickHouse/docker-server-readme
Fix clickhouse/clickhouse-server description to make it in sync
2023-02-14 12:05:48 +03:00
Alexey Milovidov
1f58369043
Merge pull request #46332 from ClickHouse/approve-trigger-merge
Trigger automerge on approved PRs
2023-02-14 12:02:46 +03:00
robot-clickhouse-ci-2
ea5b645af5
Merge pull request #46349 from ClickHouse/fix-crash-int-overflow-hash-table-deserialization-agg-state
Check overflow in HashTable::alloc
2023-02-14 10:02:13 +01:00
Robert Schulze
61e315f30d
Merge pull request #45520 from ClibMouse/z-build-0120
s390x build support
2023-02-14 10:01:38 +01:00
Antonio Andelic
5ab24285fc Fix arg parsing 2023-02-14 08:33:59 +00:00
Antonio Andelic
005888b0a4
Merge pull request #46330 from ClickHouse/delete-update-keepermap
Add support for DELETE/UPDATE for KeeperMap
2023-02-14 09:10:41 +01:00
lgbo-ustc
74d6ccad4f fixed
change window specification as (partition by a order by b rows between unbounded preceding and unbounded following)
2023-02-14 15:49:12 +08:00
lgbo-ustc
0b32a655a8 fixed 2023-02-14 15:49:12 +08:00
lgbo-ustc
82637637d0 fixed test case 2023-02-14 15:49:12 +08:00
lgbo-ustc
80a713bca0 update doc and add tests 2023-02-14 15:49:12 +08:00
lgbo-ustc
9a496aea6a add new window function, ntile 2023-02-14 15:49:11 +08:00
Alexey Milovidov
f57ba896c8
Merge pull request #46181 from saitama951/master-sanjam
IBM's s390x architecture: Issue #2053 - conversion of 256 bit to 128 bit
2023-02-14 09:34:17 +03:00
Anton Popov
1ab37ad5ed fix update of empty Nested columns 2023-02-14 02:31:42 +00:00
mateng915
d28792528a
Merge branch 'master' into replicas_status_api_optimize 2023-02-14 10:03:07 +08:00
pufit
c7105c60f5 try to fix ci 2023-02-14 00:40:27 +00:00
pufit
4290df27c6 try to fix ci 2023-02-14 00:35:40 +00:00
Nikolai Kochetov
1c0c662fe1
Merge pull request #46275 from ClickHouse/less-mem-usage-for-vertical-merge
Less memory usage for vertical merge (non-remote disk)
2023-02-13 21:10:43 +01:00
robot-ch-test-poll2
fa8ebf70af
Merge pull request #46366 from DanRoscigno/fix-search
Fix search for word "install"
2023-02-13 19:18:40 +01:00
Alexey Milovidov
3b333df17d
Update 02560_agg_state_deserialization_hash_table_crash.sql 2023-02-13 21:00:44 +03:00
Dan Roscigno
9d1b63e758
Merge branch 'master' into fix-search 2023-02-13 12:25:12 -05:00
DanRoscigno
3c2fd54aae fix search 2023-02-13 11:55:27 -05:00
DanRoscigno
2a7ea19cef fix search 2023-02-13 11:54:41 -05:00
robot-ch-test-poll
249b19405c
Merge pull request #46325 from aalexfvk/alexfvk/refine_disk_object_storage_remove
Refine removing metadata file with invalid format for DiskObjectStorage
2023-02-13 17:48:34 +01:00
SadiHassan
df68017fff update unixodbc to v2.3.11 to mitigate CVE-2011-1145 2023-02-13 08:43:46 -08:00
Azat Khuzhin
dc5d7809b6 Do not continue perf tests in case of exception in create_query/fill_query
Previously due to using of threading.Thread, exception had been
ignored, and perf test simply continues, yes it will show some errors,
but it also may show that the test became faster, while it is because
the underlying table was empty.

Replace threading.Thread with a SafeThread (inline implementation) that
simply rethrow exception in join.

Here is an example of such report [1], look at the ip_trie test.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/2101b66570cbb9eb9a492afa8ab82d562c34336b/performance_comparison_[3/4]/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-13 17:31:15 +01:00
Alexander Gololobov
3f5887248e
Update HashTable.h 2023-02-13 17:30:57 +01:00
Nikolai Kochetov
ea19a0d46e
Update src/Common/HashTable/HashTable.h
Co-authored-by: Alexander Gololobov <440544+davenger@users.noreply.github.com>
2023-02-13 17:15:41 +01:00
Azat Khuzhin
96c8c783f5 One more trim of stdout in clickhouse-test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-13 16:50:12 +01:00
Azat Khuzhin
72f61ae399 Do not polute logs in clickhouse-test
In case of there are less then 100 lines, there is no need to split
lines with '#', and in fact, it will only looks it odd and hard to
interpret.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-13 16:46:56 +01:00
Antonio Andelic
cdf570a64f Better 2023-02-13 15:23:48 +00:00
Alexander Tokmakov
304b9f1a93 remove trash from MOVE PARTITION command 2023-02-13 16:10:16 +01:00
kssenii
614d57d245 Fix race 2023-02-13 16:02:41 +01:00
Anton Popov
7f31196606 fix LOGICAL_ERROR in async inserts 2023-02-13 14:59:14 +00:00
Mikhail f. Shiryaev
7b5e31cd8d
Revert some typos, improve the language 2023-02-13 15:53:28 +01:00
Nikolai Kochetov
5d77407f39 Check overflow in HashTable::alloc 2023-02-13 14:50:23 +00:00
Antonio Andelic
95db6fb1a6
Merge pull request #45659 from ClickHouse/add-support-for-settings-alias
Add support for settings aliases/Rename `replication_alter_partitions_sync` to `alter_sync`
2023-02-13 15:31:12 +01:00
Nikolai Kochetov
ca55c01b6e
Wait for background tasks in ~UploadHelper (#46334) 2023-02-13 15:08:16 +01:00
Suzy Wang
e140bed3ea
Merge branch 'master' into z-build-0120 2023-02-13 09:06:48 -05:00
Sema Checherinda
a48b6ec612 fix candidate selection 2023-02-13 14:52:55 +01:00
Alexander Tokmakov
69f579b8ec remove an unused argument 2023-02-13 14:46:46 +01:00
Mikhail f. Shiryaev
92f2e904ee
Merge pull request #45980 from ClickHouse/avoid-backport-contrib
Improve local running of cherry_pick.py
2023-02-13 14:16:58 +01:00
Nikolai Kochetov
8173c5eb66
Update 02560_vertical_merge_memory_usage.sql 2023-02-13 13:49:28 +01:00