Azat Khuzhin
9fb6004c92
Add missing fsync for small files (ttl.txt, columns.txt, ...) in mutations
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-30 22:22:39 +01:00
Anton Popov
38f0cf9b10
fix test 01130_in_memory_parts
2022-12-28 16:40:31 +00:00
Nikolai Kochetov
03352a15b6
Use sequential source for mutations.
2022-12-23 22:39:27 +00:00
alesapin
2fecf420cb
Merge pull request #44513 from ClickHouse/small_polishing
...
Minor code polishing
2022-12-23 13:47:26 +01:00
alesapin
fa467b3398
Minor code polishing
2022-12-22 14:31:42 +01:00
Anton Popov
4b7f1e0cf2
fix mutations with setting 'max_streams_for_merge_tree_reading'
2022-12-21 01:59:53 +00:00
Sema Checherinda
02133f68dd
Merge branch 'master' into mutation-breaks-source-part
2022-12-09 17:20:57 +01:00
Alexey Milovidov
f880644d3a
Merge branch 'master' into nv/fix-mutate-fetch
2022-12-09 00:51:54 +03:00
Sema Checherinda
46f96064ea
do not hardlink serialization.json in new part
2022-12-08 12:48:34 +01:00
alesapin
7b4025ba7c
Fix bug
2022-11-30 12:43:46 +01:00
alesapin
7914e26744
Fix another part of code
2022-11-29 12:50:20 +01:00
Alexey Milovidov
bedfe68503
Merge branch 'master' into nv/fix-mutate-fetch
2022-11-22 20:06:56 +01:00
Anton Popov
b40d9200d2
better semantic of constsness of DataPartStorage
2022-10-23 15:24:20 +00:00
Anton Popov
56e5daba0c
remove DataPartStorageBuilder
2022-10-23 00:23:15 +00:00
Nikolai Kochetov
b18c6fd8e6
Fix an invalid type of a column after attach and alter.
2022-10-14 14:52:26 +00:00
alesapin
2eef384807
Add comments and test
2022-09-28 13:09:48 +02:00
Alexey Milovidov
12dc33f4fd
Merge branch 'master' into nv/fix-mutate-fetch
2022-09-28 01:28:19 +03:00
alesapin
695133cc5b
Better mutations
2022-09-27 15:23:02 +02:00
alesapin
d4d4f92976
Use copy for some operations instead of hardlinks
2022-09-27 14:38:13 +02:00
Alexander Tokmakov
981c1e95c6
Update MutateTask.cpp
2022-09-22 18:51:27 +03:00
Nicolae Vartolomei
e93a78faee
Proper comment for bad code
2022-09-20 19:56:14 +00:00
Nicolae Vartolomei
3d6fcf4ae5
Explain bad code
2022-09-20 19:46:07 +00:00
Nicolae Vartolomei
90666a43a8
CLICKHOUSE-2153: Move new_data_part shared pointer to allow Outdated part to be deleted immediately on mutation failure
2022-09-20 18:23:19 +00:00
zhongyuankai
1477bb132f
Merge branch 'master' into compress_marks_and_primary_key
2022-09-13 11:05:57 +08:00
jthmath
478d2ad06a
fix ignore projection
2022-09-07 10:23:52 +08:00
Alexey Milovidov
d7127e4b2d
Make it slightly more sane
2022-09-05 07:26:58 +02:00
Alexey Milovidov
5ee81598b5
Merge branch 'compress_marks_and_primary_key' of github.com:zhongyuankai/ClickHouse into compress-marks
2022-08-28 04:19:14 +02:00
kssenii
eb26b219b9
Merge master
2022-08-16 00:56:27 +02:00
Alexander Tokmakov
46aaf842f8
Merge pull request #40031 from ClickHouse/fix_old_tmp_dirs_cleanup
...
Fix old temporary directories cleanup
2022-08-12 20:31:20 +03:00
kssenii
768a207176
Merge master
2022-08-11 22:25:53 +02:00
Jianmei Zhang
d1051d822c
Use getSerializedFileExtension() to get correct file extension for index ( #40095 )
2022-08-11 12:39:40 +02:00
zhongyuankai
71935b96ef
support compress marks and primary key
2022-08-10 18:07:14 +08:00
Alexander Tokmakov
fe572104aa
fix old tmp dirs cleanup
2022-08-09 18:44:51 +02:00
kssenii
7a9b0bc47f
Merge master
2022-08-05 01:48:52 +02:00
Anton Popov
0492ef63a4
Merge pull request #39464 from CurtizJ/fix-custom-serializations
...
Fix columns of type `Object` with sparse serialization
2022-08-05 00:55:41 +02:00
alesapin
1eb28f5f5f
Merge pull request #39860 from ClickHouse/avoid_additional_disk_touch
...
Better total part size calculation on mutation
2022-08-04 14:21:31 +02:00
Anton Popov
04f6a85070
fix mutations
2022-08-03 17:34:46 +00:00
Anton Popov
5da32fafb3
fix ALTER MODIFY COLUMN from nested
2022-08-03 15:08:38 +00:00
alesapin
f608e62c27
Fix call
2022-08-03 14:17:31 +02:00
alesapin
56a4d26e87
Better total part size calculation on mutation
2022-08-03 14:15:45 +02:00
kssenii
e5f4a619ed
Merge master
2022-07-31 20:24:40 +03:00
Anton Popov
57e4fb2e30
Merge remote-tracking branch 'upstream/master' into HEAD
2022-07-29 11:42:11 +00:00
Anton Popov
04fd72cdef
fix alter column rename
2022-07-28 13:19:23 +00:00
Anton Popov
56039c8780
fix alter of LowCardinality
2022-07-27 15:35:09 +00:00
Anton Popov
4cf0353892
try to fix Nested
2022-07-27 14:05:16 +00:00
Alexander Gololobov
48de02a7b8
Capitalized const name
2022-07-25 16:32:16 +02:00
Alexander Gololobov
7b44950d1d
More detailed comment
2022-07-25 16:14:33 +02:00
Alexander Gololobov
6692770113
Allow to update "system" virtual columns such as _row_exists
2022-07-24 12:21:47 +02:00
Alexander Gololobov
594195451e
Cleanups
2022-07-24 12:21:18 +02:00
Alexander Gololobov
1ea9f143ff
Leave only _row_exists-based implementation of lightweight delete
2022-07-21 11:26:13 +02:00
Alexander Gololobov
f324ca9921
Cleanups
2022-07-18 20:07:22 +02:00
Alexander Gololobov
9de72d995a
POC lightweight delete using __row_exists virtual column and prewhere-like filtering
2022-07-18 20:06:42 +02:00
jianmei zhang
197d3796ec
Killed mutation has empty commands may cause SegV
2022-07-15 15:37:36 +08:00
jianmei zhang
ca42f649da
Rewrite logic for loading deleted mask related to getDeletedMask()
2022-07-15 15:31:10 +08:00
jianmei zhang
d37152a5d6
Remove loadDeletedMask() and get deleted mask when needed
2022-07-15 12:32:42 +08:00
jianmei zhang
4268ac8b0e
Add supportLightweightDeleteMutate() in IMergeTreeDataPart to disable LWD for part with projections
2022-07-15 12:32:42 +08:00
jianmei zhang
780cdfb8f0
Code changes based on review opinions. Make ordinary single alter delete lightwight by default
2022-07-15 12:32:42 +08:00
jianmei zhang
6e6f77ef8a
Fix compile error in clang tidy build
2022-07-15 12:32:41 +08:00
jianmei zhang
7e433859ea
Change deleted rows mask from String to Native UInt8 format
2022-07-15 12:32:41 +08:00
jianmei zhang
dcc7367ac4
Fix code style error
2022-07-15 12:32:41 +08:00
jianmei zhang
6248486790
Fix lightweight delete bugs: add skip files and use source part's columns to avoid metadata updated cases
2022-07-15 12:32:41 +08:00
jianmei zhang
8ad2bb7c33
Code changes due to master new fixes, and update reference for mutations table
2022-07-15 12:32:41 +08:00
jianmei zhang
9d27af7ee2
For some columns mutations, skip to apply deleted mask when read some columns. Also add unit test case
2022-07-15 12:32:41 +08:00
jianmei zhang
b4a37e1e22
Disable optimizations for count() when lightweight delete exists, add hasLightweightDelete() function in IMergeTreeDataPart
2022-07-15 12:32:41 +08:00
jianmei zhang
8696319d62
Support lightweight delete execution using string as deleted rows mask,also part of select can handle LWD
2022-07-15 12:32:41 +08:00
kssenii
b52084265c
Merge master
2022-07-04 21:37:43 +02:00
alesapin
6429b72371
Fixes
2022-06-28 14:41:22 +02:00
alesapin
0a3fab1cb6
Some sad changes
2022-06-28 12:51:49 +02:00
alesapin
d88cdcd5c1
AAA
2022-06-27 21:41:29 +02:00
kssenii
e40d9bcf55
Merge master
2022-06-22 23:28:52 +02:00
Nikolai Kochetov
854d148d73
Add some comments. Remove some commented code.
2022-06-21 12:31:02 +00:00
Nikolai Kochetov
dccf90b1ea
Cleanup.
2022-06-20 18:18:17 +00:00
Nikolai Kochetov
ef8b967c3f
Fix more tests.
2022-06-20 13:07:14 +00:00
kssenii
aaf9a46f07
Merge master
2022-06-11 15:56:05 +02:00
Nikolai Kochetov
678d978acf
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-07 15:23:00 +00:00
Anton Popov
5cf2c67410
Merge branch 'master' into fix-mutations-again
2022-06-03 14:17:05 +02:00
Nikolai Kochetov
89c5855d20
Merge branch 'master' into refactor-something-in-part-volumes
2022-06-02 12:19:07 +02:00
Anton Popov
cae2478b3f
Revert "Merge pull request #37355 from ClickHouse/revert-37266-fix-mutations-with-object"
...
This reverts commit a53cfa9fca9acb42fcdb
2022-06-01 10:57:20 +00:00
Nikolai Kochetov
6d4a26afac
Update ReadProgressCallback.
2022-05-25 19:45:48 +00:00
Nikolai Kochetov
1b85f2c1d6
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-05-25 16:27:40 +02:00
Nikolai Kochetov
3d84aae0ab
Better.
2022-05-24 20:06:08 +00:00
Nikolai Kochetov
56feef01e7
Move some resources
2022-05-20 19:49:31 +00:00
Alexander Tokmakov
f787dc7097
Revert "Fix mutations in tables with columns of type Object"
2022-05-19 13:24:48 +03:00
kssenii
5e3410f60a
Better
2022-05-16 22:09:11 +02:00
Anton Popov
b6c5ab4fcf
fix mutations in tables with columns of type Object
2022-05-16 18:26:53 +00:00
Alexey Milovidov
fdbb5b75b2
Merge branch 'master' into minor-renames
2022-05-07 14:18:50 +03:00
Nikolai Kochetov
d6735f06c7
Fixing spaces.
2022-05-05 09:24:34 +00:00
Nikolai Kochetov
35095191eb
Merge branch 'master' into refactor-something-in-part-volumes
2022-05-03 17:51:47 +02:00
Nikolai Kochetov
4a20e4f37e
Fixing build.
2022-05-03 15:48:05 +00:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
...
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
Azat Khuzhin
bf312c2a5b
Fix ALTER DROP COLUMN of nested column with compact parts
...
ALTER DROP COLUMN of nested column did not requires mutation before, and
so it leaves nested column as-is, and in case of compact parts
subsequent alter, that requires mutation, will trigger READ_COLUMN of
that nested column (because it exists in part), but it will fail because
there is no such column in the table already.
Here is example of such a failure on CI - [1].
[1]: https://s3.amazonaws.com/clickhouse-test-reports/35459/52099b23a1cb9a7ff036c5c60aa037c999b333ef/stateless_tests__thread__actions__[1/3].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-29 07:12:34 +03:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Nikolai Kochetov
e44af67fee
Merge branch 'master' into refactor-something-in-part-volumes
2022-04-26 21:08:00 +02:00
Azat Khuzhin
8b544e26d3
Move some functions from MergeTreeDataMergerMutator to MutateTask
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 18:16:38 +03:00
Azat Khuzhin
8440fec3db
Fix coding alignment in MutateTask
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 18:16:38 +03:00
Nikolai Kochetov
8c00692844
Part 8
2022-04-22 16:58:09 +00:00
Nikolai Kochetov
9133e398b8
Part 7
2022-04-21 19:19:13 +00:00
alesapin
5465415751
Fix replace/move partition with zero copy replication
2022-04-21 14:39:12 +02:00
alesapin
c14e2e0b96
Fix more
2022-04-20 21:08:26 +02:00
