Commit Graph

2522 Commits

Author SHA1 Message Date
Azat Khuzhin
2be022cb56 Log which taskstats provider is in use
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
    [1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
alesapin
ba81816dc1 Better cmake 2022-04-20 12:11:55 +02:00
mergify[bot]
0df5fda6ed
Merge branch 'master' into musl-check 2022-04-20 09:28:40 +00:00
Suzy Wang
59f0e83c4b
fix clang tidy warning, add nullptr check (#35540)
update passing reference instead of pointer in queryHasWithClause based on recommandation

Co-authored-by: larryluogit <larry.luo@ca.ibm.com>
2022-04-20 11:26:44 +02:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Antonio Andelic
bbb0be6a44
Merge pull request #36402 from rschu1ze/clang-tidy-contains
Activate clang-tidy warning "readability-container-contains"
2022-04-20 08:15:46 +02:00
alesapin
ffca5c3cdc
Merge branch 'master' into musl-check 2022-04-19 17:51:54 +02:00
alesapin
44e5c55d19 Fix build 2022-04-19 17:44:28 +02:00
Alexey Milovidov
fb9545e0b4 Remove trash 2022-04-19 17:44:27 +02:00
Alexey Milovidov
23968142c1 Update main.cpp 2022-04-19 17:44:27 +02:00
Alexey Milovidov
d6d0e82741 Update main.cpp 2022-04-19 17:44:26 +02:00
Alexey Milovidov
86ae0c9763 Warn and exit if harmful environment variables are set 2022-04-19 17:44:26 +02:00
Antonio Andelic
70f3d3a863 Merge branch 'master' into keeper-recovery-mode 2022-04-19 12:32:48 +00:00
Antonio Andelic
3e77340a81
Allow clickhouse-keeper to serve 4-letter commands before quorum (#35992)
* Use async start for clichkouse-keeper

* Return non active server for 4lw commands if quorum not achieved
2022-04-19 14:03:00 +02:00
Antonio Andelic
cd548aeb30 Refactor test for multiple cluster size 2022-04-19 08:08:36 +00:00
Antonio Andelic
6c3bf0a5d3 Format files 2022-04-19 08:08:36 +00:00
Antonio Andelic
0e1ba927bd Add argument for force recovery 2022-04-19 08:08:35 +00:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Azat Khuzhin
828d23c933 Add more harmful variables for OSX
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-18 23:40:09 +03:00
Alexey Milovidov
48fd09c7db
Merge pull request #36310 from ClickHouse/cpuid-remove-trash
Remove trash from CPUID
2022-04-18 07:01:23 +03:00
Alexey Milovidov
543e5d7242 Merge branch 'master' into musl-check 2022-04-18 02:40:13 +02:00
Alexey Milovidov
0fc61ea445
Update main.cpp 2022-04-18 03:16:30 +03:00
Alexey Milovidov
27afc08d8f Merge branch 'master' into cpuid-remove-trash 2022-04-17 16:30:30 +02:00
Alexey Milovidov
e43bdf7580
Update main.cpp 2022-04-17 17:21:20 +03:00
Alexey Milovidov
b7fe203fe1 Warn and exit if harmful environment variables are set 2022-04-17 01:56:58 +02:00
Alexey Milovidov
66dedb0011
Merge pull request #36262 from zhanghuajieHIT/fix-crash-in-fit-import-with-invalid-parameter
fix crash when you use clickhouse-git-import with invalid parameter
2022-04-16 03:20:42 +03:00
Alexey Milovidov
58fc4e033a Remove trash 2022-04-15 22:54:08 +02:00
Alexey Milovidov
efbb29539f Fix Play UI for some resultsets 2022-04-15 03:13:40 +02:00
zhanghuajie
9947008d31 fix crash when you use clickhouse-git-import with invalid parameter
for example:
clickhouse-git-import -xxx
2022-04-14 23:16:02 +08:00
alesapin
2f496c7945 Merge branch 'master' into musl-check 2022-04-12 14:40:47 +02:00
mergify[bot]
078d8baf1d
Merge branch 'master' into enable-memory-overcommit 2022-04-11 17:09:02 +00:00
Alexander Tokmakov
141fbc6980 Merge branch 'master' into mvcc_prototype 2022-04-08 13:38:11 +02:00
Azat Khuzhin
33d99c8ffb Introduce compatiblity mode for SETTINGS after FORMAT
Add allow_settings_after_format_in_insert setting, OFF by default.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: s/parser_settings_after_format_compact/allow_settings_after_format_in_insert/ (suggested by vitlibar)
v3: replace ParserSettings with a flag (requested by vitlibar)
2022-04-07 16:36:34 +03:00
Alexander Tokmakov
7f54e7b422 Merge branch 'master' into mvcc_prototype 2022-04-07 15:14:06 +02:00
Alexander Tokmakov
8290ffa88d Merge branch 'master' into mvcc_prototype 2022-04-07 13:50:42 +02:00
tavplubix
6e9c028bbb
Merge pull request #35956 from Algunenano/limit_dns_retries
DNS cache: Add option to drop elements after several consecutive failures
2022-04-07 13:20:36 +03:00
Nikolai Kochetov
3e1b3f14c0
Merge pull request #34355 from azat/processors-profiling
Profiling on Processors level
2022-04-07 12:13:14 +02:00
mergify[bot]
585cff1e95
Merge branch 'master' into limit_dns_retries 2022-04-06 18:23:17 +00:00
Anton Popov
13cb564d1e
Merge pull request #35716 from kssenii/fix-local-logs-level
Fix send_logs_level for clickhouse local
2022-04-06 18:52:47 +02:00
Kseniia Sumarokova
d3763c4a62 Update ClientBase.h 2022-04-06 12:13:34 +02:00
Alexey Milovidov
3c0c1a1176 Add a comment #35919 2022-04-05 18:35:23 +02:00
Alexey Milovidov
e452949334
Merge pull request #35919 from DevTeamBK/clang-tidy-issues
Clang tidy issues
2022-04-05 19:31:09 +03:00
mergify[bot]
bc882ded42
Merge branch 'master' into enable-memory-overcommit 2022-04-05 14:46:18 +00:00
kssenii
83488b2d13 Better 2022-04-05 14:48:26 +02:00
Alexander Tokmakov
1fe50ad201 Merge branch 'master' into mvcc_prototype 2022-04-05 14:38:02 +02:00
Raúl Marín
8a05cf3927 DNS cache: Add option to drop elements after several consecutive failures 2022-04-05 13:00:27 +02:00
Maksim Kita
cb8332c007
Merge pull request #35758 from den-crane/patch-3
extended a description of clickhouse-client compression parameter
2022-04-05 11:16:52 +02:00
Dmitry Novik
b4fed414e3 Enable memory overcommit 2022-04-04 14:28:05 +00:00
Meena Renganathan
cf71b18472 Modified the code to fix the getenv() call issue idenitified in the clang-tidy 2022-04-04 07:23:31 -07:00
Alexander Tokmakov
a2167f12b8 Merge branch 'master' into mvcc_prototype 2022-04-04 14:24:23 +02:00
Azat Khuzhin
14538f6456 Add system.processors_profile_log
This is the system table that will contain Processors level profiling.

v2: one entry per Processor, not 3 (PortFull/NeedData/work())
v3: us over ms
v4: Enable processors_profile_log table by default

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-04 13:19:41 +03:00
Alexey Milovidov
808c802cae Disable session_log 2022-04-03 05:07:37 +02:00
Alexey Milovidov
17107cb1dc Update examples and remove obsolete embedded dictionaries from configs 2022-04-03 01:21:48 +02:00
Nir Peled
409eccec84 When showing the animation, set display to inline-block instead of inline, otherwise the animation won't start 2022-04-01 19:29:13 -04:00
Nir Peled
4810936eaa Added an animation to the play ui hourglass when a query is running 2022-04-01 19:24:14 -04:00
mergify[bot]
3183b61c74
Merge branch 'master' into mvcc_prototype 2022-03-31 12:27:09 +00:00
Alexander Tokmakov
5a50ad9de3 Merge branch 'master' into mvcc_prototype 2022-03-31 11:35:04 +02:00
alesapin
ae3bcbb99b Fix logs space check 2022-03-31 00:22:36 +02:00
alesapin
81ce991494 Merge branch 'master' into startup-sanity-checks 2022-03-31 00:08:43 +02:00
kssenii
1fb9440d47 Merge master 2022-03-30 17:37:37 +02:00
Denny Crane
0722beca0c
Update Client.cpp 2022-03-30 08:45:30 -03:00
alesapin
c6c0c91b39 Followup 2022-03-29 18:20:20 +02:00
tavplubix
f3e580e876
Merge pull request #35711 from kssenii/fix-local-drop-db
Fix dropping non-empty database in clickhouse local
2022-03-29 18:39:01 +03:00
Alexander Tokmakov
287d858fda Merge branch 'master' into mvcc_prototype 2022-03-29 16:24:12 +02:00
alesapin
4db85e2809 Fix build 2022-03-29 14:20:46 +02:00
alesapin
ed2c461fe1 Merge branch 'master' into startup-sanity-checks 2022-03-29 14:09:20 +02:00
kssenii
95565b45d6 Fix 2022-03-29 13:33:17 +02:00
taiyang-li
834ac3a1b9 Merge remote-tracking branch 'ck/master' into rocksdb_metacache 2022-03-29 18:32:06 +08:00
kssenii
98fe1ca1ec Fix 2022-03-29 12:05:27 +02:00
Alexander Tokmakov
208b242188 Merge branch 'master' into mvcc_prototype 2022-03-28 19:58:06 +02:00
taiyang-li
38702be40c Merge remote-tracking branch 'ck/master' into rocksdb_metacache 2022-03-28 21:03:22 +08:00
alesapin
c95a9971bc Merge branch 'master' into clickhouse-keeper 2022-03-25 11:22:57 +01:00
alesapin
d3fbd9b2ad Fix style 2022-03-24 11:25:28 +01:00
alesapin
93d1b1d198 Merge branch 'master' into startup-sanity-checks 2022-03-24 11:17:06 +01:00
alesapin
e790a73081 Simplify strip for new packages 2022-03-23 15:14:30 +01:00
李扬
b84904b8a6
Update Client.cpp 2022-03-23 22:01:29 +08:00
Alexander Tokmakov
bcec53aadc Merge branch 'master' into mvcc_prototype 2022-03-23 11:28:43 +01:00
Antonio Andelic
9829f2d051 Merge branch 'master' into parallel-downloading-url-engine 2022-03-23 07:41:14 +00:00
taiyang-li
8dbf1c60e7 merge master and fix conflict 2022-03-23 11:36:50 +08:00
taiyang-li
1114c54899 merge master and fix conflict 2022-03-23 11:03:25 +08:00
tavplubix
dbf3e0e767
Merge pull request #35498 from ClickHouse/fix_keeper_timeout_bug
Fix keeper client timeout bug
2022-03-22 17:33:29 +03:00
alesapin
a4ab73619f
Fix UBSan build 2022-03-22 15:05:31 +01:00
alesapin
0ab9a9c0f6
Merge pull request #33664 from ClickHouse/release-steps
Refactor releasing process
2022-03-22 14:43:18 +01:00
Antonio Andelic
5da3058368 Merge branch 'master' into parallel-downloading-url-engine 2022-03-22 12:20:36 +00:00
alesapin
70d410dc4d Fix keeper client timeout bug 2022-03-22 11:41:50 +01:00
Vladimir C
2430d8192e
Merge pull request #35451 from ClickHouse/allow-bind-low-ports 2022-03-22 11:13:18 +01:00
Mikhail f. Shiryaev
1d362796df
Fix strip bug 2022-03-22 11:10:02 +01:00
Mikhail f. Shiryaev
fa2a9bb9aa
Separate BUILD_STRIPPED_BINARIES_PREFIX to option and parameter 2022-03-22 11:10:02 +01:00
Alexander Tokmakov
3c762f566d Merge branch 'master' into mvcc_prototype 2022-03-21 20:16:29 +01:00
Alexey Milovidov
24c94777f5 Allow server to bind to low-numbered ports 2022-03-21 03:32:05 +01:00
Alexey Milovidov
fc246dc568 Allow server to bind to low-numbered ports 2022-03-21 03:30:13 +01:00
mergify[bot]
5295dd0ef2
Merge branch 'master' into stress-test 2022-03-17 11:10:37 +00:00
Antonio Andelic
103a3fa140 Merge branch 'master' into parallel-downloading-url-engine 2022-03-17 10:11:58 +00:00
Alexander Tokmakov
4b3e13a4fe Merge branch 'master' into mvcc_prototype 2022-03-16 21:06:19 +01:00
Vitaly Baranov
39614e6e15
Merge pull request #35276 from vitlibar/fix-code-style-and-minor-corrections-after-allow-no-password
Fix code style and other minor corrections after implementing allow_no_password.
2022-03-16 18:55:05 +01:00
Antonio Andelic
0979155f2f Address PR comments 2022-03-16 15:45:17 +00:00
Kruglov Pavel
ea5ace7b18
Merge pull request #35309 from Avogar/fix-client-host-help
Fix disappeared host and port from client help message
2022-03-16 12:24:07 +01:00
Antonio Andelic
2291b7c1e1 Merge branch 'master' into parallel-downloading-url-engine 2022-03-16 09:59:52 +00:00
Nikolai Kochetov
a380aa6b8a
Merge pull request #35294 from ClickHouse/reload-remote_url_allow_hosts
Reload remote_url_allow_hosts after config update.
2022-03-15 22:07:16 +01:00
Vladimir C
e022245a33
Merge pull request #35193 from vdimir/issue-34776 2022-03-15 19:56:09 +01:00
avogar
96c6a4b401 Fix disappeared host and port from client help message 2022-03-15 18:36:54 +00:00
Kseniia Sumarokova
afec02fe18
Merge pull request #35264 from kssenii/test-mode-for-local
Support test mode for clickhouse-local
2022-03-15 14:53:01 +01:00
Alexander Tokmakov
1f571b7734 Merge branch 'master' into mvcc_prototype 2022-03-15 14:45:06 +01:00
Vladimir C
02414f1e88
Merge branch 'master' into issue-34776 2022-03-15 14:24:51 +01:00
Nikolai Kochetov
97aa6c82ce Reload remote_url_allow_hosts after config update. 2022-03-15 13:00:31 +00:00
Vladimir C
af88d3f133
Merge pull request #35173 from bigo-sg/dump_ast_in_dot 2022-03-15 11:18:41 +01:00
mergify[bot]
9cdd6ec7ab
Merge branch 'master' into test-mode-for-local 2022-03-15 08:28:40 +00:00
Antonio Andelic
067b79b00b Merge branch 'master' into parallel-downloading-url-engine 2022-03-15 07:55:41 +00:00
Alexander Tokmakov
9702b5177d Merge branch 'master' into mvcc_prototype 2022-03-14 21:45:38 +01:00
Alexander Tokmakov
278d779a01 log cleanup, more comments 2022-03-14 21:43:34 +01:00
Vitaly Baranov
1eb2e8693e Fix code style and other minor corrections after implementing allow_no_password. 2022-03-14 20:55:34 +01:00
Vitaly Baranov
4af61fb9d3
Merge pull request #34738 from DevTeamBK/Issue-33953
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password
2022-03-14 17:09:46 +01:00
Antonio Andelic
d3353f3f0c Merge branch 'master' into parallel-downloading-url-engine 2022-03-14 12:47:23 +00:00
vdimir
db46c2ada8
Fix reading port from config 2022-03-14 11:58:47 +00:00
kssenii
199188be08 Support test mode for clickhouse-local 2022-03-14 12:02:06 +01:00
alesapin
98144bc1f5
Merge pull request #35031 from ClickHouse/standalone_keeper_build
Building small keeper binary
2022-03-14 11:27:25 +01:00
Alexey Milovidov
8420b5c29a Change timezone example in server config 2022-03-11 23:33:26 +01:00
alesapin
96c0e9fddf Better cmake 2022-03-11 15:47:07 +01:00
alesapin
33ff2f76e5 Merge branch 'master' into standalone_keeper_build 2022-03-11 13:58:44 +01:00
Mikhail f. Shiryaev
91f1857211
Merge pull request #35196 from ClickHouse/add_strip_cmake_cmd
Add ability to strip binaries in cmake
2022-03-11 12:37:06 +01:00
Antonio Andelic
28e9508c4e Improve shared pool and add settings 2022-03-11 08:33:34 +00:00
HeenaBansal2009
3f031df225 Code refactoring 2022-03-10 22:22:51 -08:00
taiyang-li
2ae5129e2d modify play.tml 2022-03-11 12:13:46 +08:00
alesapin
0116c3bfeb Fix redundant change 2022-03-10 22:27:10 +01:00
alesapin
e53578910b Add ability to strip binaries in cmake 2022-03-10 22:23:28 +01:00
HeenaBansal2009
3ce9397246 Added Suggestions from Code review 2022-03-09 20:35:01 -08:00
mergify[bot]
78c8029aeb
Merge branch 'master' into stress-test 2022-03-09 16:22:45 +00:00
kssenii
5260822964 Merge master 2022-03-08 18:21:28 +01:00
kssenii
e231c3a3e0 Fix split build 2022-03-08 18:05:55 +01:00
Azat Khuzhin
a871036361
Fix parallel_reading_from_replicas with clickhouse-bechmark (#34751)
* Use INITIAL_QUERY for clickhouse-benchmark

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Fix parallel_reading_from_replicas with clickhouse-bechmark

Before it produces the following error:

    $ clickhouse-benchmark --stacktrace -i1 --query "select * from remote('127.1', default.data_mt) limit 10" --allow_experimental_parallel_reading_from_replicas=1 --max_parallel_replicas=3
    Loaded 1 queries.
    Logical error: 'Coordinator for parallel reading from replicas is not initialized'.
    Aborted (core dumped)

Since it uses the same code, i.e RemoteQueryExecutor ->
MultiplexedConnections, which enables coordinator if it was requested
from settings, but it should be done only for non-initial queries, i.e.
when server send connection to another server.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Fix 02226_parallel_reading_from_replicas_benchmark for older shellcheck

By shellcheck 0.8 does not complains, while on CI shellcheck 0.7.0 and
it does complains [1]:

    In 02226_parallel_reading_from_replicas_benchmark.sh line 17:
        --allow_experimental_parallel_reading_from_replicas=1
        ^-- SC2191: The = here is literal. To assign by index, use ( [index]=value ) with no spaces. To keep as literal, quote it.

    Did you mean:
        "--allow_experimental_parallel_reading_from_replicas=1"

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/34751/d883af711822faf294c876b017cbf745b1cda1b3/style_check__actions_/shellcheck_output.txt

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-08 16:42:29 +01:00
taiyang-li
b4174b0bef merge master and fix conflicts 2022-03-08 11:39:25 +08:00
taiyang-li
4f15955670 fix conflicts 2022-03-08 11:32:22 +08:00
taiyang-li
2283513fc8 merge master and solve conflict 2022-03-08 11:29:00 +08:00
Kseniia Sumarokova
cdb9a05229
Merge pull request #34605 from bigo-sg/add_metric_for_local
Add cpu/mem metric for clickhouse-local
2022-03-07 11:40:11 +01:00
mergify[bot]
977bd30e19
Merge branch 'master' into stress-test 2022-03-05 08:34:07 +00:00
taiyang-li
1b9987ceb1 fix mistake in check-style 2022-03-05 14:22:56 +08:00
alexey-milovidov
ee619dc68e
Merge pull request #35068 from ClickHouse/PlayUI_theme_fixes
Added 'theme' GET parameter to PlayUI + theme selection according to OS fixes
2022-03-05 02:59:27 +03:00
Nir Peled
9c024c9617 Changed the Play UI to select a theme by the following priority:
* 'theme' GET parameter
* 'theme' in localStorage
* According to OS preference (didn't work before)

Also, theme is only saved in localStorage if a user specifically clicked on one theme icon or the other.
2022-03-04 18:44:45 -05:00
alexey-milovidov
7da2c5f927
Update play.html 2022-03-05 02:04:49 +03:00
alesapin
c5a456802f Fix build 2022-03-04 19:39:11 +01:00
Kruglov Pavel
dbba752398
Merge branch 'master' into stress-test 2022-03-04 18:33:37 +03:00
alesapin
5416b567d5 Merge branch 'master' into standalone_keeper_build 2022-03-04 13:35:07 +01:00
alesapin
0eb7d28192 Building small keeper binary 2022-03-03 21:27:46 +01:00
mergify[bot]
c90d24e10b
Merge branch 'master' into random-settings 2022-03-03 13:07:12 +00:00
Vladimir C
eb68c21152
Merge pull request #34995 from vdimir/fix-aarch64 2022-03-03 12:18:28 +01:00
Vladimir C
ec3ed98dfe
Merge pull request #34947 from freedomDR/feature1 2022-03-03 12:14:01 +01:00
Maksim Kita
7d90afb3b0
Merge pull request #34988 from azat/safe-exit
Fix signal-unsafe TSan report in client
2022-03-03 09:21:26 +01:00
Azat Khuzhin
798da0c314 Introduce safeExit() helper (_exit() compatible with TSan)
v2: add missing defines.h header
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-02 22:17:17 +03:00
Maksim Kita
1f5837359e clang-tidy check performance-noexcept-move-constructor fix 2022-03-02 18:15:27 +00:00
avogar
d25d83580a Fix tests 2022-03-02 16:33:21 +00:00