Commit Graph

8 Commits

Author SHA1 Message Date
Nikolai Kochetov
00395e752e Cleanup 2022-06-02 16:59:14 +00:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
   previously allowed.

Hence, this change

- removes shared_ptr_helper and as a result all inherited create() methods,

- instead, Storage objects are now created using make_shared<>() by the
  caller (for that to work, many constructors had to be made public), and

- all Storage classes were marked as noncopyable using boost::noncopyable.

In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Maksim Kita
e27332ce10 RangeHashedDictionary added options range_lookup_strategy, convert_null_range_bound_to_open 2022-01-25 11:13:37 +00:00
Maksim Kita
dd62c3c93e DictionarySourceCoordinator update interface 2022-01-16 12:22:22 +00:00
Maksim Kita
117cb6c614 Fixed RangeHashedDictionary tests 2021-10-22 00:22:32 +03:00
Maksim Kita
a3a780bbf5 Dictionaries read support multiple threads 2021-10-21 17:17:53 +03:00
Maksim Kita
e12820ecb2 Added ComplexKeyRangeHashed dictionary 2021-08-15 12:18:11 +03:00
Maksim Kita
51d31b9213 Dictionaries refactor 2021-08-11 15:32:01 +03:00