Azat Khuzhin
41e6df0f4b
Remove unused offset_columns from MergeTreeReaderWide::readRows()
2021-10-18 21:19:34 +03:00
Azat Khuzhin
4e3910e564
Add a test for adjusting last granula with max_read_buffer_size=0
2021-10-18 21:19:34 +03:00
Maksim Kita
3ffca6e138
ExecutablePool dictionary source fix borrow timeout milliseconds
2021-10-18 21:04:40 +03:00
Nikolai Kochetov
34d46245c3
Try fix some tests.
2021-10-18 20:53:30 +03:00
Anton Popov
3e742524b4
update comments
2021-10-18 19:25:25 +03:00
Nikolai Kochetov
ef3597f054
Fix build.
2021-10-18 19:21:49 +03:00
Nikolai Kochetov
7962eddf60
Review fixes.
2021-10-18 19:18:09 +03:00
feng lv
ab0d2504e5
fix
2021-10-18 15:44:54 +00:00
Anton Popov
1d9cfc04ef
improve performance of aggregation in order of primary key
2021-10-18 18:32:09 +03:00
kssenii
b7a53df9de
Send columns description in clickhouse-local
2021-10-18 14:53:42 +00:00
Nikolai Kochetov
5a4a752cfb
Unite sorting steps.
2021-10-18 17:37:46 +03:00
michon470
3c8e963420
DOCSUP-15198: output_format_csv_null_representation setting translation ( #29977 )
...
* Перевод без изменений содержания
* в ру-версию добавлены ngrambf_v1 и tokenbf_v1
* Update mergetree.md
* Update docs/ru/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/engines/table-engines/mergetree-family/mergetree.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/engines/table-engines/mergetree-family/mergetree.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Update docs/ru/engines/table-engines/mergetree-family/mergetree.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
* Corrections and translation
* in EN ver. lines 349-351 were included into the codeblock -- moved them to the proper place
* ...
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-18 15:40:26 +03:00
tavplubix
837670fd85
Merge pull request #30320 from azat/clickhouse-test-longer-wait
...
Increase default wait of the server start in clickhouse-test
2021-10-18 15:11:32 +03:00
feng lv
b2976fadb0
fix test
2021-10-18 11:57:03 +00:00
Vladimir C
4a4700424e
Merge pull request #30230 from vdimir/CLOUDSUPPORT-92764
2021-10-18 14:46:02 +03:00
Kruglov Pavel
6350957709
Fix special build
2021-10-18 14:30:02 +03:00
Kruglov Pavel
003955b59f
Merge branch 'master' into clickhouse-local
2021-10-18 14:24:08 +03:00
avogar
a28b048415
Fix test
2021-10-18 14:22:27 +03:00
vdimir
042e61febf
Allow identifiers staring with numbers in multiple joins
2021-10-18 13:41:40 +03:00
lhuang0928
a6937a21cf
fix a bug:reference file without a newline at the end
2021-10-18 09:58:53 +00:00
Nikolai Kochetov
6e479b301a
Update memory optimisation for MergingSorted.
2021-10-18 12:54:12 +03:00
Anton Popov
e543f720c6
fix clang-tidy
2021-10-18 12:29:34 +03:00
Anton Popov
1131a3ebe8
fix test
2021-10-18 12:15:08 +03:00
alesapin
fa342c961a
Merge branch 'debug_keeper' of github.com:ClickHouse/ClickHouse into debug_keeper
2021-10-18 12:14:06 +03:00
alesapin
6d24ca4c3a
Review fixes
2021-10-18 12:13:24 +03:00
Anton Popov
71b474793c
Merge pull request #30174 from CurtizJ/better-interfaces
...
Better interfaces for `IDataType` and `ISerialization`
2021-10-18 12:07:04 +03:00
lhuang0928
37441fe44e
Merge remote-tracking branch 'origin/master'
2021-10-18 08:57:25 +00:00
lhuang0928
109e664188
fix date32 comparison with datetime/datetime64
2021-10-18 08:53:25 +00:00
kssenii
1cc511789d
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-local-less-threads
2021-10-18 08:30:59 +00:00
feng lv
81fb4bcf76
fix style
2021-10-18 08:14:54 +00:00
feng lv
0c628726af
fix build
2021-10-18 07:48:58 +00:00
Azat Khuzhin
09b782a52e
Increase default wait of the server start in clickhouse-test
...
Set --server-check-retries to 90 (and this is ~45 seconds), since right
now sometimes it is not enough [1].
[1]: https://clickhouse-test-reports.s3.yandex.net/30191/0e34a9d550cfe6924fe575871f36c44dd44acdaa/functional_stateless_tests_(memory).html#fail1
And the reason I guess is clickhouse-test had been rewritten to
http.client in #30065 , and since now it does not need to execute
clickhouse-client binary, which in debug/sanitizers builds can take also
sometime.
That said that with clickhouse-client for hung check it was not 15
seconds, but more (each clickhouse-client requires 0.6sec with
sanitizers for simple SELECT 1, while w/o 0.1second, also too much
should be optimized)
2021-10-18 10:46:02 +03:00
feng lv
1e3df5780c
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into filelog-engine
2021-10-18 07:33:11 +00:00
Kseniia Sumarokova
ec6b778501
Update 02051_symlinks_to_user_files.sh
2021-10-18 10:29:57 +03:00
Azat Khuzhin
6d4af3bac1
Move SquashingTransform to Interpreters (to fix split build)
...
clickhouse_common_io requires clickhouse_core:
ld.lld: error: undefined symbol: DB::blocksHaveEqualStructure(DB::Block const&, DB::Block const&)
>>> referenced by SquashingTransform.cpp:92 (/src/ch/clickhouse/src/Common/SquashingTransform.cpp:92)
>>> src/CMakeFiles/clickhouse_common_io.dir/Common/SquashingTransform.cpp.o:(void DB::SquashingTransform::append<DB::Block&&>(DB::Block&&))
>>> referenced by SquashingTransform.cpp:92 (/src/ch/clickhouse/src/Common/SquashingTransform.cpp:92)
>>> src/CMakeFiles/clickhouse_common_io.dir/Common/SquashingTransform.cpp.o:(void DB::SquashingTransform::append<DB::Block const&>(DB::Block const&))
while clickhouse_core requires clickhouse_common_io:
"clickhouse_core" of type SHARED_LIBRARY
depends on "roaring" (weak)
depends on "clickhouse_common_io" (weak)
depends on "clickhouse_common_config" (weak)
depends on "clickhouse_common_zookeeper" (weak)
depends on "clickhouse_dictionaries_embedded" (weak)
depends on "clickhouse_parsers" (weak)
Follow-up for: #30247 (cc @KochetovNicolai)
2021-10-18 10:28:36 +03:00
feng lv
6cf82f859c
fix
2021-10-18 07:27:37 +00:00
alesapin
f1fe96e194
Merge branch 'master' into debug_keeper
2021-10-18 10:16:07 +03:00
alesapin
158b4c26b7
Merge pull request #30134 from ClickHouse/fix-network-bytes-test
...
Fix flaky test 01939_network_send_bytes_metrics
2021-10-18 10:11:59 +03:00
feng lv
a32abda322
fix
2021-10-18 07:08:37 +00:00
feng lv
074e02eb14
fix
2021-10-18 06:38:47 +00:00
kssenii
ab9d5d8cc7
Better
2021-10-18 06:06:38 +00:00
alexey-milovidov
452eee7922
Merge pull request #30315 from ClickHouse/no-recursive-submodules
...
Remove recursive submodules
2021-10-18 05:02:40 +03:00
Alexey Milovidov
2cef9983fa
Remove recursive submodules
2021-10-18 02:29:04 +03:00
Alexey Milovidov
f032fb71f0
Minor modification in hardware benchmark
2021-10-18 02:09:41 +03:00
alexey-milovidov
9f21c98f2a
Merge pull request #30312 from den-crane/patch-35
...
Doc. Path to ssd_cache
2021-10-18 00:33:55 +03:00
Azat Khuzhin
0e34a9d550
Add MSan instrumentation for preadv2
...
MSan report [1]:
==10672==WARNING: MemorySanitizer: use-of-uninitialized-value
3 0x30dd6005 in DB::CompressionCodecFactory::get(unsigned char) const obj-x86_64-linux-gnu/../src/Compression/CompressionFactory.cpp:105:65
4 0x30dab4d5 in DB::CompressedReadBufferBase::readCompressedData(unsigned long&, unsigned long&, bool) obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferBase.cpp:127:53
5 0x30db54af in DB::CompressedReadBufferFromFile::readBig(char*, unsigned long) obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferFromFile.cpp:119:38
Uninitialized value was stored to memory at
0 0x9ef4e99 in __msan_memcpy (/src/ch/tmp/30191/clickhouse-msan+0x9ef4e99)
1 0xa0c1999 in DB::ReadBuffer::read() obj-x86_64-linux-gnu/../src/IO/ReadBuffer.h:173:13
2 0xa0c1999 in DB::ReadBuffer::readStrict() obj-x86_64-linux-gnu/../src/IO/ReadBuffer.h:184:27
3 0x30daafd1 in DB::CompressedReadBufferBase::readCompressedData() obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferBase.cpp:120:20
4 0x30db54af in DB::CompressedReadBufferFromFile::readBig() obj-x86_64-linux-gnu/../src/Compression/CompressedReadBufferFromFile.cpp:119:38
Uninitialized value was created by a heap allocation
0 0x9ef5285 in posix_memalign (/src/ch/tmp/30191/clickhouse-msan+0x9ef5285)
1 0xa0cb98d in Allocator<false, false>::allocNoTrack(unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Common/Allocator.h:235:27
2 0xa0caf0d in Allocator<false, false>::alloc(unsigned long, unsigned long) obj-x86_64-linux-gnu/../src/Common/Allocator.h:96:16
3 0xa0caf0d in DB::Memory<Allocator<false, false> >::alloc() obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:126:49
4 0xa0ca4a1 in DB::Memory<Allocator<false, false> >::Memory() obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:43:9
5 0xa0ca4a1 in DB::BufferWithOwnMemory<DB::SeekableReadBuffer>::BufferWithOwnMemory(unsigned long, char*, unsigned long) obj-x86_64-linux-gnu/../src/IO/BufferWithOwnMemory.h:153:29
6 0xa0ca4a1 in DB::ReadBufferFromFileBase::ReadBufferFromFileBase() obj-x86_64-linux-gnu/../src/IO/ReadBufferFromFileBase.cpp:11:7
7 0xa59d980 in DB::AsynchronousReadBufferFromFileDescriptor::AsynchronousReadBufferFromFileDescriptor() obj-x86_64-linux-gnu/../src/IO/AsynchronousReadBufferFromFileDescriptor.h:40:11
SUMMARY: MemorySanitizer: use-of-uninitialized-value obj-x86_64-linux-gnu/../contrib/libcxx/include/__hash_table:116:10 in std::__1::__constrain_hash(unsigned long, unsigned long)
[1]: https://clickhouse-test-reports.s3.yandex.net/30191/18bb0e7d8d47dd694390f3f7b2ecc921a167afac/fuzzer_msan/report.html#fail1
2021-10-17 23:54:58 +03:00
Azat Khuzhin
14baed927f
Add extensive test for various read settings
...
The following settings had been covered:
- min_bytes_to_use_direct_io
- local_filesystem_read_method
- local_filesystem_read_prefetch
- read_priority
- max_read_buffer_size
2021-10-17 23:54:58 +03:00
Azat Khuzhin
fb54d6b6e0
BufferWithOwnMemory: take reallocs into account
2021-10-17 23:54:58 +03:00
Azat Khuzhin
348033d8bd
BufferWithOwnMemory: make size aligned not capacity
...
This will fix pread_fake_async/pread_threadpool with min_bytes_to_use_direct_io
2021-10-17 23:54:58 +03:00
Azat Khuzhin
9cc1178ebc
BufferWithOwnMemory: do not try to align if buffer already aligned
2021-10-17 23:54:57 +03:00