thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-22 01:30:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
47,777 Commits 8,935 Branches 1,766 Tags 2 GiB
d418ee48a4
Commit Graph

1919 Commits

Author SHA1 Message Date
Azat Khuzhin
10b4f3b41f Optimize queries with LIMIT/LIMIT BY/ORDER BY for distributed with GROUP BY sharding_key 
Previous set of QueryProcessingStage does not allow to do this.
But after WithMergeableStateAfterAggregation had been introduced the
following queries can be optimized too under
optimize_distributed_group_by_sharding_key:
- GROUP BY sharding_key LIMIT
- GROUP BY sharding_key LIMIT BY
- GROUP BY sharding_key ORDER BY

And right now it is still not supports:
- WITH TOTALS (looks like it can be supported)
- WITH ROLLUP (looks like it can be supported)
- WITH CUBE
- SETTINGS extremes=1 (looks like it can be supported)
But will be implemented separatelly.

vX: fixes
v2: fix WITH *
v3: fix extremes
v4: fix LIMIT OFFSET (and make a little bit cleaner)
v5: fix HAVING
v6: fix ORDER BY
v7: rebase against 20.7
v8: move out WithMergeableStateAfterAggregation
v9: add optimize_distributed_group_by_sharding_key into test names
 2020-09-03 00:52:51 +03:00
alexey-milovidov
8e2fba5be1
Merge pull request #12567 from amosbird/fmi 
table function view
 2020-09-02 17:07:57 +03:00
Nikita Mikhaylov
cdb1f30630 style + fast test 2020-09-02 16:49:47 +03:00
Nikita Mikhaylov
7021f6edc1 better 
(cherry picked from commit 81481f26b5)
 2020-09-02 15:47:23 +03:00
Nikita Mikhaylov
eee19dada4 fixes + test 
(cherry picked from commit 5daee1cae1)
(cherry picked from commit c3dfb8e838)
 2020-09-02 15:47:09 +03:00
Nikolai Kochetov
811e44a937
Merge pull request #14315 from azat/EXPLAIN-SIGSEGV-fix 
[RFC] Fix QueryPlan lifetime (for EXPLAIN PIPELINE graph=1) for queries with nested interpreter
 2020-09-02 12:46:59 +03:00
Amos Bird
6bd753d85d
TableFunction view. 2020-09-02 16:02:10 +08:00
Amos Bird
be925f8d9c
Introduce columns transformers. 2020-09-02 15:36:34 +08:00
hcz
a80c1adee8 Add JSONCompactStrings formats 2020-09-02 12:15:58 +08:00
alexey-milovidov
adf50fd774
Merge pull request #13761 from zhang2014/improvement/date_time 
ISSUES-4006 add precision argument for DateTime type
 2020-09-02 05:12:35 +03:00
alexey-milovidov
2d85213629
Merge pull request #13792 from azat/lambda-arrayJoin-fix 
[RFC] Fix arrayJoin() capturing in lambda
 2020-09-02 05:10:58 +03:00
hcz
ac5877e601 Fix tests 2020-09-02 00:58:39 +08:00
bharatnc
f0d1c6c794 Merge remote-tracking branch 'upstream/master' into ncb/fix-alter-live-lock 2020-09-01 09:06:10 -07:00
bharatnc
120962b61a fix tests 2020-09-01 08:55:54 -07:00
tavplubix
cb4644ea6d
Merge pull request #14326 from ClickHouse/fix_crash_alter_table_function 
Throw exception on alter for storages created from table functions
 2020-09-01 15:03:09 +03:00
alesapin
c37a19f7b0 Better 2020-09-01 14:23:38 +03:00
alesapin
f0dc5a3085 First working test 2020-09-01 13:49:53 +03:00
hcz
c25a99aaf5 Add tests 2020-09-01 17:47:37 +08:00
alesapin
a0b4cc78d6 Throw exception on alter for storages created from table functions 2020-09-01 10:26:31 +03:00
Azat Khuzhin
d04cda0367 Fix QueryPlan lifetime (for EXPLAIN PIPELINE graph=1) for queries with nested interpreter 
Example of such queries are distributed queries, which creates local
InterpreterSelectQuery, which will have it's own QueryPlan but returns
Pipes that has that IQueryPlanStep attached.

After EXPLAIN PIPELINE graph=1 tries to use them, and will get SIGSEGV.

- TSAN:

<details>

```
==2782113==ERROR: AddressSanitizer: heap-use-after-free on address 0x6120000223c0 at pc 0x00002b8f3f3e bp 0x7fff18cfbff0 sp 0x7fff18cfbfe8
READ of size 8 at 0x6120000223c0 thread T22 (TCPHandler)
    #0 0x2b8f3f3d in DB::printPipelineCompact(std::__1::vector<std::__1::shared_ptr<DB::IProcessor>, std::__1::allocator<std::__1::shared_ptr<DB::IProcessor> > > const&, DB::WriteBuffer&, bool) /build/obj-x86_64-linux-gnu/../src/Processors/printPipeline.cpp:116:53
    #1 0x29ee698c in DB::InterpreterExplainQuery::executeImpl() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:275:17
    #2 0x29ee2e40 in DB::InterpreterExplainQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:73:14
    #3 0x2a7b44a2 in DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:389:28
    #4 0x2a7b1cb3 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:675:30
    #5 0x2b7993b2 in DB::TCPHandler::runImpl() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:253:24
    #6 0x2b7b649a in DB::TCPHandler::run() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1217:9
    #7 0x31d9c57e in Poco::Net::TCPServerConnection::start() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    #8 0x31d9d281 in Poco::Net::TCPServerDispatcher::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114:20
    #9 0x3206b5d5 in Poco::PooledThread::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    #10 0x320657ad in Poco::ThreadImpl::runnableEntry(void*) /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    #11 0x7ffff7f853e8 in start_thread (/usr/lib/libpthread.so.0+0x93e8)
    #12 0x7ffff7ea2292 in clone (/usr/lib/libc.so.6+0x100292)

0x6120000223c0 is located 0 bytes inside of 272-byte region [0x6120000223c0,0x6120000224d0)
freed by thread T22 (TCPHandler) here:
    #0 0x122f3b62 in operator delete(void*, unsigned long) (/src/ch/tmp/master-20200831/clickhouse+0x122f3b62)
    #1 0x2bd9e9fa in std::__1::default_delete<DB::IQueryPlanStep>::operator()(DB::IQueryPlanStep*) const /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2363:5
    #2 0x2bd9e9fa in std::__1::unique_ptr<DB::IQueryPlanStep, std::__1::default_delete<DB::IQueryPlanStep> >::reset(DB::IQueryPlanStep*) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2618:7
    #3 0x2bd9e9fa in std::__1::unique_ptr<DB::IQueryPlanStep, std::__1::default_delete<DB::IQueryPlanStep> >::~unique_ptr() /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2572:19
    #4 0x2bd9e9fa in DB::QueryPlan::Node::~Node() /build/obj-x86_64-linux-gnu/../src/Processors/QueryPlan/QueryPlan.h:66:12
    #5 0x2bd9e9fa in void std::__1::allocator_traits<std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> > >::__destroy<DB::QueryPlan::Node>(std::__1::integral_constant<bool, false>, std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> >&,
 DB::QueryPlan::Node*) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:1798:23
    #6 0x2bd9e9fa in void std::__1::allocator_traits<std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> > >::destroy<DB::QueryPlan::Node>(std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> >&, DB::QueryPlan::Node*) /build/obj-x86_64-lin
ux-gnu/../contrib/libcxx/include/memory:1630:14
    #7 0x2bd9e9fa in std::__1::__list_imp<DB::QueryPlan::Node, std::__1::allocator<DB::QueryPlan::Node> >::clear() /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/list:762:13
    #8 0x29fece08 in DB::InterpreterSelectQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:492:1
    #9 0x2abf7484 in DB::ClusterProxy::(anonymous namespace)::createLocalStream(std::__1::shared_ptr<DB::IAST> const&, DB::Block const&, DB::Context const&, DB::QueryProcessingStage::Enum) /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:
78:33
    #10 0x2abea85d in DB::ClusterProxy::SelectStreamFactory::createForShard(DB::Cluster::ShardInfo const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::shar
ed_ptr<DB::Throttler> const&, DB::SelectQueryInfo const&, std::__1::vector<DB::Pipe, std::__1::allocator<DB::Pipe> >&)::$_0::operator()() const /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:133:51
    #11 0x2abea85d in DB::ClusterProxy::SelectStreamFactory::createForShard(DB::Cluster::ShardInfo const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::shar
ed_ptr<DB::Throttler> const&, DB::SelectQueryInfo const&, std::__1::vector<DB::Pipe, std::__1::allocator<DB::Pipe> >&) /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:189:13
    #12 0x2abe6d99 in DB::ClusterProxy::executeQuery(DB::ClusterProxy::IStreamFactory&, std::__1::shared_ptr<DB::Cluster> const&, Poco::Logger*, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, DB::Settings const&, DB::SelectQueryInfo const&) /build/obj-x86_64-lin
ux-gnu/../src/Interpreters/ClusterProxy/executeQuery.cpp:107:24
    #13 0x2abc4b74 in DB::StorageDistributed::read(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, s
td::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::SelectQueryInfo const&, DB::Context const&, DB::QueryProcessingStage::Enum, unsigned long, unsigned int) /build/obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:514:12
    #14 0x2bda1c5a in DB::ReadFromStorageStep::ReadFromStorageStep(std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions, std::__1::shared_ptr<DB::IStorage>, std::__1::vector<std::__1::basic_st
ring<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, DB::SelectQueryInfo const&, std::__1::shared_ptr<DB::Context>, DB::QueryProcessingStage
::Enum, unsigned long, unsigned long) /build/obj-x86_64-linux-gnu/../src/Processors/QueryPlan/ReadFromStorageStep.cpp:39:26
    #15 0x2a01ca70 in std::__1::__unique_if<DB::ReadFromStorageStep>::__unique_single std::__1::make_unique<DB::ReadFromStorageStep, std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions&, std
::__1::shared_ptr<DB::IStorage>&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >&, DB::SelectQueryInfo&, st
d::__1::shared_ptr<DB::Context>&, DB::QueryProcessingStage::Enum&, unsigned long&, unsigned long&>(std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions&, std::__1::shared_ptr<DB::IStorage>&,
std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >&, DB::SelectQueryInfo&, std::__1::shared_ptr<DB::Context>&,
DB::QueryProcessingStage::Enum&, unsigned long&, unsigned long&) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3028:32
    #16 0x29ff556a in DB::InterpreterSelectQuery::executeFetchColumns(DB::QueryProcessingStage::Enum, DB::QueryPlan&, std::__1::shared_ptr<DB::PrewhereInfo> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::
__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:1383:26
    #17 0x29fe6b83 in DB::InterpreterSelectQuery::executeImpl(DB::QueryPlan&, std::__1::shared_ptr<DB::IBlockInputStream> const&, std::__1::optional<DB::Pipe>) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:795:9
    #18 0x29fe5771 in DB::InterpreterSelectQuery::buildQueryPlan(DB::QueryPlan&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:473:5
    #19 0x2a47d370 in DB::InterpreterSelectWithUnionQuery::buildQueryPlan(DB::QueryPlan&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectWithUnionQuery.cpp:182:38
    #20 0x29ee5bff in DB::InterpreterExplainQuery::executeImpl() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:265:21
    #21 0x29ee2e40 in DB::InterpreterExplainQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:73:14
    #22 0x2a7b44a2 in DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:389:28
    #23 0x2a7b1cb3 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:675:30
    #24 0x2b7993b2 in DB::TCPHandler::runImpl() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:253:24
    #25 0x2b7b649a in DB::TCPHandler::run() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1217:9
    #26 0x31d9c57e in Poco::Net::TCPServerConnection::start() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    #27 0x31d9d281 in Poco::Net::TCPServerDispatcher::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114:20
    #28 0x3206b5d5 in Poco::PooledThread::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    #29 0x320657ad in Poco::ThreadImpl::runnableEntry(void*) /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    #30 0x7ffff7f853e8 in start_thread (/usr/lib/libpthread.so.0+0x93e8)
```

</details>
 2020-09-01 10:04:08 +03:00
alesapin
e28b477f79
Merge pull request #14263 from bharatnc/ncb/disallow-codec-for-alias 
Disallow codec for ALIAS columns types
 2020-09-01 09:42:53 +03:00
bharatnc
2c0353587e add tests 2020-08-31 22:53:47 -07:00
bharatnc
c377c228ef fix tests 2020-08-31 10:22:53 -07:00
alexey-milovidov
75ca3d217f
Merge pull request #14232 from zhang2014/fix/ISSUES-14231 
ISSUES-14231 fix wrong lexer in MaterializeMySQL database engine dump stage
 2020-08-31 19:03:04 +03:00
bharatnc
c4e235b000 Merge remote-tracking branch 'upstream/master' into ncb/disallow-codec-for-alias 2020-08-31 09:01:07 -07:00
bharatnc
caed8cd474 change error code to BAD_ARGUMENTS (36) 2020-08-31 09:00:32 -07:00
Alexander Kuzmenkov
bc8765d5ad
Merge pull request #14095 from azat/DistributedFilesToInsert-fix 
Fix DistributedFilesToInsert metric (zeroed when it should not)
 2020-08-31 18:58:30 +03:00
Alexander Kuzmenkov
134aae89f3
Merge pull request #14110 from 4ertus2/decimal 
Fix Decimal to Float conversion and toDecimal256() function
 2020-08-31 17:08:49 +03:00
bharatnc
025de8cecc add tests 2020-08-31 00:12:19 -07:00
zhang2014
761512413e ISSUES-14231 allow dollar and numver in identifier 2020-08-31 14:14:02 +08:00
zhang2014
d24bf8de51 ISSUES-14231 allow dollar sign in identifier 2020-08-31 12:46:41 +08:00
alexey-milovidov
b1efc5df01
Merge pull request #14225 from amosbird/bf1 
Fix bug in mark inclusion search.
 2020-08-30 02:58:22 +03:00
Azat Khuzhin
134080ae3f Add 01460_DistributedFilesToInsert into the arcadia_skip_list 
To fix the following failure:
    Yandex synchronization check (only for Yandex employees)
 2020-08-30 01:24:21 +03:00
alexey-milovidov
2a514eae21
Merge pull request #14223 from nikitamikhaylov/update-permutaiton-bug-fix 
Fixed incorrect sorting order if LowCardinality column.
 2020-08-29 18:25:26 +03:00
Amos Bird
865c66ba7a
Add .reference 2020-08-29 23:09:09 +08:00
alexey-milovidov
4c60f36a0a
Update 01460_mark_inclusion_search_crash.sql 2020-08-29 09:46:46 +08:00
Amos Bird
591a4d60d4
Fix bug in mark inclusion search. 2020-08-29 09:46:46 +08:00
alexey-milovidov
c6f55bbe6a
Merge pull request #14151 from 4ertus2/some 
Add functions: isDecimalOverflow(), countDigits()
 2020-08-28 22:01:54 +03:00
alesapin
10c7a6c45e
Add ability to specify Default codec for columns (#14049) 
* Add ability to specify DefaultCompression codec which correspond to settings specified in config.xml

* Fix style

* Rename DefaultCompression to simple Default

* Fix compression codec

* Better codec description representation

* Less strange code and one method

* Fix delta
 2020-08-28 20:40:45 +03:00
alesapin
65c33f0802
Merge pull request #13280 from amosbird/as 
ALTER MODIFY SAMPLE BY
 2020-08-28 19:32:09 +03:00
Nikita Mikhaylov
9d1cb7e22e done 2020-08-28 18:15:15 +03:00
alesapin
057bb65658
Merge pull request #14199 from azat/01085_max_distributed_connections-flacky-fix 
Fix 01085_max_distributed_connections flackiness
 2020-08-28 13:22:30 +03:00
alesapin
0896b49533 Small fixes 2020-08-28 13:18:56 +03:00
Artem Zuikov
881cd3331a gix comment and useDefault*(), add tests for nullables 2020-08-28 13:16:42 +03:00
alesapin
35af2f9df9
Merge pull request #14198 from azat/00974_distributed_join_on-flacky-fix 
Fix 00974_distributed_join_on flackiness (by allow retries and hide logs)
 2020-08-28 10:04:39 +03:00
Azat Khuzhin
07923cd7cd Fix 01085_max_distributed_connections flackiness 
1.8 seconds is too small delay, which eventually can lead to
false-positive if the machine will be slow enough.

Increase number of remote streams and the delay, to avoid
false-positive.
 2020-08-28 02:41:11 +03:00
Azat Khuzhin
cdb6bed8b9 Fix 00974_distributed_join_on flackiness (by allow retries and hide logs) 2020-08-28 02:10:13 +03:00
alexey-milovidov
f1811bfc88
Merge pull request #14194 from ClickHouse/fix-flaky-test-12 
Fix flaky test
 2020-08-28 01:46:22 +03:00
Azat Khuzhin
a384194216 Add a test for DistributedFilesToInsert 2020-08-27 22:00:35 +03:00
Alexey Milovidov
b7c27c2a8c Remove race condition from test 2020-08-27 21:43:21 +03:00
Alexey Milovidov
01567d62a4 Fix nullptr dereference in defaultValueOfTypeName 2020-08-27 21:36:18 +03:00
Amos Bird
078b14610d
ALTER MODIFY SAMPLE BY 2020-08-27 22:31:30 +08:00
Artem Zuikov
0d134f2c26 add test 2020-08-27 17:05:55 +03:00
Artem Zuikov
2a0b98b19c add countDigits() function 2020-08-27 16:17:13 +03:00
alesapin
afe4702c2c
Merge pull request #14139 from bharatnc/ncb/min_index_granularity_bytes 
add setting min_index_granularity_bytes
 2020-08-27 12:08:07 +03:00
tavplubix
478adb75ef
Merge pull request #14143 from ClickHouse/fix-named-tuple 
Fix creation of tables with named tuples #13027
 2020-08-27 11:56:59 +03:00
tavplubix
81dc22b1d0
make test less flacky 2020-08-27 11:55:17 +03:00
Artem Zuikov
724b38adc9 isDecimalOverflow() function 2020-08-27 04:14:10 +03:00
bharatnc
7183873b67 fix more failing tests 2020-08-26 17:54:37 -07:00
alexey-milovidov
67f16d5ae8
Merge pull request #14122 from ClickHouse/fix-fuzz-test-compile-expressions 
More range checks when compile_expressions = 1
 2020-08-27 02:15:40 +03:00
alexey-milovidov
0f706c01ca
Merge pull request #13888 from vladimir-golovchenko/add-date-trunc-function 
Added date_trunc function
 2020-08-27 02:12:27 +03:00
bharatnc
10c4178938 fix tests involving index_granularity_bytes 2020-08-26 15:34:24 -07:00
bharatnc
593f054b10 minor fix exception message 2020-08-26 15:31:48 -07:00
bharatnc
b019a70ed2 add tests 2020-08-26 15:31:48 -07:00
alexey-milovidov
0152bcba21
Merge pull request #14126 from ClickHouse/unique_paths_in_zk 
Use unique paths in zookeeper for tests
 2020-08-27 01:16:55 +03:00
alexey-milovidov
330997dd0a
Merge pull request #14119 from ClickHouse/aku/min-decimal 
Fix formatting of minimal negative decimal
 2020-08-27 01:16:37 +03:00
Alexey Milovidov
651fb3539c Fix creation of tables with named tuples #13027 2020-08-27 00:57:42 +03:00
alexey-milovidov
f6f8dc9b8a
Merge pull request #13964 from zhang2014/fix/agg_combinator 
Try fix IfAggCombinator with NullAggCombinator
 2020-08-26 23:47:29 +03:00
alexey-milovidov
c53854df19
Merge pull request #14079 from livace/fix_2d_pip 
Fix pointInPolygon with const 2d array
 2020-08-26 21:02:58 +03:00
Alexander Tokmakov
47dbe9e628 use unique paths in zk for tests 2020-08-26 20:45:20 +03:00
Alexander Kuzmenkov
c4fc434a13
Merge pull request #14060 from azat/parallel_distributed_insert_select-2 
Extend parallel_distributed_insert_select to run INSERT into local table
 2020-08-26 20:37:36 +03:00
Alexey Milovidov
ee6a623077 Add test 2020-08-26 19:51:03 +03:00
Alexander Kuzmenkov
1a4fcf6650 Fix formatting of minimal negative decimal 2020-08-26 19:34:00 +03:00
alexey-milovidov
318f14b95e
Merge pull request #13691 from ClickHouse/client-progress-clobber-data 
Fix visible data clobbering by progress bar in client in interactive mode
 2020-08-26 13:25:25 +03:00
alexey-milovidov
d3a9389465
Merge branch 'master' into bharatnc-ncb/timezones-table 2020-08-26 04:26:37 +03:00
alexey-milovidov
31460db37c
Merge pull request #14028 from ClickHouse/hczhcz-patch-0819-2 
Merging #13877
 2020-08-26 04:24:24 +03:00
alexey-milovidov
5a8bd865ee
Merge pull request #14065 from ClickHouse/adjust_test_time 
Adjust test time
 2020-08-26 04:23:36 +03:00
alexey-milovidov
6d80255bca
Merge pull request #14055 from ClickHouse/investigate-test 
Fix test `01056_prepared_statements_null_and_escaping.sh`
 2020-08-26 03:47:47 +03:00
alexey-milovidov
2d9c806f1b
Merge pull request #14066 from ClickHouse/fix-flacky-test-10 
Fix error in clickhouse-benchmark test
 2020-08-26 03:41:16 +03:00
vladimir golovchenko
fb06f59ceb Added tests for date_trunc function. 2020-08-25 16:41:23 -07:00
alexey-milovidov
7c3c18da92
Merge branch 'master' into bharatnc-ncb/timezones-table 2020-08-26 02:14:53 +03:00
Alexey Ilyukhov
4f7c5fa0af Fix style in requests 2020-08-26 01:55:07 +03:00
alexey-milovidov
00c697df06
Merge pull request #14005 from ClickHouse/ucasFL-new-branch 
Merging #12195
 2020-08-26 01:33:54 +03:00
Alexey Ilyukhov
f32b7f48f1 Fix pointInPolygon with const 2d array 2020-08-26 01:13:47 +03:00
alexey-milovidov
421faed3f5
Merge pull request #14047 from 4ertus2/some 
Test for AST optimizations with Distributed query
 2020-08-26 00:11:44 +03:00
Alexey Milovidov
e2721e95d8 Merge branch 'master' into hczhcz-patch-0819-2 2020-08-25 23:50:41 +03:00
Alexey Milovidov
e05ad381ce Fix error in clickhouse-benchmark test 2020-08-25 23:33:03 +03:00
Alexey Milovidov
f77e2149fc Adjust test time 2020-08-25 23:28:38 +03:00
Alexey Milovidov
f10db9c0bc Merge branch 'master' into client-progress-clobber-data 2020-08-25 23:22:16 +03:00
Alexey Milovidov
8a70c0c9bf Fixup LIVE VIEW tests 2020-08-25 23:21:44 +03:00
Alexey Milovidov
8864356f33 Kludge 2020-08-25 23:09:23 +03:00
Azat Khuzhin
50a312534c Extend parallel_distributed_insert_select to run INSERT into local table 
Before this patch there was:

- parallel_distributed_insert_select=1, that executes:

    INSERT INTO dist_out SELECT ... FROM underlying_dist_in

After this patch there will be:

- parallel_distributed_insert_select=2, that executes:

    INSERT INTO underlying_dist_out SELECT ... FROM underlying_dist_in

And cover the behaviour w/o integration test, by using the following
techincs:
- SYSTEM STOP DISTRIBUTED SENDS
- prefer_localhost_replica=0
 2020-08-25 22:49:13 +03:00
Azat Khuzhin
308e094d04 Fix arrayJoin() capturing in lambda 
Fixes the following LOGICAL_ERROR:

    $ clickhouse-client -q 'select arrayFilter((a) -> ((a, arrayJoin([[]])) IN (Null, [Null])), [])'
    2020.08.16 00:32:01.967102 [ 1744189 ] {b40a5ebd-d710-4f03-bb18-57db67de1181} <Error> : Logical error: 'Lambda captured argument arrayJoin(array(array())) not found in required columns.'.
    clickhouse-server: ../src/Common/Exception.cpp:45: DB::Exception::Exception(const string&, int): Assertion `false' failed.

Since there are multiple input columns for arrayJoin():

    (gdb) p captured_names_
    $6 = std::vector of length 3, capacity 4 = {"arrayJoin(array(array()))", "arrayJoin(array(array()))", "__set"}

While FunctionCaptureOverloadResolver cannot handle non-unique columns.
 2020-08-25 21:06:21 +03:00
Artem Zuikov
737b255aae ignore test in ya check 2020-08-25 19:32:58 +03:00
alesapin
f95acff93c
Update 01456_modify_column_type_via_add_drop_update.sql 2020-08-25 19:00:00 +03:00
Vitaly Baranov
82c8f56713 Add test for changing column's type by performing ADD COLUMN + UPDATE + DROP COLUMN. 2020-08-25 16:30:05 +03:00
Artem Zuikov
8d2122c62c add test 2020-08-25 15:46:31 +03:00
alesapin
dffd0a8213
Merge pull request #14027 from ClickHouse/faster-test 
Faster test under TSan
 2020-08-25 10:17:59 +03:00
Alexey Milovidov
31240aa243 Minor modifications 2020-08-24 23:35:38 +03:00
bharatnc
2ef2d0976b spacing, new line at end in .sql and .reference files 2020-08-24 23:30:58 +03:00
bharatnc
87475661ce include reference file for test 2020-08-24 23:30:58 +03:00
bharatnc
a0a566bcf7 add tests for new time_zones table 2020-08-24 23:30:41 +03:00
alexey-milovidov
7ea5364299
Merge pull request #13648 from filimonov/tzdata_version2 
tzdata improvements
 2020-08-24 23:07:37 +03:00
Alexey Milovidov
846cdd70fc Merge branch 'patch-0819' of https://github.com/hczhcz/ClickHouse into hczhcz-patch-0819-2 2020-08-24 23:01:59 +03:00
Alexey Milovidov
ffd8c19385 Faster test under TSan 2020-08-24 22:59:28 +03:00
Alexey Milovidov
ec24bfe128 Added a test that proves feature exists 2020-08-24 22:54:06 +03:00
Nikita Mikhaylov
e4fc48254a
Merge pull request #13818 from bharatnc/ncb/quantileExactLowHigh 
add functions for quantileExactLow & quantileExactHigh
 2020-08-24 23:51:30 +04:00
alexey-milovidov
2e6ff0c5ec
Merge pull request #13925 from 4ertus2/ast 
Rewrite duplicate distinct optimization
 2020-08-24 22:33:22 +03:00
alexey-milovidov
6a164634d7
Merge pull request #12550 from myrrc/bug/low-cardinality-arrays-optimisations 
Optimising has(), indexOf(), and countEqual() for Array(LowCardinality(T)) and constant right arguments
 2020-08-24 22:31:29 +03:00
alexey-milovidov
14400b5b41
Merge pull request #13940 from hczhcz/patch-0821 
Fix parser to reject create table as table function with engine
 2020-08-24 22:01:40 +03:00
Alexey Milovidov
dfe870e38c Merge branch 'new-branch' of https://github.com/ucasFL/ClickHouse into ucasFL-new-branch 2020-08-24 16:26:08 +03:00
Artem Zuikov
69c77ff229 Merge branch 'master' into ast 2020-08-24 14:09:30 +03:00
Anton Popov
93d49e5815
Merge pull request #13237 from vdimir/string-locate-startpos-3776 
Support start_pos argument in `position` function
 2020-08-24 12:23:19 +03:00
hcz
7c02047060 Fix tests 2020-08-24 10:51:04 +08:00
alexey-milovidov
d0b6ba35d1
Merge pull request #8367 from amosbird/scalarfix 
fix scalar subquery hash conflicts
 2020-08-24 01:14:34 +03:00
bharatnc
70d532ace6 fix tests spacing in 0700_decimal_aggregates.reference 2020-08-23 10:09:41 -07:00
bharatnc
0814973af9 add tests for quantileExactLow & quantileExactHigh 2020-08-23 10:09:41 -07:00
hcz
559242503b Add test cases 2020-08-24 01:01:47 +08:00
zhang2014
0e8cb96eb1 Try fix IfAggCombinator with NullAggCombinator 2020-08-22 22:57:46 +08:00
alexey-milovidov
84db9a3a66
Merge pull request #13906 from tomjiang1987/optimize_error_msg_for_null 
optimize error msg for null value of TabSeparatedRow format
 2020-08-21 16:06:16 +03:00
alexey-milovidov
55ac192417
Merge pull request #13928 from ClickHouse/wring-error-for-too-long-query 
Fix wrong error for long queries.
 2020-08-21 13:18:19 +03:00
Winter Zhang
ff84040cd5
ISSUES-4006 try fix test failure 2020-08-21 14:42:31 +08:00
zhang2014
ec1572d7be ISSUES-4006 support parserDateTime32 functions 2020-08-21 13:09:25 +08:00
tao jiang
a269855e2f add testcase. due to the error msg have version string so just print matched part 2020-08-21 11:32:12 +08:00
Artem Zuikov
13bb3774ff update tests 2020-08-20 23:50:53 +03:00
Nikolai Kochetov
99b31480fd Fix wrong error for long queries. 2020-08-20 21:56:50 +03:00
Artem Zuikov
f4e84d93ba fix indirect distinct with less columns 2020-08-20 21:51:22 +03:00
alexey-milovidov
6cf1a61735
Merge pull request #13841 from azat/unknown-packet-fix 
Unknown packet fix (for Protocol::Server::Log for distributed queries)
 2020-08-20 20:25:58 +03:00
Artem Zuikov
911e6efe3e rewrite duplicate distinct optimization 2020-08-20 20:04:42 +03:00
Amos Bird
333ec2e496
fix scalar subquery hash conflicts 2020-08-20 21:19:10 +08:00
myrrc
d298409660 Merge remote-tracking branch 'upstream/master' into bug/low-cardinality-arrays-optimisations 2020-08-20 12:07:02 +03:00
hcz
cc328532af Fix timezone 2020-08-20 12:07:01 +08:00
Alexander Tokmakov
f38bf04f62 fix test 2020-08-20 00:32:39 +03:00
myrrc
4f96291c35 rewrote the LC spec as a dispatcher 2020-08-19 21:59:39 +03:00
Nikolai Kochetov
322cb241b9
Merge pull request #13887 from ClickHouse/fix-fixed-string-partial-sort 
Fix fixed string partial sort
 2020-08-19 21:41:25 +03:00
alexey-milovidov
b0a171211f
Merge pull request #13881 from ClickHouse/check-ya-make-files 
Check that ya.make files are auto-generated
 2020-08-19 21:24:20 +03:00
Alexander Tokmakov
30e0cd438e fix test 2020-08-19 18:56:26 +03:00
Nikolai Kochetov
25dd0fa4d6
Update 01453_fixsed_string_sort.sql 2020-08-19 15:43:08 +03:00
Nikolai Kochetov
ab37eee653 Added test. 2020-08-19 15:26:48 +03:00
Artem Zuikov
becc186c91
Add support for extended precision integers and decimals (#13097) 2020-08-19 14:52:17 +03:00
tavplubix
3b8ac01ed0
Merge pull request #13756 from ClickHouse/test-drop-database-race 
Fix race condition in DROP DATABASE
 2020-08-19 13:27:50 +03:00
Alexey Milovidov
425297e9c9 Check that ya.make files are auto-generated 2020-08-19 12:40:28 +03:00
alexey-milovidov
1c40e3ca4e
Merge pull request #13867 from azat/00956_sensitive_data_masking-fix 
Fix 00956_sensitive_data_masking flackiness
 2020-08-19 12:33:48 +03:00
alexey-milovidov
6d72777b6e
Merge pull request #13868 from ClickHouse/stratify-array-compact-nan 
Stratify nans comparison in arrayCompact function
 2020-08-19 11:53:58 +03:00
hcz
be2ffe07ee Add docs and tests 2020-08-19 16:07:51 +08:00
zhang2014
bdb20738e5 ISSUES-4006 compatible DateTime64 2020-08-19 13:19:36 +08:00
hexiaoting
e9be2f14ea fix implementation for \n separated lines 2020-08-19 11:50:43 +08:00
alexey-milovidov
23ccb0b6be
Merge pull request #13677 from hagen1778/merge-tree-fail-fast-on-rows-limit 
[mergeTree]: fail fast if max_rows_to_read limit exceeded on parts scan
 2020-08-18 22:24:39 +03:00
Alexey Milovidov
acf312467e Stratify nans comparison in arrayCompact function 2020-08-18 22:16:53 +03:00
Azat Khuzhin
3ba9e9f6ce Fix 00956_sensitive_data_masking flackiness 
00956_sensitive_data_masking is still flacky even after #13748 [1].

    [1]: https://clickhouse-test-reports.s3.yandex.net/10373/348ef1256ea8fb8f61109c33bbdd28daf46bdc8e/functional_stateless_tests_(debug).html#fail1

The problem is that it uses the following pattern:

    clickhouse-client -q ... & # run some query in background
    clickhouse-client -q 'show processlist' > log
    grep background-query log

But there is no guarantee that the query in background will be executed before `show processlist`:

    2020.08.18 02:52:47.916386 [ 26788 ] {98c36d38-f710-4dfb-af8f-61906abc163c} <Debug> executeQuery: (from [::1]:51650) SHOW PROCESSLIST
    ...
    2020.08.18 02:52:47.926854 [ 26756 ] {086c64fa-713b-4f8c-b702-23bfea10a49c} <Debug> executeQuery: (from [::1]:51652) select count() from system.numbers where ignore('find_me_[hidden]')=0 and ignore('fwerkh_that_magic_string_make_me_unique') = 0 FORMAT Null

Fix the test by waiting until the query in backgroud will start, and use
limited numbers + sleepEachRow over system.numbers to reduce CPU usage.
 2020-08-18 21:57:53 +03:00