alexey-milovidov
5a4a5fda20
Update ColumnVector.h
2021-02-12 01:04:55 +03:00
Maksim Kita
b276eac197
Common types template instantiations
2021-02-12 00:54:50 +03:00
Alexey Milovidov
b61ce427a8
Whitespaces
2021-02-11 23:59:00 +03:00
alesapin
df181b534e
Better connection reset
2021-02-11 23:29:01 +03:00
alesapin
5f32f65211
Merge branch 'master' into in_memory_raft
2021-02-11 23:09:29 +03:00
Azat Khuzhin
3993ad6f01
Fix test_system_merges by using mutations_sync=1
...
After early_constant_folding started to ignore not only ignore(), but
all functions with isSuitableForConstantFolding() == false, there became
more sleep(2) calls for this test:
- MergeTreeDataSelectExecutor::readFromParts -> DB::KeyCondition::KeyCondition
- MergeTreeDataMergerMutator::mutatePartToTemporaryPart -> DB::isStorageTouchedByMutations -> FilterTransform::transform
- MergeTreeDataMergerMutator::mutatePartToTemporaryPart -> DB::MergeTreeDataMergerMutator::mutateAllPartColumns -> FilterTransform::transform
While before it was optimized to 0 during WHERE analysis.
2021-02-11 22:46:56 +03:00
Azat Khuzhin
f6cfcd4da9
Fix null dereference with join_use_nulls=1
...
Found with MSan [1], the following query triggers null dereference:
```sql
SELECT
Y.id - 1
FROM X
RIGHT JOIN Y ON (X.id + 1) = Y.id
SETTINGS join_use_nulls=1; -- { serverError 53 }
```
```
Received signal 11
(version 21.3.1.5916, build id: 2E9E84AA32AEAAC7C8B6EB45DA3EC0B4F15E9ED4) (from thread 100) (query_id: 9ab8cb0d-be8d-445e-8498-930a7268488b) Received signal Segmentation fault (11)
Address: 0x10 Access: read. Address not mapped to object.
Stack trace: 0x2d079d65 0x29bf1f30 0x12b12220 0x12b13098 0x12b17b08 0x12b20459 0x2ae37913 0x2ae352d9 0x2c746072 0x2c7585dd 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d 0x2c7483e3 0x2c74e63d
4. ./obj-x86_64-linux-gnu/../contrib/boost/boost/smart_ptr/intrusive_ptr.hpp:0: DB::ColumnConst::ColumnConst(COW<DB::IColumn>::immutable_ptr<DB::IColumn> const&, unsigned long) @ 0x2d079d65 in /workspace/clickhouse
5. ./obj-x86_64-linux-gnu/../src/Common/COW.h:0: DB::createBlockWithNestedColumns(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) @ 0x29bf1f30 in /workspace/clickhouse
6. DB::FunctionOverloadResolverAdaptor::getReturnTypeDefaultImplementationForNulls(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::function<std::__1::shared_ptr<DB::IDataType const> (std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&)> const&) @ 0x12b12220 in /workspace/clickhouse
7. DB::FunctionOverloadResolverAdaptor::getReturnTypeWithoutLowCardinality(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b13098 in /workspace/clickhouse
8. DB::FunctionOverloadResolverAdaptor::getReturnType(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b17b08 in /workspace/clickhouse
9. DB::FunctionOverloadResolverAdaptor::build(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) const @ 0x12b20459 in /workspace/clickhouse
```
[1]: https://clickhouse-test-reports.s3.yandex.net/19451/64c0bf98290362fa216c05b070aa122a12af3c25/fuzzer_msan/report.html#fail1
2021-02-11 21:30:05 +03:00
alexey-milovidov
dc3ffd3fe2
Merge pull request #19451 from azat/safe-writes
...
Do not silently ignore write errors
2021-02-11 21:19:11 +03:00
Azat Khuzhin
2907385400
Avoid invalid dereference in RANGE_HASHED() dictionary
...
UBsan report the following [1], when query does not contains any columns
from the dictionary:
```sql
SELECT
toUInt32(toUInt32(NULL, toUInt32(NULL, inf, NULL), NULL)),
toUInt32(toUInt32(toUInt32(toUInt32(toUInt32(NULL, 1., NULL)), toUInt32(toUInt32(NULL, 0.5, NULL)), toUInt32(NULL, NULL)), toUInt32(toUInt32(NULL, 1., NULL)), toUInt32(NULL, NULL)), toUInt32(toUInt32(toUInt32(toUInt32(NULL, 1000.0001220703125, NULL)), toUInt32(toUInt32(NULL, 10.000100135803223, NULL)), toUInt32(NULL, NULL)), NULL, NULL, NULL))
FROM somedict
```
```
std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> >::back() @ 0x128c07a6 in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/RangeDictionaryBlockInputStream.h:0: DB::RangeDictionaryBlockInputStream<DB::RangeHashedDictionary, unsigned short, unsigned long>::fillBlock(DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 15ul, 16ul> const&, DB::PODArray<unsigned short, 4096ul, Allocator<false, false>, 15ul, 16ul> const&, DB::PODArray<unsigned short, 4096ul, Allocator<false, false>, 15ul, 16ul> const&) const @ 0x1692335e in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/RangeDictionaryBlockInputStream.h:0: DB::RangeDictionaryBlockInputStream<DB::RangeHashedDictionary, unsigned short, unsigned long>::getBlock(unsigned long, unsigned long) const @ 0x16922f96 in /workspace/clickhouse
./obj-x86_64-linux-gnu/../src/Dictionaries/DictionaryBlockInputStreamBase.cpp:23: DB::DictionaryBlockInputStreamBase::getHeader() const @ 0x166ab57c in /workspace/clickhouse
```
[1]: https://clickhouse-test-reports.s3.yandex.net/19451/64c0bf98290362fa216c05b070aa122a12af3c25/fuzzer_ubsan/report.html#fail1
2021-02-11 21:07:37 +03:00
alexey-milovidov
7b55eb8c58
Merge pull request #20178 from amosbird/delayinactive
...
Delay or throw insertion when too many inactive parts
2021-02-11 20:52:04 +03:00
alexey-milovidov
ef3c9b531c
Merge pull request #20287 from kitaisreal/delta-sum-aggregate-function-use-restrict-keyword
...
Aggregate function deltaSum use restrict keyword
2021-02-11 20:47:07 +03:00
alexey-milovidov
ac707f7165
Merge pull request #20305 from azat/fix-flaky-tests
...
Fix 00738_lock_for_inner_table flakiness
2021-02-11 20:46:42 +03:00
alexey-milovidov
15c5a1e24d
Merge pull request #20299 from alex-karo/fix_broken_link_backup_page
...
Fix broken links to "max table size" param in backup documentation
2021-02-11 20:45:15 +03:00
alexey-milovidov
d15d340691
Merge pull request #20301 from azat/numbers-numeric-limit
...
Accept arbitrary numeric types for numbers() arguments (for scientific notation)
2021-02-11 20:41:15 +03:00
Alexander Kuzmenkov
1275be58bf
Merge remote-tracking branch 'origin/master' into HEAD
2021-02-11 19:49:37 +03:00
Alexander Kuzmenkov
ebb47595aa
Merge pull request #20293 from ClickHouse/aku/window-prototype-3
...
make window functions faster
2021-02-11 19:49:02 +03:00
Alexander Kuzmenkov
a77415781f
reserve the result columns in advance
2021-02-11 19:48:27 +03:00
Alexander Kuzmenkov
62b3bf7b57
some tests and speedup
2021-02-11 19:20:57 +03:00
Maksim Kita
248a06f930
Added test
2021-02-11 19:11:07 +03:00
Maksim Kita
369dc613c4
Decimal binary operation constants fix
2021-02-11 19:05:17 +03:00
Alexander Kuzmenkov
a2943fd196
cleanpu
2021-02-11 18:47:52 +03:00
Alexander Kuzmenkov
d8f9a8d3cd
first_value and last_value
2021-02-11 18:41:54 +03:00
alesapin
bf4af9713c
Fix tests
2021-02-11 18:29:08 +03:00
Ivan
0854dccfde
Fix ANTLR parser tests
2021-02-11 18:21:21 +03:00
Alexander Kuzmenkov
ecbcf47f28
lag/lead stubs + cleanup
2021-02-11 18:07:42 +03:00
Alexander Kuzmenkov
772073a0db
Update WindowTransform.cpp
2021-02-11 17:01:09 +03:00
alexey-milovidov
263d751d64
Merge pull request #20169 from ClickHouse/no-excessive-squash-memory
...
Disable excessive squashing of blocks for StorageMemory #13052
2021-02-11 16:38:24 +03:00
Alexey Milovidov
c32ed77976
Some queries become too fast
2021-02-11 16:37:46 +03:00
Alexander Kuzmenkov
525400bc41
window function rank() and friends
2021-02-11 16:29:30 +03:00
alesapin
447fcfa1c9
Fix build
2021-02-11 15:12:01 +03:00
Nikita Mikhailov
e325ab2538
fix test
2021-02-11 15:00:14 +03:00
filimonov
47c8537f63
Add libnss_files to alpine image
...
It seems it's needed to make some of DNS-related features work
properly in certain scenarios (things like getting proper FQDN, reverse DNS lookup).
2021-02-11 12:56:26 +01:00
alesapin
3253638969
Fix backoff for failed background tasks in replicated merge tree
2021-02-11 14:46:18 +03:00
Nikita Mikhailov
d7dccb8d2c
better
2021-02-11 13:43:12 +03:00
alesapin
99a471e047
Add ability to start as follower
2021-02-11 13:25:10 +03:00
alesapin
0acd018361
Fix typo
2021-02-11 12:58:02 +03:00
alesapin
74630acff5
More debug in test
2021-02-11 12:49:49 +03:00
tavplubix
17af32a59b
Merge pull request #20215 from azat/dist-lockless-SYSTEM-FLUSH-DISTRIBUTED
...
Lockless SYSTEM FLUSH DISTRIBUTED
2021-02-11 12:30:46 +03:00
alesapin
b49b7f859d
Simplify startup with fixed config
2021-02-11 12:17:57 +03:00
Alexander Kuzmenkov
363007b964
fixes
2021-02-11 11:39:39 +03:00
alesapin
d88f7bc0c8
Merge pull request #20224 from ClickHouse/fix_config_reloader_destruction
...
Fix access control manager destruction order
2021-02-11 11:18:00 +03:00
alesapin
56453256b7
Merge pull request #20300 from ClickHouse/restrict_to_drop_version_column
...
Don't allow to drop or rename version column
2021-02-11 11:04:00 +03:00
alesapin
121c5c9605
Merge pull request #20279 from ClickHouse/relax_check_in_data_writer
...
Relax check in data writer for non adaptive tables
2021-02-11 10:57:07 +03:00
alesapin
c2bb2c2902
Merge pull request #20097 from ClickHouse/remove-adding-missed-step
...
Build actions dag to evaluate missing defaults.
2021-02-11 10:51:21 +03:00
Alexander Kuzmenkov
308fbd2ba5
Update run-fuzzer.sh
2021-02-11 10:45:51 +03:00
Alexander Kuzmenkov
467ff74814
Merge remote-tracking branch 'origin/master' into HEAD
2021-02-11 10:42:39 +03:00
Alexander Kuzmenkov
aed3f4ae66
Merge pull request #20284 from ClickHouse/aku/window-prototype-2
...
Put windows in such an order that we can sort less
2021-02-11 10:40:56 +03:00
Alexander Kuzmenkov
38678ff484
Merge remote-tracking branch 'origin/master' into HEAD
2021-02-11 10:40:05 +03:00
Alexander Kuzmenkov
2571dac984
Merge pull request #20111 from ClickHouse/aku/window-prototype
...
RANGE OFFSET window frame
2021-02-11 10:39:21 +03:00
Azat Khuzhin
222a0db3f4
Update tests expectations for early_constant_folding
2021-02-11 10:31:58 +03:00