Commit Graph

5164 Commits

Author SHA1 Message Date
Azat Khuzhin
d476a4a9bd Add type conversion for optimize_skip_unused_shards_rewrite_in
MSan reports [1]:

    2021.04.17 15:20:06.665152 [ 56 ] {2336bf92-0269-4acd-8b3f-f09623223d18} <Debug> executeQuery: (from [::1]:44744, using production parser) SELECT * FROM dist_01757 WHERE dummy IN ('255', 0) FORMAT Null
    ...
    0 0x305af885 in (anonymous namespace)::shardContains() obj-x86_64-linux-gnu/../src/Interpreters/OptimizeShardingKeyRewriteInVisitor.cpp:50:28
    ...
    Uninitialized value was created by an allocation of 'sharding_value' in the stack frame of function '_ZN12_GLOBAL__N_113shardContainsERKN2DB5FieldERKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEERKNS4_10shared_ptrINS0_17ExpressionActionsEEESC_RKNS0_7Cluster9ShardInfoERKNS4_6vectorImNS8_ImEEEE'
    0 0x305ae260 in (anonymous namespace)::shardContains() obj-x86_64-linux-gnu/../src/Interpreters/OptimizeShardingKeyRewriteInVisitor.cpp:42

  [1]: https://clickhouse-test-reports.s3.yandex.net/23212/d02eb3f6b7a8dc07bbed5605e1afcf7634436b3a/fuzzer_msan/report.html#fail1

P.S. fuzzers are great!
2021-04-19 00:03:38 +03:00
alexey-milovidov
83038f84af
Revert "Function arrayFold for folding over array with accumulator" 2021-04-18 03:34:05 +03:00
alexey-milovidov
96fced4c3c
Merge pull request #23211 from azat/mmap-accounting
[RFC] Fix memory tracking with min_bytes_to_use_mmap_io
2021-04-18 03:17:30 +03:00
alexey-milovidov
7f3a40e1b0
Merge pull request #22237 from ClickHouse/protocol-compression-auto
Autodetect compression #22234
2021-04-18 03:13:54 +03:00
Alexey Milovidov
8ac953f459 Make function unhex case insensitive for compatibility 2021-04-17 19:31:35 +03:00
Alexey Milovidov
a790652029 Merge branch 'protocol-compression-auto' of github.com:yandex/ClickHouse into protocol-compression-auto 2021-04-17 16:47:13 +03:00
Alexey Milovidov
77e64b3ebd Merge branch 'master' into protocol-compression-auto 2021-04-17 16:46:51 +03:00
alexey-milovidov
138c6ae228
Merge pull request #23185 from ClickHouse/fix_22573
Fix data_type_default_nullable on ATTACH
2021-04-17 16:13:42 +03:00
Azat Khuzhin
6bd32bd2cb Mark 01605_adaptive_granularity_block_borders as long 2021-04-17 13:50:52 +03:00
Azat Khuzhin
a963fba41a Update 00084_external_aggregation to avoid using mmap 2021-04-17 10:37:58 +03:00
Azat Khuzhin
1b367ee71d Update 01605_adaptive_granularity_block_borders to avoid using mmap 2021-04-17 10:37:58 +03:00
Azat Khuzhin
6064f3ef1d Fix memory tracking with min_bytes_to_use_mmap_io
With min_bytes_to_use_mmap_io=1 memory regions for mmap() will not be
accounted. But this creates issues, since if you will run simple
"SELECT * FROM big_enough_table" it will mmap lot's of files and the
process RSS will grow at some point, and before the kernel will
understand that it needs to unmap physical pages the clickhouse-server
will sync total_memory_tracker with RSS of the process and the
allocations will fail by per-server memory limits.

Also note, that this does not address all the issues with mmap()
regions.

v2: move track/untrack into the MMapReadBufferFromFileWithCache to avoid
data-race [1]

  [1]: https://clickhouse-test-reports.s3.yandex.net/23211/6acf6cb9b22cee7db8d1aa523a6208f63e792f7a/functional_stateful_tests_(thread).html#fail1
2021-04-17 10:37:38 +03:00
Alexey Milovidov
ecf8de7111 Add a test for #14610 2021-04-17 02:22:32 +03:00
alexey-milovidov
786f340256
Merge pull request #22755 from kssenii/postgresql-protocol-with-row-policy
Allow row policy in postgresql protocol
2021-04-17 01:55:30 +03:00
Kruglov Pavel
deb86ee520
Merge pull request #22986 from azat/StorageBuffer-flush
[RFC] Add ability to flush buffer only in background for StorageBuffer
2021-04-16 15:14:24 +03:00
Alexander Kuzmenkov
74b4c56ba4
Merge pull request #21589 from dmalkr/dmalkr/arrayFold
Function `arrayFold` for folding over array with accumulator
2021-04-16 14:23:53 +03:00
Alexander Tokmakov
ebf0a3119e fix data_type_default_nullable on attach 2021-04-16 13:29:33 +03:00
tavplubix
b5cbbce314
Merge pull request #22706 from songenjie/fetch_part
[clickhouse][server][ddl]support fetch part
2021-04-16 12:26:51 +03:00
tavplubix
ae3dc3dfc0
Merge pull request #23161 from ClickHouse/logs_for_debuging_test_failures
More verbose logs for debuging test failures with Replicated and Keeper
2021-04-16 12:01:58 +03:00
alexey-milovidov
dcb5d1b395
Merge pull request #23096 from ClickHouse/markdown-bad-alignment
Fix unpleasant behaviour of `Markdown` format
2021-04-16 00:06:58 +03:00
Alexander Tokmakov
0ad6205fa6 logs for debuging test failures with Replicated and Keeper 2021-04-15 21:34:53 +03:00
Azat Khuzhin
19e0439629 Add ability to flush buffer only in background for StorageBuffer
Add 3 new engine arguments:
- flush_time
- flush_rows
- flush_bytes

That will be checked only for background flush, this maybe useful if
INSERT latency is "crucial".
2021-04-15 21:22:13 +03:00
alexey-milovidov
02e77c3ef1
Merge pull request #23111 from ClickHouse/fix_test_name
Rename strange tests
2021-04-15 15:03:31 +03:00
alexey-milovidov
ec97414d5a
Update 01598_memory_limit_zeros.sql 2021-04-15 14:45:05 +03:00
Maksim Kita
e361f5943f
Merge pull request #22999 from azat/no-optimize_skip_unused_shards-single-node
Do not perform optimize_skip_unused_shards for cluster with one node
2021-04-15 14:36:56 +03:00
Vladimir
8c7ffda676
Merge pull request #22753 from ClickHouse/revert-19685-dev_joinon 2021-04-15 12:42:50 +03:00
Dmitry Krylov
75036debf4 Check type match of lambda and accumulator 2021-04-15 19:25:30 +10:00
Pavel Kruglov
b909899cc9 Remove extra lines 2021-04-15 11:59:56 +03:00
Pavel Kruglov
8bd77e1c0c Change markdown format test 2021-04-15 11:58:14 +03:00
alesapin
c979287526 Rename strange tests 2021-04-15 11:28:22 +03:00
alexey-milovidov
9b546f3b89
Merge pull request #22657 from amosbird/ctefix3
Fix CTE usage in view definition
2021-04-15 02:01:10 +03:00
Alexey Milovidov
346e16ce7f Fix test 2021-04-15 00:45:39 +03:00
Alexey Milovidov
17d04cbca9 Merge branch 'master' into protocol-compression-auto 2021-04-15 00:24:07 +03:00
tavplubix
2479c80fb7
Merge branch 'master' into fix_attach_mv 2021-04-15 00:07:48 +03:00
tavplubix
021cafff49
Merge pull request #23041 from ClickHouse/fix_testkeeper_multi_response
Fix multi response in TestKeeper
2021-04-14 23:25:40 +03:00
Ivan
57f61c954c
Another attempt to enable pytest (#22664)
* Fix some tests

* Fix tests
2021-04-14 19:35:17 +03:00
Alexey Milovidov
3b1adbfea4 Fix test 2021-04-14 16:48:12 +03:00
alexey-milovidov
496c2e45d0
Merge pull request #23036 from Enmk/fix_extractAllGroupsHorizontal_max_matches
Fixed erroneus failure of extractAllGroupsHorizontal on large columns
2021-04-14 15:57:19 +03:00
Ivan
2b78765957
Merge branch 'master' into postgresql-protocol-with-row-policy 2021-04-14 14:50:28 +03:00
alexey-milovidov
f8ce5547aa
Merge pull request #21318 from azat/servers-pool-wait
Fix SIGSEGV by waiting servers thread pool
2021-04-14 14:15:07 +03:00
Alexander Tokmakov
c34e27ed1c fix test 2021-04-14 14:07:56 +03:00
alexey-milovidov
d3f8a9c23a
Merge pull request #23044 from ClickHouse/array-has-any-all-generic
Fix unfinished code in GatherUtils #20272
2021-04-14 13:57:30 +03:00
alexey-milovidov
35260089e0
Merge pull request #23040 from ClickHouse/remove-useless-parts-from-suggest
Remove non-essential parts from Suggest
2021-04-14 13:55:25 +03:00
alexey-milovidov
86e20905e5
Merge pull request #23008 from ClickHouse/add-test-2719
Add a test for #2719
2021-04-14 13:54:36 +03:00
tavplubix
caf97d297b
Update arcadia_skip_list.txt 2021-04-14 12:17:41 +03:00
Nikita Mikhaylov
c0ed151239
Merge pull request #22012 from nikitamikhaylov/s3-distributed
Table function `s3Cluster`
2021-04-14 10:23:43 +03:00
songenjie
f731739fab fix suggests 2021-04-14 10:05:41 +08:00
Alexey Milovidov
311011caf8 Merge branch 'remove-useless-parts-from-suggest' of github.com:yandex/ClickHouse into remove-useless-parts-from-suggest 2021-04-14 01:08:32 +03:00
Alexey Milovidov
58281eadc0 Mark test as long 2021-04-14 01:08:09 +03:00
tavplubix
5df608a11b
Merge pull request #23043 from ClickHouse/improve_hung_check
Improve hung check in Stress tests
2021-04-14 00:29:52 +03:00