Commit Graph

115364 Commits

Author SHA1 Message Date
robot-ch-test-poll2
a0ef0955da
Merge pull request #49983 from imbingo123/imbingo123-patch-modify_docs
Update grant.md
2023-05-18 10:39:49 +02:00
libin
d294ecbc16
Update grant.md
docs: Modifying grant example
2023-05-18 15:50:19 +08:00
FFFFFFFHHHHHHH
d31371adac
Merge branch 'master' into dot_product 2023-05-18 15:31:25 +08:00
Alexey Milovidov
86e14547d4
Merge pull request #49964 from ClickHouse/kssenii-patch-7
Follow up to #49429
2023-05-18 09:20:00 +03:00
Alexey Milovidov
5065049154
Merge pull request #49971 from azat/revert-48593-group_array_nullable
[RFC] Revert "`groupArray` returns cannot be nullable"
2023-05-18 09:17:42 +03:00
Rich Raposa
03b5bfe218
Merge pull request #49968 from ClickHouse/reddit
Add Reddit comments to datasets
2023-05-17 15:26:29 -06:00
Kseniia Sumarokova
855c95f626
Update src/Interpreters/Cache/Metadata.cpp
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2023-05-17 22:46:09 +02:00
Yakov Olkhovskiy
612b79868b test added 2023-05-17 20:40:51 +00:00
Azat Khuzhin
e2e3a03dbe
Revert "groupArray returns cannot be nullable" 2023-05-17 22:33:30 +02:00
rfraposa
6a136897e3 Create reddit-comments.md 2023-05-17 13:23:53 -06:00
Han Fei
549af4d351 address comments 2023-05-17 21:23:32 +02:00
DanRoscigno
a1fc96953f reorder 2023-05-17 14:48:16 -04:00
Timur Solodovnikov
c7ab59302f
Set allow_experimental_query_cache setting as obsolete (#49934)
* set allow_experimental_query_cache as obsolete

* add tsolodov to trusted contributors

* CI linter

---------

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-05-17 20:03:42 +02:00
Dan Roscigno
addc0c0ece
Merge branch 'master' into allow_experimental_parallel_reading_from_replicas 2023-05-17 13:20:14 -04:00
Kseniia Sumarokova
1c04085e8f
Update MergeTreeWriteAheadLog.h 2023-05-17 18:15:51 +02:00
Dan Roscigno
67b8aca910
Merge pull request #49935 from ClickHouse/thomoco-patch-3
Update postgresql.md
2023-05-17 11:25:24 -04:00
kssenii
f2dbcb5146 Better fix 2023-05-17 16:27:06 +02:00
alesapin
2b7bc19cae
Merge pull request #49911 from ClickHouse/make_test_less_flaky
Retry connection expired in test_rename_column/test.py
2023-05-17 16:03:48 +02:00
alesapin
a7c179e401
Merge branch 'master' into make_test_less_flaky 2023-05-17 15:44:24 +02:00
Han Fei
ed1d036151
Merge pull request #49884 from azat/dist-fix-async-block-processing
Fix processing pending batch for Distributed async INSERT after restart
2023-05-17 15:19:42 +02:00
Alexander Tokmakov
36c31e1d79
Improve concurrent parts removal with zero copy replication (#49630)
* improve concurrent parts removal

* fix

* fix
2023-05-17 14:07:34 +03:00
Alexander Tokmakov
c4d074a0a0
Merge pull request #48726 from ClickHouse/Follow_up_Backup_Restore_concurrency_check_node_2
Back/Restore concurrency check on previous fails
2023-05-17 14:03:24 +03:00
Alexander Tokmakov
1e529263d0
Merge branch 'master' into Follow_up_Backup_Restore_concurrency_check_node_2 2023-05-17 13:57:50 +03:00
Vitaly Baranov
15ebbd2ed6
Merge pull request #48896 from vitlibar/write-encrypted-to-backup
BACKUP from encrypted disks must not decrypt data
2023-05-17 12:40:00 +02:00
Vitaly Baranov
6c8a923c9d
Merge branch 'master' into write-encrypted-to-backup 2023-05-17 12:37:05 +02:00
Kseniia Sumarokova
ac048cbbff
Merge pull request #49925 from kssenii/add-more-logging-for-cache
Add some logging
2023-05-17 12:29:40 +02:00
Kseniia Sumarokova
edceda494d
Merge branch 'master' into add-more-logging-for-cache 2023-05-17 12:24:59 +02:00
Igor Nikonov
3d8b6b708f Fix for analyzer: 02377_ ptimize_sorting_by_input_stream_properties_explain 2023-05-17 10:20:29 +00:00
Kseniia Sumarokova
3787b7f127
Update Metadata.cpp 2023-05-17 12:16:18 +02:00
Azat Khuzhin
9fe4f1a934 Extensive coverage for bandwidth limiting settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Azat Khuzhin
fdfb1eda55 Fix {Local,Remote}ReadThrottlerSleepMicroseconds metric values
And also update the test, since now you could have slightly less sleep
intervals, if query spend some time in other places.

But what is important is that query_duration_ms does not exceeded
calculated delay.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Azat Khuzhin
7383da0c52 Fix per-query remote throttler
remote throttler by some reason had been overwritten by the global one
during reloads, likely this is for graceful reload of this option, but
it breaks per-query throttling, remove this logic.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Azat Khuzhin
3c80e30f02 Fix per-query IO/BACKUPs throttling settings (when default profile has them)
When some of this settings was set for default profile (in
users.xml/users.yml), then it will be always used regardless of what
user passed.

Fix this by not inherit per-query throttlers, for this they should be
reset before making query context and they should not be initialized as
before in Context::makeQueryContext(), since makeQueryContext() called
too early, when user settings was not read yet.

But there we had also initialization of per-server throttling, move this
into the ContextSharedPart::configureServerWideThrottling(), and call it
once we have ServerSettings set.

Also note, that this patch makes the following settings - server
settings:
- max_replicated_fetches_network_bandwidth_for_server
- max_replicated_sends_network_bandwidth_for_server
But this change should not affect anybody, since it is done with
compatiblity (i.e. if this setting is set in users profile it will be
read from it as well as a fallback).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Igor Nikonov
7d647c50c7
Merge branch 'master' into clearable_hash_set_without_zero_storage 2023-05-17 11:29:01 +02:00
FFFFFFFHHHHHHH
fd1e6557e1
Merge branch 'master' into dot_product 2023-05-17 14:40:06 +08:00
fhbai
c104354894 fix 2023-05-17 14:39:30 +08:00
Vitaly Baranov
f4ac4c3f9d Corrections after review. 2023-05-17 03:23:16 +02:00
Yakov Olkhovskiy
0a44a69dc8 remove unnecessary header 2023-05-17 00:22:13 +00:00
Yakov Olkhovskiy
282297b677 binary encoding of IPv6 in protobuf 2023-05-16 23:46:01 +00:00
Thom O'Connor
15cb627688
Update postgresql.md
The type cannot be optional, so we need to be clear in the docs that [type1] [type2] cannot be in square brackets, so removed them
2023-05-16 16:35:41 -06:00
Han Fei
35f00f72b3 add functional test 2023-05-16 22:42:43 +02:00
Han Fei
3ead9e627e Merge branch 'master' into hanfei/fix-optimize-regexp-prefix 2023-05-16 22:31:01 +02:00
serxa
abacf1f990 add missing quota_key in operator== for connections 2023-05-16 19:14:54 +00:00
DanRoscigno
64bf477ff2 add DDL 2023-05-16 14:58:04 -04:00
serxa
b12eefc694 fix timeout units and log message 2023-05-16 18:57:04 +00:00
Alexander Tokmakov
0da82945ac fix 2023-05-16 18:18:48 +02:00
Alexander Tokmakov
3d26232cc0
Merge pull request #49918 from ClickHouse/remove_unused_code
Remove unused code
2023-05-16 18:53:49 +03:00
kssenii
724949927b Add logging 2023-05-16 17:36:48 +02:00
Kruglov Pavel
353791b2dd
Try to fix flaky test_distributed_load_balancing tests (#49912)
* Try to fix flaky test_distributed_load_balancing tests

* Automatic style fix

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-05-16 18:26:22 +03:00
Antonio Andelic
4bc5a76fa7
Add Compose request for GCS (#49693)
* Add compose request

* Check if outcome is successful

---------

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-05-16 17:20:06 +02:00