Commit Graph

53370 Commits

Author SHA1 Message Date
Alexey Milovidov
0e944d400c
Merge pull request #60092 from ClickHouse/index-preparation
A small preparation for better handling of primary key in memory
2024-02-17 10:15:06 +01:00
Alexey Milovidov
c5107afb94
Merge branch 'master' into lazy-primary-key-loading 2024-02-17 10:14:35 +01:00
Alexey Milovidov
69dfd721ce Fix inconsistent formatting of INSERT queries 2024-02-17 10:11:59 +01:00
Alexey Milovidov
dbb0ed8157 Fix error 2024-02-17 10:08:36 +01:00
Alexey Milovidov
3d21d546a9 Better code 2024-02-17 09:44:10 +01:00
Alexey Milovidov
f4539fc781 Merge branch 'master' of github.com:ClickHouse/ClickHouse into settings-avoid-overflow 2024-02-17 09:10:43 +01:00
Alexey Milovidov
6cae75751b
Merge pull request #60049 from ClickHouse/less-memory-usage-primary-key
Maybe less memory usage for primary keys in memory
2024-02-17 08:58:02 +01:00
Alexey Milovidov
021e11e4fc Add a setting for lazy loading 2024-02-17 06:42:53 +01:00
Alexey Milovidov
423ff759f1 Lazy loading of primary keys in memory 2024-02-17 06:35:03 +01:00
Alexey Milovidov
e9cf92245f Move methods to .cpp 2024-02-17 06:20:44 +01:00
Alexey Milovidov
fce3a8cafc A small preparation for better handling of primary key in memory 2024-02-17 06:16:56 +01:00
Alexey Milovidov
ac5bef7c74 A small preparation for better handling of primary key in memory 2024-02-17 06:16:01 +01:00
Alexey Milovidov
b5efbe62e7 Avoid overflow in settings 2024-02-17 05:41:52 +01:00
Alexey Milovidov
6b32622c7d
Merge pull request #60080 from kitaisreal/temporary-table-already-exists-exception-message-fix
Temporary table already exists exception message fix
2024-02-17 05:17:39 +01:00
Alexey Milovidov
46c2f85314 Merge branch 'master' into less-memory-usage-primary-key 2024-02-17 04:55:59 +01:00
Alexey Milovidov
d10b18afeb I found TODO in the code, that can be implemented 2024-02-17 02:21:55 +01:00
Alexey Milovidov
9686bb51bc Style check for abbreviations 2024-02-17 02:15:14 +01:00
Alexey Milovidov
2f315e0eb5 Style check for abbreviations 2024-02-17 02:14:15 +01:00
Alexey Milovidov
509d8ee99c Apply review comments 2024-02-17 01:54:54 +01:00
Alexey Milovidov
ceb65bb114 Merge branch 'master' of github.com:ClickHouse/ClickHouse into print-cpu-flags-at-startup 2024-02-17 01:53:56 +01:00
Alexey Milovidov
87134acdf0
Merge pull request #60083 from Avogar/max-query-size-ddl-entry
Use max_query_size from context in DDLLogEntry instead of hardcoded 4096
2024-02-17 01:49:08 +01:00
Alexey Milovidov
731c484b3d
Revert "Implement system.dns_cache table (#59856)"
This reverts commit b5ef034697.
2024-02-17 01:46:41 +01:00
Kirill Nikiforov
b5ef034697
Implement system.dns_cache table (#59856)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* Update 02981_system_dns_cache_table.sql

* Update 02981_system_dns_cache_table.reference

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-16 14:31:22 -05:00
avogar
4e6f04ddf1 Address comments 2024-02-16 19:30:16 +00:00
avogar
8c66db0d1c Use max_query_size from context in DDLLogEntry instead of hardcoded 4096 2024-02-16 19:21:25 +00:00
Alexander Tokmakov
31479649fe
Merge pull request #59908 from azat/rmt-uuid-macro
[RFC] Allow uuid in replica_path if CREATE TABLE explicitly has it
2024-02-16 17:31:59 +01:00
Alexander Tokmakov
3813a97775
Merge pull request #59895 from azat/rmt-mutations-polling
Do not pull mutations if pulling replication log had been stopped
2024-02-16 17:24:30 +01:00
Maksim Kita
96d9782439 Temporary table already exists exception message fix 2024-02-16 19:16:02 +03:00
Igor Nikonov
cb0ce2aaa9 Fix build 2024-02-16 15:26:08 +00:00
Dmitry Novik
a3c34a7cc2
Merge pull request #54211 from ClickHouse/Support_parameterized_view_with_analyzer
Refactor parameterized view & add support for new analyzer
2024-02-16 16:13:49 +01:00
Kruglov Pavel
4d6f167e0c
Merge pull request #59092 from Avogar/auto-format-detection
Try to detect file format automatically during schema inference if it's unknown
2024-02-16 14:32:18 +01:00
Alexey Milovidov
25f2501c7f
Merge pull request #60013 from ClickHouse/verify-parser-on-server-side
Verify formatting consistency on the server-side
2024-02-16 13:48:10 +01:00
Igor Nikonov
118263d8e8 Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http 2024-02-16 12:40:10 +00:00
alesapin
0a189e830c
Merge pull request #59942 from kitaisreal/storage-system-tables-add-metadata-version
StorageSystemTables add metadata_version
2024-02-16 13:17:22 +01:00
Alexey Milovidov
0787e9f402 Merge remote-tracking branch 'origin/master' into print-cpu-flags-at-startup 2024-02-16 13:07:03 +01:00
Alexey Milovidov
5b83e771ed Print CPU flags at startup 2024-02-16 13:06:57 +01:00
Raúl Marín
586c1e9b4e
Merge pull request #60026 from Algunenano/fix_optimize_uniq_to_count
Fix optimize_uniq_to_count removing the column alias
2024-02-16 11:52:46 +01:00
Raúl Marín
e168329ade
Revert "ReplicatedMergeTree invalid metadata_version fix" 2024-02-16 11:44:16 +01:00
Kseniia Sumarokova
0f9cf00740
Merge pull request #59630 from vitlibar/fix-read-beyond-last-offset
Fix error "Read beyond last offset" for AsynchronousBoundedReadBuffer
2024-02-16 11:11:17 +01:00
Kseniia Sumarokova
d4ab2bf38e
Merge pull request #60036 from ClickHouse/s3queue-fix-possible-no-node-shard
Fix possible exception from s3queue table on drop
2024-02-16 11:09:42 +01:00
Antonio Andelic
0f489de46e
Merge pull request #59945 from ClickHouse/keeper-prometheus-filtered-events
Send only Keeper related metrics/events for Prometheus
2024-02-16 09:43:43 +01:00
Dmitry Novik
2b02bcd67b
Merge pull request #59926 from azat/analyzer/NormalizeCountVariantsVisitor-fix
Do not rewrite sum() to count() if return value differs in analyzer
2024-02-16 09:16:46 +01:00
Alexey Milovidov
5b13c167ee
Merge pull request #60022 from Algunenano/arrayfold_logical
Fix several logical errors in arrayFold
2024-02-16 03:19:13 +01:00
Alexey Milovidov
00c28d97ed Merge branch 'master' into verify-parser-on-server-side 2024-02-16 01:29:08 +01:00
Alexey Milovidov
885e8dad63
Merge pull request #60042 from Algunenano/format_not
Fix formatting of NOT with single literals
2024-02-16 01:28:45 +01:00
Alexey Milovidov
2f36c9e965 Maybe less memory usage for primary keys in memory 2024-02-16 00:56:24 +01:00
Alexey Milovidov
3470fc70b2 Merge branch 'master' into check-stack-size-in-parser 2024-02-15 23:45:33 +01:00
Alexey Milovidov
15683ae6a0 Revert wrong modification 2024-02-15 22:58:07 +01:00
Igor Nikonov
7b1fbec4e5 Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http 2024-02-15 21:11:38 +00:00
Raúl Marín
a249840421 Fix formatting of NOT with single literals 2024-02-15 21:44:22 +01:00
Raúl Marín
f17d58cced Add comment 2024-02-15 20:53:22 +01:00
Alexey Milovidov
b8fcff36f3
Merge pull request #60010 from ClickHouse/simplify-code-2
The code should not be complex
2024-02-15 18:00:33 +01:00
Alexey Milovidov
b1a911108a
Merge pull request #60012 from ClickHouse/fix-broken-lambdas
Fix broken lambdas formatting
2024-02-15 17:59:51 +01:00
kssenii
2a783321d7 Fix deletion of s3 queue 2024-02-15 17:56:38 +01:00
Dmitry Novik
8397b856ae Cleanup 2024-02-15 17:28:54 +01:00
Dmitry Novik
dfaea604c3 Remove redundant includes 2024-02-15 17:27:26 +01:00
Robert Schulze
058461e786
Merge remote-tracking branch 'rschu1ze/master' into order-by-all-ambiguities 2024-02-15 16:21:16 +00:00
Robert Schulze
1edf3b2254
Replace ORDER BY ALL by ORDER BY * to get rid of ambiguities 2024-02-15 16:19:56 +00:00
Konstantin Bogdanov
dbb6804a70
Merge pull request #59976 from ClickHouse/add-cloud-placement
Add `PlacementInfo`
2024-02-15 19:16:56 +03:00
Dmitry Novik
a11b9553ca Fix implementation in new analyzer 2024-02-15 17:16:27 +01:00
Raúl Marín
5baae9326c Fix optimize_uniq_to_count removing the column alias 2024-02-15 14:10:55 +01:00
Igor Nikonov
1464830791 Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http 2024-02-15 12:56:32 +00:00
Igor Nikonov
c580cdb96e Fix review comment 2024-02-15 12:55:43 +00:00
Raúl Marín
91f54f44b6 Fix several logical errors in arrayFold 2024-02-15 13:21:39 +01:00
Azat Khuzhin
f10fc95933 Fix INSERT into SQLite with single quote
Previously it leads to syntax error, due to incorrect escaping of single
quotes for SQLite, "\'" had been used instead of "''"

So set output_format_values_escape_quote_with_quote=true for SQLite to
fix this.

v2: prepare modified Context for writing on storage creation
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-15 12:47:29 +01:00
Azat Khuzhin
bbe38a3fe4 Add ability to escape quotes in Values format with single quote
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-15 12:47:29 +01:00
Azat Khuzhin
504a2dd9d9 Do not rewrite sum() to count() if return value differs in analyzer
v2: fix for LowCardinality
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-15 12:41:05 +01:00
Robert Schulze
f8413481c4
Merge remote-tracking branch 'ClickHouse/master' into materialize_non_override_past_values 2024-02-15 10:29:00 +00:00
Robert Schulze
ddaef8d342
Merge pull request #59752 from rschu1ze/countMatches-fuzzed
Fix AST fuzzer issue in function `countMatches`
2024-02-15 10:02:48 +01:00
Alexey Milovidov
a86d31a005
Merge pull request #59998 from ClickHouse/revert-59699-disable_async_inserts_for_dependent_mv_dedup
Revert "Insert synchronously if dependent MV deduplication is enabled"
2024-02-15 07:52:13 +01:00
Alexey Milovidov
0258aba5c0 Verify formatting consistency on the server-side 2024-02-15 07:49:13 +01:00
Alexey Milovidov
accc63500d Fix broken lambdas formatting 2024-02-15 06:54:18 +01:00
Alexey Milovidov
d3fdd97891 The code should not be complex 2024-02-15 06:04:45 +01:00
Alexey Milovidov
a98facee52
Merge pull request #59944 from ClickHouse/fewer_lambdas
Replace lambdas with pointers to members to simplify stacks
2024-02-15 06:02:35 +01:00
Alexey Milovidov
47d8248b9d
Merge pull request #60005 from ClickHouse/non-significant-changes-3
Fix obviously wrong (but non significant) error in dictionaries
2024-02-15 05:59:07 +01:00
Alexey Milovidov
009d08561d
Merge pull request #59946 from kitaisreal/replicated-merge-tree-alter-update-metadata-version-in-single-transaction
ReplicatedMergeTree invalid metadata_version fix
2024-02-15 04:38:06 +01:00
Alexey Milovidov
0b58f16938
Merge pull request #59964 from ClickHouse/cleanups
Cleanups
2024-02-15 02:59:54 +01:00
Alexey Milovidov
5e5528a890
Merge pull request #59972 from jrdi/fix-max-num-to-warn
Fix max num to warn message
2024-02-15 02:59:29 +01:00
Alexey Milovidov
b73c9ce9f5
Merge pull request #59981 from ClickHouse/analyzer-fix-test_storage_rabbitmq
Analyzer: Fix test_storage_rabbitmq
2024-02-15 02:58:09 +01:00
Alexey Milovidov
feb8020448
Merge pull request #59983 from ClickHouse/analyzer-fix-test_shard_level_const_function
Analyzer: Fix test_shard_level_const_function
2024-02-15 02:57:39 +01:00
Alexey Milovidov
681351fe1e
Merge pull request #59987 from nickitat/fix_data_race_storage_distributed
Fix data race in `StorageDistributed`
2024-02-15 02:55:08 +01:00
Alexey Milovidov
46fb01c4f6 Fix trash 2024-02-15 02:31:46 +01:00
Alexey Milovidov
bbd7acd7f9
Merge branch 'master' into exponent-floats-inference 2024-02-15 01:46:51 +01:00
Alexey Milovidov
2688a6268c Fix obviously wrong (but non significant) error in dictionaries 2024-02-15 01:42:14 +01:00
Alexey Milovidov
7a5e152d9e
Merge pull request #59967 from ClickHouse/dashboards-to-use-merge-tables
Use merge table in the dashboard; add Cloud overview to the system table
2024-02-14 21:56:37 +01:00
Julia Kartseva
b1b58ef9a3
Revert "Insert synchronously if dependent MV deduplication is enabled" 2024-02-14 12:54:42 -08:00
Vitaly Baranov
d842c497e6 Change code to pass test 02963_remote_read_small_buffer_size_bug. 2024-02-14 20:47:34 +01:00
Nikolai Kochetov
ab8738ffe5
Merge pull request #59985 from ClickHouse/remove-context-from-comparison-functions
Remove context from comparison functions.
2024-02-14 19:32:28 +01:00
Nikolai Kochetov
9c626f9c36
Merge pull request #59899 from ClickHouse/refactor-squashing-for-inserts
Refactor Squashing for inserts.
2024-02-14 19:29:11 +01:00
Nikolai Kochetov
5833f30deb
Merge pull request #59984 from ClickHouse/update-settings-change-history
Add newlines to SettingsChangesHistory to maybe have less conflicts
2024-02-14 17:45:19 +01:00
Nikolai Kochetov
70d456dc28
Update greater.cpp 2024-02-14 17:44:06 +01:00
Nikolai Kochetov
078ec9a97f
Update notEquals.cpp 2024-02-14 17:43:49 +01:00
Dmitry Novik
433d835df6
Merge pull request #59920 from azat/http-retries-logs
Decrease logging level for http retriable errors to Warning (and fix 00157_cache_dictionary flakiness)
2024-02-14 17:11:28 +01:00
Nikita Taranov
5f87956fc8 impl 2024-02-14 16:22:14 +01:00
Maksim Kita
d4778d858d Fixed tests 2024-02-14 18:05:29 +03:00
Maksim Kita
0cce386207 Added documentation 2024-02-14 18:05:29 +03:00
Maksim Kita
f6d211b44d StorageSystemTables add metadata_version 2024-02-14 18:05:29 +03:00
Maksim Kita
be490291af Updated implementation 2024-02-14 18:05:06 +03:00
Maksim Kita
dca627026c ReplicatedMergeTree ALTER update metadata_version in single transaction 2024-02-14 18:05:06 +03:00
Raúl Marín
11519f949b
Merge pull request #59731 from kitaisreal/asof-join-try-sort-with-radix-sort
ASOF JOIN use trySort with RadixSort
2024-02-14 15:54:22 +01:00
kssenii
8fe9ede207 Add a test 2024-02-14 15:25:43 +01:00
yariks5s
c1897e74a8 fix 2024-02-14 14:04:25 +00:00
Nikolai Kochetov
c54a1d1d97 Add newlines to SettingsChangesHistory to maybe have less conflicts 2024-02-14 13:54:26 +00:00
Dmitry Novik
e95726f57c Analyzer: Fix test_shard_level_const_function 2024-02-14 13:21:23 +00:00
Igor Nikonov
d5ab7d8df0 Keep header the same as before 2024-02-14 13:19:34 +00:00
Igor Nikonov
eafa4219d9 Remove unnecessary include 2024-02-14 13:17:55 +00:00
Antonio Andelic
0bee591a0c Fix build 2024-02-14 14:10:58 +01:00
Yarik Briukhovetskyi
41304c3e11
Update src/Functions/FunctionBinaryArithmetic.h
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2024-02-14 14:08:20 +01:00
Igor Nikonov
fd5b572225 Fix 2024-02-14 13:00:22 +00:00
Vitaly Baranov
8919e3b011 Add test. 2024-02-14 13:41:23 +01:00
Vitaly Baranov
eb3836ac5a Fix error "Read beyond last offset" for AsynchronousBoundedReadBuffer. 2024-02-14 13:41:18 +01:00
Nikolai Kochetov
32a23244c9 Remove context from comparison functions.
(cherry picked from commit 57608cc6f9)
2024-02-14 12:38:13 +00:00
Nikolai Kochetov
ebf47dd7c2
Merge pull request #58916 from ClickHouse/allow-parallel-replicas-for-join-with-analyzer-2
Allow parallel replicas for JOIN with analyzer [part 2]
2024-02-14 13:30:35 +01:00
Kruglov Pavel
c8c9adbd8b
Merge pull request #59088 from Blargian/#31363_format_template_configure_in_settings
#31363 format template configure in settings
2024-02-14 13:29:13 +01:00
Nikolai Kochetov
3d86e87f7f Fixing tests. 2024-02-14 12:28:54 +00:00
Dmitry Novik
12963ce53e Analyzer: Fix test_storage_rabbitmq 2024-02-14 12:20:37 +00:00
avogar
2c34a98426 Apply suggestions from the review 2024-02-14 12:20:09 +00:00
Yarik Briukhovetskyi
941e179be2
Merge branch 'ClickHouse:master' into div_int_with_decimal 2024-02-14 13:16:13 +01:00
Nikolai Kochetov
03720d558e
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-14 12:54:29 +01:00
Konstantin Bogdanov
83f28b8537
Move definition to cpp 2024-02-14 12:51:14 +01:00
Kruglov Pavel
db2c15c0a6
Apply suggestions from code review
Co-authored-by: Sergei Trifonov <svtrifonov@gmail.com>
2024-02-14 12:24:10 +01:00
Kruglov Pavel
0263826c15
Merge pull request #59925 from Avogar/fix-json-http-crash
Fix crash in JSONColumnsWithMetadata format over http
2024-02-14 11:58:18 +01:00
Konstantin Bogdanov
e6450f8af2
More missing headers 2024-02-14 11:48:03 +01:00
Alexander Gololobov
dda7c5d2b7 Add comment with motivation 2024-02-14 11:41:07 +01:00
李扬
90d07ba82c
Trivial optimize of function coalesce. (#59627)
* reuse result of functionfactory::get

* add perf test

* Update src/Functions/coalesce.cpp

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>

* change as requested

---------

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2024-02-14 11:29:45 +01:00
Konstantin Bogdanov
5f2358b014
Add missing header 2024-02-14 11:22:47 +01:00
Konstantin Bogdanov
f678bdc546
Update tests 2024-02-14 10:51:42 +01:00
Konstantin Bogdanov
914fd27d5b
Add PlacementInfo 2024-02-14 10:19:36 +01:00
Jordi Villar
83a184d928 Fix max num to warn message 2024-02-14 10:11:21 +01:00
Robert Schulze
25667d9c9a
Attempt II at fixing the Fuzzer issue 2024-02-14 08:49:14 +00:00
Alexey Milovidov
653c6ba49f
Merge pull request #59931 from pamarcos/patch-1
Fix description for allow_prefetched_read_pool_for_local_filesystem
2024-02-14 07:47:47 +01:00
Alexey Milovidov
a76d4bbb56
Merge pull request #59968 from ClickHouse/less-conflicts
Less conflicts
2024-02-14 07:45:51 +01:00
Alexey Milovidov
9823966e13
Merge pull request #59845 from vitlibar/add-check-for-recursive-remove-low-cardinality
Add check for recursiveRemoveLowCardinality()
2024-02-14 05:57:37 +01:00
Alexey Milovidov
af2dfe0e35
Merge pull request #59537 from nickitat/fix_aggr
Fix data race with `AggregatedDataVariants`
2024-02-14 05:46:30 +01:00
Alexey Milovidov
40ac23e958 Even less conflicts 2024-02-14 04:12:50 +01:00
Alexey Milovidov
0ccad74810 Even less conflicts 2024-02-14 03:44:52 +01:00
Alexey Milovidov
98f7602ea1 Less conflicts 2024-02-14 03:01:03 +01:00
Alexey Milovidov
7b3e57e2d2 Use merge table in the dashboard 2024-02-14 02:37:42 +01:00
Alexey Milovidov
b713a8dffe
Merge pull request #59960 from jsc0218/Better_name_extract_key_value_pairs_max_pairs_per_row
rename a setting v2
2024-02-14 02:21:45 +01:00
Alexey Milovidov
102e64cf1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into dashboards-to-use-merge-tables 2024-02-14 02:20:20 +01:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Alexey Milovidov
7ee6b0bd87
Merge pull request #59941 from kitaisreal/register-storage-merge-tree-exception-message-fix
Register StorageMergeTree exception message fix
2024-02-14 01:31:00 +01:00
Alexey Milovidov
2b4949bd18 Cleanups 2024-02-14 00:21:13 +01:00
yariks5s
ac601a0cb9 fix build 2024-02-13 23:12:21 +00:00
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Alexey Milovidov
b9d3ae3b0a
Merge pull request #58195 from Unalian/feat-58127
Add InitialQuery event
2024-02-13 23:51:03 +01:00
Igor Nikonov
3d91b12a2f Fix typo 2024-02-13 22:34:10 +00:00
Igor Nikonov
e9dcc751ac Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http 2024-02-13 22:08:44 +00:00
Igor Nikonov
a27639a7f9 Fix: call first exception callback on exception
it'll update query_log
2024-02-13 22:06:00 +00:00
jsc0218
84e8755aae rename a setting 2024-02-13 19:27:29 +00:00