Robert Schulze
0f6715bd91
Follow-up to PR #37300 : semicolon warnings
...
In PR #37300 , Alexej asked why we the compiler does not warn about
unnecessary semicolons, e.g.
f()
{
}; // <-- here
The answer is surprising: In C++98, above syntax was disallowed but by
most compilers accepted it regardless. C++>11 introduced "empty
declarations" which made the syntax legal.
The previous behavior can be restored using flag
-Wc++98-compat-extra-semi. This finds many useless semicolons which were
removed in this change. Unfortunately, there are also false positives
which would require #pragma-s and HAS_* logic (--> check_flags.cmake) to
suppress. In the end, -Wc++98-compat-extra-semi comes with extra effort
for little benefit. Therefore, this change only fixes some semicolons
but does not enable the flag.
2022-05-20 15:06:34 +02:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
...
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Amos Bird
243de091bb
Validate some thoughts over making sets
2022-03-21 10:58:44 +08:00
Anton Popov
dfb9bc2a01
minor fixes in constraints
2021-11-17 18:43:02 +03:00
Anton Popov
833652e8f4
Merge branch 'nikvas0/simple_optimizations' of git://github.com/nikvas0/ClickHouse into merging-constraints
2021-11-10 19:35:28 +03:00
Azat Khuzhin
6c33eaee32
Fix filtering by tuple (some conditions was lost during analyzing)
...
Fixes : #29281
Fixes: test_cluster_copier/test_three_nodes.py::test
2021-10-10 22:37:52 +03:00
Vladimir C
0422939893
Merge pull request #29281 from lingtaolf/bugfix/tupleFilter
2021-10-07 12:24:26 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
vdimir
7444d64156
Fix for recursive tuples in MergeTreeWhereOptimizer
2021-10-01 17:01:03 +03:00
vdimir
23ce41e3bb
MergeTreeWhereOptimizer supports constant tuple in both sides of equals
2021-10-01 17:01:03 +03:00
vdimir
64ffacd9e0
MergeTreeWhereOptimizer::tryAnalyzeTuple, fix fuzz
2021-10-01 17:01:02 +03:00
vdimir
e326b12a37
Fix style in MergeTreeWhereOptimizer.cpp
2021-10-01 17:01:02 +03:00
凌涛
f660224a5f
add tests
2021-10-01 17:01:01 +03:00
凌涛
ea68944055
fixed index didn't work in tuple where
2021-10-01 17:01:01 +03:00
vdimir
e8e26463bf
Change signature of ASTSelectQuery::arrayJoinExpressionList
2021-08-31 15:27:44 +03:00
lthaooo
eecd5b21c9
fix total_size_of_queried_columns bug
2021-08-25 23:02:13 +08:00
Maksim Kita
67e9b85951
Merge ext into common
2021-06-16 23:28:41 +03:00
Nikita Vasilev
44b996df49
fix
2021-05-19 22:40:38 +03:00
Nikita Vasilev
4bf5547350
fix
2021-05-06 11:29:24 +03:00
Nikita Vasilev
496d8ff46c
improvements
2021-05-04 21:43:58 +03:00
Nikita Vasilev
0ec2726bf3
Merge remote-tracking branch 'upstream/master' into nikvas0/simple_optimizations
2021-04-26 17:33:32 +03:00
alexey-milovidov
2cfc2c8825
Merge pull request #23397 from CurtizJ/better-move-to-prewhere
...
Allow to move more conditions to PREWHERE
2021-04-24 04:39:33 +03:00
Anton Popov
a83a07246e
allow to move more conditions to PREWHERE
2021-04-21 01:03:58 +03:00
Amos Bird
32c84f77c3
Resurrect indexHint function.
2021-04-20 19:27:23 +08:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Neng Liu
0d78427fbf
fix query failed and add stateless test
2021-03-29 16:12:02 +08:00
Nikita Vasilev
02090bf59a
Merge remote-tracking branch 'upstream/master' into nikvas0/simple_optimizations
2021-03-27 13:03:55 +03:00
fuqi
487d6bdcd9
add test case
...
fix order key check
2021-03-24 16:36:45 +08:00
fuqi
cfa92f0045
fix code style
2021-03-18 00:25:43 +08:00
fuqi
b8edc12812
fix code style
2021-03-17 23:56:55 +08:00
fuqi
e116e8d5e8
fix bug
2021-03-17 22:19:10 +08:00
fuqi
9ab713c2e1
optimize select final with prewhere primary key
2021-03-17 18:57:58 +08:00
fuqi
5e20ea2c33
optimize select final with prewhere primary key
2021-03-17 18:49:24 +08:00
Nikita Vasilev
728c9ccb6d
Merge remote-tracking branch 'upstream/master' into nikvas0/simple_optimizations
2021-03-05 19:17:01 +03:00
Nikita Vasilev
7b2d8e1094
more clones
2021-02-14 17:47:15 +03:00
Maxim Akhmedov
0cd3601928
Allow using MergeTreeWhereOptimizer not only with MergeTree-based storages
2021-02-06 18:08:42 +03:00
Anton Popov
852a08eacb
allow to move conditions to prewhere with compact parts
2020-11-23 21:27:59 +03:00
alesapin
1afdebeebd
Primary key in storage metadata
2020-06-17 15:39:20 +03:00
Alexey Milovidov
25f941020b
Remove namespace pollution
2020-05-31 00:57:37 +03:00
alesapin
6281dd6893
Merge pull request #11115 from ClickHouse/consistent_metadata
...
Refactoring in storage metadata (more consistent keys)
2020-05-25 13:09:56 +03:00
Alexey Milovidov
7e1813825b
Return old names of macros
2020-05-24 01:24:01 +03:00
Alexey Milovidov
85f84550ba
Progress on task
2020-05-23 23:37:37 +03:00
alesapin
327d17ac6a
Better
2020-05-21 22:46:03 +03:00
alesapin
616902a995
Sorting and primary key (broken)
2020-05-20 21:11:38 +03:00
Alexey Milovidov
603d132d45
Checkpoint
2020-04-22 09:34:20 +03:00
Alexey Milovidov
cf9f00644e
Fix the issue with arrayJoin and PREWHERE optimization #10092
2020-04-12 01:13:06 +03:00
Ivan Lezhankin
06446b4f08
dbms/ → src/
2020-04-03 18:14:31 +03:00