alexey-milovidov
5a840c5f75
Merge pull request #30619 from azat/clickhouse-test-increase-timeout
...
clickhouse-test: increase delay for initial SELECT 1 check
2021-10-24 23:37:59 +03:00
alexey-milovidov
7200cb8bba
Merge pull request #30611 from azat/readbuffer-real-size
...
Replace estimated_size with optional<size> for readFile/createReadBufferFromFileBase
2021-10-24 23:37:30 +03:00
alexey-milovidov
34b75f86a2
Merge pull request #30613 from azat/clang-12
...
RFC: Relax minimal clang version (set it to 12, was 13)
2021-10-24 23:37:09 +03:00
kssenii
13a2a3d307
Merge branch 'master' of github.com:ClickHouse/ClickHouse into deprecate-setting
2021-10-24 23:05:21 +03:00
Anton Popov
37de54937c
fix use-after-free
2021-10-24 22:32:28 +03:00
Anton Popov
76cb191865
Merge pull request #30433 from kssenii/fix-positional
...
More full support of positional arguments
2021-10-24 21:48:17 +03:00
Kseniia Sumarokova
cd63b24061
Merge pull request #30450 from morozovsk/patch-10
...
Documentation: JSON_EXISTS/JSON_QUERY/JSON_VALUE
2021-10-24 20:16:29 +03:00
Kruglov Pavel
855b10261c
Merge pull request #30285 from kssenii/fix-local-exceptions
...
Fix printing stacktraces for clickhouse-local
2021-10-24 19:54:59 +03:00
Kseniia Sumarokova
4667ea7883
Merge pull request #29774 from kssenii/remote-connection
...
Predefined configuration for table function remote
2021-10-24 19:38:01 +03:00
Azat Khuzhin
e3074cdd5a
clickhouse-test: increase delay for initial SELECT 1 check
...
CI report [1]:
<details>
2021-10-24 04:43:13 Server is not responding. Cannot execute 'SELECT 1' query. If you are using split build, you have to specify -c option.
2021-10-24 04:43:13 Cannot get server pid with pidof -s clickhouse-server, got : Command 'pidof -s clickhouse-server' returned non-zero exit status 1.
2021-10-24 04:43:13 Thread 1 (Thread 0x7f401edd7340 (LWP 370)):
2021-10-24 04:43:13 0 0x0000000009f9a807 in __sanitizer::StackDepotBase<>::Put(__sanitizer::StackTrace, bool*) ()
2021-10-24 04:43:13 1 0x0000000009f9a6f7 in __sanitizer::StackDepotPut(__sanitizer::StackTrace) ()
2021-10-24 04:43:13 2 0x0000000009f2b0e7 in __msan::MsanDeallocate(__sanitizer::StackTrace*, void*) ()
2021-10-24 04:43:13 3 0x0000000009fa77df in operator delete(void*, unsigned long) ()
2021-10-24 04:43:13 4 0x000000004185ffc2 in std::__1::__libcpp_operator_delete<void*, unsigned long> () at ../contrib/libcxx/include/new:245
2021-10-24 04:43:13 5 std::__1::__do_deallocate_handle_size<>(void*, unsigned long) () at ../contrib/libcxx/include/new:271
2021-10-24 04:43:13 6 std::__1::__libcpp_deallocate () at ../contrib/libcxx/include/new:285
2021-10-24 04:43:13 7 std::__1::allocator<char>::deallocate () at ../contrib/libcxx/include/memory:849
2021-10-24 04:43:13 8 std::__1::allocator_traits<std::__1::allocator<char> >::deallocate () at ../contrib/libcxx/include/__memory/allocator_traits.h:476
2021-10-24 04:43:13 9 std::__1::basic_string<>::~basic_string (this=0x70400000efe8) at ../contrib/libcxx/include/string:2219
2021-10-24 04:43:13 10 Poco::XML::ContextLocator::~ContextLocator (this=0x70400000efc0) at ../contrib/poco/XML/src/ParserEngine.cpp:53
2021-10-24 04:43:13 11 0x000000004186010d in Poco::XML::ContextLocator::~ContextLocator (this=0x70400000efc0) at ../contrib/poco/XML/src/ParserEngine.cpp:52
2021-10-24 04:43:13 12 0x000000004184af75 in Poco::XML::ParserEngine::popContext (this=<optimized out>) at ../contrib/poco/XML/src/ParserEngine.cpp:599
2021-10-24 04:43:13 13 Poco::XML::ParserEngine::parse (this=<optimized out>, pInputSource=0x706000003720) at ../contrib/poco/XML/src/ParserEngine.cpp:234
2021-10-24 04:43:13 14 0x000000004184880e in Poco::XML::SAXParser::parse (this=<optimized out>, systemId=...) at ../contrib/poco/XML/src/SAXParser.cpp:201
2021-10-24 04:43:13 15 0x00000000417f3eeb in Poco::XML::DOMBuilder::parse (this=<optimized out>, uri=...) at ../contrib/poco/XML/src/DOMBuilder.cpp:69
2021-10-24 04:43:13 16 0x00000000417f2946 in Poco::XML::DOMParser::parse (this=<optimized out>, uri=...) at ../contrib/poco/XML/src/DOMParser.cpp:102
2021-10-24 04:43:13 17 0x000000003741dd6c in DB::ConfigProcessor::processConfig (this=this@entry=0x7fff89847130, has_zk_includes=has_zk_includes@entry=0x7fff898470f7, zk_node_cache=zk_node_cache@entry=0x0, zk_changed_event=...) at ../src/Common/Config/ConfigProcessor.cpp:570
2021-10-24 04:43:13 18 0x0000000037427bb7 in DB::ConfigProcessor::loadConfig (this=<optimized out>, allow_zk_includes=true) at ../src/Common/Config/ConfigProcessor.cpp:657
2021-10-24 04:43:13 19 0x000000003743fb76 in DB::ConfigReloader::reloadIfNewer (this=this@entry=0x712000002700, force=true, throw_on_error=true, fallback_to_preprocessed=true, initial_loading=true) at ../src/Common/Config/ConfigReloader.cpp:96
2021-10-24 04:43:13 20 0x000000003743d85e in DB::ConfigReloader::ConfigReloader() () at ../src/Common/Config/ConfigReloader.cpp:33
2021-10-24 04:43:13 21 0x0000000009fd3efb in std::__1::make_unique<>() (__args=<optimized out>, __args=<optimized out>, __args=<optimized out>, __args=<optimized out>, __args=<optimized out>, __args=<optimized out>, __args=<optimized out>) at ../contrib/libcxx/include/memory:2068
2021-10-24 04:43:13 22 DB::Server::main (this=<optimized out>) at ../programs/server/Server.cpp:803
2021-10-24 04:43:13 23 0x000000004175c5f9 in Poco::Util::Application::run (this=<optimized out>) at ../contrib/poco/Util/src/Application.cpp:334
2021-10-24 04:43:13 24 0x0000000009fb5d7f in DB::Server::run (this=<optimized out>) at ../programs/server/Server.cpp:405
</details>
[1]: https://clickhouse-test-reports.s3.yandex.net/30611/5ff6c5536558821824d5fdf25a75729e5b82060d/functional_stateless_tests_(memory).html#fail1
2021-10-24 19:04:36 +03:00
Azat Khuzhin
f9b27608f5
Fix reading of columns if offset_in_compressed_file is the same for mark range
...
Fixes: 00078_group_by_arrays
2021-10-24 18:58:22 +03:00
Azat Khuzhin
258b62d375
Remove one unused CompressedReadBufferFromFile ctor
2021-10-24 18:58:22 +03:00
Azat Khuzhin
34d8f78c33
Explictly pass size in DiskCacheWrapper::writeFile()
...
v0: Add explicit default value for DiskLocal::readFile()
v2: Explictly pass size in DiskCacheWrapper::writeFile()
(since v0 not google-default-arguments compatible)
2021-10-24 18:58:22 +03:00
Azat Khuzhin
93c34824c0
Fix explicit 0 size for createReadBufferFromFileBase()
2021-10-24 18:58:22 +03:00
Azat Khuzhin
4599e9191b
Fix explicit 0 size for readFile()
2021-10-24 18:58:22 +03:00
Azat Khuzhin
2b96433daf
Replace estimated_size with optional<size> for IDisk::readFile()
...
v2: rebase to fix conflicts in DiskEncrypted.cpp
2021-10-24 18:58:11 +03:00
Vitaly Baranov
c0b01e7b0b
Merge pull request #30494 from vitlibar/fix-reading-from-empty-file-on-encrypted-disk
...
Fix reading from empty file on encrypted disk
2021-10-24 16:24:47 +03:00
Nickita Taranov
877e8b579b
fix style
2021-10-24 14:45:12 +03:00
gyuton
984d6517c2
Apply suggestions from code review
...
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-24 11:10:00 +03:00
Kseniia Sumarokova
7383bdd5fa
Merge pull request #25969 from ucasfl/filelog-engine
...
Implementation of a table engine to consume application log files in ClickHouse
2021-10-24 10:14:05 +03:00
Azat Khuzhin
0eef5ee778
Relax minimal clang version (set it to 12, was 13)
...
ClickHouse compiled fine under clang-12, and also note that not a lot of
distros already switched to clang-13, so it may requires additional
steps to compile ClickHouse otherwise.
Follow-up for: #30597
2021-10-24 09:40:41 +03:00
alexey-milovidov
7911e6dd47
Merge pull request #30596 from ClickHouse/fix-perf-test-4
...
Adjust perf test for simdjson
2021-10-24 07:58:15 +03:00
alexey-milovidov
f1e96ee9ac
Merge pull request #30594 from azat/fix-logical-error-on-connection-drain
...
Fix LOGICAL_ERROR on connection draining in case of ECONNRESET
2021-10-24 05:34:27 +03:00
alexey-milovidov
6f944f7fbc
Merge pull request #30589 from azat/artifacts-metadata
...
Add metadata for *_log into tests artifacts
2021-10-24 03:15:42 +03:00
alexey-milovidov
830b83218e
Merge pull request #30579 from azat/tsan-recursion
...
Fix tests that relies on checking stack size under TSan
2021-10-24 03:14:07 +03:00
alexey-milovidov
14e891f07e
Merge pull request #30597 from ClickHouse/update-min-compiler-versions
...
Update minimum allowed compiler versions
2021-10-24 03:13:31 +03:00
Maksim Kita
de70cfb98c
Merge pull request #30595 from ClickHouse/revert-18488
...
Revert "Allow AppleClang builds"
2021-10-24 02:06:23 +03:00
alexey-milovidov
8c2413f6fe
Merge pull request #30562 from ClickHouse/fix-header-after-limit-push-down
...
Fix LimitStep header after limit push down optimization.
2021-10-24 00:19:02 +03:00
Alexey Milovidov
6d49e59016
Update compiler versions
2021-10-24 00:12:50 +03:00
Alexey Milovidov
f9529c9d78
Adjust perf test
2021-10-24 00:11:28 +03:00
Alexey Milovidov
df5739b39b
Revert "Allow AppleClang builds"
...
This reverts commit 1ddea6d7ee
.
2021-10-23 22:59:12 +03:00
Azat Khuzhin
83d68246c3
Fix LOGICAL_ERROR on connection draining in case of ECONNRESET
...
In case of ECONNRESET (Connection reset by peer) the "cancelled" will
not be set, and so drain() will fail with LOGICAL_ERROR:
<details>
2021.10.16 04:10:55.054771 [ 7635 ] {882164e0-ca26-4955-8759-708ba1f6e85c} <Error> PullingAsyncPipelineExecutor: Code: 210. DB::NetException: Connection reset by peer, while writing to socket (127.0.0.2:9000). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
...
4. ./obj-x86_64-linux-gnu/../src/Common/NetException.h:12: DB::NetException::NetException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x20db5749 in /usr/bin/clickhouse
5. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:56: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x211d56bb in /usr/bin/clickhouse
6. ./obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:47: DB::WriteBuffer::next() @ 0x14e4c874 in /usr/bin/clickhouse
7. ./obj-x86_64-linux-gnu/../src/Client/Connection.cpp:560: DB::Connection::sendCancel() @ 0x227c0c22 in /usr/bin/clickhouse
8. ./obj-x86_64-linux-gnu/../src/Client/HedgedConnections.cpp:242: DB::HedgedConnections::sendCancel() @ 0x227f1b53 in /usr/bin/clickhouse
...
2021.10.16 04:12:35.555530 [ 5575 ] {} <Fatal> : Logical error: 'Cannot drain connections: cancel first.'.
</details>
Found by stress tests on CI [1].
[1]: https://clickhouse-test-reports.s3.yandex.net/0/d3cb99701d4aaec384fd183168d10e0f650ecc1d/stress_test_(debug).html#fail1
2021-10-23 22:44:32 +03:00
alexey-milovidov
2ecfe7068a
Merge pull request #30577 from azat/doc-distributed_push_down_limit
...
Update documentation for distributed_push_down_limit
2021-10-23 22:30:52 +03:00
alexey-milovidov
187d8b2196
Update settings.md
2021-10-23 22:30:42 +03:00
Vitaly Baranov
26cb62de32
Add more tests for the "encrypted" disk type.
2021-10-23 20:58:37 +03:00
Azat Khuzhin
8f015764a7
Add metadata for *_log into tests artifacts
...
This will allow to use artifacts as-is, i.e.:
clickhouse-local --path /path/to/log/artifact
v2: convert database to Ordinary to avoid extra symlinks dependencies.
2021-10-23 20:17:01 +03:00
Vladimir Goncharov
37ee06d362
Update json-functions.md
2021-10-23 19:10:40 +03:00
Kseniia Sumarokova
00d0665bf2
Merge pull request #30477 from kssenii/postgres-fix-query
...
More reliable fetch query in postgres database
2021-10-23 19:07:34 +03:00
Vladimir Goncharov
1b2186b8ad
Update json-functions.md
2021-10-23 19:04:29 +03:00
kssenii
e04e37916e
Review fixes
2021-10-23 18:20:31 +03:00
Anton Popov
cdfa36a181
Merge pull request #30266 from CurtizJ/aggregation-in-order-4
...
Improve performance of aggregation in order of primary key
2021-10-23 18:09:17 +03:00
Anton Popov
0c80ebe787
Update read_in_order_many_parts.xml
2021-10-23 18:08:08 +03:00
kssenii
36d0f67b38
Merge branch 'master' of github.com:ClickHouse/ClickHouse into remote-connection
2021-10-23 17:12:46 +03:00
kssenii
d1e7a0122e
Fix test
2021-10-23 13:32:07 +00:00
Maksim Kita
4ccc619bd5
Added performance tests
2021-10-23 15:01:30 +03:00
Azat Khuzhin
b73092c169
Fix tests that relies on checking stack size under TSan
...
Under TSan using too much stack requires too much RSS for shadow memory,
and neither of this TSAN_OPTIONS helps:
- history_size=2
- flush_memory_ms=2000
- memory_limit_mb=50000
So instead, decrease allowed limit of the stack size in checkStackSize()
under TSan, to address exessive memory usage for the server compiled
with TSan.
Note, that before this patch 01763_max_distributed_depth test can
increase RSS of the server to 70GiB.
2021-10-23 14:09:19 +03:00
feng lv
235339d530
fix
2021-10-23 09:35:33 +00:00
Kseniia Sumarokova
05150f151c
Update ExpressionAnalyzer.cpp
2021-10-23 12:19:40 +03:00
kssenii
0e3dbabd5a
Update test
2021-10-23 09:15:52 +00:00
Vladimir C
410624749e
Merge pull request #30492 from vdimir/fix-alter-scalar-deadlock
2021-10-23 12:01:00 +03:00