Commit Graph

6 Commits

Author SHA1 Message Date
Azat Khuzhin
c5ffbc688e Do not allow SETTINGS after FORMAT for INSERT queries
Parsing SETTINGS after FORMAT, that has been introduced in [1], can
interpret SETTING as some values, which is misleading.

  [1]: https://github.com/ClickHouse/ClickHouse/pull/4174/files#diff-ba7bd0657630b1cd94cf6ed364bd857338096f49f66dc82918438d6745753775R106

Note, that we are touching only INSERT queries, not SELECT, since this
is a backward incompatible change, and in case of modifying SELECT it
can break too much.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Fixes: #35100
Fixes: #20343
2022-04-07 16:29:36 +03:00
Robert Schulze
08d3f7fa14
Add tests for ProtobufList formats
- Various tests of the Protobuf format existed already. Most of them
  check serialization/deserialization of specific data types, e.g.
  arrays, arrays in arrays, enums, maps, columns with default values
  etc. There is also an end-to-end test which uses a complex table
  that combines aforementioned data types.

- Since "ProtobufList" reuses the data conversion code of "Protobuf"
  and only differs slightly in the schema matching logic it should
  suffice to extend only the end-to-end test. This avoids testing the
  same stuff twice (and the same was done btw. for the ProtobufSingle
  format).
2022-03-16 19:33:58 +01:00
Vitaly Baranov
39d73c01b2 Add tags to tests. 2021-09-12 17:15:28 +03:00
Alexey Milovidov
348e8bf262 Fix test 2021-07-18 23:32:05 +03:00
Alexey Milovidov
ab9c50143a Fix tests 2021-07-18 23:28:18 +03:00
Vitaly Baranov
2eecaee08d Better tests for protobuf format. 2021-02-20 23:13:32 +03:00