Commit Graph

110484 Commits

Author SHA1 Message Date
Anton Popov
d2a8cd3ed4 fix performance regression 2023-03-14 14:51:28 +00:00
Alexander Tokmakov
275acb756a
Merge pull request #47575 from azat/ci/log-stats
Add missing SYSTEM FLUSH LOGS for log messages statistics
2023-03-14 17:37:07 +03:00
Vasily Nemkov
d3199da1d2
Simplify clickhouse-test usage with -b
Now it is possible to run it even without `clickhouse` binary in PATH.
2023-03-14 15:31:36 +01:00
Azat Khuzhin
7e5c643926 Fix 02572_system_logs_materialized_views_ignore_errors flakiness
v2: Add missing SYSTEM FLUSH LOGS to 02572_system_logs_materialized_views_ignore_errors
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 15:25:48 +01:00
Michael Kolupaev
92046d7b56 Make test 02473_optimize_old_parts less flaky 2023-03-14 07:21:07 -07:00
robot-ch-test-poll4
8bbfba39d5
Merge pull request #47542 from ClickHouse/totals-in-fill-transform
Remove TOTALS handling in FillingTransform
2023-03-14 15:05:32 +01:00
Azat Khuzhin
ad5dfc159b Add missing SYSTEM FLUSH LOGS for log messages statistics
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:34:02 +01:00
SmitaRKulkarni
52b6976822
Merge pull request #47495 from ClickHouse/Parameterized_view_bug_fix_47287_47247
Parameterized view bug fix 47287 47247
2023-03-14 14:33:44 +01:00
Azat Khuzhin
a72647690d Change error code in case of columns definitions was empty in ODBC
CI reports [1]:

    2023.03.14 00:29:07.031349 [ 166170 ] {110f8654-7d7d-4b47-b6b0-3ce83414a80f} <Error> ReadWriteBufferFromHTTP: HTTP request to `http://127.0.0.1:9018/columns_info?use_connection_pooling=1&version=1&connection_string=DSN%3D%7BClickHouse%20DSN%20%28ANSI%29%7D&schema=test_15&table=t&external_table_functions_use_nulls=1` failed at try 1/1 with bytes read: 0/unknown. Error: DB::HTTPException: Received error from remote server /columns_info?use_connection_pooling=1&version=1&connection_string=DSN%3D%7BClickHouse%20DSN%20%28ANSI%29%7D&schema=test_15&table=t&external_table_functions_use_nulls=1. HTTP status code: 500 Internal Server Error, body: Error getting columns from ODBC 'Code: 49. DB::Exception: Columns definition was not returned. (LOGICAL_ERROR) (version 23.2.4.12 (official build))'

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/47541/3d247b8635da44bccfdeb5fcd53be7130b8d0a32/upgrade_check__msan_.html

Here the problem is that system.columns has cached value for number of
total table to iterate, and so it can skip something.

But anyway, this should be LOGICAL_ERROR, since ODBC bridge does two
queries:
- to system.tables and
- to system.columns

And if between this two queries the table will be removed, them there
will be no columns

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:24:11 +01:00
Sema Checherinda
95e994a9cd
Merge pull request #47304 from arthurpassos/fix_find_first_not_symbols
Modify find_first_symbols so it works as expected for find_first_not_symbols
2023-03-14 14:24:05 +01:00
MeenaRenganathan22
91625184a3 Updated the krb5 submodule reference 2023-03-14 06:23:22 -07:00
Azat Khuzhin
f540a14fae ci/upgrade: store system.*_log tables on local filesystem (and fix artifacts)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:13:05 +01:00
Azat Khuzhin
55296c4881 ci/upgrade: remove obsolete function call
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:13:04 +01:00
Azat Khuzhin
7e1db1a7f7 ci/upgrade: fix creating system database with Ordinary engine
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 14:12:32 +01:00
Nikolay Degterinsky
cfb4267cfc
Merge pull request #47565 from aerosol/fix-typo
Fix typo
2023-03-14 13:51:20 +01:00
Dmitry Novik
802a3d8ed2 Fix style 2023-03-14 12:46:59 +00:00
Vitaly Baranov
859082c4b7
Merge pull request #47216 from ClickHouse/Backup_Restore_concurrency_check_node
Backup_Restore_concurrency_check_node
2023-03-14 13:36:43 +01:00
Dmitry Novik
cced9cf613 Fix build 2023-03-14 12:04:39 +00:00
Dmitry Novik
ae3d30a736 Merge remote-tracking branch 'origin/master' into fix-grouping-for-grouping-sets 2023-03-14 12:01:51 +00:00
Adam Rutkowski
694ba01c78 Fix typo 2023-03-14 12:48:00 +01:00
alesapin
d9b9d6c9ef
Merge branch 'master' into small-enhancements 2023-03-14 12:13:09 +01:00
Alexander Tokmakov
5a1ee881f8
Merge pull request #47547 from ClickHouse/filter_too_frequent_logs
Hide too noisy log messages, fix some tests
2023-03-14 13:53:21 +03:00
Nikolai Kochetov
396e1b45a4
Merge pull request #47433 from ClickHouse/apply-settings-for-explain-earlier
Apply settings for EXPLAIN earlier (in the same way we do for SELECT).
2023-03-14 11:52:20 +01:00
Nikolai Kochetov
0298a96d81
Merge pull request #47451 from ClickHouse/disable-logical-expression-optimizer-with-aliases
Disable logical expression optimizer for expression with aliases.
2023-03-14 11:51:24 +01:00
Nikolai Kochetov
be0ae6a238
Merge pull request #47537 from ClickHouse/lc_null_as_default
Fix block structure mismatch for nullable LowCardinality column
2023-03-14 11:45:39 +01:00
Azat Khuzhin
2788b7c2e7 Improve 01555_system_distribution_queue_mask (for bug fix check)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-14 10:52:56 +01:00
Smita Kulkarni
8a7bc3250d Added space to if expression of replaceQueryParameterWithValue function 2023-03-14 09:26:53 +01:00
Smita Kulkarni
4deeb13c6d Addressed review comments for parameterized view bug fix 2023-03-14 09:23:12 +01:00
Dmitry Novik
49b0bc21ad Resolve as FunctionGrouping 2023-03-14 03:33:31 +00:00
Michael Kolupaev
d3a514d221 Compress marks in memory 2023-03-13 16:29:00 -07:00
Alexander Tokmakov
ba6c6255a3 hide too noisy log messages, fix some tests 2023-03-14 00:23:36 +01:00
Vitaly Baranov
1cf1ce07fe Use server-side copy during restore from S3 to S3. 2023-03-13 23:50:13 +01:00
Igor Nikonov
e82f7b9622 Polishing 2023-03-13 21:47:21 +00:00
Igor Nikonov
4239bfb586 FillingNoopTransform for totals stream 2023-03-13 21:47:21 +00:00
Igor Nikonov
85b0c5a1a4 Remove TOTALS handling in FillTransform 2023-03-13 21:47:21 +00:00
Maksim Kita
21ec04bcd1
Merge pull request #47525 from Algunenano/less_analyzer
Adapt some tests to pass with and without the analyzer
2023-03-14 00:20:54 +03:00
Rich Raposa
4766ebcfd1
Merge branch 'master' into new-nav 2023-03-13 14:18:42 -06:00
Azat Khuzhin
3d247b8635 Preserve error in system.distribution_queue on SYSTEM FLUSH DISTRIBUTED
After refactoring in #45491 this behaviour had been changed, hence
01555_system_distribution_queue_mask became flaky, since if the flush
had not happened before SYSTEM FLUSH DISTRIBUTED the error was not saved
into the system.distribution_queue.

v2: Improve 01555_system_distribution_queue_mask test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-13 20:07:55 +01:00
avogar
637d8d0f09 Fix BSONEachRow parallel parsing when document size is invalid 2023-03-13 18:52:29 +00:00
Alexey Milovidov
741acf18c3
Merge branch 'master' into disable-logical-expression-optimizer-with-aliases 2023-03-13 21:41:55 +03:00
Dmitry Novik
6f99adcdaa Support constants in INTERPOLATE clause (new analyzer) 2023-03-13 18:41:14 +00:00
Alexey Milovidov
a411ae10b5
Merge pull request #47486 from ClickHouse/revert_25674
Remove "asynchronous connection drain"
2023-03-13 21:40:39 +03:00
Alexey Milovidov
b2510b9442
Merge pull request #47514 from tbragin/patch-6
Update clickhouse-local.md usage instructions
2023-03-13 21:39:37 +03:00
Nikolai Kochetov
a942364e50 Fixing test. 2023-03-13 18:38:27 +00:00
Azat Khuzhin
610c9aecee Fix copy-paste in 01555_system_distribution_queue_mask comments
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-13 19:29:50 +01:00
avogar
278c76f85a Fix 2023-03-13 18:23:51 +00:00
avogar
4213ec609f Proper fix for bug in parquet, revert reverted #45878 2023-03-13 18:22:09 +00:00
Nikolai Kochetov
650427614f Fix block structure mismatch for nullable LowCardinality column with default expression. 2023-03-13 17:57:07 +00:00
Roman Vasin
36c639ed2f Fix grants hierarchy for temporary tables and comment about default engine 2023-03-13 16:39:15 +00:00
Antonio Andelic
914e0fbb0a Fix monotonic check with DateTime64 2023-03-13 16:30:32 +00:00