Commit Graph

9010 Commits

Author SHA1 Message Date
serxa
b39bc650b9 better ProfileEvent names 2024-10-18 18:11:33 +00:00
Sergei Trifonov
ee557a9f11
Merge branch 'master' into fix-use-concurrency-control 2024-10-18 13:30:03 +02:00
Alexey Milovidov
d8ae693772
Merge pull request #70601 from ClickHouse/less-log-messages
Limit too frequent log messages
2024-10-18 01:35:32 +08:00
Raúl Marín
9ef8af31a0
Merge pull request #70747 from Algunenano/less_diffs_in_private_2
Reduce sync effort (part 2)
2024-10-17 15:44:59 +00:00
Alexey Milovidov
4a634e3f9f
Merge pull request #69862 from liuneng1994/parquet-prefetch
Optimize parquet IO efficiency
2024-10-17 13:05:10 +00:00
Raúl Marín
bc104fad7a Merge remote-tracking branch 'blessed/master' into less_diffs_in_private_2 2024-10-17 11:13:02 +00:00
Alexey Milovidov
bde677ff21 Merge branch 'master' into less-log-messages 2024-10-16 23:55:24 +02:00
Raúl Marín
a581593eec ZooKeeperLock.cpp sync 2024-10-16 12:54:29 +00:00
Alexey Milovidov
d9c9128c04 Merge branch 'master' into refactor-object-storages 2024-10-16 14:47:27 +02:00
Vladimir Cherkasov
5227fe0934
Merge pull request #70487 from ClickHouse/vdimir/safe_http_exception_log
Avoid spamming the logs with large HTTP response bodies
2024-10-16 08:34:48 +00:00
LiuNeng
c26d9df583
Merge branch 'master' into parquet-prefetch 2024-10-16 15:47:52 +08:00
Julia Kartseva
c725b66225 Merge remote-tracking branch 'origin/master' into refactor-object-storages 2024-10-15 23:09:45 +00:00
Robert Schulze
23fcefadc8
... re-enable only the assertions (not full debug mode) 2024-10-15 21:37:39 +00:00
Robert Schulze
b9b7a1091b
(Re)-enable libcxx debug mode
- We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx
  versions, this (surprisingly) enabled the basic debug mode [1].

- In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0
  does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1.

- The debug mode is only enabled in Debug builds. Their docs say the
  extra check change complexity guarantees + the asserts crash which we
  don't want in Release builds. The debug mode detects issues like in
  [3]. Crashes look like this (for example)

  ```
  /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped)
  ```

- I had to mute some new clang-tidy warnings in places that deal with
  container iterators. They got heavier and copy-by-value now yields a
  warning, e.g.

     for (auto it : iterators) /// <-- warning
         [...]

[1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-10-15 13:46:07 +00:00
Raúl Marín
6f635a18f7 Unify more code 2024-10-14 14:07:09 +00:00
Raúl Marín
984dfd4fab Unify ProfileEvents 2024-10-14 13:43:28 +00:00
Raúl Marín
623a620705 Unify failpoints 2024-10-14 13:41:20 +00:00
Raúl Marín
8215d6bea7 Unify CurrentMetrics.cpp 2024-10-14 13:40:19 +00:00
Raúl Marín
160cdbb879 Uniformize ErrorCodes.cpp 2024-10-14 13:30:19 +00:00
Alexey Milovidov
6e9f7dbd5b Less log messages 2024-10-13 11:23:12 +02:00
Raúl Marín
f18842bda6
Revert "Revert "Support CREATE OR REPLACE VIEW atomically"" 2024-10-10 10:57:58 +08:00
Raúl Marín
8fcdcd25fa
Revert "Support CREATE OR REPLACE VIEW atomically" 2024-10-10 10:12:04 +08:00
vdimir
38d8a9a956
Do not log HTTP body 2024-10-09 08:51:09 +00:00
vdimir
5b2f1bbf27
Revert "Truncate and escape HTTP body in logs"
This reverts commit 024851b0f0.
2024-10-09 08:42:28 +00:00
Julia Kartseva
f610c08124 Merge remote-tracking branch 'origin/master' into refactor-object-storages 2024-10-09 08:22:59 +00:00
liuneng
90f9d2d4ea support min_bytes_for_seek 2024-10-09 14:17:22 +08:00
vdimir
024851b0f0
Truncate and escape HTTP body in logs 2024-10-08 15:41:57 +00:00
liuneng
a1e38decc2 Merge remote-tracking branch 'origin/master' into parquet-prefetch
# Conflicts:
#	src/Core/FormatFactorySettingsDeclaration.h
2024-10-08 11:35:02 +08:00
Konstantin Bogdanov
307064cae5
Fix broken build 2024-10-06 12:29:45 +02:00
Konstantin Bogdanov
67c1e89d90
Apply linter changes 2024-10-06 12:29:20 +02:00
Julia Kartseva
c1a2689697 Merge remote-tracking branch 'origin/master' into refactor-object-storages 2024-10-05 21:07:24 +00:00
Sergei Trifonov
19613041d9
Merge pull request #68694 from filimonov/thread_pool_thread_creation_out_of_lock
Thread pool: move thread creation out of lock
2024-10-05 20:29:58 +00:00
Michael Kolupaev
97923069e5
Merge pull request #60669 from ClickHouse/mvrere
Refreshable MV: DatabaseReplicated support, coordination among replicas
2024-10-05 18:46:46 +00:00
Konstantin Bogdanov
f0ae77edb0
Fix build with clang-19 2024-10-05 14:47:23 +02:00
Alexey Milovidov
aae155f5a6
Merge pull request #70111 from jiebinn/changeDefaultValue
Change the default threshold to enable hyper threading
2024-10-05 07:46:33 +00:00
Alexey Milovidov
418233dbd8
Merge pull request #63689 from mariaKhr/interactive-metrics-table
An option for clickhouse-client to show realtime table with metrics
2024-10-05 07:19:14 +00:00
Raúl Marín
73a9de30a6 Remove some nested IAST.h includes in favor of forward declarations 2024-10-04 18:47:13 +02:00
Julia Kartseva
a62bda5567
Merge branch 'master' into refactor-object-storages 2024-10-04 07:21:37 -07:00
Mikhail Filimonov
48e4092d98 move the injectFault back into critical section 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
7ff6bab6c2 addressing review comments 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
01ae6f9a2c avoid unique_ptr for ScopedDecrement 2024-10-04 16:08:34 +02:00
Sergei Trifonov
c221e12be6 Update src/Common/ThreadPool.cpp 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
68dd4c273a Addressing @ilejn comments 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
975a061896 whitespaces 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
5c0a14b78c Revert "fix2"
This reverts commit 0d8dce9e7629848ea0705cdf54c093f17c3e8089.
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
dc9d09d741 fix2 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
86f222a9c0 fix 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
bf665a17b9 fix the datarace, joining the threads before modifing the threads list is crucial 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
d7fede84d8 bit better exception message and comment 2024-10-04 16:08:34 +02:00
Mikhail Filimonov
c772f8fa46 add some assert, and explicit keyword for constructor 2024-10-04 16:08:34 +02:00