Commit Graph

717 Commits

Author SHA1 Message Date
Alexey Milovidov
cbf5443585 Remove old code 2024-03-04 00:11:55 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Alexey Milovidov
3128cf1f1b Remove the check for formatting consistency from the Fuzzer 2024-02-17 02:24:21 +01:00
Azat Khuzhin
7fb31fe160 Remove ability to disable generic clickhouse components
Components like client/server/... are very generic, and there is no
point in disabling them, since it does not reduce amount of compiled
code a lot anyway (just a few modules for entrypoints, everything else
is already included in the clickhouse binary), and eventually they are
just symlinks to the clickhouse binary.

But there are few, that requires extra libraries, like ODBC bridge or
keeper components (and there is also standalone keeper binary compiled
with musl), those had been kept.

Also add some descriptions for some utils and change exit code to 0 for
--help.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:10:00 +01:00
Alexey Milovidov
8a428eb7cf Better usability for server versions in ClickHouse Cloud 2024-02-06 18:37:14 +01:00
Alexander Tokmakov
b8d69ecd5f
Update Client.cpp 2024-01-22 17:00:56 +01:00
Nikita Taranov
a32c5e976a
Don't print server revision in client on connect (#57435) 2023-12-02 16:32:34 +01:00
János Benjamin Antal
4c2451f837
Merge pull request #56741 from ClickHouse/well-known-protos 2023-11-28 15:21:15 +01:00
János Benjamin Antal
adf21e37c4 Make tests use the installed protobuf files 2023-11-27 13:39:28 +00:00
Alexey Milovidov
b62e9d3a1a Address review comments 2023-11-23 18:13:12 +01:00
János Benjamin Antal
ab935e3dd7 Use the google proto files when importing protobuf schemas 2023-11-22 12:39:41 +00:00
Nikolay Degterinsky
fd26fab07f Merge remote-tracking branch 'upstream/master' into local-send-fatal-log 2023-11-19 17:59:51 +00:00
Nikolay Degterinsky
cf46214440 Always send fatal level logs 2023-11-19 15:09:52 +00:00
Alexey Milovidov
8e820185cb Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-ccache-2 2023-11-13 11:17:18 +01:00
Alexey Milovidov
82c461031e Fix build 2023-11-13 10:09:23 +01:00
Pradeep Chhetri
be1e061764 Use SSL port for clickhouse-client for hostnames pointing to clickhouse cloud 2023-11-13 10:31:56 +08:00
Azat Khuzhin
8782873e4f Fix overrides via connections_credentials in case of root directives exists
Before the following did not work, it always uses user `dev`, even with
`clickhouse-client --connection prod`:

  ```yaml
  user: dev

  connections_credentials:
    prod:
      name: prod
      user: prod
  ```

The problem was that before it was not possible to distinguish options
that had been set via command line options and via configuration file.

I've splitted this two actions, and embedded a call to
parseConnectionsCredentials() in between.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-27 20:03:50 +02:00
Azat Khuzhin
4cb3de3110 Add pager property into ClientBase
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 22:31:55 +02:00
Azat Khuzhin
3257d5643d Move adjusting input_format_values_allow_data_after_semicolon into the client base
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 22:31:55 +02:00
Azat Khuzhin
2cbb069b68 Add ability to ignore data after semicolon in Values format
This is required for client, to handle comments in multiquery mode.

v0: separate context for input format
v2: cannot use separate context since params and stuff are changed in global context
v3: do not sent this setting to the server (breaks queries for readonly profiles)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-12 14:55:26 +02:00
Yong Wang
16f992a06e Kusto-phase2: remove fuzzing test from KQL 2023-10-10 23:50:58 -07:00
Yong Wang
8c9da6bacf Merge remote-tracking branch 'origin/master' into Kusto-phase2-oss-pr 2023-09-27 22:35:14 -07:00
Robert Schulze
cde10fe7b5
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-reenable-checks 2023-09-26 18:59:41 +00:00
George Gamezardashvili
0ce30ab6d5
SSH keys authentication (#41109)
Added new type of authentication based on SSH keys. It works only for Native TCP protocol.

Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: Robert Schulze <robert@clickhouse.com>
2023-09-26 17:50:19 +02:00
Robert Schulze
9fff447716
Re-enable clang-tidy checks 2023-09-26 09:34:12 +00:00
Yong Wang
c936c08835 Kusto-phase2: fix the CMakeList files 2023-09-25 13:43:01 -07:00
Robert Schulze
11fea581bc
Fix tests 2023-09-04 15:34:42 +00:00
Yong Wang
e5f968b0d8 Kusto-phase2: enabled fuzzing test for dialect prql 2023-08-26 07:40:40 -07:00
Yong Wang
1ec574057a Kusto-phase2: fixed some functional test 2023-08-26 07:40:40 -07:00
Larry Luo
4f02667861 Fix AST Fuzzer 2023-08-26 07:40:39 -07:00
Alexey Gerasimchuck
3140958132 Added client_info validation 2023-08-22 03:52:57 +00:00
Michael Kolupaev
dfdf5de972 Fixes 2023-07-25 10:16:28 +00:00
Vitaly Baranov
815a3857de Remove non-const function Context::getClientInfo(). 2023-07-17 15:02:07 +02:00
Alexey Gerasimchuck
3218624461
Merge branch 'master' into ADQM-956 2023-07-04 11:47:24 +10:00
Sema Checherinda
d4d85d9fe9 add explicit finalize calls 2023-06-26 16:03:47 +02:00
Alexey Gerasimchuck
25948cdd9e Added ASK_PASSWORD client constant 2023-06-19 03:57:38 +00:00
zvonand
4155d13d69 merge master and resolve conflict 2023-06-16 02:20:32 +02:00
zvonand
e60506f41b changes requested in review 2023-06-16 02:16:04 +02:00
Alexey Gerasimchuck
75e6b4475d corrections after review 2023-06-14 22:35:38 +00:00
Alexey Gerasimchuck
a6420ee338
Merge branch 'master' into ADQM-934 2023-06-15 08:25:24 +10:00
Alexey Gerasimchuck
1f76d08743 fixed --password "" --password issue 2023-06-14 02:24:45 +00:00
Alexey Gerasimchuck
f1b5d47ce2 corrections after second review iteration 2023-06-14 01:26:39 +00:00
Alexey Gerasimchuck
d0938e95e6 prohibited to use --connection 2023-06-09 06:40:57 +00:00
Alexey Gerasimchuck
7578203b46 Changes after review 2023-06-09 03:44:43 +00:00
Alexey Gerasimchuck
23a3026836 Implemented connection string 2023-06-07 03:16:29 +00:00
Andrey Zvonov
2e427ee028
Merge branch 'master' into zvonand-implicit-tz 2023-06-02 01:15:56 +03:00
Andrey Zvonov
87fc780c14
Merge branch 'master' into zvonand-implicit-tz 2023-05-30 13:13:46 +03:00
zvonand
d4cec1f0e0 fix client thread attachment + make better tests 2023-05-30 01:30:01 +02:00
Alexey Gerasimchuck
8574559e23 Disallow usage of --query and --queries-file 2023-05-28 22:25:40 +00:00
Alexey Gerasimchuck
ab5e16a713 Changes after second review iteration 2023-05-23 00:27:17 +00:00
Alexey Gerasimchuck
4a6c7254e8 --multiquery <sql> -> -n -q <sql> syntax sugar 2023-05-17 03:43:35 +00:00
Andrey Zvonov
9237b904be
Merge branch 'master' into zvonand-implicit-tz 2023-05-10 01:25:33 +02:00
Nikolay Degterinsky
b7d8c99fbe Fix member call on null pointer in fuzzer 2023-05-09 13:12:11 +00:00
zvonand
8338d54c34 Merge branch 'master' of github.com:ClickHouse/ClickHouse into zvonand-implicit-tz 2023-05-05 15:50:26 +02:00
Alexey Milovidov
98ae9be734
Revert "Added tests for ClickHouse apps help and fixed help issues" 2023-04-21 01:54:34 +03:00
Andrey Zvonov
984e8fde41
Merge branch 'master' into zvonand-implicit-tz 2023-04-20 23:13:17 +02:00
zvonand
daae5025e8 small updates due to review 2023-04-19 14:45:51 +02:00
zvonand
daef5d818a fix according to updates in ThreadStatus.h 2023-04-12 15:31:58 +02:00
zvonand
2a9f28b73b resolve 2023-04-12 12:54:39 +02:00
Yatsishin Ilya
b5b65d2149 Merge remote-tracking branch 'origin' into clickhouse-help 2023-04-11 11:24:48 +00:00
Vasily Nemkov
e36addb96a Hackish way of setting up timezone on the client
Warning: lots of debug logging
2023-04-11 13:03:03 +02:00
Nikolay Degterinsky
3b9e8a8630 Override user and password environment variables with client parameters 2023-04-05 19:40:43 +00:00
Yatsishin Ilya
d4304d2028 Merge remote-tracking branch 'origin/master' into clickhouse-help 2023-03-02 16:16:18 +00:00
Nikolay Degterinsky
af992ca2db
Better 2023-02-22 16:51:36 +01:00
Nikolay Degterinsky
cdbff57e6c
Ask for password interactively 2023-02-22 15:58:06 +01:00
Yatsishin Ilya
80857638c1 Merge remote-tracking branch 'origin/master' into clickhouse-help 2023-02-22 13:58:17 +00:00
Azat Khuzhin
2dbcfdbe15 Allow to override host for client connection credentials
Introduce new `--connection` option, by default as a connection name
`--host` will be used.

And using --connection you also can specify --host and it will be
overwritten.

Follow-up for: #45715
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-16 14:26:24 +01:00
Yatsishin Ilya
1baa15d603 Merge remote-tracking branch 'origin/master' into clickhouse-help 2023-02-07 15:46:59 +00:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Yatsishin Ilya
f4cfd8a2d9 Merge remote-tracking branch 'origin' into clickhouse-help 2023-02-03 20:08:23 +00:00
Yatsishin Ilya
98edb9f06b Update help for clickhouse tools and add test 2023-01-31 12:19:37 +00:00
Azat Khuzhin
4564a1ef29 Add ability to override connection settings based on connection names
This is somehow analog of .netrc [1].

  [1]: https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-file.html

The follow options can be overwritten on a per-hostname/connection
basis:
- hostname
- port
- secure
- user
- password
- database
- history_file

Also note, that you can have multiple settings for one hostname, can be
useful to distinguish readonly from non-readonly for example.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-28 17:01:12 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings 2023-01-27 16:03:00 +01:00
Anton Popov
92fa39798b Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-26 13:29:23 +00:00
Alexander Tokmakov
3f6594f4c6 forbid old ctor of Exception 2023-01-23 22:18:05 +01:00
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages (#45449)
* save format string for NetException

* format exceptions

* format exceptions 2

* format exceptions 3

* format exceptions 4

* format exceptions 5

* format exceptions 6

* fix

* format exceptions 7

* format exceptions 8

* Update MergeTreeIndexGin.cpp

* Update AggregateFunctionMap.cpp

* Update AggregateFunctionMap.cpp

* fix
2023-01-24 00:13:58 +03:00
Anton Popov
ca80240d84 Merge remote-tracking branch 'upstream/master' into HEAD 2023-01-12 12:13:45 +00:00
Nikolay Degterinsky
dfe93b5d82
Merge pull request #42284 from Algunenano/perf_experiment
Performance experiment
2022-12-30 03:14:22 +01:00
Azat Khuzhin
b7f92454bf Move LineReader/ReplxxLineReader out from base
This will simplify linking dependencies, and anyway this classes are not
base in any sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment 2022-12-20 09:07:48 +00:00
Anton Popov
b6f2754afb Merge remote-tracking branch 'upstream/master' into HEAD 2022-12-16 14:37:34 +00:00
Anton Popov
87e02a1744 Merge remote-tracking branch 'upstream/master' into HEAD 2022-12-14 02:08:10 +00:00
Nikolay Degterinsky
443bc3e656
Merge pull request #43719 from evillique/password_complexity_rules
Add password complexity rules
2022-12-13 17:56:45 +01:00
Nikolay Degterinsky
9b6d31b95d
Merge branch 'master' into perf_experiment 2022-12-13 17:15:07 +01:00
Nikolay Degterinsky
19e95e8cd8 Better implementation of password rules 2022-12-11 23:59:04 +00:00
Nikolay Degterinsky
f2c07c0337 Merge remote-tracking branch 'upstream/master' into password_complexity_rules 2022-12-10 00:46:05 +00:00
Anton Popov
5d9077cdb6 Merge remote-tracking branch 'upstream/master' into HEAD 2022-12-02 12:06:45 +00:00
Nikolay Degterinsky
a7eed2fd6d Throw an exception if something is broken 2022-12-01 02:59:35 +00:00
Alexey Milovidov
72bf1115e9
Merge branch 'master' into password-reset-message 2022-11-29 23:51:46 +01:00
Nikolay Degterinsky
b675898d37 Small naming fix 2022-11-29 16:36:05 +00:00
Azat Khuzhin
c35eb86a37 Fix example of colored prompt in client
After switching to replxx you don't need the following anymore:
- RL_PROMPT_START_IGNORE (\001)
- RL_PROMPT_END_IGNORE   (\002)

And those symbols also breaks the client prompt (the text length
calculated incorrectly, it does not interpret "\x01" as an escape
sequence but instead just a bunch of bytes and shows extra whitespaces
after prompt).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-27 20:30:00 +01:00
Nikolay Degterinsky
3fd10e0011 Better solution 2022-11-25 22:38:28 +00:00
Alexey Milovidov
c20dbb7770 Move password reset message from client to server 2022-11-22 19:34:38 +01:00
Raúl Marín
ad95846b2b AST fuzzer: Print data of INSERT VALUES 2022-11-22 13:10:53 +01:00
Yakov Olkhovskiy
60d116729c adjustments for progress option 2022-11-12 02:55:26 +00:00
Nikolai Kochetov
3eb6c03b47 Disable clickhouse local and clickhouse client non-interactive progress by default. 2022-11-09 19:46:47 +00:00
Alexey Milovidov
641f8576c6
Merge pull request #42003 from ClickHouse/write-progress-to-tty
Write progress directly to terminal
2022-11-05 16:51:37 +01:00
Yakov Olkhovskiy
b30f2ac12d allow '--progress err' to preserve old behavior, adjust tests 2022-11-03 03:16:55 +00:00
Anton Popov
d09039418f Merge remote-tracking branch 'upstream/master' into HEAD 2022-10-28 14:35:45 +00:00
Alexey Milovidov
cd43595ea9 Merge branch 'master' into write-progress-to-tty 2022-10-23 01:41:17 +02:00