Commit Graph

7012 Commits

Author SHA1 Message Date
Yarik Briukhovetskyi
5f767b0dfa
Merge pull request #52004 from JackyWoo/rewrite_uniq_to_count
Rewrite uniq to count
2023-07-25 11:41:00 +02:00
robot-ch-test-poll
bd5d93e439
Merge pull request #52536 from ClickHouse/Fix_disallow_concurrent_backup_restore_test
Fix disallow_concurrency test for backup and restore
2023-07-25 09:10:27 +02:00
Alexey Milovidov
fbcc06685b
Merge pull request #51367 from ClickHouse/remove-wrong-code
Attempt to remove wrong code (catch/throw in Functions)
2023-07-25 05:44:22 +03:00
Alexey Milovidov
787757fd25
Merge pull request #52497 from ClickHouse/Fix_test_insert_same_partition_and_merge_increase_timeout
Fix test_insert_same_partition_and_merge by increasing wait time
2023-07-25 05:39:20 +03:00
Kseniia Sumarokova
e05e0ec557
Merge pull request #52318 from valbok/utf8-names
MaterializedMySQL: Support unquoted utf-8 strings in DDL
2023-07-24 21:49:33 +02:00
Alexander Tokmakov
c3e2077449
Merge branch 'master' into comment-db 2023-07-24 20:53:46 +03:00
Alexey Milovidov
b9375782bd Merge branch 'master' into remove-wrong-code 2023-07-24 19:34:01 +02:00
robot-ch-test-poll3
40f53c4659
Merge pull request #52515 from ClickHouse/fix-test_throttling
Fix `test_throttling`
2023-07-24 15:58:28 +02:00
Antonio Andelic
5da6c99f6d
Add comment 2023-07-24 12:02:27 +02:00
Antonio Andelic
3710c7238d Fix test_throttling 2023-07-24 09:19:06 +00:00
Val Doroshchuk
efa638ef3c MaterializedMySQL: Support unquoted utf-8 strings in DDL
Since ClickHouse does not support unquoted utf-8 strings but MySQL does.

Instead of fixing Lexer to recognize utf-8 chars as TokenType::BareWord,
suggesting to quote all unrecognized tokens before applying any DDL.

Actual parsing and validating the syntax will be done by particular Parser.

If there is any TokenType::Error, the query is unable to be parsed anyway.
Quoting such tokens can provide the support of utf-8 names.

See `tryQuoteUnrecognizedTokens` and `QuoteUnrecognizedTokensTest`.

mysql> CREATE TABLE 道.渠(...

is converted to

CREATE TABLE `道`.`渠`(...

Also fixed the bug with missing * while doing SELECT in full sync because db or table name are back quoted when not needed.
2023-07-24 11:12:10 +02:00
Azat Khuzhin
0401dc453e Fix flakiness of test_version_update_after_mutation by enabling force_remove_data_recursively_on_drop
Since there can be some leftovers:

    2023.07.24 07:08:25.238066 [ 140 ] {} <Error> Application: Code: 219. DB::Exception: Cannot drop: filesystem error: in remove: Directory not empty ["/var/lib/clickhouse/data/system/"]. Probably database contain some detached tables or metadata leftovers from Ordinary engine. If you want to remove all data anyway, try to attach database back and drop it again with enabled force_remove_data_recursively_on_drop setting: Exception while trying to convert database system from Ordinary to Atomic. It may be in some intermediate state. You can finish conversion manually by moving the rest tables from system to .tmp_convert.system.9396432095832455195 (using RENAME TABLE) and executing DROP DATABASE system and RENAME DATABASE .tmp_convert.system.9396432095832455195 TO system. (DATABASE_NOT_EMPTY), Stack trace (when copying this message, always include the lines below):

    0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000e68af57 in /usr/bin/clickhouse
    1. ? @ 0x000000000cab443c in /usr/bin/clickhouse
    2. DB::DatabaseOnDisk::drop(std::shared_ptr<DB::Context const>) @ 0x000000001328d617 in /usr/bin/clickhouse
    3. DB::DatabaseCatalog::detachDatabase(std::shared_ptr<DB::Context const>, String const&, bool, bool) @ 0x0000000013524a6c in /usr/bin/clickhouse
    4. DB::InterpreterDropQuery::executeToDatabaseImpl(DB::ASTDropQuery const&, std::shared_ptr<DB::IDatabase>&, std::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>>>&) @ 0x0000000013bc05e4 in /usr/bin/clickhouse
    5. DB::InterpreterDropQuery::executeToDatabase(DB::ASTDropQuery const&) @ 0x0000000013bbc6b8 in /usr/bin/clickhouse
    6. DB::InterpreterDropQuery::execute() @ 0x0000000013bbba22 in /usr/bin/clickhouse
    7. ? @ 0x00000000140b13a5 in /usr/bin/clickhouse
    8. DB::executeQuery(String const&, std::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) @ 0x00000000140ad20e in /usr/bin/clickhouse
    9. ? @ 0x00000000140d2ef0 in /usr/bin/clickhouse
    10. DB::maybeConvertSystemDatabase(std::shared_ptr<DB::Context>) @ 0x00000000140d0aaf in /usr/bin/clickhouse
    11. DB::Server::main(std::vector<String, std::allocator<String>> const&) @ 0x000000000e724e55 in /usr/bin/clickhouse
    12. Poco::Util::Application::run() @ 0x0000000017ead086 in /usr/bin/clickhouse
    13. DB::Server::run() @ 0x000000000e714a5d in /usr/bin/clickhouse
    14. Poco::Util::ServerApplication::run(int, char**) @ 0x0000000017ec07b9 in /usr/bin/clickhouse
    15. mainEntryClickHouseServer(int, char**) @ 0x000000000e711a26 in /usr/bin/clickhouse
    16. main @ 0x0000000008cf13cf in /usr/bin/clickhouse
    17. __libc_start_main @ 0x0000000000021b97 in /lib/x86_64-linux-gnu/libc-2.27.so
    18. _start @ 0x00000000080705ae in /usr/bin/clickhouse
     (version 23.7.1.2012)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-24 10:34:50 +02:00
Smita Kulkarni
0e46cf86b7 Added try-except to check cases when second backup/restore is picked up first 2023-07-24 08:52:19 +02:00
Alexey Milovidov
ac54be9652 Fix a test 2023-07-24 05:56:18 +02:00
Alexey Milovidov
eb5038f3e9
Merge pull request #52295 from ClickHouse/allow_vertical_merges_from_compact_to_wide_parts
Enable `allow_vertical_merges_from_compact_to_wide_parts` by default
2023-07-24 06:44:33 +03:00
JackyWoo
ab3376a998
Merge branch 'master' into rewrite_uniq_to_count 2023-07-24 11:04:36 +08:00
Alexey Milovidov
706da4d530
Merge pull request #51973 from ClickHouse/integration-tests-fix-disaster-2
Fix disaster in integration tests, part 2
2023-07-24 02:57:39 +03:00
robot-clickhouse
dba7a0dffc Automatic style fix 2023-07-23 23:18:19 +00:00
Alexey Milovidov
40f5649811 Fix test 2023-07-24 01:02:11 +02:00
Alexey Milovidov
7ff3579115
Merge pull request #49631 from ClickHouse/sparse-columns-by-default
Enable Sparse columns by default
2023-07-23 21:18:05 +03:00
robot-ch-test-poll4
1d6e85da91
Merge pull request #52084 from valbok/conv-charsets
MaterializedMySQL: Introduce charset conversion
2023-07-23 18:36:30 +02:00
Smita Kulkarni
039cac69cf Fix test_insert_same_partition_and_merge by increasing wait time 2023-07-23 18:35:37 +02:00
Alexey Milovidov
43bd6d1b83
Revert "Add an ability to specify allocations size for sampling memory profiler" 2023-07-23 19:00:49 +03:00
Alexey Milovidov
0ef6453935
Merge pull request #52148 from azat/tests/EADDRINUSE
Fix possible EADDRINUSE ("Address already in use") in integration tests
2023-07-23 01:27:47 +03:00
Alexey Milovidov
5a3f872a4b
Merge branch 'master' into integration-tests-fix-disaster-2 2023-07-22 19:37:59 +03:00
Alexey Milovidov
b869466a6a
Merge branch 'master' into sparse-columns-by-default 2023-07-22 19:34:29 +03:00
alesapin
835c36cbf3
Merge pull request #52419 from ClickHouse/implement_borders_for_sampling_memory_profiler
Add an ability to specify allocations size for sampling memory profiler
2023-07-22 18:13:26 +02:00
Alexey Milovidov
7af9af1a3f
Merge pull request #52103 from azat/tests/test_materialized_mysql_database
tests: drop existing view in test_materialized_mysql_database
2023-07-22 03:41:52 +03:00
Alexey Milovidov
e5797b7fea
Merge pull request #51514 from azat/tests/fix-integration-tests
Fix running integration tests with spaces in it's names
2023-07-22 03:38:51 +03:00
Alexey Milovidov
37a7b13ca6
Merge pull request #52095 from azat/tests/fix-docker-network-prune
Add missing --force for docker network prune (otherwise it is noop on CI)
2023-07-22 02:30:28 +03:00
robot-ch-test-poll
8175ba8ade
Merge pull request #52408 from ClickHouse/fix-test_keeper_force_recovery
Fix `test_keeper_force_recovery`
2023-07-22 00:22:54 +02:00
Alexey Milovidov
de949b6844
Merge pull request #52306 from ClickHouse/backuptestfix
Add missing replica syncs in test_backup_restore_on_cluster
2023-07-22 00:57:24 +03:00
Antonio Andelic
6ed97a944f
Merge pull request #49450 from myrrc/feature/keeper-dyn-reconf
`reconfig` support for CH Keeper
2023-07-21 15:59:25 +02:00
robot-clickhouse
2a6b96f9e3 Automatic style fix 2023-07-21 13:51:40 +00:00
Yarik Briukhovetskyi
e7b9b42326
Merge branch 'master' into rewrite_uniq_to_count 2023-07-21 15:30:03 +02:00
Alexander Sapin
4695ec6802 Add an ability to specify allocations size for sampling memory profiler 2023-07-21 14:56:29 +02:00
Nikita Mikhaylov
5ea0971921
Merge pull request #52379 from ClickHouse/fix-test-with-encrypted-disks
Fix `test_replicated_merge_tree_encrypted_disk `
2023-07-21 14:12:51 +02:00
Antonio Andelic
59ad2d9acc
Merge branch 'master' into feature/keeper-dyn-reconf 2023-07-21 14:08:26 +02:00
Azat Khuzhin
0f96992322 Fix possible EADDRINUSE ("Address already in use") in integration tests
Here is one example [1]:

    minio1_1    | WARNING: Console endpoint is listening on a dynamic port (32911), please use --console-address ":PORT" to choose a static port.
    minio1_1    | ERROR Unable to initialize console server: Specified port is already in use
    minio1_1    |       > Please ensure no other program uses the same address/port

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/52103/7d510eac7c5f0dfb3361e269be30972e6022fada/integration_tests__tsan__[1_6].html

And here is second [2]:

    java.net.BindException: Problem binding to [0.0.0.0:50020] java.net.BindException: Address already in use; For more details see:  http://wiki.apache.org/hadoop/BindException

  [2]: https://s3.amazonaws.com/clickhouse-test-reports/51493/63e88b725d3d255a6534adce4d434ce5f95d2874/integration_tests__asan__[1_6].html

v2: increase the limit from 5K to 10K
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-21 13:47:42 +02:00
Nikolai Kochetov
e02a7c7382
Merge pull request #52375 from ClickHouse/disable-analyzer-bc-tests
Disable analyzer setting in backward_compatibility integration tests.
2023-07-21 13:39:06 +02:00
Antonio Andelic
10c2d5dade
Merge branch 'master' into feature/keeper-dyn-reconf 2023-07-21 13:24:18 +02:00
Antonio Andelic
3815a6aa62 Make test_keeper_force_recovery more stable 2023-07-21 11:16:02 +00:00
Antonio Andelic
234b5047b5
Merge pull request #52373 from ClickHouse/fix-test_keeper_session
Fix `test_keeper_session`
2023-07-21 08:33:37 +02:00
Nikita Mikhaylov
920887f315 Done 2023-07-20 16:43:59 +00:00
Michael Kolupaev
97e54d6eba Fix test_backup_restore_on_cluster flakiness caused by missing replica syncs 2023-07-20 15:57:29 +00:00
Alexander Tokmakov
a39ba00ec3
Merge pull request #52116 from aalexfvk/http_failover
Handle multiple resolved IPs for HTTP/HTTPS session connection
2023-07-20 18:25:45 +03:00
robot-clickhouse
a26de1b370 Automatic style fix 2023-07-20 15:12:55 +00:00
Nikolai Kochetov
ea252e2f61 Disable analyzer setting in backward_compatibility integration tests. 2023-07-20 15:05:07 +00:00
robot-clickhouse
5decb1f5c5 Automatic style fix 2023-07-20 14:11:11 +00:00
Antonio Andelic
f997adfe27 Retry if sessions not closed because missing leader 2023-07-20 14:02:55 +00:00