Commit Graph

117 Commits

Author SHA1 Message Date
Robert Schulze
1f17ddc6fe
Update .clang-tidy 2024-06-10 13:06:44 +00:00
Robert Schulze
a14e58ab88
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-21 05:15:35 +00:00
Robert Schulze
56e8027883
Improve comment 2024-05-19 17:53:06 +00:00
Robert Schulze
4a8e663b1a
Fix clang-tidy after clang-18 transition 2024-05-19 17:34:55 +00:00
Robert Schulze
639f7f166f
Fix typo 2024-05-19 12:53:17 +00:00
Robert Schulze
ed28cac4c2
Restore the warning 2024-05-19 12:51:14 +00:00
Robert Schulze
113bb00005
Fix clang-tidy "-readability-redundant-inline-specifier" 2024-05-19 10:23:58 +00:00
Raúl Marín
2165cc318d More helpful optimizations found by clang-tidy 2024-05-15 20:26:51 +02:00
Alexey Milovidov
258eb72c8a Useless changes 2024-05-12 01:48:03 +02:00
Alexey Milovidov
c4bb09d559 Fix error 2024-05-11 14:15:28 +02:00
Alexey Milovidov
2794a6635e Useless changes 2024-05-10 06:58:21 +02:00
Alexey Milovidov
426a51b624 Useless changes 2024-05-10 04:53:29 +02:00
Alexey Milovidov
c17a3bb944 Useless changes 2024-05-10 03:31:40 +02:00
Alexey Milovidov
224e1940ae Useless changes 2024-05-09 03:58:34 +02:00
Alexey Milovidov
1d69518c4d Useless changes 2024-05-09 02:07:04 +02:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
2024-04-07 11:09:35 +00:00
Robert Schulze
dda1a0b9f0
Also enable modernize-use-override 2024-04-03 20:44:02 +00:00
Robert Schulze
94a347cc41
Suppress bugprone-forward-declaration-namespace 2024-03-18 20:34:15 +00:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Robert Schulze
ecb11005e3
List clang-tidy checks as list instead of a string
The string representation will be deprecated at some point:
https://reviews.llvm.org/D147876
2024-03-11 10:56:26 +00:00
Robert Schulze
3b18eb4f17
Fix clang-tidy in some headers 2024-02-28 22:47:34 +00:00
Robert Schulze
3e0bc6fe42
Disable '-clang-analyzer-unix.Malloc' for now 2023-09-27 08:51:17 +00:00
Robert Schulze
9fff447716
Re-enable clang-tidy checks 2023-09-26 09:34:12 +00:00
Robert Schulze
8339c33273
Try to fix clang-tidy issue with -Wunused-command-line-argument (didn't reproduce locally) 2023-09-21 18:39:52 +00:00
Robert Schulze
f5137dd0b4
More clang-tidy fixes 2023-09-21 14:40:57 +00:00
Robert Schulze
50c51c2854
Fix new clang-tidy-s 2023-09-20 22:17:39 +00:00
Robert Schulze
804276ffe6
readability-identifier-names: adjust invalid options
The check is disabled, anyways ...
- remove UsingCase (it is probably subsumed by TypedefCase)
- rename TemplateCase to TemplateParameterCase
2023-05-13 20:28:55 +00:00
Robert Schulze
14d831e3bf
zirkon --> zircon 2023-05-13 20:18:24 +00:00
Robert Schulze
7e0bf3b8b2
Small-ish .clang-tidy update 2023-05-13 15:29:45 +00:00
Azat Khuzhin
e1d7f466cb Disable misc-use-anonymous-namespace check in clang-tidy
It is too noisy during upgrade:

$ grep error: build_log.log | awk '{print $NF}' | sort | uniq -c
      1 [bugprone-standalone-empty,-warnings-as-errors]
      1 [misc-misplaced-const,-warnings-as-errors]
   2147 [misc-use-anonymous-namespace,-warnings-as-errors]
      6 [modernize-loop-convert,-warnings-as-errors]
      9 [readability-redundant-string-cstr,-warnings-as-errors]

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:43:52 +02:00
Robert Schulze
9399a628dc
Cleanup mess in .clang-tidy
This fixes some mess I left in .clang-tidy (#43863) when clang-tidy
build times were too bad and had to be reduced urgently.

Verified locally that runtime isn't affected by this PR.
2023-04-04 16:07:02 +00:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16 2023-03-19 17:25:41 +00:00
Robert Schulze
62251b5add
Fix minor glitch 2023-03-16 16:59:24 +00:00
Robert Schulze
1b1cb105e5
clang-tidy >= 15: write CheckOptions in dictionary format
".clang-tidy files can now use the more natural dictionary syntax for specifying CheckOptions.", [0]

[0]
https://releases.llvm.org/15.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy
2023-03-16 13:59:51 +00:00
Robert Schulze
b91a537096
Address clang-tidy slowness 2023-03-14 22:24:20 +00:00
Amos Bird
c996dfe562
do-while loop trivia 2023-02-28 22:43:49 +08:00
Robert Schulze
98a11e2ebd
Temporarily disable misc-* due to being too slow 2022-12-07 11:43:47 +00:00
Robert Schulze
4122bd853d
Sort checks 2022-12-07 11:43:46 +00:00
Robert Schulze
39b34b09c1
Add comment about dictionary syntax for configuration 2022-12-07 11:43:44 +00:00
Maksim Kita
f4101861e7 Function name normalization fix functions header 2022-10-04 17:29:33 +02:00
Azat Khuzhin
4e3135383b Fix clang-tidy warnings (from clang-15)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Robert Schulze
cedf75ed5e
Enable clang-tidy for headers
clang-tidy now also checks code in header files. Because the analyzer
finds tons of issues, activate the check only for directory "base/" (see
file ".clang-tidy"). All other directories, in particular "src/" are
left to future work.

While many findings were fixed, some were not (and suppressed instead).
Reasons for this include: a) the file is 1:1 copypaste of a 3rd-party
lib (e.g. pcg_extras.h) and fixing stuff would make upgrades/fixes more
difficult b) a fix would have broken lots of using code
2022-08-31 10:48:15 +00:00
Alexey Milovidov
d2ed4c5fc5
Check what will be if I enable concurrency-mt-unsafe in clang-tidy 2022-08-15 07:49:23 +03:00
Anton Popov
df6882d2b9
Revert "Fix errors of CheckTriviallyCopyableMove type" 2022-06-07 13:53:10 +02:00
Robert Schulze
2d87af2a15
Merge pull request #37647 from DevTeamBK/Fix-all-CheckTriviallyCopyableMove-Errors
Fix errors of CheckTriviallyCopyableMove type
2022-06-05 19:58:47 +02:00
HeenaBansal2009
05d2b13510 temporary commit to get the errors of CheckTriviallyCopyableMove type 2022-05-30 04:22:41 -07:00
Alexey Milovidov
dce7a86ca9 Merge branch 'master' into llvm-14 2022-05-22 22:38:07 +02:00
Robert Schulze
5eb741ec0b
Merge pull request #37347 from ClickHouse/disable-readability-identifier-length
Disable clang-tidy readability-identifier-length
2022-05-20 09:04:59 +02:00
Robert Schulze
a609287761
Add a comment about disabling further checks 2022-05-19 17:39:53 +02:00
Robert Schulze
17afe42ad3
Disable clang-tidy readability-identifier-length
readability-identifier-length was added with Clang 14 which does not yet
run in the central builds yet but (at least on my system) locally.
Disabling the check because it is too noisy. Older clang-tidy versions
will just ignore the setting.
2022-05-19 10:41:27 +02:00