Commit Graph

5523 Commits

Author SHA1 Message Date
Amos Bird
fbfbe161ec
Unify hash tables interface. 2019-11-06 00:08:04 +08:00
millb
a03f8145bb Created check for HDFS and S3 storages
:
2019-11-05 15:40:49 +03:00
millb
d62cd6efa8 Merge branch 'master' into url_engine_problem 2019-11-05 14:42:53 +03:00
hcz
e0e5e812a7
Allow relative user_files_path 2019-11-05 17:48:49 +08:00
Nikita Mikhaylov
817b52314e Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-11-05 12:32:26 +03:00
Azat Khuzhin
4dfffdd24a Write current batch for distributed send atomically (using .tmp + rename)
Otherwise the following can happen after reboot:

    2019.11.01 11:46:12.217143 [ 187 ] {} <Error> dist.Distributed.DirectoryMonitor: Code: 27, e.displayText() = DB::Exception: Cannot parse input: expected \n before: S\'^A\0^]\0\0<BE>4^A\0r<87>\0\0<A2><D7>^D^Y\0<F2>{^E<CD>\0\0Hy\0\0<F2>^_^C\0^_&\0\0<FF><D3>\0\0
    <8D><91>\0\0<C0>9\0\0<C0><B0>^A\0^G<AA>\0\0<B5><FE>^A\0<BF><A7>^A\0<9B><CB>^A\0I^R^A\0<B7><AB>^A\0<BC><8F>\0\0˲^B\0Zy\0\0<94><AA>\0\0<98>
    <8F>\0\0\f<A5>\0\0^QN\0\0<E3><C6>\0\0<B1>6^B\0ɳ\0\0W<99>\0\0<B9><A2>\0\0:<BB>\0\0)<B1>\0\0#<8B>\0\0aW\0\0<ED>#\0\0<F1>@\0\0ˀ^B\0<D7><FC>\0\0<DF>, Stack trace:

    0. 0x559e27222e60 StackTrace::StackTrace() /usr/bin/clickhouse
    1. 0x559e27222c45 DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) /usr/bin/clickhouse
    2. 0x559e26de4473 ? /usr/bin/clickhouse
    3. 0x559e272494b5 DB::assertString(char const*, DB::ReadBuffer&) /usr/bin/clickhouse
    4. 0x559e2a5dab45 DB::StorageDistributedDirectoryMonitor::processFilesWithBatching(std::map<unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&) /usr/bin/clickhouse
    5. 0x559e2a5db5fa DB::StorageDistributedDirectoryMonitor::processFiles() /usr/bin/clickhouse
    6. 0x559e2a5dba78 DB::StorageDistributedDirectoryMonitor::run() /usr/bin/clickhouse
    7. 0x559e2a5ddbbc ThreadFromGlobalPool::ThreadFromGlobalPool<void (DB::StorageDistributedDirectoryMonitor::*)(), DB::StorageDistributedDirectoryMonitor*>(void (DB::StorageDistributedDirectoryMonitor::*&&)(), DB::StorageDistributedDirectoryMonitor*&&)::{lambda()#1}::operator()() const /usr/bin/clickhouse
    8. 0x559e2726b07c ThreadPoolImpl<std::thread>::worker(std::_List_iterator<std::thread>) /usr/bin/clickhouse
    9. 0x559e2bbc3640 ? /usr/bin/clickhouse
    10. 0x7fbd62b3cfb7 start_thread /lib/x86_64-linux-gnu/libpthread-2.29.so
    11. 0x7fbd62a692ef __clone /lib/x86_64-linux-gnu/libc-2.29.so
     (version 19.17.1.1)

v2: remove fsync, to avoid possible stalls (https://github.com/ClickHouse/ClickHouse/pull/7600#discussion_r342010874)
2019-11-05 00:24:38 +03:00
alexey-milovidov
5aceca9e17
Merge pull request #7615 from amosbird/fix21
Global context should be unique.
2019-11-05 00:16:37 +03:00
Vladimir Chebotarev
9869ee141c Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages. 2019-11-04 20:11:50 +03:00
Amos Bird
e2cfc3ecab
Global context should be unique. 2019-11-04 23:43:13 +08:00
alexey-milovidov
b261e6033a
Merge pull request #7602 from excitoon-favorites/cloneAndLoadDataPartOnSameDisk
Made `MergeTreeData::cloneAndLoadDataPart` only work for the same disk.
2019-11-04 14:42:30 +03:00
zhang2014
08894484ee fix cluster system is_local 2019-11-04 10:56:12 +08:00
Vladimir Chebotarev
e76bbfc5ad Made MergeTreeData::cloneAndLoadDataPart only work for the same disk. 2019-11-04 01:27:05 +03:00
alexey-milovidov
15c4a19bb1
Merge pull request #7585 from ernestp/macos_catalina_2019_11_01
Fixed compile errors on macOS Catalina
2019-11-02 15:46:17 +03:00
alexey-milovidov
6e4d63e394
Merge pull request #7575 from Alex-Burmak/escaping_fix
Fixed missing file name escaping in FREEZE command
2019-11-02 13:20:28 +03:00
alexey-milovidov
ad01f7b1ac
Merge pull request #7552 from azat/do-not-account-memory-for-Buffer-in-max_memory_usage
[RFC] Do not account memory for Buffer engine in max_memory_usage limit
2019-11-02 00:57:24 +03:00
alexey-milovidov
dda93e2275
Merge pull request #7561 from ClickHouse/achimbab-master
Merge for #7363
2019-11-02 00:57:13 +03:00
Ernest Poletaev
de1e5d0e53 Fixed compile errors on macOS Catalina 2019-11-01 23:33:43 +07:00
Nikolai Kochetov
239d92a94c Code cleanup. 2019-11-01 18:31:02 +03:00
alexey-milovidov
4081b0be90
Merge pull request #7497 from amosbird/countopt
Early constant folding.
2019-11-01 16:54:02 +03:00
Alexander Burmak
9b8fc9a899 Fixed missing file name escaping in FREEZE command 2019-11-01 16:17:08 +03:00
Ivan
21db9157f7
Don't initialize some constant blocks in a loop (#7475) 2019-11-01 14:34:29 +03:00
Nikolai Kochetov
388bbb950b Add flag to set that set is created. 2019-11-01 14:03:35 +03:00
Nikolai Kochetov
1f7a798c97 Add flag to set that set is created. 2019-11-01 13:58:29 +03:00
alesapin
6ef0a92535
Merge pull request #7558 from excitoon/patch-1
Made mutation to choose the same disk in `ReplicatedMergeTree`.
2019-11-01 13:52:45 +03:00
Nikolai Kochetov
d31cac33b2 Small fixes. 2019-11-01 12:41:20 +03:00
Nikolai Kochetov
5bb47e2484
Merge pull request #7181 from ClickHouse/processors-and-storages
Processors and storages
2019-11-01 12:04:49 +03:00
Azat Khuzhin
dbe45800d9 Do not account memory for Buffer engine in max_memory_usage limit
Since background flush will not be accounted there, and it can be too
tricky to calclulate this limit, in case you have multiple materialized
views with Buffer engine.

v2: test adjustment
2019-10-31 22:26:50 +03:00
Nikolai Kochetov
9a5a0a2a3b Fix types for set elements. 2019-10-31 19:14:06 +03:00
Vitaly Baranov
56011d4649
Merge pull request #7553 from vitlibar/add-constraints-columns-to-table-system-settings
Add constraints columns to table system.settings
2019-10-31 19:06:46 +03:00
Amos Bird
e04cdd4ebb
Early constant folding. 2019-10-31 23:54:32 +08:00
Vladimir Chebotarev
faf1b070ac
Typo was fixed. 2019-10-31 16:26:11 +03:00
Vladimir Chebotarev
0dea6f5458
Added comment for selecting disk for mutation. 2019-10-31 16:19:38 +03:00
Nikolai Kochetov
be1ccaa890 Fix clang build. 2019-10-31 16:18:21 +03:00
Vladimir Chebotarev
f44cee623a
Made mutation to choose the same disk in ReplicatedMergeTree. 2019-10-31 15:22:25 +03:00
Nikolai Kochetov
18378417df Fix build. 2019-10-31 14:48:35 +03:00
Nikolai Kochetov
a80338e066 Merged with master 2019-10-31 14:41:29 +03:00
Nikolai Kochetov
a38124c68e Review fixes. 2019-10-31 14:32:24 +03:00
Vitaly Baranov
5601d6ae66 Add constraints columns to table system.settings 2019-10-31 01:45:57 +03:00
alexey-milovidov
88d43488e1
Merge pull request #7412 from 4ertus2/strange
merge_max_block_size in settings
2019-10-31 00:24:43 +03:00
alexey-milovidov
bb75c7469a
Merge pull request #7545 from ClickHouse/fix_only_tuple_columns
Fix only tuple columns in table.
2019-10-30 23:34:23 +03:00
alesapin
e2424bda4c Fix style 2019-10-30 19:00:40 +03:00
alesapin
2b5ef8bdef Fix bug when table contains only tuple columns 2019-10-30 17:50:59 +03:00
Amos Bird
2c75a51d4f
Instant count() for MergeTree
Use (Replicated)MergeTree's metadata to do trivial count()
2019-10-29 17:45:47 +08:00
Nikita Mikhaylov
756a10707d Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-28 13:51:52 +03:00
alesapin
04ca163518 Merge branch 'master' into dictionaries_ddl_loader 2019-10-25 10:58:04 +03:00
alesapin
5d8d1df802
Merge pull request #7434 from excitoon-favorites/fix-7424
Allowed to have some parts on destination disk or volume in MOVE PARTITION
2019-10-24 19:45:22 +03:00
Artem Zuikov
39b64dff87
Merge pull request #7454 from 4ertus2/refactoring
Refactoring: extract non aliases logic out of QueryNormalizer
2019-10-24 14:34:53 +03:00
Vladimir Chebotarev
64f158ff28 Fixed message for ALTER MOVE PART. 2019-10-24 13:56:32 +03:00
Alexander Kuzmenkov
29052b6a37
Merge pull request #7377 from azat/INSERT-Distributed-MATERIALIZED-cols
* Fix INSERT into Distributed non local node with MATERIALIZED columns

Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891

* Cover INSERT into Distributed with MATERIALIZED columns and !is_local node

I guess that adding new cluster into server-test.xml is not required,
but it won't harm.

* Update DistributedBlockOutputStream.cpp
2019-10-24 12:35:09 +03:00
Alexander Kuzmenkov
050de71ef4
Update DistributedBlockOutputStream.cpp 2019-10-24 12:33:45 +03:00
alesapin
a6199b7e69 Merge with master 2019-10-24 12:33:40 +03:00
Vladimir Chebotarev
255da8f5e0 Fixed style. 2019-10-24 12:11:06 +03:00
Vladimir Chebotarev
3debdc2119 Added integration tests for ALTER MOVE PARTITION and fixed minor things. 2019-10-24 11:52:33 +03:00
chertus
9818eada69 rename: merge_max_block_size 2019-10-24 02:18:21 +03:00
Azat Khuzhin
ab9d9f8997 Fix INSERT into Distributed non local node with MATERIALIZED columns
Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891
2019-10-23 21:54:27 +03:00
chertus
20093fa065 extract more logic out of QueryNormalizer 2019-10-23 16:59:03 +03:00
Amos Bird
295864e6e0
better scalar query 2019-10-23 21:37:54 +08:00
millb
eca81dc32e Fixed bugs 2019-10-23 14:58:35 +03:00
Colum
a413770a97 Fixed spelling error in error message 2019-10-22 10:02:51 -07:00
Vladimir Chebotarev
9446fd2c4d Allowed to have some parts on destination disk or volume in MOVE PARTITION. #7424 2019-10-22 17:45:01 +03:00
Nikita Mikhaylov
34d8ade4a0 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-22 15:56:51 +03:00
Ivan
7ba4e36e73
Don't push to MVs when inserting into Kafka table (#7265)
* Do not insert values into MV when inserting directly to Kafka
* Add method noPushingToViews() to IStorage interface
  To separate InterpreterInsertQuery and StorageKafka
2019-10-22 13:31:28 +03:00
Guillaume Tassery
3dee295f9a Set neutral lock 2019-10-22 09:15:58 +02:00
Guillaume Tassery
d38bc27c05 put back lock 2019-10-22 08:30:51 +02:00
Guillaume Tassery
552e3b8400 update 2019-10-22 08:03:49 +02:00
chertus
f024b007a2 default_merge_block_size setting 2019-10-21 20:57:26 +03:00
Nikolai Kochetov
2b334a4adb Review fixes. 2019-10-21 19:26:29 +03:00
Nikolai Kochetov
2893c35930 Merged with master. 2019-10-21 18:33:44 +03:00
Nikolai Kochetov
f7d2e1b758 Added Pipe class. Updated MergeTreeDataSelectExecutor. 2019-10-21 18:16:08 +03:00
millb
8b8ca9a141 Support redirect improvement 2019-10-21 17:45:57 +03:00
robot-clickhouse
7381489d5d Auto version update to [19.17.1.1] [54428] 2019-10-21 15:48:00 +03:00
millb
e6d0c2a66c Redirect support added 2019-10-21 12:42:28 +03:00
alesapin
26c87e46c9 Merge branch 'master' into dictionaries_ddl_loader 2019-10-21 11:46:49 +03:00
alesapin
35e66d6696 Merge with master 2019-10-21 11:46:11 +03:00
millb
f64f6658ce Merge branch 'master' into url_engine_problem 2019-10-21 11:44:31 +03:00
Aleksey Akulovich
a019e45093 fix typos in docs and comment (#7385) 2019-10-20 12:43:54 +08:00
alexey-milovidov
52bfa9927c
Merge pull request #7384 from ClickHouse/fix_ub_in_system_parts
Fix UB in StoragesInfoStream
2019-10-19 09:59:39 +03:00
Azat Khuzhin
260a9fba2b StorageDistributed: Drop extra inclusion of materializeBlock.h 2019-10-18 23:38:33 +03:00
Alexander Kuzmenkov
5e2cc37381
Distinguish Array and Tuple field types when creating from array of Fields. (#7179) 2019-10-18 18:57:05 +03:00
Alexander Tokmakov
06b28f9fe3 fix uninitialized offset for Lazy db 2019-10-18 16:09:24 +03:00
vzakaznikov
66675edf2d Fixing data race with no_users_thread. (#7353) 2019-10-17 17:47:36 +03:00
vzakaznikov
ee1a2ce027 Fixing AddressSanitizer error in the LIVE VIEW getHeader() method. (#7271) 2019-10-17 17:43:11 +03:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00
alesapin
6dfe5c7142 Better introspection 2019-10-17 16:05:12 +03:00
Ivan
e595df05d9
Fix CREATE TABLE AS from table with virtual columns (#7183)
* Disable undefined instrumentation for rdkafka
2019-10-17 14:12:35 +03:00
philip.han
8aac4d04de Fixed weird type-casting for IN-operator in bloom_filter 2019-10-17 19:53:41 +09:00
Vladimir Chebotarev
512e97ddb3
Improved readability a little bit (MergeTreeData::getActiveContainingPart). 2019-10-16 22:01:50 +03:00
philip.han
a2bf848e12 Made bloom_filter type of index supporting LowCardinality and Nullable 2019-10-16 15:22:56 +09:00
alexey-milovidov
6a44336b86
Merge pull request #7304 from sundy-li/ttl_check
Check TTL in StorageFactory
2019-10-14 20:11:37 +03:00
sundy-li
b2109e4ece Check TTL in StorageFactory 2019-10-14 17:03:39 +08:00
alesapin
155731a676 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-14 11:49:18 +03:00
Nikolai Kochetov
757488369f Merge branch 'master' into processors-3 2019-10-12 19:24:02 +03:00
Alexander Kuzmenkov
31bd359100
Merge pull request #7231 from ClickHouse/aku/podarray-includes
Include PODArray.h into fewer files.
2019-10-12 15:08:41 +03:00
alesapin
653aa7c005 Fix unit tests and segfault 2019-10-11 18:41:52 +03:00
alesapin
967fe64793 Add simpliest tests 2019-10-11 18:22:30 +03:00
alesapin
ae42dc0d4c Attach detach and introspection queries for dictionaries 2019-10-11 16:21:52 +03:00
Alexander Kuzmenkov
8a1d57bddb Include PODArray.h into fewer files. 2019-10-11 14:28:16 +03:00
Guillaume Tassery
88491abd7b add tests 2019-10-11 12:42:25 +02:00
alesapin
3dfe961291 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-11 12:14:07 +03:00
alesapin
7159cde160 Remove accident change 2019-10-11 12:07:44 +03:00
Guillaume Tassery
c91f5fbd6d sync 2019-10-11 10:42:43 +02:00
Guillaume Tassery
145df0bb65 Fix lock 2019-10-11 08:11:53 +02:00
Nikolai Kochetov
e48755d045 Merge branch 'master' into processors-and-storages 2019-10-11 00:46:37 +03:00
Vitaly Baranov
18ccb4d64d Move backQuote() and quoteString() to a separate file, use StringRefs. 2019-10-11 00:18:52 +03:00
alesapin
2a5713e6e4 Compilable code 2019-10-10 23:47:47 +03:00
alesapin
67fc3347c2 Preparing databases for dictionaries 2019-10-10 20:33:01 +03:00
Nikolai Kochetov
ef14df4632 Added more comments. 2019-10-10 17:16:15 +03:00
millb
a00089f0b4 Renamed StorageOfAllowedURL -> RemoteHostFilter 2019-10-10 15:58:06 +03:00
Nikolai Kochetov
378052743d Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:24:29 +03:00
Nikolai Kochetov
4728bdfccd Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:20:25 +03:00
millb
a97739f67f Created class StorageOfAllowedURL
Created test for table function remote and remoteSecure
Created check allowed url in remote and remoteSecure
Fixed tests
2019-10-09 23:29:41 +03:00
Alexey Milovidov
3fbac60328 Added a test 2019-10-09 23:16:17 +03:00
Alexey Milovidov
e65b57369e transformQueryForExternalDatabase: fixed constant folding for Date and DateTime 2019-10-09 23:13:34 +03:00
Alexey Milovidov
b302fec362 Fixed bad code in transformQueryForExternalDatabase 2019-10-09 22:58:50 +03:00
millb
fec1c6deba Fixed Error message and error code 2019-10-09 14:16:14 +03:00
Nikolai Kochetov
9c5ae5f536 Merge branch 'master' into processors-and-storages 2019-10-09 14:12:47 +03:00
alexey-milovidov
5c2d478543
Merge pull request #7212 from ClickHouse/aku/field-includes
Include Field.h and FieldVisitor.h into fewer files.
2019-10-08 22:40:30 +03:00
alexey-milovidov
b9aa5d812d
Merge pull request #7171 from nikvas0/nikvas0/lazy_db
Lazy Database
2019-10-08 22:15:55 +03:00
Alexander Kuzmenkov
2b30f2696c Include Field.h in less files. 2019-10-08 16:23:24 +03:00
alexey-milovidov
3bd59edc3c
Update StorageSystemTables.cpp 2019-10-08 03:31:50 +03:00
alexey-milovidov
c92fc70f66
Update StorageSystemTables.cpp 2019-10-08 03:29:41 +03:00
alexey-milovidov
704529801e
Update StorageSystemColumns.cpp 2019-10-08 03:27:57 +03:00
Alexander Kuzmenkov
56b065881a Include FieldVisitors.h in less files. 2019-10-07 20:23:05 +03:00
Alexander Kuzmenkov
367c537106 Do not include Field.h everywhere through SettingsCommon.h.
Move the methods of SettingsCollection<> that are dependent on Field to
a separate file, and include it once for each instantiation. This allows
to work on Field without always recompiling the entire project.
2019-10-07 20:23:05 +03:00
millb
7ab1804ebb Fixed codestyle and changed Error message. 2019-10-06 18:33:25 +03:00
alexey-milovidov
bb8414bdeb
Merge pull request #7201 from vzakaznikov/enabling_again_live_view_tests
A quick fix to resolve crash in LIVE VIEW table and re-enabling all LIVE VIEW tests.
2019-10-05 20:47:34 +03:00
Vitaliy Zakaznikov
6b8e61737a * Fixing crash in LIVE VIEW
* Re-enabling all LIVE VIEW tests
2019-10-05 08:05:24 -04:00
Vasilyev Nikita
b8647f49b5 fix 2019-10-05 13:21:04 +03:00
Nikolai Kochetov
95ec0f7c2d Merged with master. 2019-10-04 20:53:21 +03:00
Nikolai Kochetov
23069ca6d0 Progress for MergeTreeSelectProcessor. 2019-10-04 20:50:07 +03:00
Nikolai Kochetov
627d48c19a Added ExecutionSpeedLimits. 2019-10-04 20:49:57 +03:00
Nikolai Kochetov
e48f7faebc Fix MergeTreeRangeReader.
Fix MergeTreeReader.

Fix MergeTreeBaseSelectProcessor.

Better exception message for TreeExecutor.

Added header_without_virtual_columns to MergeTreeBaseSelectProcessor.

Fix MergeTreeReverseSelectProcessor.

Fix MergeTreeDataSelectExecutor.
2019-10-04 20:49:29 +03:00
Nikolai Kochetov
1689576770 Update MergeTreeDataSelectExecutor. 2019-10-04 20:49:14 +03:00
alexey-milovidov
9c2f3ba41a
Merge pull request #6984 from achimbab/pr_bf
Made bloom_filter type of index supporting arrays
2019-10-04 18:08:42 +03:00
Guillaume Tassery
0f66da0e91 Resolve lock issue after review 2019-10-04 06:37:19 +02:00
alesapin
4e83f65089 Fix bug with segmentation fault in ATTACH PART query 2019-10-03 21:07:47 +03:00
Vasilyev Nikita
d6490892a7 fix metadata time 2019-10-03 17:18:17 +03:00
Guillaume Tassery
4f26f3fcfa Fix style 2019-10-03 12:52:32 +02:00
Guillaume Tassery
f54c90ccce Merge branch 'master' of github.com:PerformanceVision/ClickHouse into move_partition 2019-10-03 10:24:39 +02:00
Alexander Kuzmenkov
8e245d4e8c
Merge pull request #7135 from ClickHouse/aku/msan-field
Fix some MemorySanitizer warnings for Fields.
2019-10-03 10:33:44 +03:00
Ivan
05b17976d1
Commit to Kafka explicitly after the writing is finalized (#7175) 2019-10-03 00:17:19 +03:00
millb
7caae87e74 Fixed StorageURL.cpp 2019-10-02 20:17:09 +03:00
millb
16645bfe53 Fixed StorageUrl.cpp 2019-10-02 19:33:50 +03:00
Alexander Kuzmenkov
4af8e76bdd Use proper types for Field.
When a Field is inserted into a column, its type should be the same as
the column data type to avoid implicit reinterpret_cast. Change a
couple of usages where these types were different.
2019-10-02 16:48:26 +03:00
Vasilyev Nikita
de3deb9e85 fix 2019-10-02 15:58:13 +03:00
Nikita Mikhaylov
13e2034084
fix possible dataraces in ReplicatedMergeTree 2019-10-02 12:59:44 +03:00
Vladimir Chebotarev
e79a15c39c
Fixed time calculation in MergeTreeData. 2019-10-02 10:46:53 +03:00
Nikita Mikhaylov
0e9cad2276
fix datarace in stress test in storagemergetree 2019-10-01 21:04:42 +03:00
Vasilyev Nikita
c630d9457b opt system tables 2019-10-01 16:07:00 +03:00
Vasilyev Nikita
5793a02ef9 impr Lazy database 2019-10-01 15:44:17 +03:00
Nikita Mikhaylov
d47d4cd6c1 parallel parsing 2019-10-01 13:48:46 +03:00
millb
9246f258e8 Created ability to configure allowed URL in config.xml without tests. 2019-09-30 18:29:05 +03:00
alexey-milovidov
102b5a7dd4
Merge pull request #7111 from ClickHouse/dictionaries_ddl
Small dictionaries refactoring
2019-09-27 22:05:14 +03:00
alexey-milovidov
a2fc7e2e9e
Merge pull request #7093 from millb/merges_counter_metric
Add merge metric
2019-09-26 21:49:43 +03:00
Nikolai Kochetov
b65fe57319 Update MergeTreeRangeReader. 2019-09-26 20:29:41 +03:00
millb
259be751ee Fixed metric name.
Add metric description.
Add test.
2019-09-26 15:06:52 +03:00
alesapin
4fdb5a61e5 Rename ExternalDictionaries to ExternalDictionariesLoader 2019-09-26 13:41:33 +03:00
alesapin
5668f55ab7 Rename ExternalModels to ExternalModelsLoader 2019-09-26 13:23:14 +03:00
millb
4e893eb949 Fixed codestyle 2019-09-25 13:46:24 +03:00
millb
97a2ae176b Add CountOfMerges metric 2019-09-25 13:37:43 +03:00
Alexey Milovidov
ff07ffbbae Merge branch 'merging_redis' of https://github.com/CurtizJ/ClickHouse into CurtizJ-merging_redis 2019-09-25 02:27:05 +03:00
alexey-milovidov
7cfa52ef73
Merge pull request #7026 from ClickHouse/aku/lookup-result
Do not use iterators in find() and emplace() methods of hash tables.
2019-09-25 02:03:43 +03:00
alexey-milovidov
bc9667d881
Merge pull request #7085 from ClickHouse/merge-s3
Merge s3
2019-09-24 17:51:57 +03:00
Alexander Kuzmenkov
f3bde19b74 Do not use iterators in find() and emplace() methods of hash tables.
Instead, these methods return a pointer to the required data as they are
stored inside the hash table. The caller uses overloaded functions to
get the key and "mapped" values from this pointer. Such an interface
avoids the need for constructing iterator-like wrapper objects, which is
especially important for compound hash tables such as the future
StringHashMap.
2019-09-24 17:44:35 +03:00
robot-clickhouse
06e1a9d78e Auto version update to [19.16.1.1] [54427] 2019-09-24 14:47:32 +03:00
Alexey Milovidov
7384e04430 Revert "CHYT-142: extend KeyCondition interface so that it returns BoolMask."
This reverts commit 2cacc3cfd2.
2019-09-24 04:29:26 +03:00
alexey-milovidov
56bd02cf3a
Merge pull request #7016 from ClickHouse/yet-another-minor-changes-and-docs-for-hdfs
Cleanup hdfs docs (instead of #6876 for  #5371)
2019-09-24 02:23:59 +03:00
alexey-milovidov
e2cc551b22
Merge pull request #6914 from maqroll/master
+ Redirect URL Storage
2019-09-24 02:07:06 +03:00
Nikolai Kochetov
5108ebeece Remove Block from RangeReader. 2019-09-23 22:22:02 +03:00
Alexey Milovidov
8579c26efb Changed repository URL 2019-09-23 19:18:19 +03:00
Olga Khvostikova
a6296b2eb0
Merge branch 'master' into yet-another-minor-changes-and-docs-for-hdfs 2019-09-23 18:16:01 +03:00
stavrolia
fbe3270dfb need to mention... 2019-09-23 17:50:33 +03:00
Vladimir Chebotarev
f8c0fef919 Attempt to make table-level setting s3_min_upload_part_size. 2019-09-23 12:41:59 +00:00
maqroll
a6e7519f9d Merge remote-tracking branch 'upstream/master' 2019-09-23 07:55:07 +00:00
philip.han
613927c36c Removed useless code and improve type checking for bloom_filter index 2019-09-23 12:40:48 +09:00
Alexey Milovidov
bdea16e308 Merging S3: Moved S3 settings to <s3> in config to correspond to <merge_tree> and <kafka> 2019-09-23 01:44:10 +03:00
Alexey Milovidov
c03857b2ae Merging S3: part 2 2019-09-23 01:13:42 +03:00
alexey-milovidov
2054f80623
Merge pull request #5596 from excitoon-favorites/table_function_s3
s3 table function and storage
2019-09-23 00:53:06 +03:00
alexey-milovidov
5970aafd9a
Merge pull request #7032 from azat-archive/distributed-directory-monitor-SIGSEGV
Avoid SIGSEGV on batch send failure (file with index XX is absent)
2019-09-22 05:12:55 +03:00
Azat Khuzhin
b22b65dd29
Avoid SIGSEGV on batch send failure (file with index XX is absent)
In case of the following error:
  Failed to send batch: file with index 23742 is absent

NULL dereference will occur for the "remote".
2019-09-21 02:22:25 +03:00
Alexey Milovidov
42b739550b Renamed "storage_policy_name" to "storage_policy" 2019-09-20 23:35:50 +03:00
alexey-milovidov
123b8cb43c
Merge pull request #6990 from Akazz/timeout_for_sync_replica_cmd
Fixed timeout mechanism for SYNC REPLICA command + simplified related code
2019-09-20 20:32:51 +03:00
Ivan
cffc254922
Always read and insert Kafka messages as a whole (#6950)
* Always read and insert Kafka messages as a whole.
2019-09-20 15:12:32 +03:00
stavrolia
7309e813bc cleanup hdfs docs 2019-09-20 14:26:00 +03:00
alesapin
b289d7e6a5 Fix system contributors generating script 2019-09-19 17:41:49 +03:00
Akazz
4ae3db45c6 Fixed timeout reading in SYNC REPLICA 2019-09-19 14:04:57 +03:00
philip.han
365f61c896 Fix code-style 2019-09-19 18:24:07 +09:00
maqroll
3765084358 Proper ReadWriteBufferFromHTTP constructor args 2019-09-19 07:33:54 +00:00
Artem Zuikov
aae82eed5a
Merge pull request #6940 from 4ertus2/mjoin
PartialMergeJoin
2019-09-18 16:16:10 +03:00
root
ea5480fd72 merge
Committer: maqroll <loteroc@gmail.com>
2019-09-18 13:13:40 +00:00
CurtizJ
79a08ef8ea Merge remote-tracking branch 'upstream/master' into merging_redis 2019-09-18 12:58:22 +03:00
philip.han
b25151b61b Make bloom_filter-index support some types of Arrays. 2019-09-18 18:32:44 +09:00
Azat Khuzhin
780341060f
Replace libsparsehash with sparsehash-c11
- use sparsehash-c11 over libsparsehash
- fix typos in find_sparsehash and users of the vars (s/SPARCE/SPARSE/)
- drop libsparsehash-dev from docker images (but keep for unbunlded build)
- use ::google over GOOGLE_NAMESPACE
2019-09-18 00:08:20 +03:00
CurtizJ
df82e4bde8 fix build 2019-09-17 17:55:09 +03:00
CurtizJ
4480e97f9f fix build 2019-09-17 17:16:07 +03:00
Guillaume Tassery
acaa9cdbad Rename move partition to partition_expr to move partition to table partition_expr 2019-09-17 13:59:09 +02:00
Guillaume Tassery
713cc6c825 Add lock before every function call 2019-09-17 11:00:20 +02:00
Guillaume Tassery
3ac8f52dd8 call CloneAndLoadDataPart on database dest 2019-09-17 08:12:27 +02:00
root
5ec0005400 +UpdatableSessionBase
Committer: maqroll <loteroc@gmail.com>
2019-09-16 17:28:41 +00:00
chertus
cbd96af079 fix use after free (change Join <-> AnalyzedJoin ownership) 2019-09-16 15:37:46 +03:00
Guillaume Tassery
a47f0b1a60 cleanup partition after moving it 2019-09-16 10:56:30 +02:00
Guillaume Tassery
8920f36d96 merge master 2019-09-16 09:27:38 +02:00
Guillaume Tassery
ae8db96415 Fix move partition for storage merge tree 2019-09-16 06:17:37 +02:00
alexey-milovidov
6503369138
Merge pull request #6895 from azat-archive/distributed_directory_monitor_max_sleep_time-v2
[RFC] Drop max_sleep_time limit from StorageDistributedDirectoryMonitor
2019-09-14 18:39:27 +03:00
Nikolai Kochetov
3c53dfd227 Add processors to StorageMergeTree [WIP]. 2019-09-13 18:41:09 +03:00
Nikolai Kochetov
1f5e62d741 Added IStorage::readWithProcessors. 2019-09-13 15:59:48 +03:00
alesapin
02cff38fef Merge with master 2019-09-13 13:58:23 +03:00
Guillaume Tassery
2402e84bfc Merge branch 'master' of github.com:PerformanceVision/ClickHouse into move_partition 2019-09-13 11:20:40 +02:00
Vladimir Chebotarev
1b715069fb Merge fix. 2019-09-12 14:38:53 +00:00
Vladimir Chebotarev
599ff389f7 Merge fix. 2019-09-12 11:57:55 +00:00
Azat Khuzhin
02befdd8c2
Introduce distributed_directory_monitor_max_sleep_time_ms setting
This will replace static 30 seconds max_sleep_time for the
StorageDistributedDirectoryMonitor, since in some cases 30 seconds can
be too large.
2019-09-12 03:16:06 +03:00
alesapin
b0fce77c3d Fix path to data on disk 2019-09-11 20:17:10 +03:00
l
cdbcfc2c90 + Redirect 2019-09-11 18:39:30 +02:00
chertus
73dafaa223 better required-right-keys logic 2019-09-11 18:57:09 +03:00
Ivan Lezhankin
c5f1352394 Decide to put delimiter only after polled message 2019-09-11 16:16:43 +03:00
alesapin
0b8aec469f Make absolute path on disks start from /clickhouse/data, fix freeze and rename, add tests 2019-09-11 13:57:32 +03:00
Amos Bird
a1310ffbe6 Split libdbms.so using object library
Now the linking time of incremental builds are around 1-2 seconds
2019-09-11 01:56:01 +08:00
alesapin
34a454aa62 Remove redundant code, that caused race for part object 2019-09-10 20:17:10 +03:00
alesapin
5a45265344 Create global dir 2019-09-10 17:32:32 +03:00
alesapin
65851e27d0 Fix freeze partition 2019-09-10 16:06:26 +03:00
alesapin
ac4ab3ca2b Fix rename bug 2019-09-10 15:23:18 +03:00
alesapin
193049293a More comments, more readable code 2019-09-10 14:21:59 +03:00
alesapin
4702e40ed7 Fix bug with b_free and small refactoring 2019-09-10 11:56:27 +03:00
chertus
1b313eedfa MergeJoin in progress 2019-09-09 22:43:37 +03:00
alesapin
23f2cb5016 Remove double space 2019-09-09 20:02:52 +03:00
alesapin
189644e743 Better logging 2019-09-09 20:01:19 +03:00
Ivan
6c32fc3fc1
Store offsets manually for each message (#6872) 2019-09-09 19:59:51 +03:00
alesapin
9f88baebb9 More constants, better tests 2019-09-09 16:50:19 +03:00
alesapin
2288d25972 Add parser test 2019-09-09 15:41:46 +03:00
alesapin
ef08d6f10b More tests 2019-09-09 15:28:28 +03:00
alesapin
27419c965e Merge with master 2019-09-09 14:13:36 +03:00
alexey-milovidov
8389200229
Merge pull request #6832 from CurtizJ/merging_input_function
Merging #5450 (table function input).
2019-09-07 20:16:45 +03:00
alexey-milovidov
25de2e12a2
Merge pull request #6399 from Enmk/replica_recovery_interval
Improvements for failover of Distributed queries
2019-09-07 03:21:30 +03:00
stavrolia
f533485d19 Minor code cleanup 2019-09-06 21:29:41 +03:00
alesapin
cfd753a1f3 Add test and found bugs 2019-09-06 18:09:20 +03:00
Anton Popov
69da4f30b3
Merge branch 'master' into merging_input_function 2019-09-06 16:20:00 +03:00
alesapin
ea8e543b1a Add protocol version to cookies 2019-09-06 15:18:56 +03:00
alesapin
0c9a9dee1c Merge with master 2019-09-06 11:53:32 +03:00
Olga Khvostikova
4129d8cf60
Merge pull request #6092 from yandex/globs-in-file-one-more-attempt
Globs in storage file and HDFS
2019-09-05 23:05:37 +03:00
stavrolia
5e37510aae Better 2019-09-05 21:09:19 +03:00
alesapin
ab518d7787 Split code to parts 2019-09-05 18:53:23 +03:00
stavrolia
587a780ba2 Better 2019-09-05 17:42:17 +03:00
CurtizJ
b04cea7463 minor fixes of table function input 2019-09-05 16:17:01 +03:00
alesapin
f576cbb8a4 Simplify code 2019-09-05 16:12:29 +03:00
Vasily Nemkov
c2fc71b5e5 Post-PR fixes
Renamed settings, updated docs.
2019-09-05 13:35:36 +03:00
alesapin
b71faee8cd Merge branch 'master' into ObjatieGroba-feature_multiple_disks 2019-09-05 13:19:05 +03:00
Ivan
ab7df6b6dd
Fix kafka tests (#6805)
* Commit offsets more precisely
* Get rid of DelimitedReadBuffer since read buffers don't line up well
* Increase timeouts
2019-09-05 00:25:33 +03:00
stavrolia
5d6959173c Improvement 2019-09-04 22:55:56 +03:00
alesapin
66362cedbc Refactoring 2019-09-04 21:26:18 +03:00
alesapin
c003f443f9 Refactor 2019-09-04 20:26:53 +03:00