Commit Graph

15578 Commits

Author SHA1 Message Date
vdimir
31a6c7c1c4
Style changes around filterKeysForPartitionPruning 2023-11-20 18:08:45 +00:00
vdimir
95e9a27417
Remove ast based code from filterKeysForPartitionPruning 2023-11-20 17:59:58 +00:00
vdimir
a915eeded8
StorageS3 use filters from SourceStepWithFilter 2023-11-20 17:59:58 +00:00
vdimir
1cddfb1e6b
rewrite getBlockWithVirtuals for S3Storage 2023-11-20 17:59:57 +00:00
vdimir
cbb2e02c03
Analyzer: partition pruning for S3 2023-11-20 17:59:53 +00:00
Aleksandr Musorin
38133692bb Add total_bytes for RocksDB storage
Show total_bytes in system tables for RocksDB storage

Previously it did not work because total_rows was calculated only when optimize_trivial_approximate_count_query=1
2023-11-20 17:08:35 +01:00
Kevin Mingtarja
1d668264e1 Fix style 2023-11-20 23:54:36 +08:00
Kevin Mingtarja
d84d5692ef Enable implicit constraint for VersionedCollapsing 2023-11-20 23:52:22 +08:00
Zhiguo Zhou
be0f0b6879 Fix code style 2023-11-20 23:34:52 +08:00
kssenii
9b5e180995 Fix 2023-11-20 16:27:02 +01:00
avogar
f537bad469 Merge branch 'master' of github.com:ClickHouse/ClickHouse into schema-inference-union 2023-11-20 14:32:50 +00:00
avogar
872556a5d4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into schema-inference-union 2023-11-20 14:03:36 +00:00
Sema Checherinda
f999337dae
Revert "Revert "s3 adaptive timeouts"" 2023-11-20 14:53:22 +01:00
Alexander Tokmakov
5031f239c3
Revert "s3 adaptive timeouts" 2023-11-20 14:28:59 +01:00
Raúl Marín
8217915064 Replace part_committed_locally_but_zookeeper with retries 2023-11-20 13:55:50 +01:00
kssenii
1ade4b797b Add a comment 2023-11-20 12:48:49 +01:00
kssenii
10fb40ece9 Fix 2023-11-20 12:44:17 +01:00
alesapin
857ce2d880
Merge branch 'master' into implicit-constraint-collapsing-merged-tree 2023-11-20 12:28:55 +01:00
Raúl Marín
aadb786b2b Merge remote-tracking branch 'blessed/master' into backup_1 2023-11-20 10:53:31 +01:00
Zhiguo Zhou
1f044b11e3 Enhance unittest MergeTree.CombineFilters 2023-11-20 16:00:14 +08:00
Kevin Mingtarja
af0c954c9e Add implicit constraint for CollapsingMergeTree sign column 2023-11-20 15:05:12 +08:00
melvynator
cfdb663892 Remove a tab 2023-11-20 00:46:14 +01:00
Nikolay Degterinsky
9683adfb03
Merge pull request #56830 from evillique/better-add-column
Fix flattening existing Nested columns during ADD COLUMN
2023-11-19 16:21:56 +01:00
Sema Checherinda
a950595c24
Merge pull request #56314 from CheSema/s3-aggressive-timeouts
s3 adaptive timeouts
2023-11-19 14:12:14 +01:00
serxa
9023f61349 Merge branch 'master' into async-loader-integration 2023-11-19 13:05:58 +00:00
Alexey Milovidov
edc3b2fe48
Merge pull request #56958 from ClickHouse/metric-queued-jobs
Add metrics for the number of queued jobs, which is useful for the IO thread pool
2023-11-19 10:37:18 +01:00
jsc0218
0171d61fa5 Add MySQL Engine Filter 2023-11-19 02:34:14 +00:00
Sema Checherinda
c465933b1d
Merge pull request #56808 from CheSema/retry-fetch-part
Fetching a part waits when that part is fully committed on remote replica
2023-11-19 01:57:25 +01:00
melvynator
3ade60a261 Keep trying to fix style 2023-11-19 01:31:21 +01:00
melvynator
88b0525306 Style check 2023-11-19 01:10:25 +01:00
melvynator
5f0f9b0ad4 Test check style 2023-11-19 01:05:11 +01:00
Ubuntu
ddd9a23116 Fix newline 2023-11-19 00:02:33 +00:00
Ubuntu
89b93adf82 Fix trailing whitespace 2023-11-18 23:55:46 +00:00
Ilya Golshtein
a8abec6cac merge_row_policy: cleanup after merge 2023-11-18 21:45:17 +00:00
Antonio Andelic
274f2c71f2
Merge pull request #56460 from ClickHouse/keeper-map-backup-restore
Backup/Restore for KeeperMap tables
2023-11-18 19:27:36 +01:00
Ubuntu
16e7bd201b Add experimental flag for PostgresSQL table engine. Also add documentation on how to enable it 2023-11-18 18:22:33 +00:00
Alexey Milovidov
d56cbda185 Add metrics for the number of queued jobs, which is useful for the IO thread pool 2023-11-18 19:07:59 +01:00
Nikolay Degterinsky
a18b715591 Fix a bug 2023-11-18 15:44:45 +00:00
Raúl Marín
210a0ee045 Merge remote-tracking branch 'blessed/master' into backup_1 2023-11-17 18:50:24 +01:00
Sema Checherinda
29e64347b9 improve exception message 2023-11-17 17:37:14 +01:00
jsc0218
5b20118c66 Fix Typo 2023-11-17 14:55:36 +00:00
jsc0218
fb96f65904 Fix Style 2023-11-17 14:15:33 +00:00
Raúl Marín
3633e77a37 Refactor ZooKeeperWithFaultInjection 2023-11-17 12:57:32 +01:00
Sema Checherinda
86119dbc3f fix data race 2023-11-17 12:26:50 +01:00
Kseniia Sumarokova
3322f54713
Merge branch 'master' into remove-unused-code 2023-11-17 11:55:02 +01:00
Antonio Andelic
9bcedf3764 Cleanup 2023-11-17 10:27:19 +00:00
Antonio Andelic
803d9668e2 Merge branch 'master' into keeper-map-backup-restore 2023-11-17 10:11:59 +00:00
Ilya Golshtein
9eeae568e4 Merge remote-tracking branch 'origin/master' into merge_row_policy
merge_row_policy: changes because of refactoring in master
2023-11-17 09:19:56 +00:00
Aleksei Filatov
163b8a814e Fix clang-tidy issues and disable parallel execution of tests 2023-11-17 11:02:07 +03:00
jsc0218
bd5a715244 Fix Style 2023-11-17 03:26:36 +00:00
jsc0218
4c73b870b4 Fix the Error by Only Filter PostgreSQL 2023-11-17 03:01:25 +00:00
Alexey Milovidov
482d8ca9d8
Merge pull request #56102 from ClickHouse/coverage
Granular code coverage with introspection
2023-11-16 23:23:40 +01:00
Alexander Tokmakov
dfd606ef7e
Update StorageReplicatedMergeTree.cpp 2023-11-16 20:53:45 +01:00
Nikolai Kochetov
ca6de31ce5
Merge pull request #56695 from ClickHouse/table-function-input-in-subquery
Fix duplicate usage of table function input().
2023-11-16 20:48:10 +01:00
Kseniia Sumarokova
a28d541ba5
Merge branch 'master' into remove-unused-code 2023-11-16 17:17:51 +01:00
Raúl Marín
19931fee67 Prepare the introduction of more keeper faults 2023-11-16 15:46:39 +01:00
Sema Checherinda
ddca2c2187 server side waiting 2023-11-16 15:44:14 +01:00
Robert Schulze
ed052d76e6
Merge pull request #56141 from zvonand/zvonand-more-globs
Performance enhancement for File, HDFS globs
2023-11-16 14:09:22 +01:00
alesapin
ddcfecacc2
Merge pull request #56000 from evillique/fix-replica-already-exists-storage
Fix `REPLICA_ALREADY_EXISTS` for ReplicatedMergeTree
2023-11-16 12:51:50 +01:00
alesapin
437a911d7b
Merge pull request #56809 from ClickHouse/add_async_moves_execution
Implement asynchronous execute of `ALTER TABLE ... MOVE ... TO DISK|VOLUME`
2023-11-16 12:47:31 +01:00
Antonio Andelic
203f83c2c2 Merge branch 'master' into keeper-map-backup-restore 2023-11-16 11:31:11 +00:00
Aleksei Filatov
21a17f8334 Add cancellation hook for moving background operation 2023-11-16 13:37:51 +03:00
Andrey Zvonov
fc15b0c1e7
Merge branch 'ClickHouse:master' into zvonand-more-globs 2023-11-16 11:19:12 +01:00
Antonio Andelic
352eca7aa0
Merge pull request #56789 from ClickHouse/fix-no-user
Try fix `No user in current context, it's a bug`
2023-11-16 08:20:52 +01:00
Nikolay Degterinsky
7623153d38 Fix flattening existing Nested columns during ADD COLUMN 2023-11-16 07:01:49 +00:00
zvonand
4ff82528f1 small fixes after review 2023-11-16 00:01:36 +01:00
Alexander Tokmakov
c529e64768 Merge branch 'master' into rmt_check_shutdown_flags_in_retry_loops 2023-11-15 23:40:22 +01:00
zvonand
cb74f27b00 Merge branch 'master' of github.com:ClickHouse/ClickHouse into zvonand-more-globs 2023-11-15 21:56:51 +01:00
jsc0218
0d2acf9eec Able to Filter Engine When Scanning System Tables 2023-11-15 20:30:36 +00:00
Sema Checherinda
f3f8392051 upgrade replication protocol 2023-11-15 19:03:55 +01:00
avogar
28522d56b7 Support Iceberg metadata files for metastore tables 2023-11-15 17:45:07 +00:00
Alexander Sapin
3e26161eaa Implement asynchronous excute of ALTER TABLE ... MOVE ... TO DISK|VOLUME 2023-11-15 18:33:59 +01:00
Nikolay Degterinsky
57aa049fef Change table name to table UUID, fix test 2023-11-15 16:21:13 +00:00
Alexander Tokmakov
bf10989515
Fix unexpected parts handling (#56693)
* fix unexpected parts handling

* Automatic style fix

* fix

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2023-11-15 16:54:47 +01:00
zvonand
a8aa206cfd Update after review
expandSelector is now returning vector<string> directly
minor changes
2023-11-15 16:37:24 +01:00
zvonand
70aa6e2672 Added a shortcut for no-wildcard globs in HDFS 2023-11-15 16:37:24 +01:00
zvonand
3e47a54a94 Added a shortcut for no-wildcard globs in file storage 2023-11-15 16:37:24 +01:00
Antonio Andelic
5c4e58d27d Try fix No user 2023-11-15 15:14:46 +00:00
Nikolai Kochetov
62378b4219 Fixing style. 2023-11-15 13:56:51 +00:00
Nikolai Kochetov
6ef5c4cafe
Merge pull request #56522 from kitaisreal/analyzer-support-explain-estimate
Analyzer support EXPLAIN ESTIMATE
2023-11-15 13:17:31 +01:00
Antonio Andelic
d567e718eb Merge branch 'master' into keeper-map-backup-restore 2023-11-15 11:51:27 +00:00
serxa
bd66ac483c Load queries for dashboard page from new system.dashboards table 2023-11-14 23:03:06 +00:00
Nikolai Kochetov
1356dc2eaa Fixing style. 2023-11-14 14:55:21 +00:00
Sema Checherinda
b9cc1580e0
Merge pull request #56367 from canhld94/ch_table_reinit_new_disk
Adding new disk to storage configuration without restart
2023-11-14 15:54:22 +01:00
Nikolai Kochetov
d5907e10de Fixing tests. 2023-11-14 12:51:25 +00:00
Ilya Golshtein
3e6a5d8208 merge_row_policy: some comments 2023-11-14 12:22:32 +00:00
Kseniia Sumarokova
0676c09d72
Merge branch 'master' into remove-unused-code 2023-11-14 11:59:53 +01:00
Sema Checherinda
8d36fd6e54 get rid off of client_with_long_timeout_ptr 2023-11-14 11:34:12 +01:00
Sema Checherinda
27fb25d056 alter the naming, fix client_with_long_timeout in s3 storage 2023-11-14 11:34:12 +01:00
Robert Schulze
2931bbfe62
Merge pull request #56665 from rschu1ze/refactor-ast-hash-calculation
Small refactoring of AST hash calculation (follow-up to #56545)
2023-11-14 11:24:30 +01:00
Antonio Andelic
29f54db917 Merge branch 'master' into keeper-map-backup-restore 2023-11-14 09:47:54 +00:00
Alexander Gololobov
80ca41f18d
Merge pull request #56420 from ClickHouse/system_replicas_with_many_tables
Optimizations for system.replicas with many tables
2023-11-14 10:23:48 +01:00
Duc Canh Le
3152cd25dc only check for exact column definitions in replicated merge tree
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-11-14 07:41:45 +00:00
Duc Canh Le
57b160b6b9 compare type name in column description
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-11-14 07:12:12 +00:00
Alexey Milovidov
3ef14f6098 Merge branch 'master' of github.com:ClickHouse/ClickHouse into coverage 2023-11-14 06:08:32 +01:00
Nikolai Kochetov
4004248c13 Fix duplicate usage of table function input(). 2023-11-13 19:01:36 +00:00
Alexey Milovidov
c81cc3f953
Merge pull request #56660 from ClickHouse/better-ccache-2
Better use of build cache
2023-11-13 19:28:33 +01:00
Alexander Gololobov
b49f50bf47 Set DB:Exception on unscheduled requests 2023-11-13 17:53:38 +01:00
Alexander Gololobov
6e861a6176 Handle query cancellation 2023-11-13 17:53:38 +01:00
Alexander Gololobov
1113b3041b Return exception from the job 2023-11-13 17:53:38 +01:00
Alexander Gololobov
c27913f09a Separate thread pools for request with and w/o zk 2023-11-13 17:53:38 +01:00
Alexander Gololobov
45f5d28299 Deduplicate concurrent requests in system.replicas 2023-11-13 17:53:38 +01:00
Nikolay Degterinsky
b8cba418e3
Merge pull request #56493 from evillique/fix-alter-column-alias
Fix ALTER COLUMN with ALIAS
2023-11-13 17:48:06 +01:00
Robert Schulze
d6df7d8403
Merge remote-tracking branch 'rschu1ze/master' into refactor-ast-hash-calculation 2023-11-13 15:54:21 +00:00
Antonio Andelic
9e91e4d671 Define BackupReferenceEntry 2023-11-13 14:43:02 +00:00
Sema Checherinda
7f3a082c0e
Merge pull request #56456 from ucasfl/fix-mysql
Fix transfer query to MySQL compatible query
2023-11-13 15:25:58 +01:00
kssenii
876b2cd7bc Remove unused code 2023-11-13 15:10:57 +01:00
Antonio Andelic
59480205d4 Merge branch 'master' into keeper-map-backup-restore 2023-11-13 12:21:26 +00:00
Alexey Milovidov
7a489059ac
Merge pull request #56350 from ClickHouse/system-symbols
Remove garbage.
2023-11-13 12:25:18 +01:00
Robert Schulze
50cd59a72b
Remove default value for argument 'ignore_aliases' from IAST::getTreeHash() 2023-11-13 10:27:38 +00:00
Alexey Milovidov
8e820185cb Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-ccache-2 2023-11-13 11:17:18 +01:00
Alexey Milovidov
82c461031e Fix build 2023-11-13 10:09:23 +01:00
Kseniia Sumarokova
b7915e6983
Merge pull request #55782 from aiven-sal/aiven-sal/namedcoll_pr
NamedCollections: prevent fields overriding in functions' calls
2023-11-13 09:07:09 +01:00
Alexey Milovidov
58319f08be Merge branch 'master' into system-symbols 2023-11-11 04:12:37 +01:00
Alexey Milovidov
fcd45d47e4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-cpp-templates-2 2023-11-11 03:45:54 +01:00
Alexey Milovidov
c095b1e9ef
Merge pull request #56502 from amosbird/fix-56481
Fix two cases of projection analysis.
2023-11-11 02:29:04 +01:00
Alexey Milovidov
3bec4dce8e Merge branch 'master' into remove-cpp-templates-2 2023-11-11 00:50:32 +01:00
Maksim Kita
bf08f3ef5a
Revert "Inserting only non-duplicate chunks in MV" 2023-11-10 21:21:13 +03:00
Kseniia Sumarokova
2709ecd50d
Merge pull request #56457 from ClickHouse/fix-test-database-hdfs
Fix test `02725_database_hdfs.sh`
2023-11-10 11:40:18 +01:00
Kseniia Sumarokova
e48df94772
Merge pull request #56377 from ClickHouse/minor-improvements-for-s3-queue
Minor improvements for S3Queue
2023-11-10 11:28:09 +01:00
Antonio Andelic
5fea9f9dc6 Small fixes 2023-11-10 09:27:26 +00:00
Alexey Milovidov
e5df9de12b Merge branch 'remove-cpp-templates-2' into system-symbols 2023-11-10 05:28:45 +01:00
Alexey Milovidov
8c253b9e3e Remove C++ templates 2023-11-10 05:25:02 +01:00
Amos Bird
16578d97a3
Fix two cases of projection analysis.
1. Fix projection analysis with partitions.
2. Apply alter conversions during projection analysis.
2023-11-10 10:23:02 +08:00
Alexey Milovidov
29b75d034a Fix FreeBSD 2023-11-09 23:43:12 +01:00
Alexey Milovidov
2c220ba5ec Fix FreeBSD 2023-11-09 23:43:12 +01:00
Alexey Milovidov
84ada59e42 Fix FreeBSD 2023-11-09 23:43:12 +01:00
Alexey Milovidov
8f67894157 Add table system.symbols 2023-11-09 23:43:12 +01:00
Alexey Milovidov
cc39484f7f Merge branch 'master' into system-symbols 2023-11-09 23:05:55 +01:00
Maksim Kita
6fb7d44b62 Analyzer support EXPLAIN ESTIMATE 2023-11-09 19:43:14 +03:00
Salvatore Mesoraca
178f2bbee5
Fix format 2023-11-09 17:25:20 +01:00
Salvatore Mesoraca
1174689f8b
Refactoring 2023-11-09 17:25:20 +01:00
Salvatore Mesoraca
b8e478195f
Simplify code 2023-11-09 17:25:19 +01:00
Salvatore Mesoraca
52e49f4ce3
Add explanatory comments 2023-11-09 17:25:19 +01:00
Salvatore Mesoraca
45e4e122fe
Update src/Common/NamedCollections/NamedCollections.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-11-09 17:25:19 +01:00
Salvatore Mesoraca
7d206cbc3c
NamedCollections: prevent fields overriding in functions call
Add syntax in SQL and XML to mark specific fields to allow
override or not.
Also add a new setting to control the default behaviour when
overriding support is not specified.
2023-11-09 17:25:16 +01:00
Antonio Andelic
f9895ab37b Small fixes and add test 2023-11-09 15:56:57 +00:00
Alexander Tokmakov
113add2556 rmt: check shutdown flags in retry loops 2023-11-09 16:41:01 +01:00
Nikolai Kochetov
c643069b0d
Merge pull request #54905 from nickitat/fix_key_analysis_merge_engine
Fix key analysis (with set) for `Merge` engine
2023-11-09 14:52:54 +01:00
Kseniia Sumarokova
49f9b6d340
Merge pull request #56260 from joelynch/delta-lake-repeated-add
deltalake: Do not raise errors when processing add and remove actions
2023-11-09 13:15:31 +01:00
Kseniia Sumarokova
0760e69e54
Merge pull request #56312 from ClickHouse/parallelize-backup-entries-collector
Parallelize `BackupEntriesCollector`
2023-11-09 13:07:48 +01:00
Kseniia Sumarokova
a9d8e4170f
Merge pull request #56387 from ClickHouse/fix-backup-of-mv-with-no-inner-table
Allow backup of mat view with dropped inner table instead of failing the backup
2023-11-09 13:02:41 +01:00
Nikolai Kochetov
f7e7089bc9
Merge pull request #56391 from ClickHouse/rocks-db-analyzer
Fix rocksdb with analyzer.
2023-11-09 12:48:18 +01:00
Nikolay Degterinsky
4ac3dcc417 Fix ALTER COLUMN with ALIAS 2023-11-09 07:07:41 +00:00
flynn
41cdd5dd1a Fix 2023-11-09 06:23:23 +00:00
Ilya Golshtein
9c5f9f7dcb merge_row_policy: style fix, cleanup 2023-11-09 00:51:57 +03:00
Ilya Golshtein
f1af83447e merge_row_policy: cleanup, traces removed 2023-11-08 23:07:08 +03:00
Alexander Gololobov
517a184d5a
Make IMergeTreeDataPart::getState() inlinable (#56461) 2023-11-08 20:30:45 +01:00
flynn
4e263956e0 Merge branch 'fix-mysql' of github.com:ucasfl/ClickHouse into fix-mysql 2023-11-08 16:22:16 +00:00
flynn
ca18674f1a update test 2023-11-08 16:21:16 +00:00
Alexey Milovidov
68d3f60ef7 Merge branch 'master' into system-symbols 2023-11-08 17:07:11 +01:00
Ilya Golshtein
6e189b17c0 merge_row_policy: processAliases introduced 2023-11-08 18:55:19 +03:00
flynn
d0ba561faa
Update src/Storages/transformQueryForExternalDatabase.cpp
Co-authored-by: Sema Checherinda <104093494+CheSema@users.noreply.github.com>
2023-11-08 23:20:12 +08:00
Antonio Andelic
4438c2f70a Remove unnecassary log 2023-11-08 14:36:39 +00:00
Antonio Andelic
1f000242a1 Merge branch 'master' into keeper-map-backup-restore 2023-11-08 13:16:47 +00:00
Antonio Andelic
18a5eeec38 Make on cluster backup/restore work 2023-11-08 13:16:38 +00:00
kssenii
a5b9ba51cd Better test 2023-11-08 12:55:14 +01:00
flynn
399d61b222 Fix transfer query to MySQL compatible query 2023-11-08 11:34:49 +00:00
kssenii
dfcc94fff0 Fix test 2023-11-08 12:29:40 +01:00
Antonio Andelic
86ba6ad1e8 Local backup and restore 2023-11-08 10:22:44 +00:00
Alexey Milovidov
ca83da14f2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into system-symbols 2023-11-07 19:43:19 +01:00
slvrtrn
f663228404 Add information_schema.statistics 2023-11-07 18:59:45 +01:00
kssenii
15517d04df Fix 2023-11-07 18:02:44 +01:00
kssenii
70048236f3 Add ProfileEvents column to system.backups 2023-11-07 17:32:08 +01:00
kssenii
9dce1a52e1 Review fix 2023-11-07 16:31:41 +01:00
Alexey Milovidov
5169e4e54d Fix FreeBSD 2023-11-07 15:30:31 +01:00
Alexander Tokmakov
706f2dcf54
Add a metric for suspicious parts in ZooKeeper (#56395) 2023-11-07 12:55:57 +01:00
Nikolai Kochetov
c58c583043 Fix tests. 2023-11-07 11:43:16 +00:00
Nikita Mikhaylov
0555f8a68c
Fix crash in case of adding a column with type Object(JSON) (#56307) 2023-11-07 12:01:52 +01:00
serxa
19aa1375fc Merge branch 'master' into async-loader-integration 2023-11-07 10:25:38 +00:00
Nikita Mikhaylov
b696540a5a
Merge branch 'master' into rocks-db-analyzer 2023-11-07 00:44:49 +01:00
Vitaly Baranov
1f4697fbb7
Merge pull request #56339 from vitlibar/fix-using-table-shared-id-during-backup-and-improve-logs
Fix using table shared id during backup and improve logs.
2023-11-07 00:04:59 +01:00
Alexey Milovidov
9e6dee93f3 Fix FreeBSD 2023-11-06 23:26:11 +01:00
Alexander Tokmakov
cf6ab2e110
Merge pull request #56282 from ClickHouse/fix_unexpected_parts_after_truncate
Fix unexpected parts after drop range
2023-11-06 21:03:57 +01:00
Nikolai Kochetov
34fdb8a7c6 Fix rocksdb with analyzer. 2023-11-06 18:46:39 +00:00
kssenii
7883a74f6d Fix 2023-11-06 19:05:12 +01:00
Sema Checherinda
a5e17dc919
Merge pull request #55566 from CheSema/remote-blobs-naming
feature: storage_metadata_write_full_object_key
2023-11-06 16:41:49 +01:00
Alexey Milovidov
66b180d751 Fix FreeBSD 2023-11-06 16:31:02 +01:00
kssenii
f2c0434c4d Merge remote-tracking branch 'origin/master' into minor-improvements-for-s3-queue 2023-11-06 15:51:11 +01:00
kssenii
8db2aca832 Add a test 2023-11-06 15:48:04 +01:00
kssenii
da21413354 Better shutdown 2023-11-06 15:47:57 +01:00
kssenii
9952261a59 Add missing write to s3queue_log, pass cached FileStatus 2023-11-06 15:47:45 +01:00
Alexander Tokmakov
13599ff462 review fixes 2023-11-06 15:31:54 +01:00
Alexander Tokmakov
eba52b318d
Merge pull request #56272 from ClickHouse/rdb_fix_rare_logical_error
Fix rare logical error in Replicated database
2023-11-06 14:14:55 +01:00
Ilya Golshtein
d900f8a352 merge_row_policy: aliases slightly work 2023-11-06 15:18:25 +03:00
Sema Checherinda
52850d5a45
Update StorageSystemRemoteDataPaths.cpp 2023-11-06 11:45:17 +01:00
Kseniia Sumarokova
a050cdd897
Merge branch 'master' into delta-lake-repeated-add 2023-11-06 11:30:58 +01:00
Duc Canh Le
4c21ba7b6f tables auto initialize new disks without restart
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-11-06 10:26:48 +00:00
Alexey Milovidov
99fe7a46fc Minor changes 2023-11-06 01:12:13 +01:00
Alexey Milovidov
8182d51978 Add table system.symbols 2023-11-06 01:11:53 +01:00
Vitaly Baranov
1e89e7a6b2 Fix using table shared id during backup and improve logs. 2023-11-05 09:38:08 +01:00
Igor Nikonov
9bdcba1b20
Merge branch 'master' into pr-progress-bar 2023-11-05 00:09:46 +01:00
Alexander Tokmakov
155bdfcf0d fix 2023-11-04 22:50:19 +01:00
Alexey Milovidov
cd94d02455 Merge branch 'master' into coverage 2023-11-04 21:49:59 +01:00
Arthur Passos
b6e205dcdf
Add ClickHouse setting to disable tunneling for HTTPS requests over HTTP proxy (#55033)
* initial commit. integ tests passing, need to re-run unit & my own personal tests

* partial refactoring to remove Protocol::ANY

* improve naming

* remove all usages of ProxyConfiguration::Protocol::ANY

* fix ut

* blabla

* support url functions as well

* support for HTTPS requests over HTTP proxy with tunneling off

* remove gtestabc

* fix silly mistake

* ...

* remove usages of httpclientsession::proxyconfig in src/

* got you

* remove stale comment

* it seems like I need reasonable defaults

* fix ut

* add some comments

* remove no longer needed header

* matrix out

* add https over http proxy with no tunneling

* soem docs

* partial refactoring

* rename to use_tunneling_for_https_requests_over_http_proxy

* improve docs

* use shorter version

* remove useless test

* rename the setting

* update

* fix typo

* fix setting docs typo

* move ); up

* move ) up
2023-11-04 13:47:52 -04:00
Alexander Tokmakov
9acd3707cb fix tests 2023-11-04 15:44:55 +01:00
Nikita Taranov
26d3a3a1e0
Add assertion that SizePredictor is set if preferred_block_size_bytes is set (#56302)
* Test

* fix
2023-11-03 23:13:18 +01:00
alesapin
f69796471c
Merge pull request #56303 from ClickHouse/fix_obscure_segfault
Fix rare race condition related to Memory allocation failure
2023-11-03 23:00:11 +01:00
Alexander Tokmakov
a44e27b0dc fix 2023-11-03 22:28:10 +01:00
Nikita Mikhaylov
000d6cd7e5
Merge pull request #56234 from evillique/fix-suggestions
Fix client suggestions for user without grants
2023-11-03 17:55:51 +01:00
Alexander Sapin
3b212a2593 Reserver in advance 2023-11-03 16:53:52 +01:00
Alexander Sapin
a0a0dd02d5 Fix typo everywhere 2023-11-03 16:40:50 +01:00
Alexander Sapin
c3dcb81a62 Fix race condition in case of memory errors 2023-11-03 16:00:16 +01:00
Alexander Sapin
a9ffb9808e Merge branch 'master' into fix_obscure_segfault 2023-11-03 12:20:52 +01:00
Kseniia Sumarokova
31ae602d37
Merge pull request #56131 from ClickHouse/backup-some-more-retries
Add missing zookeeper retries in StorageReplicatedMergeTree::backupData
2023-11-03 12:00:41 +01:00
Alexander Tokmakov
b50c4c9f3b fix 2023-11-03 11:24:10 +01:00
vdimir
86524fce0f
Merge pull request #56246 from ClickHouse/vdimir/analyzer_01019_alter_materialized_view
Analyzer: fix 01019_alter_materialized_view_consistent
2023-11-03 11:04:14 +01:00
vdimir
a70d0c5203
Merge pull request #56264 from azat/rocksdb/block-based-table-options
Add ability to specify BlockBasedTableOptions for rocksdb
2023-11-03 10:15:19 +01:00
vdimir
55a1baf029
Merge pull request #56022 from ClickHouse/vdimir/check_all_tables
Add CHECK query for all the tables
2023-11-03 10:10:42 +01:00
Alexander Tokmakov
480e58b427 fix unexpected parts after drop range 2023-11-03 01:47:50 +01:00
alesapin
2daff2d41e Fxi 2023-11-03 00:32:07 +01:00
Alexey Milovidov
b400a6682e
Merge pull request #56275 from ClickHouse/23.11-prepare
Update version after release
2023-11-02 20:20:03 +01:00
Alexey Milovidov
1348d4c696 Update autogenerated version to 23.11.1.1 and contributors 2023-11-02 20:18:15 +01:00
Alexander Tokmakov
e88fa10aa2
Merge pull request #56142 from ClickHouse/make_replicated_start_more_robust
Better process broken parts on table start for replicated tables
2023-11-02 20:11:22 +01:00
Alexander Tokmakov
0ce1560e5d retry if table replica being restarted 2023-11-02 18:30:32 +01:00
serxa
e97edf5285 Merge branch 'master' into async-loader-integration 2023-11-02 14:56:32 +00:00
Robert Schulze
99dd3ed060
Merge pull request #56226 from HarryLeeIBM/hlee-ftsearch-compress
Add compression of posting lists for inverted index
2023-11-02 15:56:30 +01:00
Azat Khuzhin
decf85baca Add ability to specify BlockBasedTableOptions for rocksdb
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-02 15:36:00 +01:00
Sema Checherinda
90b64bcdb9 backward compatibility and implementation feature storage_metadata_write_full_object_key 2023-11-02 15:20:55 +01:00
kssenii
d0bc77f084 Fxi 2023-11-02 14:45:15 +01:00
Joe Lynch
67e29d5eb9
Allow repeated adds and removes for delta lake files 2023-11-02 13:40:50 +01:00
alesapin
3ba12b6e3e
Merge pull request #56238 from evillique/remove-less-parts
Do not remove part if `Too many open files` is thrown
2023-11-02 12:33:02 +01:00
Alexey Milovidov
1267246785
Merge pull request #55642 from ClickHouse/morton-utils
Indexing by space-filling curves
2023-11-02 12:21:33 +01:00
alesapin
5c4915e264
Update src/Storages/MergeTree/MergeTreePartInfo.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-11-02 12:02:04 +01:00
alesapin
7917a2cb40
Update src/Storages/MergeTree/MergeTreePartInfo.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-11-02 12:01:58 +01:00
alesapin
800f2f097c
Update src/Storages/MergeTree/MergeTreePartInfo.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-11-02 12:01:51 +01:00
alesapin
81b93ef12b
Update src/Storages/MergeTree/MergeTreePartInfo.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-11-02 12:01:46 +01:00
vdimir
5703e0995b
Analyzer: fix 01019_alter_materialized_view_consistent 2023-11-02 10:27:22 +00:00
Nikolay Degterinsky
0d6a0d04ae Do not remove parts if 'Too many open files' is thrown 2023-11-02 05:01:53 +00:00
Nikolay Degterinsky
f93c032425 Fix suggestions for user without grants 2023-11-02 03:56:59 +00:00
Nikolay Degterinsky
1af52d3b00 Better 2023-11-02 00:42:57 +00:00
Igor Nikonov
823b62a55c
Merge pull request #56162 from ClickHouse/part-check-scheduling-monotonic-time
Use monotonic clock for part check scheduling
2023-11-01 23:15:27 +01:00
Azat Khuzhin
09c1e76982 Allow manual compaction of rocksdb via OPTIMIZE query
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-01 22:27:11 +01:00
HarryLeeIBM
013e4b40c6 Add compression of posting lists for inverted index 2023-11-01 14:14:38 -07:00
Igor Nikonov
447386edd9
Merge branch 'master' into fix-schedule-delayed-part-checks 2023-11-01 21:26:06 +01:00
Duc Canh Le
7d4c97e8f3
print broken part path before throw (#56181)
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-11-01 19:11:23 +01:00
Alexander Sapin
1e0cab93f6 Satisfy tidy 2023-11-01 16:51:20 +01:00
Alexander Sapin
bfcd8b7de5 Better logging and tests 2023-11-01 16:50:02 +01:00
Azat Khuzhin
c25d6cd624
Rename directory monitor concept into background INSERT (#55978)
* Limit log frequence for "Skipping send data over distributed table" message

After SYSTEM STOP DISTRIBUTED SENDS it will constantly print this
message.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename directory monitor concept into async INSERT

Rename the following query settings (with preserving backward
compatiblity, by keeping old name as an alias):
- distributed_directory_monitor_sleep_time_ms -> distributed_async_insert_sleep_time_ms
- distributed_directory_monitor_max_sleep_time_ms -> distributed_async_insert_max_sleep_time_ms
- distributed_directory_monitor_batch -> distributed_async_insert_batch_inserts
- distributed_directory_monitor_split_batch_on_failure -> distributed_async_insert_split_batch_on_failure

Rename the following table settings (with preserving backward
compatiblity, by keeping old name as an alias):
- monitor_batch_inserts -> async_insert_batch
- monitor_split_batch_on_failure -> async_insert_split_batch_on_failure
- directory_monitor_sleep_time_ms -> async_insert_sleep_time_ms
- directory_monitor_max_sleep_time_ms -> async_insert_max_sleep_time_ms

And also update all the references:

    $ gg -e directory_monitor_ -e monitor_ tests docs | cut -d: -f1 | sort -u | xargs sed -e 's/distributed_directory_monitor_sleep_time_ms/distributed_async_insert_sleep_time_ms/g' -e 's/distributed_directory_monitor_max_sleep_time_ms/distributed_async_insert_max_sleep_time_ms/g' -e 's/distributed_directory_monitor_batch_inserts/distributed_async_insert_batch/g' -e 's/distributed_directory_monitor_split_batch_on_failure/distributed_async_insert_split_batch_on_failure/g' -e 's/monitor_batch_inserts/async_insert_batch/g' -e 's/monitor_split_batch_on_failure/async_insert_split_batch_on_failure/g' -e 's/monitor_sleep_time_ms/async_insert_sleep_time_ms/g' -e 's/monitor_max_sleep_time_ms/async_insert_max_sleep_time_ms/g' -i

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename async_insert for Distributed into background_insert

This will avoid amigibuity between general async INSERT's and INSERT
into Distributed, which are indeed background, so new term express it
even better.

Mostly done with:

    $ git di HEAD^ --name-only | xargs sed -i -e 's/distributed_async_insert/distributed_background_insert/g' -e 's/async_insert_batch/background_insert_batch/g' -e 's/async_insert_split_batch_on_failure/background_insert_split_batch_on_failure/g' -e 's/async_insert_sleep_time_ms/background_insert_sleep_time_ms/g' -e 's/async_insert_max_sleep_time_ms/background_insert_max_sleep_time_ms/g'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Mark 02417_opentelemetry_insert_on_distributed_table as long

CI: https://s3.amazonaws.com/clickhouse-test-reports/55978/7a6abb03a0b507e29e999cb7e04f246a119c6f28/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-01 15:09:39 +01:00
Alexander Tokmakov
65f3cf81dc
Merge pull request #55987 from ClickHouse/fix_lost_part_count
Avoid counting lost parts twice
2023-11-01 15:07:27 +01:00
Kruglov Pavel
5533258091
Merge pull request #55477 from Avogar/streaming-errors
Allow to save unparsed records and errors in RabbitMQ, NATS and FileLog engines
2023-11-01 14:35:35 +01:00
vdimir
2ca1a14ac4
Merge pull request #55741 from ClickHouse/vdimir/fix_analyzer_materialized_distributed_join
Analyzer: fix block stucture mismatch in matview with engine distributed
2023-11-01 14:16:33 +01:00
Kseniia Sumarokova
4510014014
Update StorageReplicatedMergeTree.cpp 2023-11-01 14:05:12 +01:00
Kseniia Sumarokova
c300297153
Fix style check 2023-11-01 13:27:38 +01:00
Alexander Sapin
b4328ad8dc Fix stupid bug 2023-11-01 13:06:19 +01:00
kssenii
68fd273114 Better 2023-11-01 11:18:58 +01:00
Zhiguo Zhou
b66a9e8fd3 Optimize DB::combineFilters with AVX512_VBMI2 intrinsic
The DB::combineFilters combines two UInt8 columns (filters) by
scanning the first column for non-zero elements and replacing them
with elements in the second column contiguously.

This function is optimized with Intel's AVX512_VBMI2 intrinsic,
_mm512_mask_expandloadu_epi8, which is designed for implementing
the exact operation when the bits in the writemask are set when
the corresponding packed integers in the first filter are non-zero,
and are not set otherwise. The dynamic dispatch ensures that this
optimization only applies to devices with AVX512_VBMI2 support.
2023-11-01 17:14:40 +08:00
Zhiguo Zhou
1ae951efc2 Add unittest MergeTree.CombineFilters
This commit adds a unittest for validating DB::combineFilters.
2023-11-01 17:14:40 +08:00
jsc0218
f1c7665feb
Merge pull request #56121 from lithiumlabcompany/fix-auto-configuration-queue-for-librdkafka
Correctly set queued.min.messages
2023-10-31 19:59:04 -04:00
Michael Kolupaev
9c79c165b9
Re-fix 'Block structure mismatch' on concurrent ALTER and INSERTs in Buffer table (#56140)
* Fix 'Block structure mismatch' on concurrent ALTER and INSERTs in Buffer table

* Fix the test
2023-10-31 13:41:54 -07:00
Alexander Sapin
3a1182f6c0 Proper implementation 2023-10-31 18:53:33 +01:00
kssenii
ae1a7fffec Fix 2023-10-31 16:19:08 +01:00
Alexander Tokmakov
f39f0c6a74
Merge pull request #56083 from ClickHouse/fix_drop_range_commit_existing_part_race
Fix race condition between DROP_RANGE and committing existing block
2023-10-31 14:24:53 +01:00
Alexander Sapin
f4081e3f85 Merge branch 'master' into make_replicated_start_more_robust 2023-10-31 14:16:39 +01:00
Alexander Tokmakov
4d437ca462
Merge pull request #56137 from ClickHouse/fix_unexpected_parts_handling
Do not try to activate covered parts when handilng unexpected parts
2023-10-31 14:00:47 +01:00
Azat Khuzhin
11b00e92fd Add more details to "Data after merge is not byte-identical to data on another replicas"
It should be a very rare error, but in case of error you need as much
details as there are:
- print mismatched info (hash, size)
- print all files with size and checksum (this may help for instance
  when new file is added, or when extesion changed -- compression marks)

P.S. maybe detach_not_byte_identical_parts should be enabled by default?
Thoughts?

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-31 12:31:27 +01:00
Igor Nikonov
f8a7bdb8f0 Use monotonic time for part checks scheduling 2023-10-31 11:21:20 +00:00
Alexey Milovidov
016285ea87
Merge branch 'master' into morton-utils 2023-10-31 01:47:16 +01:00
Han Fei
1237cef26d address comments 2023-10-31 00:53:46 +01:00
alesapin
20b8954872 Better process broken parts on table start for replicated tables 2023-10-30 23:16:04 +01:00
avogar
7eefb72c53 Merge branch 'master' of github.com:ClickHouse/ClickHouse into schema-inference-union 2023-10-30 19:44:26 +00:00
Alexander Tokmakov
373d8bbb20 do not try to activate covered parts 2023-10-30 20:17:10 +01:00
Igor Nikonov
0958d0b168 Fix style 2023-10-30 16:35:00 +00:00
Nikolai Kochetov
cc3c038394 Fixing test. 2023-10-30 16:29:22 +00:00
kssenii
6fc4c8d332 Add retries 2023-10-30 17:20:17 +01:00
Alexander Tokmakov
ae8d7a557b
Update ReplicatedMergeTreeSink.cpp 2023-10-30 15:43:48 +01:00
Alexander Tokmakov
073a6a6f0e
Update src/Storages/StorageReplicatedMergeTree.cpp
Co-authored-by: Raúl Marín <git@rmr.ninja>
2023-10-30 15:33:35 +01:00
Alexander Tokmakov
6635b84a46 fixes 2023-10-30 15:20:04 +01:00
Igor Nikonov
f2acc366f7 Fix: schedule delayed part checks correctly 2023-10-30 12:57:43 +00:00
Nikolai Kochetov
554ceb4e1d Merge branch 'master' into planner-prepare-filters-for-analysis-2 2023-10-30 11:56:30 +01:00
Stas Morozov
5a922014f7
Avoid problem with configuration queued.min.messages automatically for Kafka storage 2023-10-30 13:53:52 +03:00
avogar
9eb498b48d Fix tests for HDFS 2023-10-30 10:50:05 +00:00
Kruglov Pavel
e22cfa3d5b
Remove unneeded changge 2023-10-30 11:35:44 +01:00
Kruglov Pavel
53b6a455fc
Remove unused field from .h file 2023-10-30 11:35:09 +01:00
Kruglov Pavel
ba736beaf2
Remove unused field 2023-10-30 11:34:42 +01:00
Han Fei
19cdc6dfe2 Merge branch 'master' into hanfei/statistic 2023-10-30 04:53:18 +01:00
Alexey Milovidov
3631e476eb
Merge pull request #54947 from amosbird/minmax-combinator
Introduce -ArgMin/-ArgMax combinators.
2023-10-30 03:35:28 +01:00
Alexey Milovidov
64b6e68a50
Merge pull request #55683 from amosbird/issue-55653
Reuse granule during skip index reading
2023-10-30 00:51:51 +01:00
Han Fei
df1e019268 address comments 2023-10-30 00:39:16 +01:00
Alexey Milovidov
8e6a7fdff0 Fix f-string 2023-10-29 23:43:36 +01:00
Alexey Milovidov
9aff0a8872 Revert "Fix 'Block structure mismatch' on concurrent ALTER and INSERTs in Buffer table (#55995)"
This reverts commit b65c498016.
2023-10-29 04:34:04 +03:00
Alexey Milovidov
1b085b1161
Merge pull request #55900 from ClickHouse/make-test-better
Make test `system_zookeeper_connection` better
2023-10-28 15:01:36 +02:00
Nikita Taranov
213ce63ffb
Merge branch 'master' into optimize_reading3 2023-10-28 00:04:20 +02:00
Michael Kolupaev
b65c498016
Fix 'Block structure mismatch' on concurrent ALTER and INSERTs in Buffer table (#55995) 2023-10-27 10:06:43 -07:00
Alexander Tokmakov
e07bb123d3 fix race condition between DROP_RANGE and committing existing block 2023-10-27 17:50:45 +02:00
Alexander Tokmakov
db5e9f1d1c beter check for duplicate lost parts 2023-10-27 17:33:30 +02:00
vdimir
faffdba8a2
Split source and worker processors in InterpreterCheckQuery 2023-10-27 15:22:10 +00:00
vdimir
c1ae369919
wip CHECK query for all tables 2023-10-27 15:22:10 +00:00
avogar
e630868eac Fix tests 2023-10-27 14:11:27 +00:00
Kruglov Pavel
bb4b95e891
Merge branch 'master' into schema-inference-union 2023-10-27 14:53:58 +02:00
Sergei Trifonov
a5d7c2b6a2
Merge branch 'master' into async-loader-integration 2023-10-27 10:39:12 +02:00
Kruglov Pavel
570b66f027
Merge branch 'master' into schema-inference-union 2023-10-26 19:26:00 +02:00
Alexander Tokmakov
9db5f4396c Merge branch 'master' into fix_lost_part_count 2023-10-26 17:40:37 +02:00
Andrey Zvonov
5737369d0b
Merge branch 'ClickHouse:master' into zvonand-datetime-ranges 2023-10-26 11:42:13 +02:00
vdimir
12890eb70c
Merge pull request #55806 from canhld94/rocksdb_trivial_count
Support trivial count for rocksdb and storage join
2023-10-26 11:22:38 +02:00
vdimir
1d5f75fd71
Merge pull request #53404 from ClickHouse/vdimir/check_table_improvements2
Improve CHECK TABLE system query, support checking part
2023-10-26 10:57:44 +02:00
Nikolay Degterinsky
3c690337ec Improvements 2023-10-26 03:17:30 +00:00
zvonand
0766c73aab Rename date_time_overflow_mode -> date_time_overflow_behavior, moved it to format settings 2023-10-25 23:11:13 +02:00
Igor Nikonov
1a5d485c6c
Merge branch 'master' into pr-progress-bar 2023-10-25 19:53:20 +02:00
Alexander Tokmakov
3c0b8aeb6a avoid counting lost parts twice 2023-10-25 19:29:40 +02:00
Alexander Tokmakov
c0482cb537
Merge pull request #55944 from azat/rmt-retriable-exception-log
Do not write retriable errors for Replicated mutate/merge into error log
2023-10-25 18:25:59 +02:00
alesapin
0d68a52c06
Merge pull request #50181 from ClickHouse/repro_49887
Make exception about `ALTER TABLE ... DROP COLUMN|INDEX|PROJECTION` more clear
2023-10-25 15:57:17 +02:00
Nikolay Degterinsky
2606b60e66 Fix REPLICA_ALREADY_EXISTS for ReplicatedMergeTree 2023-10-25 04:17:35 +00:00
Igor Nikonov
7b7f100250 Merge remote-tracking branch 'origin/master' into pr-progress-bar 2023-10-24 21:02:29 +00:00
李扬
465962df7f
Support orc filter push down (file + stripe + rowgroup level) (#55330)
* support orc filter push down

* update orc lib version

* replace setqueryinfo with setkeycondition

* fix issue https://github.com/ClickHouse/ClickHouse/issues/53536

* refactor source with key condition

* fix building error

* remove std::cout

* update orc

* update orc version

* fix bugs

* improve code

* upgrade orc lib

* fix code style

* change as requested

* add performance tests for orc filter push down

* add performance tests for orc filter push down

* fix all bugs

* fix default as null issue

* add uts for null as default issues

* upgrade orc lib

* fix failed orc lib uts and fix typo

* fix failed uts

* fix failed uts

* fix ast fuzzer tests

* fix bug of uint64 overflow in https://s3.amazonaws.com/clickhouse-test-reports/55330/de22fdcaea2e12c96f300e95f59beba84401712d/fuzzer_astfuzzerubsan/report.html

* fix asan fatal caused by reused column vector batch in native orc input format. refer to https://s3.amazonaws.com/clickhouse-test-reports/55330/be39d23af2d7e27f5ec7f168947cf75aeaabf674/stateless_tests__asan__[4_4].htm

* fix wrong performance tests

* disable 02892_orc_filter_pushdown on aarch64. https://s3.amazonaws.com/clickhouse-test-reports/55330/be39d23af2d7e27f5ec7f168947cf75aeaabf674/stateless_tests__aarch64_.html

* add some comments

* add some comments

* inline range::equals and range::less

* fix data race of key condition

* trigger ci
2023-10-24 12:08:17 -07:00
Kruglov Pavel
844c1fb688
Fix 2023-10-24 19:35:03 +02:00
Ilya Golshtein
0d27150948 merge_row_policy: cleanup 2023-10-24 13:09:57 +00:00
Kruglov Pavel
cb63b07e89
Merge pull request #55912 from wxybear/fix/storage_null_supports_subcolumns
fix: StorageNull supports subcolumns
2023-10-24 14:03:46 +02:00
Alexander Gololobov
04b82d6463
Merge pull request #55935 from ClickHouse/set_has_lwd
Set storage.has_lightweight_delete_parts flag when a part has been loaded
2023-10-24 14:01:11 +02:00
serxa
749cdb9954 Merge branch 'master' into async-loader-integration 2023-10-24 10:09:49 +00:00
Azat Khuzhin
da408df4a7 Proper ignoring of retriable errors during merge/mutate
The exception cannot be simply suppressed, since sanity checks in the
WriteBuffer dtor relies on the std::uncaught_exceptions(), and if the
exception will be suppressed, then if the buffer was not finalized, it
may abort (even though it is only in debug/sanitizers build).

So instead, IExecutableTask::printExecutionException() had been
introduced to distinguish when exception should be printed and when not.
2023-10-24 10:19:18 +02:00
Duc Canh Le
e3aa799ca2 disable approximate count by default + fix tests
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-24 03:18:33 +00:00
Srikanth Chekuri
8876a92b42 Merge remote-tracking branch 'upstream/master' into issue-55023 2023-10-23 21:21:25 +05:30
avogar
cfa510ea0a Add more documentation, fix build 2023-10-23 14:38:34 +00:00
Robert Schulze
0703c88381
Merge pull request #55915 from rschu1ze/sanity-check-rpnbuildertreenode
Add sanity check to RPNBuilderFunctionTreeNode
2023-10-23 16:09:56 +02:00
Robert Schulze
601276aa60
Update src/Storages/MergeTree/RPNBuilder.cpp
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2023-10-23 15:23:23 +02:00
Azat Khuzhin
38a4547c05 Do not write retriable errors for Replicated mutate/merge into error log
Fixes: e3f892f84a ("fix gtest with MemoryWriteBuffer, do not mute exception in ReplicatedMergeMutateTaskBase")
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-23 15:14:58 +02:00
Igor Nikonov
0bbf7ba921
Merge branch 'master' into pr-progress-bar 2023-10-23 14:56:59 +02:00
vdimir
7583394c9c
Support CHECK TABLE ... PART ... query 2023-10-23 12:33:35 +00:00
Kruglov Pavel
32da07b4ee
Merge pull request #55695 from Avogar/restrict-iceberg
Fixes and improvements for Iceberg storage
2023-10-23 13:58:23 +02:00
Alexander Gololobov
99a14410ee Set storage.has_lightweight_delete_parts flag when a part has been loaded 2023-10-23 13:36:27 +02:00
vdimir
8f0d7954ff
IStorage::checkDataNext returns optional 2023-10-23 10:12:30 +00:00
Robert Schulze
5cf3c95ea4
Update RPNBuilder.cpp 2023-10-23 11:49:52 +02:00
vdimir
fe95c0d0e4
Improve CHECK TABLE system query
Resubmit PR #52745
2023-10-23 09:35:26 +00:00
Robert Schulze
77e7f71e02
Add sanity check to RPNBuilderFunctionTreNode 2023-10-22 19:56:05 +00:00
wxybear
53a49164d6 fix: StorageNull supports subcolumns 2023-10-22 16:24:01 +08:00
Srikanth Chekuri
327386a348 Merge remote-tracking branch 'upstream/master' into issue-55023 2023-10-22 10:22:14 +05:30
Alexey Milovidov
2972dbdc40 Merge branch 'master' into morton-utils 2023-10-22 03:52:30 +02:00
Alexey Milovidov
2b72430e24 Make test system_zookeeper_connection better 2023-10-21 23:56:20 +02:00
Srikanth Chekuri
852d627f6a Introduce setting create_table_empty_primary_key_by_default
If set to true and the table of MergeTree family does not contain
ORDER BY and PRIMARY KEY, then an empty tuple is used by default
2023-10-21 21:37:04 +05:30
Igor Nikonov
e378d920c4
Merge branch 'master' into pr-progress-bar 2023-10-21 13:16:12 +02:00
Kruglov Pavel
6f61ccfe28
Merge branch 'master' into schema-inference-union 2023-10-20 22:54:11 +02:00
avogar
6934e27e8b Add union mode for schema inference to infer union schema of files with different schemas 2023-10-20 20:46:41 +00:00
Nikita Taranov
2a6a97c1fa read sync from cache 2023-10-20 22:24:56 +02:00
Anton Popov
5819bcd07a
Support asynchronous inserts for native protocol (#54730)
* support async insert for native protocol

* use separate queue for async inserts via native protocol

* fix test

* better logging for async inserts and more tests

* disable mixed internal and external data in async inserts

* fix tests

* fix quota in async inserts

* disable async insert for secondary query of distributed
2023-10-20 18:39:48 +02:00
Raúl Marín
d08ce13107
Merge pull request #51692 from Algunenano/parallel_replicas_row_estimation
Automatic decision of nº of parallel replicas
2023-10-20 15:50:43 +02:00
alesapin
c3c62d90c8
Update MergeTreeData.cpp 2023-10-20 13:48:23 +02:00
alesapin
88f80078e1
Merge branch 'master' into repro_49887 2023-10-20 13:04:00 +02:00
helifu
57d60dc4f2
Add a new column xid for zookeeper_connection (#50702)
* Refactor the code

* Add a new column xid for zookeeper_connection

* Support hostnames in the configuration

* Fix a typo

* Fix a typo

* Fix a typo

* Fix a bug about connect_time

* Update test case

* Update test case

* Fix a special build check error

* Resolve conflicts caused by rebase.

* Update failed test case

* Refactor the code according to comment

* Fix two compilation errors
2023-10-20 11:38:44 +02:00
Igor Nikonov
16c1b64773 Merge remote-tracking branch 'origin/master' into pr-progress-bar 2023-10-20 08:12:28 +00:00
Raúl Marín
4a53943926 Merge remote-tracking branch 'blessed/master' into parallel_replicas_row_estimation 2023-10-19 15:20:50 +00:00
Duc Canh Le
d968dc1a15 StorageJoin: supports trivial count()
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-19 06:30:25 +00:00
Duc Canh Le
b708fa21f9 rocksdb: trivial count
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-19 06:28:32 +00:00
Duc Canh Le
d8f73e7240 Merge branch 'master' into rocks_db_serialization
Fix a mysterious style check fail
2023-10-19 06:26:16 +00:00
Alexey Milovidov
4306b5a991 Revert unnecessary change 2023-10-19 08:13:23 +02:00
Alexey Milovidov
f6db0a5261 Merge branch 'master' into morton-utils 2023-10-19 08:11:25 +02:00
Alexey Milovidov
98111fad3d Fix error 2023-10-19 08:10:36 +02:00
Kseniia Sumarokova
4e0122a299
Merge pull request #54422 from kssenii/s3-queue-fixes
Fixes for storage `S3Queue`
2023-10-18 21:51:51 +02:00
kssenii
f90e31eb31 Enable log by default 2023-10-18 15:23:16 +02:00
Igor Nikonov
38895ad2da Less copying in DefaultCoordinator 2023-10-18 12:59:12 +00:00
kssenii
c4bad255b7 Fix 2023-10-18 14:37:33 +02:00
Igor Nikonov
01fa15c33f Less copying while handling annoucement 2023-10-18 12:20:14 +00:00
Duc Canh Le
2d638d6470 rocksdb: not creating block during writing
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-18 09:43:54 +00:00
Amos Bird
602f01f651
Reuse granule during skip index reading 2023-10-18 14:40:34 +08:00
Igor Nikonov
135e4c8412 Merge remote-tracking branch 'origin/master' into pr-progress-bar 2023-10-17 20:42:39 +00:00
Igor Nikonov
fb3d3a37ba Add progress bar for in order coordinator 2023-10-17 20:09:39 +00:00
Alexey Milovidov
79eccfb642
Merge pull request #55678 from azat/fix-OR-resubmit
Fix filtering by virtual columns with OR filter in query (resubmit)
2023-10-17 20:33:19 +02:00
avogar
323486f9e8 Add tests 2023-10-17 18:10:47 +00:00
kssenii
eb4519b9d6 Fix 2023-10-17 19:02:04 +02:00
Kseniia Sumarokova
7cedfeff12
Merge pull request #55145 from kssenii/materialized-pg-allow-unique-identifier
Allow to have several MaterializedPostgreSQL tables following the same Postgres table
2023-10-17 18:47:32 +02:00
Han Fei
4b23142775
Merge branch 'master' into hanfei/statistic 2023-10-17 16:40:31 +02:00
vdimir
c657e500ac
Analyzer: fix block stucture mismatch in matview with engine distributed 2023-10-17 14:02:30 +00:00
vdimir
1d2ac48261
Merge pull request #55681 from ClickHouse/vdimir/fix_analyzer_materialized_distributed_join
Fix StorageMaterializedView::isRemote
2023-10-17 16:00:15 +02:00
alesapin
abe6df6fbc
Merge pull request #55645 from ClickHouse/restore_top_level_parts
Restore only top-level parts instead of unexpected
2023-10-17 15:45:21 +02:00
kssenii
c549083e2c Fix 2023-10-17 14:23:59 +02:00
avogar
032d82e004 Fixes 2023-10-17 12:12:10 +00:00
Alexander Gololobov
11a62bc751
Merge pull request #55621 from ClickHouse/merge-52352
Merging #52352
2023-10-17 13:58:53 +02:00
avogar
527e96db3f Fix 2023-10-17 11:43:51 +00:00
avogar
4892618aa9 Update with master, fix comments 2023-10-17 11:42:19 +00:00
avogar
bb46aa4d57 Clean uo 2023-10-17 11:07:41 +00:00
avogar
f87938735a Fixes and improvements for Iceberg storage 2023-10-17 11:07:37 +00:00
Duc Canh Le
f20d055e1e do not re-create serialization for each row
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-17 10:12:27 +00:00
kssenii
42ed249954 Fix build 2023-10-17 12:03:49 +02:00
Robert Schulze
96a82df75a
Merge pull request #55616 from HarryLeeIBM/hlee-fts-max-rows
Inverted index: Replace setting density with `max_rows_in_postings_list`
2023-10-17 11:36:46 +02:00
Raúl Marín
3eaf752284 Merge remote-tracking branch 'blessed/master' into parallel_replicas_row_estimation 2023-10-17 11:36:39 +02:00
Kseniia Sumarokova
550a658236
Merge pull request #55144 from kssenii/fix-iceberg-metadata-parsing
Fix storage Iceberg files retrieval
2023-10-17 11:31:07 +02:00
kssenii
4464c86895 Merge remote-tracking branch 'origin/master' into s3-queue-fixes 2023-10-17 11:16:52 +02:00
kssenii
8744cd9c0d Fix 2023-10-17 11:15:53 +02:00
Igor Nikonov
4b36761f89
Merge branch 'master' into pr-progress-bar 2023-10-17 10:36:32 +02:00
Alexey Milovidov
de8215f5dd Merge remote-tracking branch 'origin/master' into morton-utils 2023-10-17 04:55:45 +02:00
HarryLeeIBM
fb8cd298d1 Code refactoring according to code review 2023-10-16 17:52:39 -07:00
Michael Kolupaev
ce7eca0615
DWARF input format (#55450)
* Add ReadBufferFromFileBase::isRegularLocalFile()

* DWARF input format

* Review comments

* Changed things around ENABLE_EMBEDDED_COMPILER build setting

* Added 'ranges' column

* no-msan no-ubsan
2023-10-16 17:00:07 -07:00
Ilya Golshtein
786183ee24 merge_row_policy: get rid of RequiredSourceColumnsVisitor 2023-10-16 22:16:53 +00:00
Ilya Golshtein
7f991bf6e7 merge_row_policy: a comment 2023-10-16 21:49:16 +00:00
robot-clickhouse
89eed73fb9
Merge pull request #55519 from azat/zk-retry-fix
Avoid retrying keeper operations on INSERT after table shutdown
2023-10-16 23:32:13 +02:00
Ilya Golshtein
ea95a49e86 merge_row_policy: some changes per code review 2023-10-16 21:22:43 +00:00
Kseniia Sumarokova
96c518be5b
Merge branch 'master' into s3-queue-fixes 2023-10-16 22:19:13 +02:00
Kseniia Sumarokova
3e9a1cf69f
Merge branch 'master' into fix-iceberg-metadata-parsing 2023-10-16 22:18:52 +02:00
Kseniia Sumarokova
c31299d86c
Merge branch 'master' into materialized-pg-allow-unique-identifier 2023-10-16 22:18:23 +02:00
robot-ch-test-poll1
aca98cf725
Merge pull request #53774 from helifu/master13
Display reloaded values of server settings
2023-10-16 21:17:17 +02:00
Kruglov Pavel
cbdb62d389
Merge pull request #55666 from ClickHouse/Avogar-patch-1
Fix progress bar for s3 and azure Cluster functions with url without globs
2023-10-16 18:25:00 +02:00
kssenii
0a6a4b3894 Review fixes 2023-10-16 18:15:17 +02:00
Kseniia Sumarokova
8f3974d289
00002_log_and_exception_messages_formatting ... 2023-10-16 17:30:02 +02:00
vdimir
c9a2a4922d
Fix StorageMaterializedView::isRemote 2023-10-16 15:18:47 +00:00
Igor Nikonov
6abd1a6462
Merge branch 'master' into zk-retry-fix 2023-10-16 16:56:07 +02:00
Azat Khuzhin
96f2a46a66 Fix filtering by virtual columns with OR filter in query
The problem with the initial implementation #52653 was:
- OR can have multiple arguments
- It simply not correct to assume that if there are two arguments this is OK.
  Consider the following example:

    "WHERE (column_not_from_partition_by = 1) OR false OR false"

  Will be converted to:

    "WHERE false OR false"

And it will simply read nothing.

Yes, we could apply some optimization for bool, but this will not always
work, since to optimize things like "0 = 1" we need to execute it.

And the only way to make handle this correctly (with ability to ignore
some commands during filtering) is to make is_constant() function return
has it use something from the input block, so that we can be sure, that
we have some sensible, and not just "false".

Plus we cannot simply ignore the difference of the input and output
arguments of handling OR, we need to add always-true (1/true) if the
size is different, since otherwise it could break invariants (see
comment in the code).

This includes (but not limited to):
- _part* filtering for MergeTree
- _path/_file for various File/HDFS/... engines
- _table for Merge
- ...

P.S. analyzer does not have this bug, since it execute expression as
whole, and this is what filterBlockWithQuery() should do actually
instead, but this will be a more complex patch.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit b107712e0c)
2023-10-16 15:42:10 +02:00
Raúl Marín
f799f5d7a1 Merge remote-tracking branch 'blessed/master' into parallel_replicas_row_estimation 2023-10-16 15:07:11 +02:00
Igor Nikonov
fdd7bfbb83 Merge remote-tracking branch 'origin/master' into pr-progress-bar 2023-10-16 12:59:00 +00:00
alesapin
9a925a0802 Fix typo 2023-10-16 13:35:20 +02:00
Raúl Marín
478f635d60
Merge pull request #53792 from ClickHouse/revert-53782-revert-52762-planner-prepare-filters-for-analysis
Revert "Revert "Planner prepare filters for analysis""
2023-10-16 13:21:54 +02:00
helifu
dc0f8ed793 Add a new column 'is_hot_reloadable' to indicate whether hot loading is supported 2023-10-16 19:10:35 +08:00
serxa
0e17da22eb Merge branch 'master' into async-loader-integration 2023-10-16 11:08:29 +00:00
alesapin
31dc46a889 Better test 2023-10-16 13:04:45 +02:00
Kruglov Pavel
6dcc756948
Fix for azure 2023-10-16 12:38:55 +02:00
Kruglov Pavel
836e35b6c4
Fix progress bar for s3 and azure Cluster functions with url without globs 2023-10-16 12:38:10 +02:00
alesapin
dbebdc3dca Fix comment 2023-10-16 11:05:59 +02:00
Antonio Andelic
6c543c730b
Merge pull request #55657 from ClickHouse/revert-55418-fix-OR
Revert "Fix filtering by virtual columns with OR filter in query"
2023-10-16 10:51:06 +02:00
alesapin
2d9812b9e9 Fix headers 2023-10-16 10:43:25 +02:00
alesapin
692fcd8422 Merge remote-tracking branch 'origin/master' into repro_49887 2023-10-16 10:39:16 +02:00
alesapin
697c1e3bb0
Merge pull request #55604 from ClickHouse/evillique-partition-parameters
Implement query paramenters support in partition expression
2023-10-16 10:26:02 +02:00
alesapin
26a8aa441c Better shutdown handling 2023-10-16 10:24:54 +02:00
Antonio Andelic
fb901c24a1
Revert "Fix filtering by virtual columns with OR filter in query" 2023-10-16 09:45:49 +02:00
Alexey Milovidov
f5aabbecfc Add a comment 2023-10-16 02:24:34 +02:00
Alexey Milovidov
26c0c0b86d More tests 2023-10-16 02:19:24 +02:00
Alexey Milovidov
8e8471f5db Fix error 2023-10-16 00:25:00 +02:00
Alexey Milovidov
724f04e6f6 Allow conditions on part of arguments 2023-10-15 22:21:27 +02:00
Alexey Milovidov
c932a5e0a1 Allow conditions on part of arguments 2023-10-15 22:21:10 +02:00
Alexey Milovidov
0bf6fd3671 Merge remote-tracking branch 'origin/master' into morton-utils 2023-10-15 21:28:00 +02:00
alesapin
bdafe17e9a
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:55 +02:00
alesapin
13ca296497
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:50 +02:00
alesapin
6ac790e918
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:46 +02:00
alesapin
8a865cdfb2
Merge pull request #55646 from ClickHouse/fix_some_typos
Fix some typos
2023-10-15 18:28:33 +02:00
Alexey Milovidov
0f89b4aad6
Merge pull request #55640 from ClickHouse/preparation-key-condition-2
KeyCondition: small changes
2023-10-15 18:23:53 +02:00
Kseniia Sumarokova
2015a0fc17
Merge branch 'master' into fix-iceberg-metadata-parsing 2023-10-15 18:03:53 +02:00
kssenii
f3056b1643 Add a test 2023-10-15 18:02:34 +02:00
alesapin
3b02748cb6 Fix some typos 2023-10-15 15:43:02 +02:00
alesapin
41479b21e6 Restore only top-level parts instead of unexpected 2023-10-15 15:33:33 +02:00
kssenii
0ddee6ad6c Fix 2023-10-15 14:44:57 +02:00
Kseniia Sumarokova
b26115eabe
Merge branch 'master' into materialized-pg-allow-unique-identifier 2023-10-15 14:17:32 +02:00
Alexander Gololobov
395a54915d
Fix totalBytes() 2023-10-15 10:40:37 +02:00
Alexey Milovidov
42f3751bd5 Minor changes 2023-10-15 06:33:59 +02:00
Alexey Milovidov
17cbc12831
Update KeyCondition.cpp 2023-10-15 07:20:04 +03:00
Alexey Milovidov
22b06e61f2 Add a comment 2023-10-15 06:00:28 +02:00
Alexey Milovidov
569f42d1d9 It might be working 2023-10-15 05:36:53 +02:00
Alexey Milovidov
daaa3db809 Add space-filling curves 2023-10-15 04:37:10 +02:00
Alexey Milovidov
438811ea8c Add space-filling curves 2023-10-15 04:34:26 +02:00
Alexey Milovidov
1ef7bc41d4 Fix garbage 2023-10-15 00:07:28 +02:00
Alexey Milovidov
7764dedb8e Something strange 2023-10-14 22:44:44 +02:00
Alexey Milovidov
25efd188d5 KeyCondition: small changes 2023-10-14 22:17:36 +02:00
Alexey Milovidov
50ee412b19
Merge pull request #55625 from ClickHouse/preparation-key-condition
KeyCondition: preparation
2023-10-14 22:13:39 +02:00
Alexey Milovidov
bafabf1a56 Fix typo in comment 2023-10-14 19:31:46 +02:00
Alexey Milovidov
d6984a2819 Preparation 2023-10-14 04:46:22 +02:00
Alexey Milovidov
a904ee970f KeyCondition: preparation 2023-10-14 04:32:25 +02:00
Alexey Milovidov
bbd67d262a Merging #52352 2023-10-14 02:52:53 +02:00
Alexey Milovidov
769ed2e19d
Merge branch 'master' into fix-OR 2023-10-14 02:25:21 +02:00
alesapin
cc92359225 Fxi 2023-10-13 19:46:53 +02:00
HarryLeeIBM
25545d504d Replace setting density to max_rows_in postings_list for full text search 2023-10-13 10:31:21 -07:00
Kseniia Sumarokova
310e922b40
Merge branch 'master' into materialized-pg-allow-unique-identifier 2023-10-13 19:14:50 +02:00
alesapin
daa8dbbbae Make as flexible as it can be 2023-10-13 18:51:32 +02:00
alesapin
f80dd06f52 Fix tuple parser 2023-10-13 17:36:38 +02:00