Commit Graph

92244 Commits

Author SHA1 Message Date
alesapin
83b584b2dd Something 2022-06-26 18:43:28 +02:00
Robert Schulze
959cbaab02
Move loop over patterns into implementations
- This is preparation for non-const regexp arguments, where this loop
  will run for each row.
2022-06-26 16:26:13 +00:00
Robert Schulze
cb5d1a4a85
Fix style check 2022-06-26 16:25:49 +00:00
Robert Schulze
b8f67185bf
Cosmetics: Whitespaces 2022-06-26 16:25:49 +00:00
Robert Schulze
e2b11899a1
Move check if cfg allows hyperscan into implementations
- This is not needed for non-const regexp array arguments but cleans up
  the code and runs the check only in functions which actually use
  hyperscan.
2022-06-26 16:25:49 +00:00
Robert Schulze
c2cea38b97
Move local variable into if statement 2022-06-26 16:25:49 +00:00
Robert Schulze
c9ce0efa66
Instantiate MultiMatchAnyImpl template using enums
- With this, invalid combinations of the FindAny/FindAnyIndex bools are
  no longer possible and we can remove the corresponding check

- Also makes the instantiations more readable.
2022-06-26 16:25:49 +00:00
Robert Schulze
2f15d45f27
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 16:25:43 +00:00
Robert Schulze
3478db9fb6
Move check for regexp array size into implementations
- This is not needed for non-const regexp array arguments (the
  cardinality of arrays is fixed per column) but it cleans up the code
  and runs the check only in functions which have restrictions on the
  number of patterns.

- For functions using hyperscans, it was checked that the number of
  regexes is < 2^32. Removed the check because I don't think anyone will
  every specify 4 billion patterns.
2022-06-26 15:38:12 +00:00
Robert Schulze
7913edc172
Move check for hyperscan regexp constraints into implementations
- This is preparation for non-const regexp arguments, where this check
  will run for each row.
2022-06-26 15:38:05 +00:00
Robert Schulze
89bfdd50bf
Remove unnecessary check
- getReturnTypeImpl() ensures that the haystack column has type "String"
  and we can simply assert that.
2022-06-26 15:34:24 +00:00
Robert Schulze
580d89477f
Minimally faster performance 2022-06-26 15:34:22 +00:00
Robert Schulze
4bc59c18e3
Cosmetics: Move some code around + docs + whitespaces + minor stuff 2022-06-26 15:34:15 +00:00
Robert Schulze
1273756911
Cosmetics: fmt-based exceptions 2022-06-26 15:33:18 +00:00
Robert Schulze
e5c74a14f7
Cosmetics: More consistent naming
- rename utility function and file to "checkHyperscanRegexp"
2022-06-26 15:33:18 +00:00
Robert Schulze
072e0855a8
Cosmetics: Make member variables const 2022-06-26 15:32:26 +00:00
Robert Schulze
2ebfd01c2e
Cosmetics: Pull out settings variable 2022-06-26 15:32:23 +00:00
Robert Schulze
bb7c627964
Cosmetics: Pass patterns around as std::string_view instead of StringRef
- The patterns are not used in hashing, there should not be a performance
  impact when we use stuff from the standard library instead.

- added forgotten .reserve() in FunctionsMultiStringPosition.h
2022-06-26 15:32:19 +00:00
Igor Nikonov
68927dd60c Adapt distinct for sorted chunks to handle sorted stream, so we can use
it for final distinct as well
2022-06-26 14:52:36 +00:00
kssenii
a15238d147 Review fixes, fix hdfs tests 2022-06-26 16:51:08 +02:00
larryluogit
b32cf5da4a
Merge branch 'ClickHouse:master' into add-tlsv1_3-test 2022-06-26 10:21:21 -04:00
Larry Luo
8dd6f09cf1 fix style check error 2022-06-26 07:19:22 -07:00
xiedeyantu
7e660933f0 add allow trailing comma test 2022-06-26 21:39:53 +08:00
xiedeyantu
9eafae968d Allow trailing comma in columns list 2022-06-26 21:39:53 +08:00
mergify[bot]
f63c959679
Merge branch 'master' into cleanup_garbage_in_store_dir 2022-06-26 13:35:10 +00:00
kssenii
8da6136f88 Fix 2022-06-26 13:21:05 +02:00
Igor Nikonov
aca6a6f1b0 Merge remote-tracking branch 'origin/master' into dictinct_in_order_optimization 2022-06-26 09:45:59 +00:00
Igor Nikonov
1140cf6fb5 Fixes:
+ test warning
+ proper capacity for column positions array in DistinctTransform
2022-06-26 09:43:31 +00:00
Alexey Milovidov
e29582daad
Merge pull request #38417 from ClickHouse/lower-mutex-scope
Lower mutex scope in ThreadStatus
2022-06-26 10:05:25 +03:00
Alexey Milovidov
b3098822e0
Merge pull request #38171 from ClickHouse/hyper-to-vectorscan
Replace hyperscan by vectorscan
2022-06-26 10:01:45 +03:00
Nikita Taranov
95d413d7ec put the thing into its own cache line 2022-06-26 01:38:45 +02:00
kssenii
725d80d470 get rid of path separation 2022-06-26 01:17:19 +02:00
Alexey Milovidov
25cc406201
Update src/Common/ThreadStatus.cpp
Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>
2022-06-26 01:29:06 +03:00
Robert Schulze
07f14c9bb2
Disable vectorscan-on-ARM for now 2022-06-26 00:03:01 +02:00
Alexey Milovidov
37903bfee0 Fix after #38427 2022-06-25 23:18:33 +02:00
Nikita Taranov
abcefeeb41 cleanup 2022-06-25 23:15:59 +02:00
Alexey Milovidov
38dc2b1cbc
Merge pull request #38427 from ClickHouse/automated-benchmark
Automated benchmark
2022-06-25 23:54:02 +03:00
Alexey Milovidov
756fd0dac8 Automated hardware benchmark 2022-06-25 18:27:26 +02:00
Alexey Milovidov
7734d1059d Slightly better 2022-06-25 18:09:53 +02:00
Alexey Milovidov
d4b9d5f067 Automatic upload from hardware benchmark 2022-06-25 18:09:53 +02:00
Alexey Milovidov
9bc23f579e Automated hardware benchmark 2022-06-25 18:09:53 +02:00
Alexey Milovidov
90307177b4
Merge pull request #38428 from ClickHouse/remove-codec-asynchronous-metric-log
Remove useless codec from `system.asynchronous_metric_log`
2022-06-25 18:59:02 +03:00
Mikhail f. Shiryaev
1d661d0bad
Merge pull request #38343 from ClickHouse/integration-tests-proxy
Upload logs for getting all tests command
2022-06-25 14:08:45 +02:00
alesapin
0304c73573
Merge pull request #38394 from ClickHouse/update-compose
Update docker-compose to try get rid of v1 errors
2022-06-25 13:59:06 +02:00
Kseniia Sumarokova
a6e868dddc
Update RabbitMQSource.cpp 2022-06-25 11:26:08 +02:00
Kseniia Sumarokova
901e8cfc6c
Update test.py 2022-06-25 11:24:11 +02:00
Kseniia Sumarokova
0d626982ee
Merge pull request #38369 from kssenii/fix-pg-compatibility
Fix postgres database engine possible incompatibility on upgrade
2022-06-25 11:18:46 +02:00
Kseniia Sumarokova
3c70e07fe9
Merge pull request #38366 from kssenii/fix-pg-ndim-with-schema
Fix postgres engine not using pg schema when retrieving array dimension size
2022-06-25 11:14:01 +02:00
Kseniia Sumarokova
3c19621454
Merge pull request #38424 from ClickHouse/fix-filesystem-local
Fix wrong implementation of filesystem* functions
2022-06-25 11:10:20 +02:00
xinhuitian
ccb4802ab1 fix some wrong links in alter docs 2022-06-25 14:01:41 +08:00