Commit Graph

3809 Commits

Author SHA1 Message Date
alexey-milovidov
985805fd01
Merge pull request #19583 from ClickHouse/merge-log-comment
Merging #18549
2021-01-26 17:11:07 +03:00
vdimir
bcae07128a
Merge pull request #19530 from taiyang-li/length_for_map
enable length for map, which returns keys number in map
2021-01-26 16:21:21 +03:00
vdimir
a4643bcff2
Whitespace fixes 2021-01-26 16:19:13 +03:00
feng lv
cea8ae162f fix test 2021-01-26 12:37:44 +00:00
Nikolai Kochetov
87246ea91b Fix header for MergeJoin with constants. 2021-01-26 15:37:42 +03:00
Nikolai Kochetov
d821cf11f8 Fix function neighbor for LowCardinality argument. 2021-01-26 13:31:29 +03:00
tavplubix
b8d6655131
Merge pull request #19572 from ClickHouse/fix_19568
Fix DROP TABLE ON CLUSTER SYNC hang with Atomic database
2021-01-26 12:51:07 +03:00
Maksim Kita
463a48dfe3
Merge pull request #19533 from kitaisreal/multi-if-constant-result-support
Function multiIf constant result support
2021-01-26 12:44:23 +03:00
Maksim Kita
16eb7b01b6
Merge pull request #19571 from kitaisreal/create-simple-dictionary-id-expression-fix
Query CREATE DICTIONARY id expression fix
2021-01-26 12:43:49 +03:00
tavplubix
16561753e8
Update arcadia_skip_list.txt 2021-01-26 11:21:18 +03:00
Azat Khuzhin
27a5794795 Fix UBsan report in lcm()/gcd()
Changelog:
- Check against INT64_MIN/INT64_MAX
- Check against std::numeric_limits<>::min/max
- Move common code into separate header - GCDLCMImpl.h
- Forbid floats

UBsan report [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/19466/cb30a02540a0f223df6668c5f88ff84aa666ff54/fuzzer_ubsan/report.html#fail1
2021-01-26 08:33:49 +03:00
Amos Bird
3afcccaad2
Fix global with after union refactoring 2021-01-26 10:29:12 +08:00
Amos Bird
824aee4020
better cte and with global 2021-01-26 10:29:11 +08:00
Azat Khuzhin
f4a4d33c2d Suppress UBsan reports in addYears()
https://clickhouse-test-reports.s3.yandex.net/19528/1c364b6ee3a44487529954cf2792e615f7de0f82/fuzzer_ubsan/report.html#fail1
2021-01-26 01:12:40 +03:00
alexey-milovidov
8084e4d614
Merge pull request #19414 from ClickHouse/fix-15889-continuation
Continue fix for Block structure mismatch in PipelineExecuting stream
2021-01-26 00:05:35 +03:00
alexey-milovidov
7197552535
Merge pull request #19430 from ClickHouse/fix-14100
Fix error Extremes transform was already added to pipeline
2021-01-26 00:04:14 +03:00
Alexey Milovidov
a47b0190fd Add a test 2021-01-25 22:25:49 +03:00
Maksim Kita
ce9a6d32eb Updated tests with always false condition 2021-01-25 21:53:47 +03:00
Maksim Kita
f70a704e2c Added test 2021-01-25 21:22:27 +03:00
Anton Popov
658f24dcff
Merge pull request #19358 from CurtizJ/fix-subcolumns
Fix several cases, while reading subcolumns
2021-01-25 20:26:07 +03:00
Nikolai Kochetov
a6f787faea
Merge pull request #19253 from ClickHouse/split-actions-dag
Split actions dag
2021-01-25 18:13:42 +03:00
alesapin
7d4bf6d56c
Merge pull request #19551 from ClickHouse/fix_01459_test
Fix 01459_manual_write_to_replicas flaky test
2021-01-25 18:05:20 +03:00
Anton Popov
f203a33a8f
Merge pull request #19515 from hexiaoting/map_functions_fix
Bug fix : support const column processing in mapContains, mapKeys, mapValues functions
2021-01-25 17:30:59 +03:00
dankondr
fb268ec339 Add toMinute MySQL compatibility alias 2021-01-25 16:35:58 +03:00
dankondr
23e86a57d8 Add toSecond MySQL compatibility alias 2021-01-25 16:26:38 +03:00
dankondr
8ca52f9894 Add toQuarter MySQL compatibility alias 2021-01-25 16:24:06 +03:00
dankondr
f49c8779a8 Add repeat MySQL compatibility alias 2021-01-25 16:20:40 +03:00
dankondr
d7c5dd3767 Add toYear MySQL compatibility alias 2021-01-25 16:00:11 +03:00
dankondr
8f115f2923 Add toMonth MySQL compatibility alias 2021-01-25 15:59:49 +03:00
Alexander Tokmakov
769257acf4 fix drop table on cluster hang 2021-01-25 15:44:10 +03:00
taiyang-li
586def7fa3 enable empty/notEmpty for map data type 2021-01-25 18:31:39 +08:00
alesapin
94f6a5533e Fix 01459_manual_write_to_replicas flaky test 2021-01-25 10:43:20 +03:00
alesapin
fe133580ee
Merge pull request #19346 from azat/system.parts-_state-fix
Fix system.parts _state column
2021-01-25 10:11:19 +03:00
alexey-milovidov
ba3e064a63
Merge pull request #19371 from kssenii/test-coverage-with-factories
test coverage with factories
2021-01-25 07:11:09 +03:00
Maksim Kita
dac6cceac1 Function multiIf constant result support 2021-01-25 00:35:49 +03:00
alexey-milovidov
73501102f3
Merge pull request #19528 from azat/merge_tree_min_for_concurrent_read-SIGSEGV
Fix SIGSEGV with merge_tree_min_rows_for_concurrent_read/merge_tree_min_bytes_for_concurrent_read=0/UINT64_MAX
2021-01-25 00:18:42 +03:00
alexey-milovidov
77af612bc5
Merge pull request #19466 from azat/UBsan-report-fixes
UBsan report fixes (arraySlice, addMinutes/addHours/addWeeks/addDays, sumWithOverflow(Decimal))
2021-01-24 22:27:15 +03:00
dankondr
3746f6cbd7 Add tests 2021-01-24 15:16:34 +00:00
taiyang-li
f51c3ee9a3 enable length for map, which returns keys number in map 2021-01-24 22:54:08 +08:00
Azat Khuzhin
1c364b6ee3 Fix SIGSEGV with merge_tree_min_rows_for_concurrent_read/merge_tree_min_bytes_for_concurrent_read=0/UINT64_MAX
In case of 0 or too huge value it will try to read not existing marks
and got:

    Logical error: 'Trying to get non existing mark 11936128518282651045, while size is 2'.
2021-01-24 14:39:57 +03:00
Azat Khuzhin
cb30a02540 Fix UBsan report in addDays(INT64_MAX)
https://clickhouse-test-reports.s3.yandex.net/19466/df53438a66ee95de790b60d35f36eca986590027/fuzzer_ubsan/report.html#fail1
2021-01-24 13:51:05 +03:00
Azat Khuzhin
df53438a66 Fix UBsan report in sumWithOverflow(Decimal)
https://clickhouse-test-reports.s3.yandex.net/19450/3fffa16aab8f5342926b3a6b1e3c6a14208e3322/fuzzer_ubsan/report.html#fail1
2021-01-24 09:26:07 +03:00
feng lv
667119918e add sign math function 2021-01-24 05:18:59 +00:00
alexey-milovidov
ab6343ff1f
Merge pull request #19474 from ClickHouse/aes-fix-strange-code
Fix insufficient args check in AES functions
2021-01-23 22:05:01 +03:00
alexey-milovidov
9df296b55e
Merge pull request #19480 from ClickHouse/blns
Integrate with "Big List of Naughty Strings"
2021-01-23 21:52:41 +03:00
hexiaoting
0f05b0ac9a Add Const column test cases for mapContains/Keys/Values 2021-01-23 22:53:08 +08:00
hexiaoting
143b84240e Add const column test case for mapKeys and mapValues 2021-01-23 22:48:14 +08:00
Alexey Milovidov
2b85007af9 Update test 2021-01-23 15:15:03 +03:00
kssenii
0d940c6137 Add AggregateFunctionCombinatorFactory, better names 2021-01-23 12:07:37 +00:00
Alexey Milovidov
598952c243 Remove flawed variants of "encrypt" from tests 2021-01-23 12:32:30 +03:00
alexey-milovidov
c3fc1d83dc
Merge branch 'master' into aes-fix-strange-code 2021-01-23 12:14:17 +03:00
alexey-milovidov
1e42caa888
Merge pull request #19475 from ClickHouse/avg-weighted-ubsan
Fix UBSan report in avgWeighted
2021-01-23 12:13:28 +03:00
Alexey Milovidov
9983beed83 Remove Arcadia 2021-01-23 12:08:54 +03:00
Alexey Milovidov
d1bd4ef793 Merge branch 'master' of github.com:yandex/ClickHouse into blns 2021-01-23 12:08:38 +03:00
alexey-milovidov
7a10fbc9c3
Merge pull request #19479 from ClickHouse/columns-description-idiotic
Fix wrong serde of ColumnsDescription
2021-01-23 12:08:15 +03:00
Alexey Milovidov
ba7438a893 Remove Arcadia 2021-01-23 12:07:58 +03:00
alexey-milovidov
9baac1204e
Merge pull request #19472 from ClickHouse/date-lut-buffer-overflow
Fix buffer overflow in DateLUT
2021-01-23 12:05:10 +03:00
alexey-milovidov
40c9b0ae1b
Merge pull request #19461 from ClickHouse/great-circle-distance-ubsan
Avoid UBSan report in greatCircleDistance
2021-01-23 12:03:02 +03:00
alexey-milovidov
bbaa0786d9
Merge pull request #19460 from ClickHouse/running-difference-ubsan
Fix UBSan report in runningDifference
2021-01-23 12:02:48 +03:00
alexey-milovidov
474ff29ded
Merge pull request #19459 from ClickHouse/array-slice-ubsan
Fix UBSan report in arraySlice and substring
2021-01-23 12:02:34 +03:00
Maksim Kita
f5deb6d523
Merge pull request #19354 from kitaisreal/accurate-cast-or-null-fixed-unitialized-values
Function accurateCastOrNull fixed unitialized values for numeric cast
2021-01-23 10:58:52 +03:00
Azat Khuzhin
86ead0f0a9 Suppress UBsan for addMinutes/addHours/addWeeks with inf
https://clickhouse-test-reports.s3.yandex.net/19466/bb6f775b89da564cff9892a2443332a758e884c0/fuzzer_ubsan/report.html#fail1
2021-01-23 08:31:20 +03:00
alexey-milovidov
feebf64cb1
Merge pull request #19397 from ClickHouse/aes-msan
Fix MSan report in AES functions
2021-01-23 04:47:36 +03:00
Alexey Milovidov
b326a4b7f9 Integrate with Big List of Naughty Strings for better fuzzing 2021-01-23 04:42:04 +03:00
Alexey Milovidov
1b6ee55c6a More tests 2021-01-23 04:26:03 +03:00
Alexey Milovidov
7005e3a826 Fix wrong serde of ColumnsDescription 2021-01-23 04:11:18 +03:00
Alexey Milovidov
02d28c1f9b Fix UBSan report in avgWeighted 2021-01-23 03:17:58 +03:00
Alexey Milovidov
f7db6e10d3 Fix very strange code in AES functions 2021-01-23 02:35:40 +03:00
Alexey Milovidov
505898747e Fix buffer overflow in DateLUT 2021-01-23 01:58:41 +03:00
Alexey Milovidov
bbe3c54f34 Merge branch 'aes-msan' into aes-remove-complications 2021-01-23 00:48:45 +03:00
Azat Khuzhin
bb6f775b89 Fix UBsan report in arraySlice (with INT64_MIN as offset)
- arraySlice([], INT64_MIN) -- FunctionArraySlice::executeImpl

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/19378/2c42600cf9bd8e9962b5b5a0ebb4bf11a10887ea/fuzzer_ubsan/report.html#fail1

v2: removed fixes that is already included into #19459
    - arraySlice(groupArray([]), INT64_MIN) -- sliceDynamicOffsetUnbounded
2021-01-23 00:25:50 +03:00
Azat Khuzhin
f2910deec2 Fix UBsan report in date functions
Found with fuzzer [1]:

  [1]: https://clickhouse-test-reports.s3.yandex.net/19381/95c9e57ec13e450ec6535cf723f504a2e68e3e2c/fuzzer_ubsan/report.html#fail1
2021-01-23 00:25:49 +03:00
Alexey Milovidov
0528ca60d6 Avoid UBSan report in greatCircleDistance 2021-01-23 00:03:59 +03:00
alexey-milovidov
25ea281297
Merge pull request #19360 from vdimir/issue-18197
Fix default value in join types with non-zero default (close #18197)
2021-01-22 23:51:56 +03:00
Alexey Milovidov
4047542b61 Fix UBSan report in runningDifference 2021-01-22 23:46:51 +03:00
Alexey Milovidov
4afcb94a8a Fix Style check 2021-01-22 23:41:26 +03:00
Alexey Milovidov
ae8de8259f Fix UBSan report in substring 2021-01-22 23:40:04 +03:00
alexey-milovidov
a04360e6b2
Update 01664_array_slice_ubsan.sql 2021-01-22 23:36:10 +03:00
Alexey Milovidov
fb71a0704e Fix UBSan report in arraySlice 2021-01-22 23:35:16 +03:00
tavplubix
49e1321df4
Merge pull request #19072 from ClickHouse/fix_19021
Fix checkpoint in PeekableReadBuffer over ConcatReadBuffer
2021-01-22 21:00:04 +03:00
Nikolai Kochetov
290eadc121
Merge branch 'master' into split-actions-dag 2021-01-22 18:09:34 +03:00
tavplubix
9801bfc0ee
Merge branch 'master' into fix_18063 2021-01-22 17:28:05 +03:00
alexey-milovidov
f44f169aaa
Merge pull request #19385 from ClickHouse/sum-ubsan
Avoid UBSan report in aggregate function sum
2021-01-22 17:25:55 +03:00
alexey-milovidov
6e1d660e36
Merge pull request #19390 from ClickHouse/http_referer
Add http_referer to client info
2021-01-22 17:25:09 +03:00
alexey-milovidov
9818bd319a
Merge pull request #19381 from azat/parts-types-metrics
Add metrics for MergeTree parts (Wide/Compact/InMemory) types
2021-01-22 17:24:50 +03:00
alexey-milovidov
3431e39587
Merge pull request #19393 from ClickHouse/extract-all-groups-fail-fast
Fail fast in incorrect usage of extractAllGroups
2021-01-22 17:24:13 +03:00
alexey-milovidov
9add38f47b
Merge pull request #19394 from ClickHouse/quantile-weighted-overflow
Fix UBSan report in quantileExactWeighted
2021-01-22 17:18:01 +03:00
alexey-milovidov
7b62871765
Merge pull request #19383 from ClickHouse/h3-fix-buffer-overflow
Fix buffer overflow in Uber H3
2021-01-22 17:14:29 +03:00
Kruglov Pavel
b2d5370b36
Merge pull request #17359 from ildus/tuple_arg_for_argMinMax
Add tuple argument support for argMin and argMax
2021-01-22 17:11:01 +03:00
Nikolai Kochetov
70b4199869 Add test. 2021-01-22 16:30:01 +03:00
Maksim Kita
d712748304 Function accurateCastOrNull fixed unitialized values for numeric cast 2021-01-22 16:24:51 +03:00
tavplubix
2d988f6791
Update arcadia_skip_list.txt 2021-01-22 16:01:04 +03:00
kssenii
6dc32ae4cb More correct for functions and aggr. functions 2021-01-22 11:58:29 +00:00
Alexander Kuzmenkov
6296cc6b09
Merge pull request #19361 from ClickHouse/aku/reconnect
Reconnect after client errors
2021-01-22 13:32:56 +03:00
Alexander Kuzmenkov
8b9105bf39
Merge pull request #18446 from azat/constant-folding
Fix constant folding when the result is unknown
2021-01-22 13:26:24 +03:00
Nikolai Kochetov
2e95000d64 Update tests. 2021-01-22 13:25:59 +03:00
Nikolai Kochetov
b19316a2af Fix test. 2021-01-22 13:06:59 +03:00
Nikolai Kochetov
42d46e2a26 Update tests. 2021-01-22 12:39:33 +03:00
Alexey Milovidov
56d09886e2 Fix MSan report in AES functions 2021-01-22 04:08:10 +03:00
alexey-milovidov
4e11e7cfa9
Merge pull request #18772 from azat/optimize-memory-tracking-fix
[RFC] Fix memory tracking for OPTIMIZE TABLE/merges
2021-01-22 03:48:06 +03:00