Commit Graph

137687 Commits

Author SHA1 Message Date
János Benjamin Antal
f1f388d9d2 Remove RangeHashedDictionary as exception from large objects check 2024-03-12 10:02:44 +00:00
János Benjamin Antal
47a4ce8a4e Move RangeHashedDictionary::getColumn into source file 2024-03-12 10:02:33 +00:00
Azat Khuzhin
ccd47126fd Fix 01603_insert_select_too_many_parts flakiness
CI: https://s3.amazonaws.com/clickhouse-test-reports/60695/048a042dc4963631a23358d3e454dcd8a9eaafa2/stateless_tests__aarch64_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 11:02:02 +01:00
Pablo Musa
f6abe68b60
Clarify sentence about clusterAllReplicas
The explanation about `clusterAllReplicas` is not clear. This change tries to simplify the sentence and clarify the explanation.
2024-03-12 10:52:22 +01:00
Azat Khuzhin
3c08e198ad tests: wait for mutations in 02994_merge_tree_mutations_cleanup.sql.j2
Otherwise it fails in private fork CI

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2024-03-12 10:39:41 +01:00
Azat Khuzhin
4bd6d4456e Fix expectations for test_all_projection_files_are_dropped_when_part_is_dropped
Since after DROP PART mutations are not cleaned anymore.

Here an example:

                objects_at_the_end = list_objects(cluster)
    >           assert objects_at_the_end == objects_empty_table
    E           AssertionError: assert ['data/evt/iczupcswcatzvjikqwmovahturdht', 'data/oxq/dmkgqbdzeeiwmukogoxawfoxxnrqs'] == ['data/oxq/dmkgqbdzeeiwmukogoxawfoxxnrqs']
    E             At index 0 diff: 'data/evt/iczupcswcatzvjikqwmovahturdht' != 'data/oxq/dmkgqbdzeeiwmukogoxawfoxxnrqs'
    E             Left contains one more item: 'data/oxq/dmkgqbdzeeiwmukogoxawfoxxnrqs'
    E             Full diff:
    E               [
    E             +  'data/evt/iczupcswcatzvjikqwmovahturdht',
    E                'data/oxq/dmkgqbdzeeiwmukogoxawfoxxnrqs',
    E               ]

    test_replicated_zero_copy_projection_mutation/test.py:155: AssertionError

And decoded paths:

    node1 :) select local_path from system.blob_storage_log where remote_path = 'data/evt/iczupcswcatzvjikqwmovahturdht'

    SELECT local_path
    FROM system.blob_storage_log
    WHERE remote_path = 'data/evt/iczupcswcatzvjikqwmovahturdht'

    Query id: 9ee5a9c0-c3b7-46ad-82bd-64c8bcbda78d

    ┌─local_path────────────────────────────────────────────────────────┐
    │ store/bce/bcea71c9-35cd-4368-9504-c563253b1964/tmp_mutation_1.txt │
    │ store/bce/bcea71c9-35cd-4368-9504-c563253b1964/mutation_1.txt     │
    └───────────────────────────────────────────────────────────────────┘

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 10:39:41 +01:00
Azat Khuzhin
6c74ab18c0 Do not clean mutations for MergeTree on DROP PART (to match ReplicatedMergeTree)
Even if this should be done, only related mutations should be cleaned,
not all.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 10:39:41 +01:00
Azat Khuzhin
f559767d22 Fix finished_mutations_to_keep=0 for MergeTree (as docs says 0 is to keep everything)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 10:39:41 +01:00
Max Kainov
fb1e5923a3 CI: fix runner for arm perf tests
#do_not_test
2024-03-12 09:12:25 +00:00
lgbo-ustc
5f1991fbef too big translation unit in Aggregator 2024-03-12 16:17:33 +08:00
Zhuo Qiu
05969a39f3 resolve conflicts 2024-03-12 14:45:25 +08:00
Alexey Milovidov
5222ebc4b4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-12 06:37:38 +01:00
Alexey Milovidov
bdc884dfa5
Merge pull request #60255 from ClickHouse/dont-load-useless-index-parts-in-memory
Do not load useless columns from the index in memory
2024-03-12 08:30:53 +03:00
Zhuo Qiu
4ad8141a16 Maintain compatibility of estimateNeededDiskSpace()
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2024-03-12 13:07:46 +08:00
Zhuo Qiu
c628eaca8b Consider deleted rows when selecting parts to merge 2024-03-12 13:07:39 +08:00
Alexey Milovidov
bd4f948f12
Merge pull request #61058 from ClickHouse/rip-copier
Delete `clickhouse-copier`
2024-03-12 07:15:48 +03:00
Alexey Milovidov
c3a839d595 Merge pull request #61127 from ClickHouse/remove-in-memory-data-parts-2
Remove in-memory data parts, part 3.
2024-03-12 07:07:07 +03:00
Alexey Milovidov
1b04cc0b4d Fix strange log message 2024-03-12 03:56:10 +01:00
Raúl Marín
3cc07603ff Merge remote-tracking branch 'blessed/master' into compilation 2024-03-11 22:53:55 +01:00
Raúl Marín
563df9bdcb Fix multiple bugs in groupArraySorted 2024-03-11 22:49:18 +01:00
johnnymatthews
281dc8d29d Improves varSamp docs. Adds varSampStable docs. 2024-03-11 17:48:12 -03:00
johnnymatthews
120a1fdb5f Improves varPop docs. Adds varPopStable. 2024-03-11 17:24:33 -03:00
Han Fei
037f4cf5a6
Merge pull request #60262 from Aed-p/fix_LRUResource_cache_bug
fix LRUResource Cache bug (Hive cache)
2024-03-11 21:16:07 +01:00
Kruglov Pavel
d20389b7f7
Merge pull request #61200 from ClickHouse/revert-60430-max-parallel-replicas-validate
Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense"
2024-03-11 21:13:19 +01:00
Kruglov Pavel
a90a6e9a27
Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense" 2024-03-11 21:05:44 +01:00
avogar
2e74685ba6 Make variant tests a bit faster 2024-03-11 19:58:43 +00:00
Nikita Taranov
3a26b9c89e impl 2024-03-11 19:42:25 +00:00
Kruglov Pavel
9b055c3a43
Use assert_cast to prevent nullptr dereference on bad column types in FunctionsConversion 2024-03-11 20:38:30 +01:00
Azat Khuzhin
5a400c181b Fix llvm symbolizer on CI
In #61011 the whole toolchain installation had been removed from the
base image to reduce image sizes, and this is a good thing indeed.

However it also breaks the symbolizer for sanitizers, which makes
stacktraces unreadable, so let's fix this by getting back llvm package,
this should be OK, since it's size is not gigabytes, but only 48MiB (at
least for llvm-14):

    # dpkg -L llvm-14| xargs file | grep -v directory | cut -d: -f1 | xargs du -sch | grep total
    48M     total

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-11 20:36:15 +01:00
Nikita Mikhaylov
904a2c313c Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 20:08:26 +01:00
Max K
d03a4fa637
Merge pull request #61185 from ClickHouse/ci_hot_style_fix
CI: ci.py hot style fix
2024-03-11 19:57:27 +01:00
Max Kainov
b7b83085d1 CI: ci.py hot style fix
#do_not_test
2024-03-11 18:49:45 +00:00
kssenii
5a71636411 Fxi 2024-03-11 19:44:52 +01:00
Kruglov Pavel
55a8204761
Fix test 2024-03-11 19:43:30 +01:00
Raúl Marín
a1e5161cee Disable sanitizers with 02784_parallel_replicas_automatic_decision_join 2024-03-11 19:25:34 +01:00
Han Fei
fd68fed047 fix flaky 02949_ttl_group_by_bug 2024-03-11 19:21:35 +01:00
Nikita Mikhaylov
fcf8a3821d Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 19:12:49 +01:00
Max K
7676d71c5d
Merge pull request #59738 from ClickHouse/ci_arm_integration_fix_1
CI: support batch specification in commit message
2024-03-11 19:01:03 +01:00
Max K
90a5143b8d
Merge pull request #61172 from ClickHouse/ci_fix_sync_issue_with_builds
CI: fix sync build issue with reuse
2024-03-11 18:52:57 +01:00
Kseniia Sumarokova
97a935ea10
Merge branch 'master' into revive-cache-contention-fix 2024-03-11 18:43:16 +01:00
Kseniia Sumarokova
4b94bcd54e
Update ReadSettings.h 2024-03-11 18:41:17 +01:00
Kseniia Sumarokova
cb3cb8ec52
Merge pull request #60308 from ClickHouse/add-a-way-to-force-read-through-filesystem-cache-for-merges
Add a setting to force read-through cache for merges
2024-03-11 18:40:11 +01:00
Max Kainov
f973e405ee CI: fixing ARM integration tests
#do_not_test
2024-03-11 17:20:36 +00:00
Max Kainov
f656a01538 CI: fix sync build issue with reuse
#do_not_test
2024-03-11 17:15:23 +00:00
Nikolai Kochetov
8cfe0e4df7
Merge pull request #61104 from ClickHouse/use-global-scalars-cache-analyzer
Use global scalars cache with analyzer
2024-03-11 18:11:10 +01:00
Kruglov Pavel
16e01eb93a
Fix style 2024-03-11 18:05:51 +01:00
Kruglov Pavel
1c1336bdc0
Merge pull request #60430 from Avogar/max-parallel-replicas-validate
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-03-11 18:04:54 +01:00
avogar
260c638755 Replace forgotten logical error 2024-03-11 16:59:01 +00:00
avogar
74281b0a4e Avoid some logical errors in experimantal Object type 2024-03-11 16:42:45 +00:00
Raúl Marín
5db0829245 Remove another template 2024-03-11 17:20:53 +01:00