Commit Graph

52455 Commits

Author SHA1 Message Date
Nikita Taranov
3355ed7139
Add [[nodiscard]] to a couple of methods 2024-01-23 00:28:15 +01:00
Nikita Taranov
09e24ed6c5
Merge pull request #58068 from zhongyuankai/limit_materialized_view_size
A limit on the number of materialized views attached to a table.
2024-01-22 22:50:56 +01:00
Nikita Taranov
b161921825 impl 2024-01-22 22:33:23 +01:00
Bhavna Jindal
084ee74b68 minor fix 2024-01-22 13:32:57 -08:00
Bhavna Jindal
d9edd5a7f3 fix spell check 2024-01-22 13:32:57 -08:00
Bhavna Jindal
f935493f28 fix trailing whitespaces 2024-01-22 13:32:57 -08:00
Bhavna Jindal
c59f3e164f Return baseline component as fourth array 2024-01-22 13:32:57 -08:00
Max K
4932b1cad9
Merge branch 'master' into better-read-buffers 2024-01-22 21:52:55 +01:00
Arthur Passos
24b8bbe9fa
Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition (#39507)
* temp commit

* temp commit

* draft impl for feedback

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* fix weird style changes

* aa

* aa

* Add integ tests and remove partition key restriction

* fix small incosistency in partition id

* style fix

* style fix

* style fix

* use existing DataPartStorageBuilder instead of new one

* Refactor part clone to make it more readable and maintainable

* Add MergeTreeDataPartCloner docs

* define ErrorCodes::BAD_ARGUMENTS

* Rebase

* camel case methods

* address some comments

* yet another rebase?

* Move from integ tests to stateless tests

* address more comments

* add finalize on min_max_idx files

* Add sync option to DistinctPartitionExpCloner

* just a temp test

* revert temp change

* Use echoOn to distinguish test queries

* remove comment

* fix build issue during rebase

* atempt to fix build after rebase

* finally fix build

* clear minmaxidx hyperrectangle before loading it

* Fix error on min_max files deletion where it was being assumed that partition expression contained all columns

* get it to the state it was previously

* add missing include

* getting functional?

* refactoring and renaming

* some more refactoring

* extern bad arguments

* try to fix style

* improvements and docs

* remove duplicate includes

* fix crash

* make tests more stable by ordering

* rebase once again..

* fix

* make ci happy?

* fix rebase issues

* docs

* rebase, but prolly needs to be improved

* refactor out from nasty inheritance to static methods

* fix style

* work around optional

* refactor & integrate some changes

* update column_type

* add tests by dencrane

* set utc

* fix ref file

* fix tests

* use MergeTree instead of SummingMergeTree

* mark MergeTreeDataPart::getBlock as const

* address a few comments

* compute module function name size at compile time

* simplify branching in getPartitionAstFieldsCount

* remove column_indexes argument

* merge getBlock with buildBlock

* add some const specifiers

* small adjustments

* remove no longer needed isNull check

* use std::min and max to update global min max idx

* add some assertions

* forward declare some symbols

* fix grammar

* forward decl

* try to fix build..

* remove IFunction forward decl

* Revert "use std::min and max to update global min max idx"

This reverts commit b2fe79dda7.

* Revert "remove no longer needed isNull check"

This reverts commit 129db2610f.

* Revert "Revert "remove no longer needed isNull check""

This reverts commit 9416087dd8.

* Revert "Revert "use std::min and max to update global min max idx""

This reverts commit 20246d4416.

* remove some comments

* partial use of MonotonicityCheckMatcher

* ranges

* remove KeyDescriptionMonotonicityChecker

* remove duplication of applyfunction

* move functions to anonymous namespace

* move functions to cpp

* Relax partition compatibility requirements by accepting subset, add tests from partitioned to unpartitioned

* updte reference file

* Support for partition by a, b, c to partition by a, b

* refactoring part 1

* refactoring part 2, use hyperrectangle, still not complete

* refactoring part 3, build hyperrectangle with intersection of source & destination min max columns

* Support attaching to table with partition expression of multiple expressions

* add tests

* rename method

* remove some code duplication

* draft impl for replicatedmergetree, need to dive deeper

* ship ref file

* fix impl for replicatedmergetree..

* forbid attach empty partition replicatedmergetree

* Add replicated merge tree integration tests

* add test missing files

* fix black

* do not check for monotonicity of empty partition

* add empty tests & fix replicated

* remove no longer needed buildBlockWithMinMaxINdexes

* remove column logic in buildHyperrectangle

* simplify implementation by using existing methods

* further simplify implementation

* move all MergeTreeDataPartClone private methods to .cpp file

* decrease decomposition

* use different namespaces

* reduce code duplication

* fix style

* address a few comments

* add chassert to assert arguments size on MonotonicityCheckVisitor

* remove deleteMinMaxFiles method

* remove useless checks from sanitycheck

* add tests for attach partition (not id)

* Remove sanityCheckASTPartition and bring back conditional getPartitionIDFromQuery

* remove empty block comment

* small fixes

* fix formatting

* add missing include

* remove duplicate iuncludes

* trigger ci

* reduce some code duplication

* use updated partition id on replicatedmergetree

* fix build

* fix build

* small refactor

* do not use insert increment on fetch part

* remove duplicate includes

* add one more integ test

* black

* black

* rely on partition exp instead of partition id on replicated part fetch to decide if it is a different partition exp

* add one more integ test

* add order by clause

* fix black

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2024-01-22 21:00:04 +01:00
serxa
f1ab22d4c3 fix style 2024-01-22 19:54:50 +00:00
serxa
fad5aeede3 fix 2024-01-22 19:43:25 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Raúl Marín
f5ffe4e473 Try getting a better error 2024-01-22 18:58:06 +01:00
Raúl Marín
a5a3ad2afe Merge remote-tracking branch 'blessed/master' into fix_sum_map 2024-01-22 18:56:15 +01:00
kssenii
1aa8e62bb7 Fix 2024-01-22 18:26:44 +01:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Robert Schulze
748371d127
Refactor locking in AsynchronousMetrics 2024-01-22 16:51:02 +00:00
Robert Schulze
1262945df7
Cosmetics 2024-01-22 16:51:02 +00:00
Nikolai Kochetov
65c5ea31a8
Revert "Revert "Allow parallel replicas for JOIN with analyzer [part 1]."" 2024-01-22 17:09:34 +01:00
Duc Canh Le
ed031f32af address review comments
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-22 16:06:29 +00:00
Dmitry Novik
f702afb72d Fix includes 2024-01-22 15:26:25 +00:00
Dmitry Novik
1abe1307db Make test to check the feature 2024-01-22 15:15:30 +00:00
Anton Popov
e1e7a9cd45
Merge branch 'master' into better-read-buffers 2024-01-22 15:50:48 +01:00
Alexander Tokmakov
2f1d4f094b
Add a parameter for testing purposes (#59027)
* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp

* Update ConnectionParameters.cpp
2024-01-22 15:48:44 +01:00
Alexander Tokmakov
cddd41ccd5
Merge pull request #59070 from ClickHouse/revert-55575-no-octal-leading-zeroes
Revert "Consume leading zeroes when parsing a number in ConstantExpressionTemplate"
2024-01-22 15:35:16 +01:00
Alexander Tokmakov
c2202ff347
Skip unavailable replicas in parallel distributed insert select (#58931)
* Update StorageDistributed.cpp

* Update StorageDistributed.cpp

* Update StorageDistributed.cpp

* add a test

* Update 01099_parallel_distributed_insert_select.sql
2024-01-22 15:34:46 +01:00
Alexander Tokmakov
9b6455122c
Revert "Consume leading zeroes when parsing a number in ConstantExpressionTemplate" 2024-01-22 15:31:08 +01:00
mochi
0606a77267
Update src/Storages/MergeTree/MutateTask.cpp
Co-authored-by: Dmitry Novik <mrnovikd@gmail.com>
2024-01-22 22:02:50 +08:00
Raúl Marín
1e875431db
Style 2024-01-22 14:59:53 +01:00
vdimir
0791c75315
Merge pull request #58654 from yariks5s/paste_join_aliases_requirement
Avoid alias duplicates in PASTE JOIN and fix aliases requirement
2024-01-22 14:48:13 +01:00
Dmitry Novik
3d0e915088
Followup to 57853 2024-01-22 14:44:07 +01:00
avogar
b4dcd6755a Use ColumnConst instead of Field in IColumn::createWithOffsets 2024-01-22 13:41:58 +00:00
Sema Checherinda
66cd61eb7e remove flaky test 2024-01-22 14:17:25 +01:00
Nikita Taranov
4d6ef8ed86
Merge pull request #56961 from nickitat/some_questionable_code
Bypass `Poco::BasicBufferedStreamBuf` in `ReadBufferFromIStream`
2024-01-22 14:08:09 +01:00
Alexander Tokmakov
0f0785cf20
Merge pull request #59059 from ClickHouse/revert-58838-allow-parallel-replicas-for-join-with-analyzer
Revert "Allow parallel replicas for JOIN with analyzer [part 1]."
2024-01-22 14:07:26 +01:00
Dmitry Novik
a18a8d8ea3
Merge pull request #59009 from nickitat/uniq_optimisation_for_distributed
`uniqExact` state parallel merging for distributed queries
2024-01-22 14:05:02 +01:00
kssenii
4b4eac7c06 Fix 2024-01-22 13:55:15 +01:00
Alexander Tokmakov
4315d44517
Revert "Allow parallel replicas for JOIN with analyzer [part 1]." 2024-01-22 13:30:35 +01:00
alesapin
478b91cc37
Merge pull request #59010 from ClickHouse/alesapin-patch-1
Change log level for super imporant message in Keeper
2024-01-22 13:16:56 +01:00
kssenii
3faf4087e3 Fix 2024-01-22 12:07:49 +01:00
Sema Checherinda
9adab57771
Correct initialization of ConnectionTimeouts (#59000) 2024-01-22 12:03:36 +01:00
Kseniia Sumarokova
aec76d6653
Merge pull request #58877 from ClickHouse/multiple-read-file-log-storage-in-mv
Multiple read file log storage in mv
2024-01-22 12:02:41 +01:00
Alexander Sapin
f7b21b6016 Fix build 2024-01-22 11:53:21 +01:00
Antonio Andelic
274c128bd7 Free memory 2024-01-22 10:48:39 +00:00
skyoct
fdf8008804 Fix redirect retry 2024-01-22 10:27:35 +00:00
Sergei Trifonov
04a040ee5c
Merge pull request #59013 from ClickHouse/remove-static-resource-manager 2024-01-22 10:59:58 +01:00
Raúl Marín
d9ab300300
Merge pull request #57853 from jiebinn/rewriteSumFunction
Rewrite the AST/Analyzer of sum(column +/- literal) function
2024-01-22 10:41:30 +01:00
Antonio Andelic
59f9abcf58 Merge branch 'master' into keeper-reduce-memory 2024-01-22 08:04:17 +00:00
Antonio Andelic
ecaef80ea0
Merge pull request #58938 from ClickHouse/keeper-fetch-max-file-desc-once
Call `getMaxFileDescriptorCount` once in Keeper
2024-01-22 08:57:58 +01:00
MochiXu
02b178cc9c fix drop inverted index 2024-01-22 11:10:58 +08:00
jsc0218
6f3124acdb
Merge pull request #58402 from zhangyifan27/add_max_estimated_execution_time
Seperate max_execution_time and max_estimated_execution_time
2024-01-21 19:57:06 -05:00
Alexey Milovidov
37f70e07bd
Merge pull request #59022 from ClickHouse/better-visible-width
Better behavior of `visibleWidth`
2024-01-22 01:08:12 +01:00
Alexey Milovidov
eb4f61ba31
Update visibleWidth.cpp 2024-01-21 17:50:21 +03:00
alesapin
72f5dce9f4
Update src/Coordination/KeeperDispatcher.cpp
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2024-01-21 11:16:27 +01:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
Vitaly Baranov
9377f4276b
Merge pull request #58962 from vitlibar/fix-memory-dealloc-in-copy-data-to-s3
Fix memory management in copyDataToS3File
2024-01-20 23:35:42 +01:00
Igor Nikonov
4be068c73b
Merge pull request #58993 from ClickHouse/revert-58992-revert_flaky
Revive: Parallel replicas custom key: skip unavailable replicas
2024-01-20 19:44:56 +01:00
Nikita Taranov
bbf25b9cb9
Merge pull request #58996 from nickitat/fix_02404_with_analyzer
Fix 02404_memory_bound_merging with analyzer (follow up #56419)
2024-01-20 18:39:07 +01:00
serxa
5738a7cb36 Merge branch 'master' into remove-static-resource-manager 2024-01-20 17:33:56 +00:00
Sema Checherinda
1bbb5f7f51
Merge pull request #59015 from ClickHouse/chesema-adaptive-timeouts-gcp
preserve 'amz-sdk-invocation-id' and 'amz-sdk-request' headers with gcp
2024-01-20 17:48:20 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
f3a1a2f3ad
Fix build 2024-01-20 15:02:13 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
Kseniia Sumarokova
689e617c12
Merge pull request #58963 from ClickHouse/follow-up-disk-configuration
Follow up to #58357
2024-01-20 14:41:34 +01:00
serxa
208c92a7dc rename tests accordingly 2024-01-20 12:51:13 +00:00
serxa
172d68ceca Merge branch 'master' into cpu-scheduler 2024-01-20 12:21:21 +00:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00
Sergei Trifonov
50a153ef7e
Merge pull request #59011 from ClickHouse/fix-async-loader-assert
Fix async loader stress test
2024-01-20 12:11:26 +01:00
Alexey Milovidov
a8022ed624 Better behavior of visibleWidth 2024-01-20 11:22:23 +01:00
Alexey Milovidov
587295aca1
Merge pull request #58981 from azat/prom-handler
Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
2024-01-20 09:42:05 +01:00
Alexey Milovidov
0951cf8d64
Merge pull request #59006 from ClickHouse/disk-web-follow-up
DiskWeb fix loading
2024-01-20 06:54:39 +01:00
Alexey Milovidov
8acc981e8c
Merge pull request #59008 from ClickHouse/fix-log-level-for-http
Update log level for http buffer
2024-01-20 04:02:42 +01:00
Igor Nikonov
59025b2d3a Merge remote-tracking branch 'origin/master' into revert-58992-revert_flaky 2024-01-19 23:38:24 +00:00
Kruglov Pavel
20379d34d5
Merge branch 'master' into variant-data-type 2024-01-19 23:17:42 +01:00
Kruglov Pavel
e34b8b931d
Merge pull request #58555 from Avogar/settings-changes-check
Add settings changes check to Upgrade check (debug)
2024-01-19 23:16:37 +01:00
Sema Checherinda
539451bbe3 preserve 'amz-sdk-invocation-id' and 'amz-sdk-request' headers with gcp 2024-01-19 21:07:47 +01:00
Michael Kolupaev
fd361273f0 Fix StorageURL forgetting headers on server restart 2024-01-19 11:35:12 -08:00
serxa
3ace1cd087 Remove StaticResourceManager 2024-01-19 19:33:56 +00:00
Yarik Briukhovetskyi
e28fd94e1c
fix style 2024-01-19 20:19:34 +01:00
serxa
c8b1aff2a7 remove unnecessary assertion 2024-01-19 19:10:33 +00:00
alesapin
d275d79947
Update KeeperDispatcher.cpp 2024-01-19 19:25:27 +01:00
yariks5s
76b43a6aba small changes(revert) 2024-01-19 18:13:05 +00:00
Nikita Taranov
60a910e94f better 2024-01-19 18:47:21 +01:00
Jiebin Sun
e9662d4d62 polish the code and adjust some code style 2024-01-20 01:43:06 +08:00
Nikita Taranov
f1efb29a66 better 2024-01-19 18:13:03 +01:00
Alexey Milovidov
044df784e0
Update getMaxFileDescriptorCount.cpp 2024-01-19 20:07:38 +03:00
Vitaly Baranov
1a1b0894eb Rename function checkQueryNotCancelled() and add check for thread_group. 2024-01-19 18:05:30 +01:00
kssenii
4c8ced6af8 Fix log level 2024-01-19 18:04:58 +01:00
Alexey Milovidov
6a75641048
Merge pull request #58966 from ClickHouse/arseek
Fix seek in ReadBufferFromZipArchive
2024-01-19 18:04:03 +01:00
Alexey Milovidov
b249416671
Merge pull request #58968 from ClickHouse/clickhouse-local-less-threads
Less threads in `clickhouse-local`
2024-01-19 18:03:36 +01:00
Alexey Milovidov
3557bb6c73
Merge pull request #58971 from ClickHouse/better-error-message-tuples
Better error message about tuples
2024-01-19 18:03:13 +01:00
Antonio Andelic
0132455b39 Reduce Keeper memory usage 2024-01-19 17:00:53 +00:00
kssenii
f9fc4c9fe1 Fix style check 2024-01-19 17:59:44 +01:00
kssenii
226026e2aa Fix 2024-01-19 17:55:03 +01:00
Nikita Taranov
a47d15ab62 impl 2024-01-19 16:59:01 +01:00
Alexey Milovidov
decdb62cef
Merge pull request #58800 from ZhiguoZh/20240115-combine-filter-bmi2
Optimize DB::combineFilters with BMI2/SSE intrinsics
2024-01-19 16:50:04 +01:00
Smita Kulkarni
d22fc3a224 Updated to fetch default from settings 2024-01-19 16:13:58 +01:00
Dmitry Novik
728276ab3f Fix crash when indexHint() is used 2024-01-19 14:59:33 +00:00
Smita Kulkarni
c51d1f04f6 Add settings max_unexpected_write_error_retries for Azure Blob Storage 2024-01-19 15:57:20 +01:00
zhongyuankai
cbb51659f6
Merge branch 'master' into limit_materialized_view_size 2024-01-19 22:00:12 +08:00
Dmitry Novik
d8b5623c67 Analyzer: Support GROUP BY injective function elimination 2024-01-19 14:00:12 +00:00
Raúl Marín
47df16f896 Style is not happy with orphan headers 2024-01-19 14:28:18 +01:00
Nikita Taranov
0cafb58c47 impl 2024-01-19 14:17:50 +01:00
Raúl Marín
f6f30eb990 Fix DB::Field operators for Float64 2024-01-19 14:15:49 +01:00
Kseniia Sumarokova
facbd89d48
Merge pull request #58986 from ClickHouse/fix-typo
Fix typo
2024-01-19 14:12:50 +01:00
Igor Nikonov
131f71b50a
Revert "Revert flaky" 2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
This reverts commit 8ba9b4a7ef, reversing
changes made to 0f39245cb8.
2024-01-19 12:46:05 +00:00
Vitaly Baranov
19bc0b744f Add comments and const after review. 2024-01-19 12:54:55 +01:00
Azat Khuzhin
d940afd6cd Fix timeouts for HTTP/1.1 non-chunked requests (missing Connection: close)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-19 14:48:50 +03:00
kssenii
5113b719e9 Fix typo 2024-01-19 12:48:48 +01:00
kssenii
f055d668af Merge remote-tracking branch 'origin/follow-up-disk-configuration' into follow-up-disk-configuration 2024-01-19 12:31:44 +01:00
kssenii
9dea75b1e7 Fix 2024-01-19 12:30:49 +01:00
avogar
b1c67f143e Add more missing settings 2024-01-19 11:22:24 +00:00
Kseniia Sumarokova
7beb288b27
Update RegisterDiskObjectStorage.cpp 2024-01-19 12:09:58 +01:00
avogar
580501c2b4 Add new settings to settings changes history 2024-01-19 11:08:56 +00:00
avogar
8f2d78bbbf Merge branch 'master' of github.com:ClickHouse/ClickHouse into settings-changes-check 2024-01-19 11:04:50 +00:00
Kseniia Sumarokova
b6094ac233
Merge branch 'master' into filecache-small-optimization 2024-01-19 11:59:04 +01:00
avogar
0c85339ddb Fix style 2024-01-19 10:50:13 +00:00
Azat Khuzhin
38ad4ef493 Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive)
Before:

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m10.018s # default keep_alive_timeout is 10 seconds
    user    0m0.005s
    sys     0m0.001s

After

    $ time curl -s --http1.1 127.1:9363/metrics > /dev/null
    real    0m0.008s
    user    0m0.006s
    sys     0m0.000s

And if you will look at the test_prometheus_endpoint, you will see that
it takes > 30 seconds (it obtains metrics 3 times), after this patch it
should be finished more or less instantly.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-19 13:29:17 +03:00
avogar
7ae631de1e Remove wron check, remove duplicate tests 2024-01-19 10:23:40 +00:00
kssenii
2f34ef6ff8 Follow up 2024-01-19 11:19:59 +01:00
vdimir
b8340afddf
Merge pull request #58943 from ClickHouse/vdimir/analyzer_column_not_found
Analyzer: fix join column not found with compound identifiers
2024-01-19 10:40:03 +01:00
Kseniia Sumarokova
1c74e7fa08
Merge pull request #58902 from ClickHouse/fs-cache-refactorings
fs cache: minor refactoring
2024-01-19 10:25:45 +01:00
Jiebin Sun
0fb7d2290c
Update src/Analyzer/Passes/RewriteSumFunctionWithSumAndCountPass.cpp
Co-authored-by: Raúl Marín <git@rmr.ninja>
2024-01-19 17:01:11 +08:00
Alexey Milovidov
e9acae7774
Merge pull request #58950 from ClickHouse/fix-data-race-in-slru-2
Fix data race in slru (2)
2024-01-19 09:31:25 +01:00
Alexey Milovidov
8a288055c9
Merge pull request #58949 from MikhailBurdukov/fix_s3_copy
Using the destination object for  paths generation in S3copy.
2024-01-19 09:28:13 +01:00
Antonio Andelic
19ca00f233 Call getMaxFileDescriptorCount once 2024-01-19 08:19:20 +00:00
zhangyifan27
7e56a2d925 fix test failure when allow_experimental_analyzer=1 2024-01-19 16:11:30 +08:00
Alexey Milovidov
ff8e1d1595
Merge pull request #58930 from CurtizJ/fix-functions-to-subcolumns-pass
Fix `FunctionToSubcolumnsPass` in debug build
2024-01-19 08:40:55 +01:00
Alexey Milovidov
6792f72c6b Better error message about tuples 2024-01-19 06:26:11 +01:00
Alexey Milovidov
0c1e92aea5 Less threads in clickhouse-local 2024-01-19 04:53:14 +01:00
Alexey Milovidov
dcdbaf9150
Merge pull request #58900 from MikhailBurdukov/restriction_for_s3_access_key_id
Restriction for the access key id for s3.
2024-01-19 04:13:17 +01:00
Alexey Milovidov
370815803e
Update Client.cpp 2024-01-19 06:12:44 +03:00
Alexey Milovidov
bcff1bac47
Merge pull request #58874 from ClickHouse/disk-minor-improvement
DiskWeb minor improvement in loading
2024-01-19 03:52:05 +01:00
Michael Kolupaev
3a19ea6e6c Fix seek in ReadBufferFromZipArchive 2024-01-19 01:46:07 +00:00
avogar
cfc8c60aa7 Fix build 2024-01-18 21:26:55 +00:00
Robert Schulze
1bfeee1954
Some fixups 2024-01-18 20:49:50 +00:00
Kseniia Sumarokova
7f92bf6f0b
Merge pull request #58921 from ClickHouse/add-a-test-for-azure
Fix and test for azure #58697
2024-01-18 21:41:54 +01:00
avogar
3dcc2056a5 Fix conflicts 2024-01-18 20:39:36 +00:00
Vitaly Baranov
24ca8fbbec Improve logs. 2024-01-18 21:15:39 +01:00
Vitaly Baranov
0caafe4810 Fix memory deallocation in copyDataToS3File()
- ReadBufferFromS3 is created now only when it's necessary and destroyed after that.
2024-01-18 20:48:56 +01:00
Yakov Olkhovskiy
43aaccdaa1 clang tidy 2024-01-18 19:17:05 +00:00
Robert Schulze
15700592f7
Merge remote-tracking branch 'ClickHouse/master' into column_level_compress_block 2024-01-18 19:12:57 +00:00
Nikita Taranov
b5e333df96 remove test 2024-01-18 19:56:02 +01:00
Yakov Olkhovskiy
1144f60515 clenup 2024-01-18 18:17:07 +00:00
Yakov Olkhovskiy
b914938c4c clenup 2024-01-18 18:10:54 +00:00
Yakov Olkhovskiy
bb1058e2b2 fix storage replacement with insertion block for analyzer 2024-01-18 17:59:23 +00:00
Kruglov Pavel
5444cde408
Merge branch 'master' into variant-data-type 2024-01-18 18:31:27 +01:00
avogar
f202d71371 Make alter with variant espansion as no-op, add tests for alters 2024-01-18 17:29:36 +00:00
slvrtrn
0ec385064c Add SIGNED/UNSIGNED aliases for Int64/UInt64 2024-01-18 17:28:47 +01:00
Anton Popov
d2142041cd Merge remote-tracking branch 'upstream/master' into HEAD 2024-01-18 16:03:54 +00:00
Kseniia Sumarokova
bfe8037653
Merge branch 'master' into fix-data-race-in-slru-2 2024-01-18 16:54:52 +01:00
kssenii
d20a33424f Fix race 2024-01-18 16:53:10 +01:00
yariks5s
6ad6d6a121 fix due to review 2024-01-18 15:41:25 +00:00
MikhailBurdukov
b3d74fc907 style 2024-01-18 15:39:25 +00:00
Robert Schulze
cf115e696b
Merge pull request #58929 from slvrtrn/mysql-show-warnings
Add `SHOW WARNINGS` support in MySQL interface
2024-01-18 16:24:50 +01:00
MikhailBurdukov
eac310fcb2 Review 2024-01-18 15:19:11 +00:00
avogar
8ac04c6dd8 Address comments 2024-01-18 15:15:57 +00:00
Alexander Gololobov
e9919f47c1 Move paramaters from span name to attributes 2024-01-18 14:26:19 +01:00
Dmitry Novik
ba2dad98bb
Merge pull request #58913 from ClickHouse/fix-style
Style fix
2024-01-18 14:24:39 +01:00
Nikolai Kochetov
9db8b50753
Merge pull request #58838 from ClickHouse/allow-parallel-replicas-for-join-with-analyzer
Allow parallel replicas for JOIN with analyzer [part 1].
2024-01-18 14:01:08 +01:00
vdimir
f2e73c13a9
Analyzer: fix join column not found with compound identifiers 2024-01-18 12:30:28 +00:00
Vitaly Baranov
4c6d3e7efa Add server settings "shutdown_wait_backups_and_restores" (default=true)
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
János Benjamin Antal
f34d1ae647 Use WithContext 2024-01-18 11:47:59 +00:00
MikhailBurdukov
7518241be4 Use dest object storage to native copy for path generation. 2024-01-18 11:46:16 +00:00
robot-ch-test-poll
2030d7f609
Merge pull request #58917 from azat/fix-fault-handler
Fix fault handler in case of thread (for fault handler) cannot be spawned
2024-01-18 12:46:03 +01:00
kssenii
dd396b678a Fix data race 2024-01-18 12:23:40 +01:00
kssenii
9b674e640d Fxi 2024-01-18 12:20:40 +01:00
Jiebin Sun
206e1c87e0 revise the comments 2024-01-18 19:07:02 +08:00
Robert Schulze
316669b90f
Merge pull request #58396 from zenmiao7/u/zhengmiao/AddArrayFunctionShingles
Add function `arrayShingles()`
2024-01-18 11:38:56 +01:00
vdimir
1595dd8a3f
Merge pull request #56396 from ClickHouse/vdimir/disable_max_rows_in_set_to_optimize_join
Disable max_rows_in_set_to_optimize_join
2024-01-18 10:32:28 +01:00
Duc Canh Le
b16a4cf361 add document
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-18 07:55:44 +00:00
Antonio Andelic
30a04471ac
Merge pull request #58806 from ClickHouse/fix-keeper-data-race
Fix data race in Keeper
2024-01-18 08:48:16 +01:00
Tim Liou
a5d15c10e8 use getPriorityName 2024-01-18 14:51:21 +08:00
robot-ch-test-poll
fba4d3f427
Merge pull request #58896 from ClickHouse/fix-data-race-aggregatetransform
Fix data race in `AggregatingTransform`
2024-01-18 07:46:49 +01:00
Duc Canh Le
22afcd46f4 add ALTER COLUMN MODIFY/RESET SETTING
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-18 05:17:07 +00:00
Srikanth Chekuri
c23c7e0b6f
feat: add DDSketch quantile (#56342)
* feat: add DDSketch quantile

* Fix StyleCheck

* Move quantileddsketch.md under right dir

* Update stateless test number and add stateful test

* Throw exception when relative accuracy is too low

* Update test number

* Fix undefined behaviour for empty store

* Fix quantileGK test

* Update test numbers

* Update src/AggregateFunctions/

* Throw exception on out of range values

* Update relative accuracy docs and add encoding details

* Address review comments and suggestions

* Remove unused function

* Address alexey review comments

* Remove unused function isFloat64FieldType

* Throw error on invalid relative accuracy

* Simplify mapping

* Address remaining review comments

* Add effective memory usage suggestions

* Fix Stylecheck

* Fix fast test

* Incorporate bins capacity suggestion

* Fix fuzzer

* Remove inheritance in Mapping, Store and DDSketch

* Add checks for bin resizing

* Add note about the binary compatible implementation
2024-01-17 19:51:32 -08:00
Yakov Olkhovskiy
490bb809c3
Merge pull request #58846 from ClickHouse/fix-compress-destructor
Fix HTTP compressors finalization
2024-01-17 17:49:12 -05:00
Anton Popov
94bb9a171d fix FunctionToSubcolumnsPass 2024-01-17 21:36:23 +00:00
Alexey Milovidov
67f74b5520
Merge pull request #58362 from ClickHouse/fix-suspended-workers
Fix suspended workers for AsyncLoader
2024-01-17 22:10:43 +01:00
slvrtrn
cb8372a3f9 Add SHOW WARNINGS support in MySQL interface 2024-01-17 22:00:48 +01:00
Alexey Milovidov
7731297aef
Merge pull request #58894 from ClickHouse/whitespace-4
Whitespaces
2024-01-17 21:01:22 +01:00
Alexey Milovidov
f499cf3fd5
Update Client.cpp 2024-01-17 22:30:18 +03:00
kssenii
ef48b90bca Fix and test 2024-01-17 18:44:09 +01:00
Alexander Gololobov
0a42dbafe8 Add attributes 2024-01-17 17:46:15 +01:00
Anton Popov
72b0fed4ef
Merge pull request #58729 from CurtizJ/nested-size0
Fix reading of offsets subcolumn (`size0`) from `Nested`
2024-01-17 17:16:27 +01:00
Alexey Milovidov
4ac063ffe9
Merge pull request #58890 from chhetripradeep/pchhetri/add-keeper-soft-limit-metric
Add metric for keeper memory soft limit
2024-01-17 17:11:53 +01:00
Alexey Milovidov
1161dbbd54
Merge pull request #57993 from mkmkme/mkmkme/reload-config-again
Update `query_masking_rules` when reloading the config, attempt 2
2024-01-17 17:09:36 +01:00
Azat Khuzhin
c6225bdda2 Fix fault handler in case of thread (for fault handler) cannot be spawned
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-17 18:49:02 +03:00
Robert Schulze
226f1804b7
Fix spelling and style 2024-01-17 15:26:18 +00:00
Nikita Taranov
1db805dfa4 impl 2024-01-17 16:24:24 +01:00
Alexander Gololobov
7dda18c209 Spans in mergeBlock and finalizeImpl 2024-01-17 16:07:53 +01:00
Dmitry Novik
3a1c3638e8 Style fix 2024-01-17 15:04:50 +00:00
Yarik Briukhovetskyi
38914ef70c
Update QueryAnalysisPass.cpp 2024-01-17 15:48:26 +01:00
Yarik Briukhovetskyi
f05733e7b8
Update QueryAnalysisPass.cpp 2024-01-17 15:28:02 +01:00
Jiebin Sun
784cab638a rename some function_name and add more tests 2024-01-17 22:10:08 +08:00
kssenii
dd9e56f08f Better 2024-01-17 14:58:42 +01:00
Kruglov Pavel
c701633955
Merge pull request #58805 from ucasfl/avro-zstd
Avro format support Zstd codec
2024-01-17 14:55:54 +01:00
kssenii
591a9f9661 Update unit tests 2024-01-17 14:52:24 +01:00
Anton Popov
245e1cbd5c Merge remote-tracking branch 'upstream/master' into better-read-buffers 2024-01-17 13:46:48 +00:00