Commit Graph

5162 Commits

Author SHA1 Message Date
kssenii
de70a57700 Better 2021-12-21 21:48:25 +03:00
kssenii
175ad8a989 Fix 2021-12-21 00:20:08 +03:00
kssenii
965e2bfb21 Fix 2021-12-20 08:43:07 +03:00
alexey-milovidov
6083869b5d
Merge pull request #32669 from Algunenano/wip_mv_into_join
Fix LOGICAL_ERROR when the target of a materialized view is a JOIN or a SET table
2021-12-16 02:01:31 +03:00
alexey-milovidov
d112b30d78
Merge pull request #32291 from cmsxbc/fix-multiply-row-policies-on-same-column
Fix broken select query with multiply row policies on same column
2021-12-16 01:52:12 +03:00
Maksim Kita
655cc20525
Merge pull request #32758 from kitaisreal/sql-user-defined-functions-support-subqueries
SQLUserDefinedFunctions support subqueries
2021-12-15 15:57:20 +03:00
mergify[bot]
c915b26a17
Merge branch 'master' into fix-multiply-row-policies-on-same-column 2021-12-14 16:21:35 +00:00
alesapin
d7663b2179 Merge branch 'master' into fix_special_build_check 2021-12-14 19:08:28 +03:00
alesapin
884801e1bd Fixing 2021-12-14 19:08:08 +03:00
Maksim Kita
c4bc72672e SQLUserDefinedFunctions support subqueries 2021-12-14 18:46:21 +03:00
Anton Popov
bbb981655d
Merge pull request #32695 from CurtizJ/fix-add-ttl
Fix `MATERIALIZE TTL` with `TTL WHERE` and `TTL GROUP BY`
2021-12-14 14:01:15 +03:00
mergify[bot]
96f6915233
Merge branch 'master' into wip_mv_into_join 2021-12-14 01:31:47 +00:00
Kseniia Sumarokova
dadaeabda7
Merge pull request #32670 from CurtizJ/fix-reading-in-order
Fix reading in order of sorting key from `Distributed` and `Merge` tables
2021-12-14 00:42:48 +03:00
Kseniia Sumarokova
a9ca84ff7d
Merge pull request #32325 from stigsb/table-overrides
Add TABLE OVERRIDE feature for MaterializedMySQL databases
2021-12-13 20:39:42 +03:00
Anton Popov
0b68980977 fix MATERIALIZE TTL with WHERE and GROUP BY 2021-12-13 17:21:05 +03:00
Kruglov Pavel
52328f6abc
Merge pull request #32490 from ClickHouse/quote-more-identifiers
Fix issue with ambiguous query formatting in distributed queries.
2021-12-13 16:41:01 +03:00
Anton Popov
745fd4fc16 fix reading in order from Distributed and Merge tables 2021-12-13 15:35:25 +03:00
Raúl Marín
b25cfa0b4d InterpreterInsertQuery::buildChain: Make sure to keep the context alive 2021-12-13 11:50:46 +01:00
tavplubix
be35ab171b
Merge pull request #32572 from azat/DROP-INSERT-UAF-fix
Fix table lifetime in case of parallel DROP TABLE and INSERT
2021-12-12 17:05:07 +03:00
cmsxbc
e4b405716f fix multiply row policies on same column 2021-12-12 09:54:07 +00:00
Alexey Milovidov
453135eb63 Fix indecent error message 2021-12-12 05:24:47 +03:00
Alexey Milovidov
58ffe89643 Merge branch 'master' into quote-more-identifiers 2021-12-12 03:33:20 +03:00
Azat Khuzhin
9a71598973 Fix table lifetime in case of parallel DROP TABLE and INSERT
Stress tests founds [1]:

==527==WARNING: MemorySanitizer: use-of-uninitialized-value
    0 0x37078ffd in unsigned long std::__1::__cxx_atomic_fetch_add<unsigned long>(std::__1::__cxx_atomic_base_impl<unsigned long>*, unsigned long, std::__1::memory_order) obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1050:12
    1 0x37078ffd in std::__1::__atomic_base<unsigned long, true>::fetch_add(unsigned long, std::__1::memory_order) obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1719:17
    2 0x37078ffd in std::__1::__atomic_base<unsigned long, true>::operator++() obj-x86_64-linux-gnu/../contrib/libcxx/include/atomic:1756:57
    3 0x37078ffd in SimpleIncrement::get() obj-x86_64-linux-gnu/../src/Common/SimpleIncrement.h:20:16
    4 0x37078ffd in DB::MergeTreeDataWriter::writeTempPart(DB::BlockWithPartition&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::__1::shared_ptr<DB::Context const>) obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeDataWriter.cpp:276:46
    5 0x373c446c in DB::MergeTreeSink::consume(DB::Chunk) obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeSink.cpp:27:65

  Uninitialized value was created by a heap deallocation
    6 0x32d481e8 in DB::DatabaseCatalog::TableMarkedAsDropped::~TableMarkedAsDropped() obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.h:248:12
    7 0x32d3c134 in DB::DatabaseCatalog::dropTableDataTask() obj-x86_64-linux-gnu/../src/Interpreters/DatabaseCatalog.cpp:908:1

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/32534/fa6090f588dbf4cbb5f28bd2210847b070bb8218/stress_test__memory__actions_.html

The query was CREATE MATERIALIZED VIEW ... POPULATE AS SELECT ... from
00040_aggregating_materialized_view test.
2021-12-11 11:00:31 +03:00
alexey-milovidov
c90e588e24
Merge pull request #32506 from ClickHouse/fix-has-column-in-table-subquery
Fix queries with hasColumnInTable constant condition and non existing column
2021-12-11 02:50:06 +03:00
alexey-milovidov
17e5f5ccfe
Merge pull request #32508 from vdimir/issue_32458
Handle const column in JoinCommon::removeColumnNullability
2021-12-11 01:21:10 +03:00
Anton Popov
37837f3881
Merge pull request #32453 from kssenii/disable-optimizations-for-window-functions
Disable some optimizations for window functions
2021-12-11 00:37:24 +03:00
vdimir
ed4ea6fe3a
Handle const column in JoinCommon::removeColumnNullability 2021-12-10 15:57:36 +03:00
Nikolai Kochetov
7bf5c83561 Fix queries with hasColumnInTable constant condition and non existing column. 2021-12-10 15:45:04 +03:00
Alexey Milovidov
5c90ed2ed9 Unambiguous formatting of distributed queries 2021-12-10 00:55:14 +03:00
Nikolai Kochetov
e41974fabf
Merge branch 'master' into fix-31538 2021-12-09 19:00:22 +03:00
Nikolai Kochetov
272c0bb35a Fix crash in case of MATERIALIZE COLUMN with no default expression. 2021-12-09 18:58:28 +03:00
kssenii
40c9ffdfff Disable 2021-12-09 14:15:23 +03:00
Nikita Mikhaylov
dbf5091016
Parallel reading from replicas (#29279) 2021-12-09 13:39:28 +03:00
Nikita Mikhaylov
7a8fe9a9ad
Merge pull request #32234 from FrankChen021/span_name
Improve the operation name of an opentelemetry span
2021-12-08 15:46:19 +03:00
Nikita Mikhaylov
9a6a1379fd
Merge pull request #32358 from nikitamikhaylov/mutation-livelock
Fixed empty mutations livelock
2021-12-08 15:43:19 +03:00
Kruglov Pavel
e0a8c5a4ac
Merge pull request #32348 from CurtizJ/fix-materialize-column
Add cast to `MATERIALIZE COLUMN`
2021-12-08 11:13:17 +03:00
Nikita Mikhaylov
76f91c2c6c Done 2021-12-07 16:50:57 +00:00
Anton Popov
ef7ae7cb75 fix MATERIALIZE COLUMN in case when data type of expression is not equal to data type of column 2021-12-07 16:45:30 +03:00
mergify[bot]
79351e9d59
Merge branch 'master' into span_name 2021-12-07 12:05:48 +00:00
Stig Bakken
bb521cd363 Add TABLE OVERRIDE feature for MaterializedMySQL databases 2021-12-07 09:45:02 +01:00
dongyifeng
9df664e1c9
fix bug when remove unneeded columns in subquery (#32289) 2021-12-07 11:09:39 +03:00
tavplubix
657db07795
Merge pull request #32288 from ClickHouse/fix_xml_dict_cyclic_dependency
Fix cyclic dependency with XML dictionary and StorageDictionary
2021-12-06 20:02:38 +03:00
Alexander Tokmakov
7797a72907 fix false-positive ciclyc dependency with XML dict 2021-12-06 16:35:43 +03:00
Maksim Kita
11df9a6bc4
Merge pull request #32187 from kitaisreal/dictionary-qualify-name-with-database-fix
DictionariesLoader qualify name with database fix
2021-12-06 15:11:09 +03:00
Maksim Kita
1ec9039b1d ExternalDictionariesLoader fix getCurrentDatabase multiple times 2021-12-06 14:01:56 +03:00
Kruglov Pavel
007e323515
Merge pull request #31820 from kitaisreal/fix-recursive-user-defined-functions-crash
Fix recursive user defined functions crash
2021-12-06 13:52:56 +03:00
Nikolai Kochetov
91c4c89c66
Merge pull request #31636 from Algunenano/pull_timeout
Check max_execution_time in the pipeline and pulling executors
2021-12-06 11:33:39 +03:00
frank chen
55d50c0b4d Improve span operation name
Signed-off-by: frank chen <frank.chen021@outlook.com>
2021-12-04 21:56:52 +08:00
Maksim Kita
4c916a0e38 DictionariesLoader qualify name with database fix 2021-12-03 14:31:49 +03:00
mergify[bot]
478c35538d
Merge branch 'master' into trace_finish_time_bug 2021-12-03 10:12:48 +00:00