Commit Graph

8594 Commits

Author SHA1 Message Date
Alexander Sapin
5a524a7819 Remove empty lines 2018-06-05 22:20:16 +03:00
Alexander Sapin
4e3dc0d8a2 Introduce logging in shared library dictionaries 2018-06-05 22:17:16 +03:00
Alexey Zatelepin
3947f25365 add general comment about the mutation algorithm [#CLICKHOUSE-3747] 2018-06-05 17:55:35 +03:00
Alexey Zatelepin
2fde0acb36 allow ALTER DELETE in distributed DDL [#CLICKHOUSE-3688] 2018-06-05 16:23:52 +03:00
alexey-milovidov
39e69b421a
Merge pull request #2468 from yandex/fix-partition-key-parts-pruning
Fix pruning of parts by conditions on partition key columns
2018-06-05 15:52:47 +03:00
proller
4d12a823da Use copy-headers from cmake. (working compiler test without package install) (#2456)
* Try use copy-headers from cmake [WIP]

* Using internal compiler without install

* 32bit Compile fix

* Fixes

* fix

* clean

* fix

* clean
2018-06-04 23:26:17 +03:00
alexey-milovidov
f69ecf7a9d
Merge pull request #2448 from LiuYangkuan/fix-issue-2439
fix Exception in issue#2439
2018-06-04 23:17:44 +03:00
alexey-milovidov
3af746aab1
Merge pull request #2462 from proller/fix19
Build fixes
2018-06-04 23:17:21 +03:00
alexey-milovidov
88efe5ad56
Merge pull request #2463 from yandex/pvs-studio
Fixes according to PVS-Studio report.
2018-06-04 22:59:47 +03:00
Alexey Milovidov
0f96a5c1c5 Suppressions for PVS-Studio [#CLICKHOUSE-3] 2018-06-04 22:46:47 +03:00
Alexey Milovidov
a6caf556ef Fixed potential issue found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 22:43:38 +03:00
Alexey Milovidov
f467fb38c7 Fixed bug found by PVS-Studio; added test [#CLICKHOUSE-3] 2018-06-04 22:37:58 +03:00
Alexey Milovidov
ca52d96e09 Insignificant changes for PVS-Studio [#CLICKHOUSE-3] 2018-06-04 22:22:27 +03:00
proller
9907388766 32bit Compile fix 2018-06-04 20:04:31 +03:00
Alexey Milovidov
e5682e81f7 Slightly better (preparation) [#CLICKHOUSE-3] 2018-06-04 20:01:00 +03:00
Alexey Zatelepin
a9b348fe5e check if partition key condition can be true in parallelogram instead of range [#CLICKHOUSE-3757] 2018-06-04 19:20:02 +03:00
Alexey Zatelepin
ec7446e541 calculate primary key when mutating a part [#CLICKHOUSE-3747] 2018-06-04 18:45:34 +03:00
Alexey Milovidov
df11490b2a Insignificant changes guided by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:45:08 +03:00
Alexey Milovidov
5fa1cdf49e Better code (preparation) [#CLICKHOUSE-3] 2018-06-04 18:44:29 +03:00
Alexey Milovidov
d811647668 Suppressions for PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:28:25 +03:00
Alexey Milovidov
9b4823769a Better fix [#CLICKHOUSE-3] 2018-06-04 18:26:20 +03:00
Alexey Milovidov
522cd82e76 Non significant change: slightly better [#CLICKHOUSE-3] 2018-06-04 18:07:32 +03:00
Alexey Milovidov
1001209e2a Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:05:19 +03:00
Alexey Milovidov
fa3a01f942 Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:03:21 +03:00
Alexey Milovidov
531e9d14be Non significant change: slightly better [#CLICKHOUSE-3] 2018-06-04 18:01:24 +03:00
Alexey Milovidov
de72b4adde Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:01:18 +03:00
alexey-milovidov
f428f30bc6
Merge pull request #2461 from yandex/CLICKHOUSE-3749
Clickhouse-3749
2018-06-04 17:24:35 +03:00
Alexey Milovidov
1829aba596 Non significant change: slightly better [#CLICKHOUSE-3] 2018-06-04 17:17:47 +03:00
Alexey Milovidov
278ccdff73 Non significant change: removed redundant checks [#CLICKHOUSE-3] 2018-06-04 17:17:24 +03:00
Alexey Milovidov
9cbcfc87f2 Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 17:16:08 +03:00
Nikolai Kochetov
1b4c294f01 Added left tuple argument unpacking for IN function if it doesn't equals to set types. [#CLICKHOUSE-3749] 2018-06-04 16:30:38 +03:00
Alexey Zatelepin
2e77c508ad add comments [#CLICKHOUSE-3747] 2018-06-04 14:43:09 +03:00
Alexey Zatelepin
e55097b866 introduce constants for max level and max block number 2018-06-04 14:23:47 +03:00
Alexey Milovidov
8cb65277e2 Non significant changes according to clang's -Weverything, part 5 [#CLICKHOUSE-2] 2018-06-04 01:11:50 +03:00
Alexey Milovidov
7c60adbebb Non significant changes according to clang's -Weverything, part 4 [#CLICKHOUSE-2] 2018-06-03 23:48:36 +03:00
Alexey Milovidov
f5adbceed2 Non significant changes according to clang's -Weverything, part 3 [#CLICKHOUSE-2] 2018-06-03 23:39:06 +03:00
Alexey Milovidov
1c2b024c39 Non significant changes according to clang's -Weverything, part 2 [#CLICKHOUSE-2] 2018-06-03 20:43:56 +03:00
Alexey Milovidov
734cebdf09 Non significant changes according to clang's -Weverything, part 1 [#CLICKHOUSE-2] 2018-06-03 19:51:31 +03:00
alexey-milovidov
02f7277dc7
Update ReplicatedMergeTreeQueue.h 2018-06-01 21:06:43 +03:00
alexey-milovidov
46cb408fd8
Update BackgroundSchedulePool.cpp 2018-06-01 16:35:16 +03:00
Alexey Zatelepin
af06ca5d3c Merge branch 'master' into replicated-mergetree-mutations 2018-06-01 16:21:14 +03:00
Alexey Milovidov
3cb68784ad Miscellaneous [#CLICKHOUSE-3753] 2018-05-31 22:30:08 +03:00
Alexey Milovidov
515bd29df7 Better name [#CLICKHOUSE-3753] 2018-05-31 22:28:30 +03:00
Alexey Milovidov
5dbd5b6d68 Fixed error in ZK library [#CLICKHOUSE-3753] 2018-05-31 22:26:21 +03:00
Alexey Milovidov
f45c479a8b Removed wrong query optimization [#CLICKHOUSE-3726] 2018-05-31 21:28:04 +03:00
Alexey Zatelepin
f63d2dc3c8 cannot take a number of unlocked abandonable lock 2018-05-31 20:28:17 +03:00
Alexey Zatelepin
c9bb986330 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Storages/MergeTree/AbandonableLockInZooKeeper.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-05-31 18:52:42 +03:00
Alexey Zatelepin
dbf6949e0b support skipping mutations (just in case) [#CLICKHOUSE-3747] 2018-05-31 18:21:00 +03:00
Babacar Diassé
3d518e48b9 NULL check to allow insertion in distributed tables with Materialized views 2018-05-31 17:21:35 +03:00
Vitaliy Lyudvichenko
dc5de3bbec More optimal conflicts check in future_parts. [#CLICKHOUSE-2] 2018-05-31 17:14:50 +03:00
Vitaliy Lyudvichenko
888f5f4a24 Allow merges after CLEAR COLUMN. [#CLICKHOUSE-3]
Resolves #2315
2018-05-31 17:14:50 +03:00
Alexey Zatelepin
d89221c458 easier init and deactivation of BackgroundSchedulePool tasks 2018-05-31 16:18:52 +03:00
alexey-milovidov
cdacf073e8
Merge pull request #2449 from proller/fix15
CLICKHOUSE-3587 Always write client error to log
2018-05-30 22:27:21 +03:00
proller
dc721ed721 Try make cache for getSampleBlock (#2313)
* Cache for getSampleBlock

* Update InterpreterSelectWithUnionQuery.cpp

* Update 00632_get_sample_block_cache.sql

* Add tests
2018-05-30 22:23:15 +03:00
proller
b1f4bf3199 CLICKHOUSE-3587 Always write client error to log 2018-05-30 19:15:35 +03:00
LiuYangkuan
7eb25ef55b fix Exception in issue#2439 2018-05-30 11:11:53 -04:00
Vadim
31a6613105 fix error 2018-05-30 02:01:36 +03:00
proller
ead9493741 Build fixes 2018-05-29 20:54:48 +03:00
proller
0cd644f5ec Fix test (no zookeeper detection) 2018-05-29 15:48:36 +03:00
Vadim
3aa24d39d4 Add comparison and fix functions 2018-05-28 23:01:20 +03:00
Alexey Zatelepin
f6c72f8e56 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Common/ActionBlocker.h
	dbms/src/Storages/MergeTree/ActiveDataPartSet.cpp
	dbms/src/Storages/MergeTree/ActiveDataPartSet.h
	dbms/src/Storages/MergeTree/MergeTreeData.h
	dbms/src/Storages/MergeTree/MergeTreeDataPart.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeAlterThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeRestartingThread.cpp
	dbms/src/Storages/StorageMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.h
2018-05-28 18:37:30 +03:00
Vitaliy Lyudvichenko
7615f5a09a More detail dignostic when parse JSONEachRow. [#CLICKHOUSE-2] 2018-05-28 14:40:07 +03:00
Vadim
79791ead1e Add startsWith and endsWith 2018-05-28 01:43:31 +03:00
Alexey Zatelepin
59fe12ed15 part log and metrics [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
aff6ad42ed support empty parts [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
2b80fbf972 DROP PARTITION now works with mutated parts [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
fdb33d8f3c execute mutation log entries [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
fd81cc7f66 mutation executor for MergeTree [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
1147e052e8 select and write part mutations to queue [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
41b7e533cd more honest constness in ActionBlocker 2018-05-25 23:06:36 +03:00
Alexey Zatelepin
2721daf782 don't select merges of parts with different mutation versions [#CLICKHOUSE-3747] 2018-05-25 23:06:28 +03:00
Alexey Zatelepin
4c661df146 notify relevant events directly from queue [#CLICKHOUSE-3747] 2018-05-25 23:06:23 +03:00
Alexey Zatelepin
42850f09b7 load mutations from ZK [#CLICKHOUSE-3747] 2018-05-25 23:06:15 +03:00
Alexey Zatelepin
49439aa2d2 write mutations to ZK [#CLICKHOUSE-3747] 2018-05-25 23:06:08 +03:00
Alexey Zatelepin
4ca3bf65f3 test getting abandonable lock in all partitions [#CLICKHOUSE-3747] 2018-05-25 23:05:10 +03:00
Alexey Zatelepin
9a32c76e76 parts versioning [#CLICKHOUSE-3687] 2018-05-25 23:04:07 +03:00
Alexey Zatelepin
17437a95bf merge selection based on checking current inserts [#CLICKHOUSE-3732] 2018-05-25 23:03:56 +03:00
alexey-milovidov
dcebf08620
Merge pull request #2400 from bocharov/master
Fix DateTime vs DateTime('UTC') inconsistency on data read.
2018-05-25 21:44:11 +03:00
Amos Bird
9eec14e9be Let's make it fancier (function try catch block). 2018-05-25 23:38:57 +08:00
Alexey Milovidov
13762471da Changed DayNum_t to DayNum as Amos Bird suggested [#CLICKHOUSE-3] 2018-05-25 16:29:15 +03:00
proller
87e8d8be5a
Fix internal compiler includes with new clang (#2406) 2018-05-24 15:40:02 +03:00
Vitaliy Lyudvichenko
87ad1df259 More atomic insert to MATERIALIZED VIEW. [#CLICKHOUSE-3743] 2018-05-23 19:18:04 +03:00
Vitaliy Lyudvichenko
6cc7068c6b Supress dummy program_options assertions in Debug. [#CLICKHOUSE-2] 2018-05-23 19:14:00 +03:00
Alex Bocharov
3618842579 Fix DateTime vs DateTime('UTC') inconsistency on data read.
Original problem was described in PR #1650 and partially fixed by
b5af4c95, however one place was forgotten and it was causing query
exceptions when trying to read DateTime column across parts with
different DateTime and DateTime('UTC') data type.
2018-05-22 12:23:07 +01:00
alexey-milovidov
2b581ed2c3
Merge pull request #2293 from proller/fix19
`clickhouse-client`: option --ask-password for interactively ask for credentials #1044
2018-05-21 22:54:32 +03:00
alexey-milovidov
55cfebc36b
Merge pull request #2395 from yandex/string_range-pointers-comparsion
Renamed StringRangeHash to StringRangePointersHash and added StringRa…
2018-05-21 22:42:42 +03:00
proller
051395a761 clickhouse-client: option --ask-password for interactively ask for credentials #1044 2018-05-21 20:27:18 +03:00
Vitaliy Lyudvichenko
8349d2b9a0 Fixed gcc7 compilation. [#CLICKHOUSE-2] 2018-05-21 18:10:50 +03:00
Vitaliy Lyudvichenko
c888903488
Add query ALTER TABLE t1 [REPLACE|ATTACH] PARTITION FROM t2
* Add ATTACH PARTITION FROM table for MergeTree. [#CLICKHOUSE-3546]

* Implemented replicated case on non-leader replica. [#CLICKHOUSE-3546]

* Disable merges in the dropping range. [#CLICKHOUSE-3546]

* DROP PARTITION is atomic and simpler now. [#CLICKHOUSE-3546]

* Implemented more SYSTEM queries. [#CLICKHOUSE-2931] [#CLICKHOUSE-3546]

SYSTEM queries:
RESTART REPLICAS
SYNC REPLICA db.name
STOP MERGES [db.name]
START MERGES [db.name]
STOP FETCHES [db.name]
START FETCHES [db.name]
STOP REPLICATED SENDS [db.name]
START REPLICATED SENDS [db.name]
STOP REPLICATION QUEUES [db.name]
START REPLICATION QUEUES [db.name]

* Fixed a bunch of bugs in REPLACE PARTITION. [#CLICKHOUSE-3546]

* Add tests for REPLACE PARTITION and SYSTEM. [#CLICKHOUSE-3546]

* Add system.part_log logging. [#CLICKHOUSE-3546]

* Fixed long wait in SYNC REPLICA. [#CLICKHOUSE-3546]

* Add requested changes. [#CLICKHOUSE-3546]

Fixed clickhouse-client bad return code.

* Add requested chenges. [#CLICKHOUSE-3546]

* Add requested chenges. [#CLICKHOUSE-3546]
2018-05-21 16:49:54 +03:00
Nikolai Kochetov
aeaec2e6d7 Renamed StringRangeHash to StringRangePointersHash and added StringRangePointersEqualTo. 2018-05-21 14:18:11 +03:00
zhang2014
3afb33593a ISSUES-2260 add some improvements 2018-05-21 13:26:35 +08:00
zhang2014
fa865636ce ISSUES-2259 add comment & move delete database metadata implementation 2018-05-21 11:38:46 +08:00
zhang2014
c8f655c1aa ISSUES-2259 fix the test after the merge master 2018-05-21 11:38:46 +08:00
zhang2014
6613e56784 ISSUES-2259 support truncate syntax 2018-05-21 11:38:46 +08:00
alexey-milovidov
0fe2984d00
Merge pull request #2388 from yandex/fix-prepared-sets-creation
Fix prepared sets creation
2018-05-19 19:03:04 +03:00
alexey-milovidov
517318334a
Merge pull request #1722 from silviucpp/background-schedule-pool-fix
Background schedule pool fixed
2018-05-19 19:00:43 +03:00
Alexey Milovidov
577268d8f5 Style #2387 2018-05-18 21:31:18 +03:00
Alexey Milovidov
74a6b0010f utils/check-style/fix-style #2387 2018-05-18 21:30:02 +03:00
Nikolai Kochetov
a4b04739c8 Renamed need_parents back to need_parens. [#CLICKHOUSE-3735] 2018-05-18 21:28:11 +03:00
Nikolai Kochetov
f739078ea5 Fixed IAST::clone() implementations which were without children deep copy. [#CLICKHOUSE-3735] 2018-05-18 21:28:11 +03:00