Commit Graph

3038 Commits

Author SHA1 Message Date
Alexey Milovidov
829bd066c4 Fix progress bar 2022-02-21 00:25:07 +01:00
Azat Khuzhin
9b749ae90b Fix undefined __pthread_mutex_lock/unlock for glibc 2.34+/DISABLE_HERMETIC_BUILD
Right now it fails with:

    ld.lld: error: undefined symbol: __pthread_mutex_lock
    >>> referenced by ThreadFuzzer.cpp:300 (./src/Common/ThreadFuzzer.cpp:300)
    >>> src/CMakeFiles/clickhouse_common_io.dir/Common/ThreadFuzzer.cpp.o:(pthread_mutex_lock)
    >>> did you mean: __pthread_mutex_lock@GLIBC_2.2.5
    >>> defined in: /usr/lib/libc.so.6

Here is the list of matched symbols for 2.35:

    $ nm -D /lib/libc.so.6 | fgrep pthread_mutex_lock
    00000000000908a0 T __pthread_mutex_lock@GLIBC_2.2.5
    00000000000908a0 T pthread_mutex_lock@@GLIBC_2.2.5

    $ nm -D /lib/libpthread.so.0 | fgrep -c pthread_mutex_lock
    0

And this is for 2.33:

    $ nm -D /lib/x86_64-linux-gnu/libc.so.6 | fgrep pthread_mutex_lock
    0000000000083eb0 T pthread_mutex_lock@@GLIBC_2.2.5

    $ nm -D /lib/x86_64-linux-gnu/libpthread.so.0 | fgrep pthread_mutex_lock
    000000000000af00 T __pthread_mutex_lock@@GLIBC_2.2.5
    000000000000af00 W pthread_mutex_lock@@GLIBC_2.2.5

Because "likely" starting from 27a448223cb2d3bab191c61303db48cee66f871c
("nptl: Move core mutex functions into libc") [1], __pthread_mutex_lock
is not exported anymore.

  [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=27a448223cb2d3bab191c61303db48cee66f871c

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-20 22:51:47 +03:00
Alexey Milovidov
1d5e99362f Fix progress bar jumping near 50% 2022-02-20 19:29:09 +01:00
Vladimir C
5284083647
Merge pull request #34683 from vdimir/fix_aarch64/position_utf_8
Fix `positionUTF8` on aarch64
2022-02-20 11:35:40 +01:00
kssenii
6b60f7c57f Add limit for file segment size and split it if exceeds the limit 2022-02-19 18:59:22 +01:00
alexey-milovidov
73fe35e552
Update Volnitsky.h 2022-02-19 19:53:36 +03:00
alexey-milovidov
82728e03b5
Update Volnitsky.h 2022-02-19 19:52:38 +03:00
kssenii
acf9a092a9 Review fixes 2022-02-18 19:09:54 +01:00
Azat Khuzhin
c204ac7744 Export MemoryTracker::getHardLimit()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-18 12:05:12 +03:00
Anton Popov
0a7895ebb9 add comments and small refactoring 2022-02-17 22:00:25 +03:00
vdimir
b474dc87ac
check len of char with upper and lower case in putNGramUTF8CaseInsensitive 2022-02-17 12:39:29 +00:00
Dmitry Novik
c32313b045
Merge branch 'master' into memory-overcommit-test 2022-02-17 00:50:15 -08:00
Dmitry Novik
371d5e0e2d Disable memory overcommit if timeout is not set 2022-02-16 22:24:09 +00:00
Dmitry Novik
07d0e3c823 cleanup 2022-02-16 20:19:10 +00:00
Dmitry Novik
44d5ddc939 Fix deadlock in OvercommitTracker 2022-02-16 20:02:14 +00:00
kssenii
47f94120da Merge master 2022-02-16 14:43:28 +01:00
Kruglov Pavel
adf58ea1ce
Merge pull request #34490 from Avogar/fix-client
Refactor client fault tolerant connection
2022-02-16 12:39:46 +03:00
kssenii
886b300b8d Less seeks 2022-02-15 16:12:25 +01:00
Dmitry Novik
bb6dad7d0e Fix lock order 2022-02-15 15:04:13 +00:00
kssenii
690dcea8be Style 2022-02-15 10:11:33 +01:00
alexey-milovidov
bc206ec423
Merge pull request #31182 from ClickHouse/memory-overcommit
Memory overcommit
2022-02-14 23:55:02 +03:00
kssenii
bdbbe85f95 Fixes 2022-02-14 19:28:48 +01:00
Maksim Kita
9ae2271922
Merge pull request #34506 from freedomDR/fix_lowcardinality_group_by
fix lowcardinality on group by of any model
2022-02-13 15:07:49 +01:00
Maksim Kita
9cb440e8d9
Update ColumnsHashing.h 2022-02-13 14:43:02 +01:00
freedomDR
8e5ba9e778 Avoid crash in case of GROUP BY LowCardinality(Nullable(String)) column and group_by_overflow_mode='any' 2022-02-13 10:19:58 +00:00
Maksim Kita
13cbf79ecb Improve performance of insert into table functions URL, S3, File, HDFS 2022-02-10 20:06:23 +00:00
mergify[bot]
cb3e5f8538
Merge branch 'master' into memory-overcommit 2022-02-10 11:01:43 +00:00
avogar
75c56163a0 Refactor client fault tolerant connection 2022-02-10 12:43:08 +03:00
Anton Popov
18940b8637 Merge remote-tracking branch 'upstream/master' into HEAD 2022-02-09 23:38:38 +03:00
Nikolai Kochetov
38fb50f736
Merge pull request #33958 from Algunenano/mv_cacheable_scalars
Scalar cache improvements
2022-02-09 16:46:53 +03:00
DF5HSE
cfefa57485 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 19:53:55 +03:00
Vitaly Baranov
9a8e45805a
Merge pull request #34226 from vitlibar/add-submodule-minizip
Add submodule minizip
2022-02-08 22:07:34 +07:00
DF5HSE
c08bc7ad65 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-fault-tolerant-connection 2022-02-08 11:37:31 +03:00
DF5HSE
c1df291b18 Fix error with IPv6 in host param 2022-02-08 02:03:41 +03:00
kssenii
2e58733750 Merge master 2022-02-07 15:23:10 +01:00
mergify[bot]
dd947f964c
Merge branch 'master' into mv_cacheable_scalars 2022-02-07 10:07:26 +00:00
Vitaly Baranov
23fac284ea Add utility classes ZipArchiveReader and ZipArchiveWriter. 2022-02-05 23:45:20 +07:00
Vitaly Baranov
f8ef1cd23d Add submodule minizip-ng 2022-02-05 23:45:16 +07:00
alexey-milovidov
a089f9918c
Update ThreadPool.cpp 2022-02-04 03:54:33 +03:00
Alexey Milovidov
78eebd5c7c Fix parallel loading of data parts 2022-02-04 02:29:46 +03:00
Maksim Kita
f4423937bd
Merge pull request #34275 from ClickHouse/fix-progress-bar
Fix progress bar width
2022-02-03 11:21:08 +01:00
Alexey Milovidov
f047a28ed8 Fix progress bar width 2022-02-03 04:48:52 +03:00
Anton Popov
5bb1b3ce77 support async inserts in clickhouse-client for queries with inlined data 2022-02-02 20:59:37 +03:00
kssenii
aeec749173 Fix predownload case part 1 2022-02-02 17:25:25 +03:00
kssenii
5cba11428a Fixes 2022-02-02 00:25:16 +03:00
Dmitry Novik
80694006f2
Update src/Common/MemoryTracker.cpp
Co-authored-by: alesapin <alesapin@clickhouse.com>
2022-02-01 16:15:00 +03:00
Dmitry Novik
1310a89fb2
Update src/Common/MemoryTracker.cpp
Co-authored-by: alesapin <alesapin@clickhouse.com>
2022-02-01 16:14:48 +03:00
Anton Popov
836a348a9c Merge remote-tracking branch 'upstream/master' into HEAD 2022-02-01 15:23:07 +03:00
Azat Khuzhin
d0d71180dd Add fmt::runtime in gtest_log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:44:47 +03:00
Azat Khuzhin
3b3635c6d5 Fix formatting error in logging messages
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
bedf208cbd Use fmt::runtime() for LOG_* for non constexpr
Here is oneliner:

    $ gg 'LOG_\(DEBUG\|TRACE\|INFO\|TEST\|WARNING\|ERROR\|FATAL\)([^,]*, [a-zA-Z]' -- :*.cpp :*.h | cut -d: -f1 | sort -u | xargs -r sed -E -i 's#(LOG_[A-Z]*)\(([^,]*), ([A-Za-z][^,)]*)#\1(\2, fmt::runtime(\3)#'

Note, that I tried to do this with coccinelle (tool for semantic
patchin), but it cannot parse C++:

    $ cat fmt.cocci
    @@
    expression log;
    expression var;
    @@

    -LOG_DEBUG(log, var)
    +LOG_DEBUG(log, fmt::runtime(var))

I've also tried to use some macros/templates magic to do this implicitly
in logger_useful.h, but I failed to do so, and apparently it is not
possible for now.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

v2: manual fixes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Azat Khuzhin
a09bc1d72e Add fmt::runtime() in Exception ctor
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
kssenii
218a633fec Some fixes, more assertions and logging 2022-01-31 10:51:34 +03:00
Maksim Kita
5ef83deaa6 Update sort to pdqsort 2022-01-30 19:49:48 +00:00
Anton Popov
78b9f15abb Merge remote-tracking branch 'upstream/master' into HEAD 2022-01-30 03:24:37 +03:00
kssenii
6b03c577d6 Make downloader's term resticted to one nextImpl 2022-01-29 23:58:53 +03:00
Maksim Kita
76067efbef
Merge pull request #34076 from bigo-sg/poolbase
Add expire() in PoolBase
2022-01-29 13:51:55 +01:00
lgbo-ustc
5f1969c6c5 fixed code styles 2022-01-29 09:46:00 +08:00
lgbo-ustc
c576393143 fixed code styles 2022-01-28 18:34:54 +08:00
lgbo-ustc
f5ffdaac21 fixed code styles 2022-01-28 16:55:17 +08:00
lgbo-ustc
7a3324b29a add expire() in PoolBase 2022-01-28 14:03:34 +08:00
alexey-milovidov
4060290eb6
Merge pull request #33925 from benbiti/USE_DEBUG_HELPERS-OFF
when not DEBUG set USE_DEBUG_HELPERS OFF
2022-01-27 22:59:55 +03:00
tavplubix
8c9266b24c
Merge pull request #33978 from amosbird/separatesystemlog
Separate base parts out of SystemLog
2022-01-27 20:07:55 +03:00
mergify[bot]
260942e0f0
Merge branch 'master' into hlee-issue-7334 2022-01-27 14:30:13 +00:00
Nikolay Degterinsky
c5ca5b608e
Merge pull request #33314 from evillique/classification
Merge functions for text classification
2022-01-27 17:15:08 +03:00
kssenii
c91b86e220 Better 2022-01-26 21:56:08 +03:00
Raúl Marín
4b5ab80e3b Better scalar cache handling
- Fixes global CTE scalar cache.
- Adds MVs back (views dependent on the source are cached locally and others globally
2022-01-26 17:36:45 +01:00
Kruglov Pavel
662ea9d024
Merge pull request #33927 from kitaisreal/range-hashed-dictionary-refactoring
RangeHashedDictionary refactoring
2022-01-26 15:26:57 +03:00
alexey-milovidov
0a112bcf61
Update StringSearcher.h 2022-01-26 13:45:26 +03:00
tavplubix
9e91a9dfd1
Merge pull request #33429 from zzsmdfj/MaterializeMySQL_support_set_and_other_dataType
MaterializeMySQL support SET YEAR TIME GEOMETRY dataType
2022-01-26 11:29:46 +03:00
HarryLeeIBM
8b24688afb Issue 7334: Fixed utf8 string case-insensitive searching issue 2022-01-25 13:56:05 -05:00
tavplubix
35534a4b92
Update Types.h 2022-01-25 16:42:55 +03:00
Maksim Kita
bcbd956b83 RangeHashedDictionary change layout structure 2022-01-25 11:13:37 +00:00
Amos Bird
385caa3e0a
Separate base parts out of SystemLog 2022-01-25 18:48:43 +08:00
Nikolay Degterinsky
5edbae6734 Merge branch 'master' into classification 2022-01-25 10:22:47 +00:00
Kruglov Pavel
9f12f4af13
Merge pull request #33302 from Avogar/formats-with-suffixes
Allow to create new files on insert for File/S3/HDFS engines
2022-01-25 10:56:15 +03:00
kssenii
aef99dedba Fixes 2022-01-25 01:46:44 +03:00
kssenii
898139acae Fix tests 2022-01-24 12:32:39 +03:00
benbiti
d97c43034c fix build on USE_DEBUG_HELPERS OFF 2022-01-24 14:29:38 +08:00
kssenii
710bba895e Fix partially downloaded no continuation case 2022-01-23 23:49:13 +03:00
kssenii
cf49f41f75 Better 2022-01-23 19:51:18 +03:00
kssenii
690db142b9 Better 2022-01-23 02:12:33 +03:00
Kseniia Sumarokova
2c43e4eb57
Merge branch 'master' into local-cache-for-remote-fs 2022-01-22 22:53:55 +03:00
kssenii
36a41ac146 Better 2022-01-22 20:42:39 +03:00
Mikhail f. Shiryaev
13f7f56c5b
Merge pull request #33342 from JaySon-Huang/get_cpu_cores_under_cgroup
Fix cpu count with cgroup limits
2022-01-22 11:32:08 +01:00
alexey-milovidov
f3053d3727
Merge pull request #33706 from hanqf-git/avx512_memcmpSmall
Avx512 memcmp small
2022-01-22 13:02:47 +03:00
alexey-milovidov
eb6849f7c7
Merge pull request #33842 from azat/cmake-contrib-fixes
More cmake external modules cleanups
2022-01-22 10:34:54 +03:00
Nikolai Kochetov
b4311cf3c9 Fix cmake for mac. 2022-01-21 22:08:42 +03:00
Anton Popov
e8ce091e68 Merge remote-tracking branch 'upstream/master' into HEAD 2022-01-21 20:11:18 +03:00
kssenii
1858f69f5a Make space reservation incremental 2022-01-21 18:39:34 +03:00
tavplubix
71d69d813c
Merge pull request #33860 from azat/fix-zk-lib
Fix zookeeper library dependency from interpreters (by marking library STATIC)
2022-01-21 16:21:48 +03:00
JaySon-Huang
e155057cc5 Fix cpu count with cgroup limits
Signed-off-by: JaySon-Huang <tshent@qq.com>
2022-01-21 21:03:23 +08:00
Kruglov Pavel
daba57a933
Merge pull request #33737 from Avogar/bool-type
Some improvements and fixes for Bool data type
2022-01-21 15:24:58 +03:00
Azat Khuzhin
d463031105 Fix zookeeper library dependency from interpreters (by marking library STATIC)
This had been introduced in #33534, and an attempt to fix this had been
made in #33844 but it was not strictly correct, since there is undefined
reference to `DB::SystemLog<DB::ZooKeeperLogElement>::add`:

    $ nm -D ./src/Common/ZooKeeper/libclickhouse_common_zookeeperd.so | fgrep SystemLog | c++filt
          U DB::SystemLog<DB::ZooKeeperLogElement>::add(DB::ZooKeeperLogElement const&)

That patch works, because default is not
`-Wl,--unresolved-symbols=report-all`, so I guess shared build on OSX
may after #33844.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-21 11:10:03 +03:00
Azat Khuzhin
d25b59803e contrib/abseil: add cmake ALIAS library
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-21 10:11:06 +03:00
zzsmdfj
411f43ec4d to MaterializeMySQL_support_set_and_other_dataType 2022-01-21 12:24:12 +08:00
Maksim Kita
8567c3a20e
Merge pull request #33848 from kitaisreal/fix-build-with-examples
Fix build with ENABLE_EXAMPLES
2022-01-20 23:18:47 +01:00
Maksim Kita
e2fe8dc3a7 Fix build with ENABLE_EXAMPLES 2022-01-20 19:29:21 +00:00
tavplubix
d26d139974
Update CMakeLists.txt 2022-01-20 20:27:14 +03:00
Maksim Kita
502c1637d5
Merge pull request #33827 from kitaisreal/range-hashed-dictionary-handle-invalid-intervals
RangeHashedDictionary handle invalid intervals
2022-01-20 17:16:49 +01:00
Kruglov Pavel
7bfb1231b9
Merge branch 'master' into formats-with-suffixes 2022-01-20 14:47:17 +03:00
Maksim Kita
844eb4ccdc RangeHashedDictionary handle invalid intervals 2022-01-20 11:16:18 +00:00
avogar
ba54a5ff80 Some improvements and fixes for Bool data type 2022-01-20 14:16:11 +03:00
Azat Khuzhin
a6d482d3e1 Cleanup jemalloc contrib 2022-01-20 10:02:03 +03:00
Azat Khuzhin
9926f336e3 Cleanup cpuid contrib 2022-01-20 10:02:03 +03:00
Azat Khuzhin
3e58094bcb Fix build w/o replxx 2022-01-20 10:02:02 +03:00
Azat Khuzhin
e0e81b340d Fix w/o ODBC build 2022-01-20 10:02:02 +03:00
Azat Khuzhin
e160a20769 Remove USE_OPENCL (removed in #31744) 2022-01-20 10:02:02 +03:00
Azat Khuzhin
a75b748fee Remove unbundled mysql support 2022-01-20 10:02:01 +03:00
Azat Khuzhin
7420bd9b18 Move pdqsort 2022-01-20 10:01:59 +03:00
Azat Khuzhin
a773e7ff01 Remove unbundled libpqxx support 2022-01-20 10:01:59 +03:00
Azat Khuzhin
592bc1e97d Remove unbundled yaml-cpp support 2022-01-20 10:01:59 +03:00
Azat Khuzhin
f1cc63d900 Remove unbundled cityhash support 2022-01-20 10:01:12 +03:00
Azat Khuzhin
8ede97925e Remove unbundled sparsehash support 2022-01-20 10:01:11 +03:00
Azat Khuzhin
789dfd9f3b Remove unbundled re2 support
v2: preserve re2_st name to make PVS check pass (since docker image
update fails)
2022-01-20 10:00:49 +03:00
Azat Khuzhin
aef6668cb4 Remove unbundled hdfs3 support 2022-01-20 08:47:16 +03:00
Azat Khuzhin
cf30669cc9 Remove unbundled openssl/boringssl (crypo/ssl) support 2022-01-20 08:47:16 +03:00
Azat Khuzhin
313716be94 Remove unbundled thrift support 2022-01-20 08:47:16 +03:00
Azat Khuzhin
ca8525a733 Remove unbundled zlib support 2022-01-20 08:47:16 +03:00
mergify[bot]
cbb87e762c
Merge branch 'master' into formats-with-suffixes 2022-01-19 17:21:18 +00:00
Maksim Kita
41a6cd54aa
Merge pull request #33516 from kitaisreal/range-hashed-dictionary-interval-tree
RangeHashedDictionary use interval tree
2022-01-19 16:30:31 +01:00
mergify[bot]
e2f92cf18f
Merge branch 'master' into avx512_memcmpSmall 2022-01-19 12:25:04 +00:00
Maksim Kita
1f72bde52f Fix performance tests 2022-01-19 10:41:58 +00:00
Nikolay Degterinsky
8d03099c91 Merge branch 'master' into classification 2022-01-19 09:21:31 +00:00
alexey-milovidov
d222cb9771
Merge pull request #33695 from amosbird/buildimprove
Some build improvement
2022-01-19 03:19:22 +03:00
kssenii
a566099759 Local cache for remote filesystem 2022-01-19 00:42:11 +03:00
Nikolay Degterinsky
9d45025c7d Merge branch 'master' into classification 2022-01-18 21:41:03 +00:00
Dmitry Novik
4e612d0e1a
Merge branch 'master' into memory-overcommit 2022-01-18 23:33:29 +03:00
alesapin
e5ec1aa446
Merge pull request #33642 from ClickHouse/add_integration_test_for_zero_duplication
Fix bug with background moves in zero copy replication
2022-01-18 18:32:16 +03:00
Maksim Kita
821c5dd989 Fix build 2022-01-18 14:46:19 +00:00
Kruglov Pavel
2295a07066
Merge pull request #33534 from azat/fwd-decl
RFC: Split headers, move SystemLog into module, more forward declarations
2022-01-18 17:22:49 +03:00
Maksim Kita
562098779f Fixed style check 2022-01-18 13:26:23 +00:00
Maksim Kita
60bcf88228 Added IntervalTree documentation 2022-01-18 13:20:43 +00:00
Dmitry Novik
c0970b75ee
Merge branch 'master' into memory-overcommit 2022-01-18 15:30:24 +03:00
Dmitry Novik
83c663e2d6 Cleanup after code review 2022-01-18 12:21:59 +00:00
mergify[bot]
b318f9b5db
Merge branch 'master' into formats-with-suffixes 2022-01-18 12:17:07 +00:00
alesapin
eff85d3352 Review fixes 2022-01-18 11:27:01 +03:00
Amos Bird
6d62060e16
Build improvement 2022-01-17 22:36:27 +08:00
Maksim Kita
f311960b00 Added tests 2022-01-17 14:22:01 +00:00
alesapin
4caef03e6a Add ephemeral lock in zookeeper 2022-01-17 14:52:51 +03:00
alesapin
b2271cc2d9
Merge pull request #33288 from JackyWoo/add_lower_bound_session_timeout_to_keeper
Add lower bound session timeout to keeper
2022-01-17 14:06:15 +03:00
Maksim Kita
ea78c0b33c Fixed style 2022-01-16 16:45:33 +00:00
Maksim Kita
c3d0e8e6f1 Fix style check 2022-01-16 12:23:40 +00:00
Maksim Kita
1076ec5539 Added IntervalTree example 2022-01-16 12:23:40 +00:00
Maksim Kita
0626720893 Added IntervalTree 2022-01-16 12:23:40 +00:00
Kruglov Pavel
5a908e8edd
Merge branch 'master' into formats-with-suffixes 2022-01-14 16:45:20 +03:00
avogar
eeec8c6c11 Fix error codes order 2022-01-14 16:36:12 +03:00
hanqf-git
46f3a699df Add x86 feature avx512 support for memcmpSmall 2022-01-14 20:21:22 +08:00
alesapin
d3a93f5d7e
Merge pull request #33602 from ClickHouse/interpret_keeper_error_in_our_client
Make ZooKeeper client better interpret keeper server connection reject
2022-01-14 11:32:27 +03:00
alesapin
30180ddc19 Better text 2022-01-13 19:12:01 +03:00