thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 00:52:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
61,485 Commits 9,166 Branches 1,781 Tags 2.1 GiB
dfa6e34fb2
Commit Graph

12204 Commits

Author SHA1 Message Date
Anton Popov
c5354885a6
Merge pull request #22654 from azat/log-nested-fix 
[RFC] Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
 2021-04-06 00:34:58 +03:00
kssenii
68154fe10a Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into postgres-add-bool 2021-04-05 20:27:04 +00:00
Maksim Kita
de71553c9d
Merge pull request #22593 from zlobober/introduce_distributed_write 
Introduce IStorage::distributedWrite method for distributed INSERT SELECTS
 2021-04-05 22:59:57 +03:00
kssenii
dc42d5189d Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-04-05 15:36:35 +00:00
alesapin
c830397317 Fix two stupid bugs in mutation wait 2021-04-05 18:08:43 +03:00
kssenii
cc2fdc6c62 Add bool type 2021-04-05 14:49:52 +00:00
kssenii
89a2e94364 Fixes 2021-04-05 14:08:49 +00:00
feng lv
f6e4e13f89 fix conflict 2021-04-05 14:08:30 +00:00
feng lv
56073db22d max distributed depth 
Add settings max_distributed_depth

fix style

fix

fix

fix

fix test

fix

fix
 2021-04-05 14:00:54 +00:00
kssenii
9dba529494 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into library-bridge 2021-04-05 13:14:51 +00:00
alesapin
156ba8a7fc Disable setting by default and ban for old-syntax MergeTree 2021-04-05 12:16:38 +03:00
Maksim Kita
d9cc03bc34 Fixed tests 2021-04-05 11:29:05 +03:00
alesapin
8d5a787f6b Merge branch 'master' into merge_tree_deduplication 2021-04-05 10:40:03 +03:00
Azat Khuzhin
181cde0970 Fix impossible invalid-read for system.errors accounting 
Simple reproducer is throw Exception(-1, "foo"), but there is no such
code, hence it is impossible.
 2021-04-05 09:01:29 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause 
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
 2021-04-05 08:48:04 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix 
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
 2021-04-05 05:20:16 +03:00
alexey-milovidov
f78c846bdf
Merge pull request #22591 from nvartolomei/nv/out-init-check 
Try flush write buffer only if it is initialized
 2021-04-05 04:32:54 +03:00
Maxim Akhmedov
725fa17961 Introduce IStorage::distributedWrite method for distributed INSERT SELECT. 2021-04-05 02:14:27 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
6e93d936d3 Highlight potential bugs in code 2021-04-05 01:38:47 +03:00
Maksim Kita
deb35c5f4e DirectDictionary dictGet multiple columns optimization 2021-04-05 01:26:26 +03:00
Maksim Kita
e486fde35e
Update HashMap.h 2021-04-05 01:20:17 +03:00
Maksim Kita
fa49817421
Update HashMap.h 2021-04-05 01:01:20 +03:00
alexey-milovidov
b1e7624b3f
Merge pull request #22589 from ClickHouse/fix-comments 
Fix comments
 2021-04-05 00:22:27 +03:00
alexey-milovidov
c0a13bb5d2
Merge pull request #22586 from ClickHouse/minor-improvement-deserialize-index 
Minor improvement in index deserialization
 2021-04-05 00:20:29 +03:00
alesapin
caaa19edb8
Merge pull request #22373 from ClickHouse/jepsen_for_ci 
Add image to run jepsen tests
 2021-04-04 18:35:21 +03:00
alesapin
0ceb95aa55 Merge branch 'master' into merge_tree_deduplication 2021-04-04 18:32:27 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1 
Fix bugs in aggregation by primary key
 2021-04-04 18:17:04 +03:00
Maksim Kita
027ca2484e FlatDictionary added layout options initial_array_size, max_array_size 2021-04-04 16:30:48 +03:00
Maksim Kita
41ef9291f1 Fixed tests 2021-04-04 16:30:48 +03:00
Maksim Kita
ff86c21e65 Dictionary update field fix 2021-04-04 16:30:48 +03:00
alesapin
76d0e60e26 Merge branch 'master' into jepsen_for_ci 2021-04-04 16:07:53 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena 
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
 2021-04-04 15:38:17 +03:00
alexey-milovidov
72cf7b01e8
Merge pull request #22571 from mastertheknife/allow_unbundled_xz_lzma 
Allow building with unbundled xz
 2021-04-04 15:36:45 +03:00
Alexey Milovidov
32f9a407ff More precise and safe accurate comparison of int vs. float 2021-04-04 14:49:48 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix 
ClickHouseDictionarySource loop fix
 2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread 
Refs: #22560
 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5ced6e2e9a StorageStripeLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Azat Khuzhin
5ef845af40 StorageLog: drop mutable qualifier for rwlock 2021-04-04 13:25:43 +03:00
Alexey Milovidov
d67ced585a Fix engrish 2021-04-04 13:09:39 +03:00
fuqi
043bd11d2e fix dist map type select 2021-04-04 18:00:30 +08:00
Nicolae Vartolomei
49abdeb967 Try flush write buffer only if it is initialized 
Fixes #22579
 2021-04-04 12:59:51 +03:00
Alexey Milovidov
54caa61af5 Fix comments 2021-04-04 12:33:06 +03:00
fuqi
b590926c1c fix dist map type select 2021-04-04 17:23:47 +08:00
Alexey Milovidov
8b5d0a598f Minor improvement in index deserialization 2021-04-04 12:17:54 +03:00
alesapin
548ec6d2cb Trying enabled setting 2021-04-04 11:02:09 +03:00
Alexey Milovidov
a0f2b85cd3 Make round function to behave consistently on non-x86_64 2021-04-04 05:21:56 +03:00
alexey-milovidov
b35ba1152f
Update IColumnDummy.h 2021-04-04 05:04:11 +03:00
Maksim Kita
b9e8ff137a Fixed build 2021-04-04 01:19:57 +03:00
mastertheknife
65ca073f42 Allow unbundled xz (lzma) using USE_INTERNAL_XZ_LIBRARY=OFF 2021-04-04 01:05:07 +03:00
alexey-milovidov
cb4e119c3d
Merge pull request #22561 from traceon/apple-clang-compilation-fix 
AppleClang compilation fix
 2021-04-04 00:25:58 +03:00
Alexey Milovidov
3050486308 Fix assert in Arena 2021-04-03 22:50:49 +03:00
alexey-milovidov
67fdfd4b89
Merge pull request #22560 from azat/tiny-log-rwlock-ub-fix 
Fix UB by unlocking the rwlock of the TinyLog from the same thread
 2021-04-03 21:59:01 +03:00
Denis Glazachev
36b03b2740 Compilation fix 2021-04-03 22:17:51 +04:00
alesapin
1906c77884 Fix tidy one more time 2021-04-03 17:57:03 +03:00
Azat Khuzhin
6cebd3ee1f Fix UB by unlocking the rwlock of the TinyLog from the same thread 
Before this patch the build with libstdc++ hangs for
00967_insert_into_distributed_different_types test (and I guess some
others), this is because the rwlock is acquired from different thread as
it was unlocked which causes UB [1], fix this by moving unlock into
writeSuffix().

  [1]: The pthread_rwlock_unlock() function shall release a lock held on
       the read-write lock object referenced by rwlock. Results are undefined
       if the read-write lock rwlock is not held by the **calling thread**.
 2021-04-03 16:04:39 +03:00
Azat Khuzhin
10d35867e3 Drop mutable qualifier for StorageTinyLog::rwlock 2021-04-03 16:03:17 +03:00
alesapin
0204f5dd35 Merge branch 'master' into merge_tree_deduplication 2021-04-03 15:24:26 +03:00
alesapin
b127e31451 CI fixes 2021-04-03 14:56:56 +03:00
alexey-milovidov
30ece2c28f
Merge pull request #22510 from vdimir/merge-join-lc-bug-fix 
Convert right block to full in MergeJoin
 2021-04-03 12:54:34 +03:00
alexey-milovidov
143f4b59a0
Merge pull request #22527 from ClickHouse/fix-missing-nl-parse-tsv 
Fix deserialization of empty string without newline at end of TSV format
 2021-04-03 12:51:10 +03:00
alexey-milovidov
2de808ec5a
Update SerializationNullable.cpp 2021-04-03 12:50:57 +03:00
alexey-milovidov
687d1e9b54
Merge pull request #22528 from kitaisreal/format-settings-null-as-default-default-value-fix 
FormatSettings null_as_default default value fix
 2021-04-03 12:49:08 +03:00
kssenii
13d1f17d3e Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-04-03 08:00:09 +00:00
alexey-milovidov
9f5cd35a69
Merge pull request #22323 from abyss7/poco-http2 
Follow up to #19516
 2021-04-03 02:09:10 +03:00
alexey-milovidov
3d860fc6ac
Merge pull request #22322 from abyss7/issue-21907 
Do not limit HTTP chunk size
 2021-04-03 01:58:22 +03:00
Maksim Kita
07d5a1ec21 ClickHouseDictionarySource loop fix 2021-04-03 00:40:07 +03:00
Maksim Kita
5ba6c7b731 FormatSettings null_as_default default value fix 2021-04-03 00:05:40 +03:00
Alexey Milovidov
7a4637c645 Fix deserialization of empty string without newline at end of TSV format 2021-04-02 23:54:03 +03:00
alexey-milovidov
c3a9cbe01c
Merge pull request #22421 from ClickHouse/fix-buffer-overflow-in-token-extractor 
Fix buffer overflow in token extractor
 2021-04-02 22:08:28 +03:00
alexey-milovidov
840ecb5e99
Update MergeJoin.cpp 2021-04-02 21:07:11 +03:00
alesapin
b884593186 Followup fix 2021-04-02 20:55:05 +03:00
alesapin
ca30c91868 More comments 2021-04-02 20:54:24 +03:00
alesapin
fc3afe1087 Fix typos 2021-04-02 20:51:57 +03:00
alesapin
b105153d2c Useful comment 2021-04-02 20:48:58 +03:00
alesapin
ab34873344 Add some comments 2021-04-02 20:46:01 +03:00
alesapin
a555d078a2 Add exception handling 2021-04-02 19:56:02 +03:00
Alexander Kuzmenkov
d0037329cf
Merge pull request #22459 from ClickHouse/aku/window-frame-offset 
fix window frame offset check and add more tests
 2021-04-02 19:49:59 +03:00
alesapin
759dd79c76 Add tests 2021-04-02 19:45:18 +03:00
kssenii
2de6b99f84 Better names 2021-04-02 16:12:14 +00:00
kssenii
02c6332e86 Pass null values properly 2021-04-02 18:45:42 +03:00
robot-clickhouse
39b5674bef Auto version update to [21.5.1.1] [54450] 2021-04-02 18:34:29 +03:00
Alexander Kuzmenkov
e7df8893df
Merge pull request #22300 from ClickHouse/trying_parallel_func_tests 
Trying parallel func tests
 2021-04-02 18:09:58 +03:00
vdimir
c8f51998ba
Remove LowCardinality from right block sample in MergeJoin 2021-04-02 17:51:02 +03:00
tavplubix
93bd2c3b67
Merge pull request #18978 from myrrc/feature/attach-partition-local 
Lookup parts/partitions in replica's own detached/ folder before downloading them from other replicas
 2021-04-02 17:46:03 +03:00
Nikolai Kochetov
0421460943 Always call even.set for zk client callbacks. 2021-04-02 17:06:53 +03:00
vdimir
8cd841c4ac
Handle lowcardinality block in MergeJoin extractMinMax 2021-04-02 16:55:42 +03:00
alesapin
6f36661575 Buildable code 2021-04-02 16:34:36 +03:00
tavplubix
c1ab9de720
Update MergeTreeDataPartChecksum.cpp 2021-04-02 15:57:30 +03:00
alesapin
2ab87d61eb Some build fixes 2021-04-02 15:37:42 +03:00
Alexander Kuzmenkov
16c5658df6 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-02 15:16:24 +03:00
Anton Popov
a000d6154c fix clang-tidy 2021-04-02 15:10:49 +03:00
alesapin
14634689e5 Idea code 2021-04-02 14:46:42 +03:00
Ivan Lezhankin
8a455d347a Fix build 2021-04-02 14:08:32 +03:00
Kruglov Pavel
6fb70cfd3f
Merge pull request #22443 from Avogar/hedged 
Remove socket from epoll before cancelling packet receiver in HedgedConnections to prevent possible race
 2021-04-02 11:49:21 +03:00
Vladimir
9b40f384e9
Merge pull request #20622 from vdimir/issue-20497 2021-04-02 11:48:29 +03:00
Maksim Kita
3b799c5d7d
Merge pull request #22413 from kitaisreal/added-function-dict-get-or-null 
Added function dictGetOrNull
 2021-04-02 11:39:01 +03:00
Maksim Kita
d06fb1197a
Merge pull request #22096 from kitaisreal/hierarchy-dictionaries-updated 
Refactored hierarchy dictionaries interface
 2021-04-02 11:38:01 +03:00
Kseniia Sumarokova
b80951b06a
Merge pull request #21519 from fastio/aliases_to_visitParam 
add aliases to visitParam/visitParamExtract* functions
 2021-04-02 10:31:32 +03:00
Anton Popov
56320bcbfd minor refactoring 2021-04-02 01:16:54 +03:00
Anton Popov
88cd775f6a Merge remote-tracking branch 'upstream/master' into HEAD 2021-04-02 00:14:03 +03:00
kssenii
b66e0401f6 Lowercase 2021-04-01 23:07:01 +03:00
alesapin
4eaf585fe5 Almost nothing added 2021-04-01 22:49:51 +03:00
Mike Kot
c947280dfc Merge remote-tracking branch 'upstream/master' into feature/attach-partition-local 2021-04-01 21:38:51 +03:00
Mike Kot
60e5946449 Removed needless logging, fixed data part initialization while checking 
in the detached folder
 2021-04-01 20:11:14 +03:00
Alexander Kuzmenkov
d006c5532e fix window frame offset check and add more tests 2021-04-01 18:56:58 +03:00
Pavel Kruglov
6f65a72112 Remove socket from epoll before cancelling packet receiver to prevent race 2021-04-01 17:35:00 +03:00
alexey-milovidov
2d1a2ddb9b
Merge pull request #22411 from nvartolomei/nv/replication-queue-directory-already-exists 
Delete temporary fetch directory if it already exists
 2021-04-01 17:12:51 +03:00
alexey-milovidov
c7f134d0b7
Merge pull request #22430 from mastertheknife/ppc64le_compile_stacktrace 
ppc64le: Fix compile and stack trace
 2021-04-01 17:11:32 +03:00
kssenii
99f0b08ac3 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into replicas-shards-for-mysql-and-postgres 2021-04-01 13:48:33 +00:00
Alexey Milovidov
39c3efdb00 Fix build 2021-04-01 16:38:04 +03:00
Alexey Milovidov
fbb4b05df0 Merge remote-tracking branch 'origin' into fix-buffer-overflow-in-token-extractor 2021-04-01 16:30:10 +03:00
Ivan Lezhankin
d9d143675a Merge remote-tracking branch 'upstream/master' into issue-21907 2021-04-01 16:29:26 +03:00
alexey-milovidov
28c7980fba
Merge pull request #22427 from ClickHouse/protocol-break-oom 
Better exception message in client in case of exception while writing blocks
 2021-04-01 16:28:50 +03:00
Ivan Lezhankin
19550d5173 Initialize pointer with nullptr 2021-04-01 16:26:13 +03:00
alexey-milovidov
e3aa47c525
Merge pull request #22425 from ClickHouse/parallel-formatting-memory 
Add memory accounting in parallel formatting
 2021-04-01 16:23:48 +03:00
alesapin
85fbb7eccf
Merge pull request #21976 from ClickHouse/try-fix-excessive-rows-for-collapsing-merge 
CollapsingSortedAlgorithm should not return more than index_granularity rows
 2021-04-01 16:20:28 +03:00
Ivan Lezhankin
cc1c439ad8 Merge remote-tracking branch 'upstream/master' into poco-http2 2021-04-01 16:20:15 +03:00
Alexander Kuzmenkov
c7bf01fa33 typo 2021-04-01 16:08:18 +03:00
Alexander Kuzmenkov
ba64bc8557 quick fix for inaccessible DatabaseReplicated 2021-04-01 15:21:29 +03:00
alesapin
8fc01195ce Some improvements 2021-04-01 15:19:39 +03:00
kssenii
8300a74f5a Fix 2021-04-01 12:09:44 +00:00
Maksim Kita
2c522cf8bb
Update FunctionsExternalDictionaries.h 2021-04-01 15:06:08 +03:00
kssenii
2c70183652 Fix settings 2021-04-01 11:41:22 +00:00
vdimir
3f464595eb
Accurate removing 'join' part for queries to 'Merge' engine 2021-04-01 14:31:57 +03:00
vdimir
fff8043e55
Revert "Fix joined table access with Merge engine and aggregation" 
This reverts commit 5476e68d6c.
 2021-04-01 14:31:46 +03:00
kssenii
522d170588 Add default port 2021-04-01 11:30:20 +00:00
vdimir
5476e68d6c
Fix joined table access with Merge engine and aggregation 2021-04-01 14:26:28 +03:00
Alexander Kuzmenkov
b669b3aca9 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-01 14:25:04 +03:00
kssenii
747967a9bb Better 2021-04-01 10:27:24 +00:00
Maksim Kita
42ae39f78f Updated tests 2021-04-01 12:13:36 +03:00
alesapin
7c8f54e694 More changes 2021-04-01 11:07:56 +03:00
mastertheknife
2a44a808a6 ppc64le: Fix compile and stack trace 2021-04-01 10:44:26 +03:00
alexey-milovidov
956dba1d9c
Merge pull request #22396 from ClickHouse/stress-oom 
Fix some OOMs in stress tests
 2021-04-01 10:12:31 +03:00
kssenii
799a1f177e Rename to SimpleJSON* 2021-04-01 14:24:10 +08:00
fastio
4daf011e0b add aliases to visitParam/visitParamExtract* functions 2021-04-01 14:24:10 +08:00
alexey-milovidov
5ae494521d
Merge pull request #22389 from ClickHouse/map-op-ubsan 
Fix UBSan report in mapOp
 2021-04-01 07:35:44 +03:00
alexey-milovidov
95d761f350
Merge pull request #22412 from ClickHouse/aku/invalid-frame-start 
fix error message for invalid window frame start
 2021-04-01 07:17:03 +03:00
Alexey Milovidov
9d65d83c83 Better exception message in client in case of exception while writing blocks 2021-04-01 07:12:07 +03:00
Alexey Milovidov
b0539eb28f Move method 2021-04-01 06:28:25 +03:00
Alexey Milovidov
14f2cf9b80 Add memory accounting in parallel formatting 2021-04-01 06:17:23 +03:00
Alexey Milovidov
7db8fcdebd Fix buffer overflow in TokenExtractor #19233 2021-04-01 05:37:19 +03:00
Alexey Milovidov
7589a014f9 Better fix 2021-04-01 03:44:02 +03:00
Alexey Milovidov
c9fac714b4 Merge branch 'master' into map-op-ubsan 2021-04-01 03:27:33 +03:00
Alexey Milovidov
12ff56673b Merge branch 'master' into datasketches-cmake 2021-04-01 03:17:05 +03:00
alexey-milovidov
bbd41d64c2
Update DataPartsExchange.cpp 2021-04-01 02:59:47 +03:00
alexey-milovidov
538be4086b
Recursive removal is extremely dangerous. 2021-04-01 02:59:23 +03:00
Alexey Milovidov
e67d93d165 Merge branch 'master' into stress-oom 2021-04-01 01:43:40 +03:00