thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 20:42:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
131,051 Commits 9,183 Branches 1,782 Tags 2.2 GiB
e09c68db32
Commit Graph

50828 Commits

Author SHA1 Message Date
Alexey Milovidov
d751561d44 Remove useless headers 2023-12-15 21:42:05 +01:00
Alexey Milovidov
a33d6b0c96
Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo 
Fix system.stack_trace for threads with blocked SIGRTMIN
 2023-12-15 20:28:05 +01:00
Raúl Marín
6cf8c9b607 Review improvements 2023-12-15 19:44:13 +01:00
Alexey Milovidov
7e55eab1c3 Revert "Merge pull request #56573 from mkmkme/mkmkme/reload-config" 
This reverts commit 3067ca64df, reversing
changes made to 1e46460910.
 2023-12-15 19:28:25 +01:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
James Nock
9aa1ec488c Apply full-text skipping index when using hasAll() 2023-12-15 17:28:33 +00:00
Azat Khuzhin
106042cf41 Fix system.stack_trace for threads with blocked SIGRTMIN 
Some third-party libraries (i.e. librdkafka) could block it, and in this
case system.stack_trace will return stacktrace for the main process
(usually, basically it could be any thread with non blocked signal).

By replacing sigqueue() with more precise rt_tgsigqueueinfo(), other
threads will not respond to the signal.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-12-15 17:47:01 +01:00
Maksim Kita
a4d287b576 Fixed tests 2023-12-15 18:54:15 +03:00
flynn
82fc51ffa6 add test 2023-12-15 15:29:15 +00:00
Raúl Marín
5b88c4ef05 BackupEntriesCollector format log 2023-12-15 16:09:46 +01:00
Robert Schulze
066579f7d7
Improve code aesthetics 2023-12-15 15:07:40 +00:00
Sema Checherinda
0dfe530a7f
Merge pull request #56744 from MikhailBurdukov/native_copy_for_s3_disks 
Enabled s3 `copyObject` for copy between s3 disks.
 2023-12-15 16:05:16 +01:00
Raúl Marín
6b4658ef52 Mysql log format 2023-12-15 16:00:58 +01:00
Nikita Mikhaylov
1780671443
ClickHouse Cloud promotion (#57638) 
Co-authored-by: Alexander Sapin <alesapin@gmail.com>
 2023-12-15 15:23:23 +01:00
Kruglov Pavel
4687b4a576
Delete debug logging in OutputFormatWithUTF8ValidationAdaptor 2023-12-15 14:54:04 +01:00
Yarik Briukhovetskyi
325374c68b
Merge pull request #57342 from bharatnc/ncb/better-hint-if-table-doesnt-exist 
provide a better hint if a table doesn't exist
 2023-12-15 12:35:13 +01:00
Raúl Marín
946defa8a6
Merge pull request #57860 from zvonand/zvonand-fix-57819 
Try to fix memory leak in StorageHDFS
 2023-12-15 11:50:17 +01:00
kssenii
7bbb456ae9 Fix style check 2023-12-15 11:32:26 +01:00
kssenii
5de9c143a5 Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive 2023-12-15 11:32:14 +01:00
Kseniia Sumarokova
f285a01b17
Merge pull request #57863 from ClickHouse/fix-flaky-pg-test 
Follow up to #57568
 2023-12-15 11:29:32 +01:00
Kseniia Sumarokova
06438cc17b
Merge pull request #57578 from ClickHouse/allow-to-change-some-cache-settings-without-restart 
Allow to apply some fs cache config settings changes without server restart
 2023-12-15 11:18:19 +01:00
Nikolay Degterinsky
c7ce2b5d5f
Merge pull request #57569 from skyoct/fix/fix_format_error 
Fix formatting string prompt error
 2023-12-15 11:10:08 +01:00
Maksim Kita
8a5ffbb5f2 InterpreterCreateQuery sample block fix 2023-12-15 12:55:19 +03:00
flynn
2d45213f70 Fix transform query for external database 2023-12-15 08:34:58 +00:00
Duc Canh Le
6e6eb5c01e fast get default enum serialization 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2023-12-15 07:38:23 +00:00
Julia Kartseva
7a5b40563a
Merge pull request #57574 from ClibMouse/dev-seriesPeriodDetect 
Revert "Revert "Implemented series period detect method using pocketfft lib""
 2023-12-14 21:10:23 -08:00
skyoct
3319934055 reafactor function 2023-12-15 04:49:38 +00:00
Alexey Milovidov
23cee7ef37
Merge pull request #57851 from azat/revert-55271-local-lazy-database 
Revert "Replace --no-system-tables with loading virtual tables of system database lazily"
 2023-12-15 03:25:59 +01:00
Robert Schulze
eee4bacd71
Fix #57816, fix #57458. 2023-12-14 21:03:17 +00:00
Robert Schulze
f17d7e44f4
Refactorings: rename variables, decreases scopes, add comments 2023-12-14 20:48:18 +00:00
Bharat Nallan Chakravarthy
c9f35a8f84 review fixes 2023-12-14 11:28:49 -08:00
Bharat Nallan Chakravarthy
daef2febf3 Merge with 'upstream/master' 2023-12-14 11:19:44 -08:00
Andrey Zvonov
0174b94469
Merge branch 'ClickHouse:master' into zvonand-fix-57819 2023-12-14 20:14:54 +01:00
Raúl Marín
546484d46b Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-14 19:03:59 +01:00
Bhavna Jindal
bb8589cabe minor cosmetic changes 2023-12-14 08:34:37 -08:00
Duc Canh Le
93dd6b83e7
Do not allow creating replicated table with inconsistent merge params (#56833) 
* save all merge params to zookeeper

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* calculate hash for graphite merge params

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* add graphite params hash to zookeeper + fix tests

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* install new graphite for testing

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* fix backward incompatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* minor fix test

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

* Update src/Storages/MergeTree/ReplicatedMergeTreeTableMetadata.cpp

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>

* remove peekString and add more comments

- peekString doesn't always work even for ReadBufferFromString
- more comment re. backward compatibility

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>

---------

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
 2023-12-14 17:26:35 +01:00
vdimir
eb350ffa7e
Fix assertion in HashJoin 2023-12-14 15:52:35 +00:00
Andrey Zvonov
f9579580e9 Retrigger CI + make docs a bit better 2023-12-14 16:34:10 +01:00
kssenii
12ed9952c4 Merge remote-tracking branch 'origin/allow-to-change-some-cache-settings-without-restart' into allow-to-change-some-cache-settings-without-restart 2023-12-14 16:31:13 +01:00
kssenii
3edbbab9a3 Better 2023-12-14 16:30:15 +01:00
kssenii
3605caa8d9 Fxi 2023-12-14 16:05:40 +01:00
kssenii
ea7e55b929 Simplify 2023-12-14 15:58:06 +01:00
skyoct
0a4882d781 feat: update style 2023-12-14 14:26:47 +00:00
skyoct
d700eb2501 feat: support trivial count optimization for Merge 2023-12-14 14:08:24 +00:00
kssenii
a4a264c785 Fix 2023-12-14 14:04:17 +01:00
Raúl Marín
3200933144 Leave backups as HEAD 2023-12-14 13:49:06 +01:00
Andrey Zvonov
7d7aea9826 try fix memory leak in StorageHDFS 2023-12-14 13:01:47 +01:00
Nikita Mikhaylov
a0af0392cd
Random changes in random files (#57642) 2023-12-14 12:47:11 +01:00
János Benjamin Antal
fdfd1481df
Merge pull request #57610 from kitaisreal/jit-add-assembly-printer 
CHJIT add assembly printer
 2023-12-14 12:39:20 +01:00
Igor Nikonov
42d0afef1f
Merge pull request #57749 from ClickHouse/pr-perf-improve-hope 
Parallel replicas: announcement response handling improvement
 2023-12-14 11:48:51 +01:00
Konstantin Bogdanov
808b4a0213
Merge pull request #57628 from azat/config-nodes-override 
Allow nodes in config with from_env/from_zk and non empty element with replace=1
 2023-12-14 13:20:46 +03:00
Raúl Marín
efcacd3c34 Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-14 11:08:50 +01:00
Robert Schulze
b36a93a25d
Revert "Remove arrayFold" 
This reverts commit 15dc0ed610.
 2023-12-14 09:52:29 +00:00
Azat Khuzhin
0e86e16a01
Revert "Replace --no-system-tables with loading virtual tables of system database lazily" 2023-12-14 09:07:47 +01:00
Alexey Milovidov
e4901323fd
Merge pull request #57836 from ClickHouse/remove-array-fold 
Remove `arrayFold`
 2023-12-14 07:15:29 +01:00
Alexey Milovidov
7a2edb4804
Merge pull request #57822 from azat/kafka-disable-stat 
Disable system.kafka_consumers by default (due to possible live memory leak)
 2023-12-14 04:37:50 +01:00
Alexey Milovidov
15dc0ed610 Remove arrayFold 2023-12-14 04:34:32 +01:00
Yakov Olkhovskiy
9e1d583f54 fix style 2023-12-13 23:36:54 +00:00
Kseniia Sumarokova
79db3c66df
Merge branch 'master' into allow-to-change-some-cache-settings-without-restart 2023-12-13 23:33:59 +01:00
Yakov Olkhovskiy
441050adce fix style, cleanup 2023-12-13 22:26:38 +00:00
Anton Popov
82ebb5e2d1
Merge pull request #57790 from CurtizJ/fix-external-aggregation-with-projections 
Fix result of external aggregation in case of partially materialized projection
 2023-12-13 22:56:02 +01:00
Julia Kartseva
b8d274d070
Add malformed output generation to JSON fuzzer (#57646) 
Randomly modify structural characters of a valid JSON ('{', '}', '[', ']',
':', '"', ',') to generate output that cannot be parsed as JSON.

Follow-up to https://github.com/ClickHouse/ClickHouse/pull/56490
 2023-12-13 19:59:31 +01:00
Alexey Milovidov
e989eb7bd2
Merge pull request #57787 from kitaisreal/serialization-string-reduce-memory-usage 
SerializationString reduce memory usage
 2023-12-13 19:56:56 +01:00
Alexey Milovidov
bf4964b177
Merge pull request #57712 from ClickHouse/clickbench-ci 
Add ClickBench to CI
 2023-12-13 19:52:44 +01:00
Nikita Taranov
560e66f3ca
More respect to min_number_of_marks in ParallelReplicasReadingCoordinator (#57763) 2023-12-13 19:51:49 +01:00
jsc0218
78773157b6
Merge pull request #57436 from ryanmjacobs/fix_issue_43186_pg_quote_array_ndims 
Fix several issues regarding PostgreSQL `array_ndims` usage.
 2023-12-13 13:41:43 -05:00
kssenii
38e38ef43f Minor fix 2023-12-13 19:32:47 +01:00
Yakov Olkhovskiy
f4e2933f5d use storage uuid instead of table name as a key in storage info because there are can be multiple dropped table with the same name 2023-12-13 18:08:41 +00:00
Azat Khuzhin
055c231438 Disable system.kafka_consumers by default (due to possible live memory leak) 
It is not safe to use statistics because of how KafkaEngine works - it
pre-creates consumers, and this leads to the situation when this
statistics entries generated (RD_KAFKA_OP_STATS), but never consumed.

Which creates a live memory leak for a server with Kafka tables, but
without materialized view attached to it (and no SELECT).

Another problem is that this makes shutdown very slow, because of how
pending queue entries are handled in librdkafka, it uses
TAILQ_INSERT_SORTED, which is sorted insert into linked list, which
works incredibly slow (likely you will never wait till it ends and kill
the server)

For instance in my production setup the server was running for ~67 days
with such table, and it got 1'942'233 `TAILQ_INSERT_SORTED` entries
(which perfectly matches by the way - `67*86400/3` = 1'929'600), and it
moved only 289'806 entries for a few hours, though I'm not sure how much
time the process was in the running state, since most of the time it was
with debugger attached.

So for now let's disable it, to make this patch easy for backporting,
and I will think about long term fix - do not pre-create consumers in
Kafka engine.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-12-13 18:13:13 +01:00
Robert Schulze
d0a4443bbc
Consolidate substring() tests 2023-12-13 16:49:39 +00:00
Alexey Milovidov
54698cd2de
Merge pull request #55876 from ClickHouse/keeper-http-readiness-endpoint 
Keeper HTTP readiness endpoint
 2023-12-13 17:07:57 +01:00
Robert Schulze
bbd7d0c057
Merge pull request #57277 from slvrtrn/substr-with-enums 
Add Enums support to `substring` function
 2023-12-13 17:03:03 +01:00
Raúl Marín
d4522ee088
Merge pull request #57811 from Algunenano/revert_negative_positional_arguments 
Revert #57741
 2023-12-13 16:39:23 +01:00
Yakov Olkhovskiy
0ea4b16530
Merge branch 'master' into ft-dropped_tables_parts 2023-12-13 09:01:59 -05:00
Igor Nikonov
c165be76ab
Parallel replicas: friendly settings (#57542) 2023-12-13 14:42:06 +01:00
Raúl Marín
dd405a655e Merge remote-tracking branch 'blessed/master' into backup_1 2023-12-13 13:39:58 +01:00
Raúl Marín
8c2137e0c6 Revert "Merge pull request #57741 from ucasfl/negtive-position" 
This reverts commit 3d846800e0, reversing
changes made to b31b4c932f.
 2023-12-13 13:09:36 +01:00
Vitaly Baranov
96bbff3af0
Merge pull request #57764 from vitlibar/fix-retries-for-disconnected-nodes-for-backup-on-cluster 
Fix retries for disconnected nodes for BACKUP/RESTORE ON CLUSTER
 2023-12-13 13:06:32 +01:00
Kseniia Sumarokova
b1325450e9
Merge pull request #57754 from ClickHouse/fix-loading-dependent-table-materialized-postgresql 
Table engine MaterializedPostgreSQL fix dependency loading
 2023-12-13 12:17:01 +01:00
robot-ch-test-poll1
c2f32f5994
Merge pull request #57795 from CurtizJ/fix-totals-maxMap 
Fix merge in aggregation functions with `*Map` combinator
 2023-12-13 10:31:15 +01:00
Yakov Olkhovskiy
5121bfcd78 major refactoring 2023-12-13 07:16:30 +00:00
Alexey Milovidov
62b6d1ef5e iMerge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci 2023-12-13 01:41:27 +01:00
Alexey Milovidov
f11b90e7bb Allow buckets without List access 2023-12-13 00:10:58 +01:00
Han Fei
6abe4b113a
Merge pull request #57375 from lingtaolf/feature/more_warnings 
Feature/more warnings
 2023-12-12 22:48:51 +01:00
Igor Nikonov
616d054dee Merge remote-tracking branch 'origin/master' into pr-perf-improve-hope 2023-12-12 21:27:31 +00:00
Igor Nikonov
7f4a028196 Test and fix 2023-12-12 21:26:58 +00:00
Alexander Tokmakov
3482224f83 Merge branch 'master' into keeper-http-readiness-endpoint 2023-12-12 21:19:57 +01:00
Bhavna Jindal
1190abae22 multiple rows fix 2023-12-12 10:55:15 -08:00
Vitaly Baranov
028763def5 Simplify logic in BackupCoordinationStageSync::readCurrentState() and return earlier from the cycly on a connection problem. 2023-12-12 18:53:52 +01:00
Anton Popov
e4e97471a6 fix totals in aggregation functions with Map combinator 2023-12-12 17:31:56 +00:00
serxa
57d7a58dbe Rename system.async_loader into system.asynchronous_loader 2023-12-12 16:55:27 +00:00
Anton Popov
64d7abde09 fix result of external aggregation in case of partially materialized projection 2023-12-12 16:51:23 +00:00
Vitaly Baranov
7196103be5 Always recreate ephemeral "alive" node on reconnection. 2023-12-12 17:45:27 +01:00
Kruglov Pavel
6567fb2c08
Merge pull request #56859 from Avogar/csv-infer-numbers-from-strings 
Allow to infer numbers from strings in CSV format
 2023-12-12 17:09:02 +01:00
Kruglov Pavel
fd08c6f06a
Merge pull request #57751 from Avogar/better-json-inference-unnamed-tuples 
Slightly better inference of unnamed tupes in JSON formats
 2023-12-12 17:08:34 +01:00
kssenii
cc71b40002 Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive 2023-12-12 16:40:04 +01:00
Maksim Kita
7142eacad3 SerializationString reduce memory usage 2023-12-12 18:07:01 +03:00
Alexander Gololobov
09d6e6b945
Merge pull request #57743 from ClickHouse/other_timeout_for_wait 
Increase async block cache deduplication timeout
 2023-12-12 15:40:04 +01:00
Raúl Marín
049fb60c73 Fix error on retries due to TABLE_IS_READ_ONLY 2023-12-12 15:37:28 +01:00
Nikolai Kochetov
23ef8444d1
Merge pull request #57691 from ClickHouse/reset-agg-state-whenever-possible 
Release memory for aggregation earlier.
 2023-12-12 15:36:03 +01:00