Commit Graph

8 Commits

Author SHA1 Message Date
Alexander Tokmakov
70d1adfe4b
Better formatting for exception messages (#45449)
* save format string for NetException

* format exceptions

* format exceptions 2

* format exceptions 3

* format exceptions 4

* format exceptions 5

* format exceptions 6

* fix

* format exceptions 7

* format exceptions 8

* Update MergeTreeIndexGin.cpp

* Update AggregateFunctionMap.cpp

* Update AggregateFunctionMap.cpp

* fix
2023-01-24 00:13:58 +03:00
Smita Kulkarni
605fc5f121 Addressed review comments
- Added finalizeImpl() override in ForkWriteBuffer to call finalize() of all the buffers.
- Removed clearing buffer in ForkWriteBuffer destructor.
2022-07-20 21:02:54 +02:00
Smita Kulkarni
8b523bec16 Addressed review comments
- Updated destructor of ForkWriteBuffer to clear buffer
2022-07-18 22:12:26 +02:00
Smita Kulkarni
228b9e7ec4 Addressed review comments
- Updated exception message in ForkWriteBuffer
- Added test case to tests/queries/0_stateless/02346_into_outfile_and_stdout.sh for calling nextImpl more than once
2022-07-17 20:09:18 +02:00
Smita Kulkarni
6318927fba addressed review comment: ForkWriteBuffer for loop 2022-07-15 18:37:50 +02:00
Smita Kulkarni
d7fc7a4290 Addressed review comments
- Removed first_buffer, finalizeImpl and logic to different buffer size from ForkWriteBuffer
2022-07-15 16:08:53 +02:00
Smita Kulkarni
5a8d6ba0fc clang tidy feedback addressed: updated src/IO/ForkWriteBuffer.cpp to use const reference 2022-07-15 09:06:25 +02:00
Smita Kulkarni
1dc2187f9c Addressed review comments
Implementation:
- Added a new buffer ForkWriteBuffer takes a vector of WriteBuffer and writes data to all of them. It uses the buffer of the first element as its buffer and copies data from first buffer to all the other buffers
Testing:
- Updated tests/queries/0_stateless/02346_into_outfile_and_stdout.sh
Documentation:
- Updated the english documentation for SELECT.. INTO OUTFILE with AND STDOUT.
2022-07-14 22:47:38 +02:00