Commit Graph

71 Commits

Author SHA1 Message Date
Alexey Milovidov
23cf6d0d8b Useless changes 2024-05-11 22:51:57 +02:00
Alexey Katsman
ca4e2f581a Add columns for values used in the formatting message into system.text_log 2024-04-23 17:26:56 +01:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
2024-04-07 11:09:35 +00:00
Raúl Marín
c35a436435 Remove nested dependency on DateLutImpl 2024-04-02 14:45:48 +02:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Alexey Milovidov
1b04cc0b4d Fix strange log message 2024-03-12 03:56:10 +01:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Maksim Kita
5b1919aff1 Loggers initialization fix 2024-01-29 20:11:14 +03:00
Tim Liou
7981d182bc Merge branch 'master' into level-int-to-word 2024-01-23 22:29:07 +08:00
Tim Liou
a5d15c10e8 use getPriorityName 2024-01-18 14:51:21 +08:00
Alexey Milovidov
7731297aef
Merge pull request #58894 from ClickHouse/whitespace-4
Whitespaces
2024-01-17 21:01:22 +01:00
Alexey Milovidov
28b27e34ee Whitespaces 2024-01-17 07:29:45 +01:00
Mikhail Koviazin
9e0414f557
fix data race in SensitiveDataMasker
This commit fixes the data race that was introduced in 3067ca6. That commit
added scope lock for `getInstance` and `setInstance`, but `getInstance`
returned a pointer that could be invalidated between call for `getInstance` and
actual usage of the pointer.

This commit changes `SensitiveDataMasker` singleton from `unique_ptr` to
`shared_ptr`, so even if `setInstance` will be called right after
`getInstance`, the pointer returned from `getInstance` will live long enough to
call `wipeSensitiveData` on it.
2024-01-17 08:10:50 +02:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Victor Krasnov
27b0190c72 Amend clumsy code 2023-09-01 13:23:54 +03:00
Alexey Milovidov
5d68f7c04d Remove unneeded columns from logs 2023-08-20 04:11:39 +02:00
Alexey Milovidov
aa757490bd Ditch tons of garbage 2023-08-09 02:19:02 +02:00
Alexey Gerasimchuck
63b05da1f2 System logs improvements 2023-07-28 07:23:34 +00:00
Dmitry Kardymon
5124f74fcc Merge remote-tracking branch 'origin/master' into ADQM-996 2023-07-21 05:54:36 +00:00
Dmitry Kardymon
688b55b6ff Try to fix test, rename arg 2023-07-19 13:29:07 +00:00
Dmitry Kardymon
9d0391e6fb Add ifndef to fix build 2023-07-18 18:13:57 +00:00
Dmitry Kardymon
7466ef5837 Add index 2023-07-18 13:05:20 +00:00
Dmitry Kardymon
6b00a38aa4 Remove SystemLogBase (wip) 2023-07-18 10:06:44 +00:00
Dmitry Kardymon
f153d6aa3c Fix shutdown 2023-07-14 10:02:18 +00:00
Dmitry Kardymon
4a10c7286e Add name to logger in queue 2023-07-13 12:41:17 +00:00
Dmitry Kardymon
220c0255ab Remove mutex 2023-07-13 08:15:50 +00:00
Dmitry Kardymon
771b1f8f47 Prototype (working) 2023-07-12 15:48:09 +00:00
Victor Krasnov
acd17c7974 Make a deal with the "Style check" 2023-07-07 10:40:04 +08:00
Victor Krasnov
d86ceef663 Implement log file names rendering 2023-07-06 14:14:48 +08:00
Andrey Zvonov
07191ce10d
Merge branch 'master' into zvonand-implicit-tz 2023-06-20 00:24:53 +02:00
Alexey Milovidov
598501011f Relax "too many parts" further 2023-06-11 17:51:54 +02:00
Andrey Zvonov
d95be4162f
Merge branch 'master' into zvonand-implicit-tz 2023-06-08 18:34:45 +03:00
Michael Kolupaev
e7868e576c Don't crash if config doesn't have logger section 2023-06-02 00:50:28 +00:00
zvonand
2a9f28b73b resolve 2023-04-12 12:54:39 +02:00
zvonand
a9499eed79 moved getting server TZ DateLUT to separate place, upd tests and fix 2023-04-12 12:47:05 +02:00
Andrey Zvonov
4327d707e0
Merge branch 'master' into zvonand-implicit-tz 2023-03-15 22:18:52 +01:00
Alexey Milovidov
399634a1bc More tests 2023-03-15 00:38:46 +01:00
Han Fei
b7eef62458
Merge pull request #45491 from azat/dist/async-send-refactoring
[RFC] Rewrite distributed sends to avoid using filesystem as a queue, use in-memory queue instead
2023-03-06 12:32:33 +01:00
Robert Schulze
740aeaba1f
Apply some CTAD 2023-03-02 13:36:47 +00:00
Azat Khuzhin
b5434eac3b Rename StorageDistributedDirectoryMonitor to DistributedAsyncInsertDirectoryQueue
Since #44922 it is not a directory monitor anymore.

v2: Remove unused error codes
v3: Contains some header fixes due to conflicts with master
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-28 22:33:36 +01:00
zvonand
f3e19144d8 update 2023-02-27 14:38:15 +01:00
Alexey Milovidov
d8cda3dbb8 Remove PVS-Studio 2023-02-19 23:30:05 +01:00
Alexander Tokmakov
93509395fb add a column with a message pattern to text_log 2022-12-23 15:06:30 +01:00
Dmitry Novik
323fdeff0b
Merge branch 'master' into fix-odr-vialation 2022-09-09 00:42:14 +02:00
Dmitry Novik
29b5d023ee Replace WITH_TEXT_LOG by WITHOUT_TEXT_LOG 2022-09-08 19:16:37 +02:00
Azat Khuzhin
313747688e Ignore memory limits while logging
Otherwise there can be pretty noisy messages, like here [1]:

    Cannot add message to the log: Code: 241. DB::Exception: Memory limit (for user) exceeded: would use 42.02 MiB (attempt to allocate chunk of 2101278 bytes), maximum: 4.77 MiB. OvercommitTracker decision: Waiting timeout for memory to be freed is reached. (MEMORY_LIMIT_EXCEEDED), Stack trace (when copying this message, always include the lines below):

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/efc74e33e580b7d3ff33c3e269db86addfaa6b51/stateless_tests__msan__[2/3].html

And it should be okay to ignore server limits too, since it always
better to have a proper log message in a proper place, not stderr which
does not inspected usually.

Follow-up for: #24069
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-05 12:20:15 +02:00
Mallik Hassan
87a28c25f5 Update src/Loggers/Loggers.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-08-30 23:20:19 -03:00
root
f02f7ce99c addressed minor change requests 2022-08-30 23:20:19 -03:00
root
834ab5cd2b removed redundant initializer for base class 'OwnPatternFormatter' 2022-08-30 23:20:19 -03:00
root
790a437eb2 Addressed review requests: removed this pointer in functions and config variable in class 2022-08-30 23:20:19 -03:00