Commit Graph

5775 Commits

Author SHA1 Message Date
alexey-milovidov
e25d9843d1
Merge pull request #25025 from azat/parallel-kill-mutation
Distinguish KILL MUTATION for different tables.
2021-06-08 21:40:53 +03:00
Maksim Kita
59071d9bd1
Merge pull request #25060 from den-crane/tests/attach-partition-from
test for attach partition from
2021-06-08 13:22:38 +03:00
Nikolai Kochetov
ab2529d4f0
Merge pull request #25055 from amosbird/projection-fix9
Fix using aggregate projection when group by without key
2021-06-08 12:15:25 +03:00
Maksim Kita
93691f6809
Update test to have consistent style 2021-06-08 12:11:06 +03:00
Azat Khuzhin
fc46005033 Mark 01900_kill_mutation_parallel as long
https://clickhouse-test-reports.s3.yandex.net/25025/80f5395e2e49b0ba45683f03adb851bd34f210ec/functional_stateless_tests_flaky_check_(address)/test_run.txt.out.log
2021-06-08 10:51:22 +03:00
Azat Khuzhin
1062d0ec91 Distinguish KILL MUTATION for different tables.
Before this patch KILL MUTATION marks mutation as canceled just by name
(and part numbers) so if you have multiple tables with the same part
name, then killing mutation for one table, will mark it as killed for
another too.

Fix this by comparing StorageID too (it is better to use StorageID over
database/table to avoid ambiguity by using UUIDs for comparing).

Here is a failure of the 01414_freeze_does_not_prevent_alters on CI [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/24069/9fb69dcf98c71a939d200cad3c8491bf43a44622/functional_stateless_tests_(ubsan).html#fail1
2021-06-08 10:51:22 +03:00
alexey-milovidov
deeaa98af5
Merge pull request #24069 from azat/log-ignore-errors
[RFC] Suppress exceptions from logger code
2021-06-08 03:59:06 +03:00
Denis Zhuravlev
857551178c test for attach partition from. #17500 2021-06-07 18:34:02 -03:00
Denis Zhuravlev
944940d6fb test for attach partition from. #17500 2021-06-07 18:30:03 -03:00
Ivan
71f1a101c1
More pytest fixes (#23538) 2021-06-07 20:29:19 +03:00
Amos Bird
840895509e
Fix using aggregate projection when group by without key 2021-06-07 22:44:42 +08:00
Nikolai Kochetov
0043434d5c
Merge pull request #24894 from amosbird/notinpartitionprune
Allow not in be used in partition pruning
2021-06-07 12:42:48 +03:00
Kruglov Pavel
ee683ea90e
Merge pull request #24729 from vdimir/segment-lenght-sum-fixes
Minor fixes in AggregateFunctionSegmentLengthSumData
2021-06-07 11:01:29 +03:00
Azat Khuzhin
38c7056ecc Rewrite 01594_too_low_memory_limits
After #24483 had been merged the only place where the allocation may
fail is the insert into PODArray in DB::OwnSplitChannel::log, but this
MR ignores the errors in this function, so to check new behaviour
separate server is required.
2021-06-07 09:38:15 +03:00
Azat Khuzhin
ac1ff225a3 Revert "Cleanup 01594_too_low_memory_limits (by using clientError)"
--testmode can't be used since this disables logging while the
failed allocation comes from:

    2021.06.04 09:54:49.576479 [ 31070 ] {} <Error> ServerErrorHandler: Code: 241, e.displayText() = DB::Exception: Memory limit (for query) exceeded: would use 2.01 MiB (attempt to allocate chunk of 4096 bytes), maximum: 1.00 B, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:133: std::exception::capture() @ 0xe2d88 in /src/ch/clickhouse/.cmake/programs/server/libclickhouse-server-libd.so
    1. /src/ch/clickhouse/.cmake/../contrib/libcxx/include/exception:111: std::exception::exception() @ 0x1e9b92 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    2. /src/ch/clickhouse/.cmake/../contrib/poco/Foundation/src/Exception.cpp:28: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x1dd943 in /src/ch/clickhouse/.cmake/contrib/poco-cmake/Foundation/lib_poco_foundationd.so
    3. /src/ch/clickhouse/.cmake/../src/Common/Exception.cpp:59: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x2aaffd in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    4. /src/ch/clickhouse/.cmake/../src/Common/Exception.h:40: DB::Exception::Exception<char const*, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*&&, char const*&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, long&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&) @ 0x2ebef0 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    5. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:226: MemoryTracker::allocImpl(long, bool) @ 0x2eac82 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    6. /src/ch/clickhouse/.cmake/../src/Common/MemoryTracker.cpp:0: MemoryTracker::allocImpl(long, bool) @ 0x2eae3e in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    7. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:47: CurrentMemoryTracker::(anonymous namespace)::allocImpl(long, bool) @ 0x27b621 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    8. /src/ch/clickhouse/.cmake/../src/Common/CurrentMemoryTracker.cpp:61: CurrentMemoryTracker::alloc(long) @ 0x27b541 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    9. /src/ch/clickhouse/.cmake/../src/Common/Allocator.h:96: Allocator<false, false>::alloc(unsigned long, unsigned long) @ 0x274b71 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    10. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:120: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::alloc<>(unsigned long) @ 0x305af3 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    11. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:146: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::realloc<>(unsigned long) @ 0x305cbb in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    12. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:182: void DB::PODArrayBase<4ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::reserveForNextSize<>() @ 0x306010 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    13. /src/ch/clickhouse/.cmake/../src/Common/PODArray.h:0: void DB::PODArray<unsigned int, 4096ul, Allocator<false, false>, 15ul, 16ul>::push_back<unsigned int>(unsigned int&&) @ 0x5423a6a in /src/ch/clickhouse/.cmake/src/AggregateFunctions/libclickhouse_aggregate_functionsd.so
    14. /src/ch/clickhouse/.cmake/../src/Columns/ColumnVector.h:280: DB::ColumnVector<unsigned int>::insert(DB::Field const&) @ 0x3c6422 in /src/ch/clickhouse/.cmake/src/libclickhouse_columnsd.so
    15. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:60: DB::OwnSplitChannel::logSplit(Poco::Message const&) @ 0xa2833 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so
    16. /src/ch/clickhouse/.cmake/../base/loggers/OwnSplitChannel.cpp:35: DB::OwnSplitChannel::log(Poco::Message const&) @ 0xa2588 in /src/ch/clickhouse/.cmake/base/loggers/libloggersd.so

This reverts commit 0cecc754709cc774c90269a1dc8653eac8725341.
2021-06-07 09:38:15 +03:00
Azat Khuzhin
d5767da5fd Cleanup 01594_too_low_memory_limits (by using clientError) 2021-06-07 09:38:15 +03:00
Azat Khuzhin
0d34cb655c Disable 01594_too_low_memory_limits under sanitizers 2021-06-07 09:38:15 +03:00
mergify[bot]
da637c08b2
Merge branch 'master' into fix-bad-test-2 2021-06-06 18:02:37 +00:00
alexey-milovidov
295dc6b517
Revert "Add initial_query_start_time to query log" 2021-06-06 20:57:04 +03:00
alexey-milovidov
81a12404c7
Merge pull request #24940 from azat/settings-limit-offset-fix
Fix limit/offset settings for distributed queries (ignore on the remote nodes)
2021-06-06 17:39:15 +03:00
alexey-milovidov
c3baba2287
Merge pull request #24930 from amosbird/distributedfix
Allow shard pruning with IN literal
2021-06-06 17:36:47 +03:00
Alexey Milovidov
9f1b7afd7c Fix bad test 2021-06-06 16:38:53 +03:00
alexey-milovidov
db384a163c
Merge pull request #24388 from amosbird/initialquerystarttime
Add initial_query_start_time to query log
2021-06-06 16:15:37 +03:00
Nikita Mikhaylov
af32228e9f
Merge pull request #24523 from Algunenano/i24461
Fix crash when chaining uniqStates
2021-06-04 17:26:34 +03:00
Amos Bird
fd336411ee
Allow shard pruning with IN literal 2021-06-04 21:16:15 +08:00
Nikita Mikhaylov
f1733a93e5
Merge pull request #24857 from kssenii/postgresql_protocol
Fix NULL values in postgresql protocol
2021-06-04 14:43:47 +03:00
vdimir
494ee6eb41
Rename segmentLengthSum -> intervalLengthSum 2021-06-04 09:09:05 +03:00
Azat Khuzhin
8164c49f04 Fix limit/offset settings for distributed queries (ignore on the remote nodes) 2021-06-03 21:14:24 +03:00
Kruglov Pavel
8acf031c1b
Merge pull request #24398 from Avogar/fix-deltasum
Fix logical error AggregateFunctionFactory returned nullptr
2021-06-03 19:40:06 +03:00
Kseniia Sumarokova
9f9f4c5a25
Update skip_list.json 2021-06-03 16:38:47 +03:00
tavplubix
1aff716f18
Merge pull request #24777 from ClickHouse/fix_intersection_with_lost_part
Do not crash on intersecting virtual parts
2021-06-03 15:42:46 +03:00
Vladimir
17f0900c31
Merge pull request #19766 from achimbab/pr_sequenceNextNode 2021-06-03 13:16:42 +03:00
kssenii
47f2764ab8 Fix test 2021-06-03 09:15:22 +00:00
Amos Bird
df86f8ed36
Allow not in be used in partition pruning 2021-06-03 11:36:43 +08:00
Nikita Mikhaylov
f41e1da5fe
Merge pull request #24886 from nikitamikhaylov/debugging-rocks-db 2021-06-02 22:42:51 +03:00
Maksim Kita
5804d0ddcc
Merge pull request #24450 from DimasKovas/dakovalkov/fix_storage_buffer_total_bytes
Fix totalBytes computation in StorageBuffer
2021-06-02 22:32:04 +03:00
Nikita Mikhaylov
58f118daf0 done 2021-06-02 15:55:20 +00:00
Amos Bird
9bbc9f97b4
Implement antlr parser for projections (#24245)
* implement projection grammer for antlr parser

* Add comment
2021-06-02 18:09:55 +03:00
Anton Popov
c0ef021c6a
Merge pull request #24822 from CurtizJ/merging-23260
Merging #23260
2021-06-02 15:02:37 +03:00
tavplubix
b0fd75f20a
Merge pull request #24805 from ClickHouse/fix_database_replicated_enqueue_race
Fix race on enqueue query in Replicated database
2021-06-02 13:44:19 +03:00
vdimir
1b936c8af6
Remove example usage of allow_experimental_funnel_functions from windowFunnel 2021-06-02 09:16:21 +03:00
kssenii
c1f79fb046 Add test to parallel skip list 2021-06-01 17:45:03 +00:00
tavplubix
375dd1b6c4
Update 01154_move_partition_long.sh 2021-06-01 19:26:54 +03:00
kssenii
ccf5455624 Allow null values in postgresql protocol 2021-06-01 15:00:32 +00:00
Alexander Tokmakov
7d7c5638a5 Merge branch 'master' into fix_intersection_with_lost_part 2021-06-01 16:32:59 +03:00
Nikolai Kochetov
e615858b10 Merge branch 'master' into refactor-MergeTreeDataSelectExecutor 2021-06-01 16:25:04 +03:00
Anton Popov
84af235a60 fix test 2021-06-01 15:21:41 +03:00
Alexander Kuzmenkov
f51ecf8a72
Merge pull request #23769 from vdimir/issue-20309
Add qualified names for right columns for storage join
2021-06-01 14:42:49 +03:00
Alexander Tokmakov
94d2aed336 fix tests 2021-06-01 13:24:06 +03:00
Nikolai Kochetov
b54ff696e5 Merge branch 'master' into refactor-MergeTreeDataSelectExecutor 2021-06-01 12:08:37 +03:00