Commit Graph

1270 Commits

Author SHA1 Message Date
Alexander Tokmakov
c588a7f386 Merge branch 'master' into make_code_worse 2023-10-26 17:39:10 +02:00
Alexander Tokmakov
fa963d60d0
Merge pull request #55641 from evillique/resubmit-cluster-groups
Resubmit #54421
2023-10-26 15:53:53 +02:00
Nikolay Degterinsky
d5ee863594 Fix 2023-10-25 19:06:50 +00:00
Nikolay Degterinsky
97c99132e0 Simplify the implementation 2023-10-25 19:02:48 +00:00
Alexander Tokmakov
0f4260bf26 fix some bad code by making it worse 2023-10-25 19:51:51 +02:00
Sergei Trifonov
966f1b6378
Merge pull request #55877 from ClickHouse/serxa-patch-3
Fix digest check in replicated ddl worker
2023-10-23 14:25:20 +02:00
Anton Popov
5819bcd07a
Support asynchronous inserts for native protocol (#54730)
* support async insert for native protocol

* use separate queue for async inserts via native protocol

* fix test

* better logging for async inserts and more tests

* disable mixed internal and external data in async inserts

* fix tests

* fix quota in async inserts

* disable async insert for secondary query of distributed
2023-10-20 18:39:48 +02:00
Sergei Trifonov
fd93bc74bd
Fix digest check in replicated ddl worker 2023-10-20 18:03:16 +02:00
kssenii
4bc32c6387 Fix uncaught exception in background tasj 2023-10-16 17:31:30 +02:00
kssenii
3cd175d11d Fix test 2023-10-16 13:01:36 +02:00
Nikolay Degterinsky
b737866d02 Fixes 2023-10-14 19:29:21 +00:00
Nikolay Degterinsky
c1fba94d67 Resubmit #54421
This reverts commit 3e60451ac7.
2023-10-14 19:04:01 +00:00
Kseniia Sumarokova
310e922b40
Merge branch 'master' into materialized-pg-allow-unique-identifier 2023-10-13 19:14:50 +02:00
Alexander Tokmakov
3e60451ac7 Revert "Merge pull request #54421 from evillique/cluster-groups"
This reverts commit 211c80e1a0, reversing
changes made to b53a98217c.
2023-10-13 18:55:51 +02:00
Alexander Tokmakov
83daf766c9 Revert "Merge pull request #55587 from azat/fix-replica-group"
This reverts commit ebfad5c8b8, reversing
changes made to e64abfc557.
2023-10-13 18:55:22 +02:00
Azat Khuzhin
db1b9408f3 Fix replica groups for Replicated database engine
Should fix 02447_drop_database_replica test

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-13 12:32:17 +02:00
robot-clickhouse-ci-1
211c80e1a0
Merge pull request #54421 from evillique/cluster-groups
Add replica groups to Replicated database engine
2023-10-12 18:14:42 +02:00
Nikolay Degterinsky
20e16be27b Fixes & improvements 2023-10-12 15:02:08 +00:00
kssenii
1917a882b7 Better 2023-10-12 16:36:19 +02:00
Vitaly Baranov
d841b8179e
Merge pull request #55060 from vitlibar/fix-detecting-column-default-for-dist-table
Fix detecting DEFAULT for columns of a Distributed table created without AS
2023-09-29 19:54:16 +02:00
kssenii
d1f6888119 Allow unique consumer identifier 2023-09-29 16:17:02 +02:00
Vitaly Baranov
cd2063d154 Fix detecting DEFAULT for a column of a Distributed table created without AS. 2023-09-28 13:00:37 +02:00
Robert Schulze
9fff447716
Re-enable clang-tidy checks 2023-09-26 09:34:12 +00:00
Robert Schulze
f5e8028bb1
Merge pull request #54642 from rschu1ze/broken-re2st
Remove broken lockless variant of re2
2023-09-17 15:30:57 +02:00
robot-ch-test-poll4
5fb8e46967
Merge pull request #54635 from Avogar/cluster-func-names-with-spaces
Fix schema inference for *Cluster functions for column names with spaces
2023-09-15 20:36:33 +02:00
avogar
e647346b36 Better 2023-09-15 11:11:04 +00:00
Robert Schulze
7b378dbad3
Remove broken lockless variant of re2 2023-09-14 16:40:42 +00:00
Val Doroshchuk
6cfbaf9f86 MaterializedMySQL: Introduce Character Set Introducers
If some string literals are used in DDL, they might have `Character Set Introducers`
https://dev.mysql.com/doc/refman/8.0/en/charset-introducer.html
f.e. _utf8mb4'1' which is not parsable by current ParserStringLiteral.

Since we use utf8 by default, suggesting to automatically convert the string literals to utf8
before executing the query and avoid any charset introducers there.
Conversion from utf8 to utf8 is not needed and skipped.

Also it might convert double quotes to single quotes if any
which might solve issues with COMMENT and empty string literals "" in DEFAULT expressions.

SELECT _latin1"abc"; -- might be also valid for MySQL
... DEFAULT "",
... COMMENT "abc"

Currently no DEFAULT expressions are supported, not parsable at all,
but using this MR it allows to parse the expressions together with double quotes as string literals.
2023-09-14 08:24:25 +02:00
Nikolay Degterinsky
483184cbdb Add cluster groups to Replicated database engine 2023-09-07 16:02:11 +00:00
Alexey Gerasimchuck
3a212217a3 Implemented globs to select * from '<file>' 2023-08-31 04:20:44 +00:00
Kseniia Sumarokova
8633b8fbc9
Merge pull request #53832 from kssenii/mat-pg-fix-get-create-table
Materialized postgres: fix uncaught exception in getCreateTableQueryImpl
2023-08-25 18:24:07 +02:00
kssenii
8e3dd4c9d2 Fux 2023-08-25 12:46:28 +02:00
Nikolai Kochetov
ef3489762a Fix typo in cluster name. 2023-08-25 10:00:51 +00:00
Robert Schulze
a20ceef398
Merge pull request #53447 from davvard/master
USearch HNSW index for ANN search
2023-08-21 23:34:26 +02:00
Yarik Briukhovetskyi
af1d23720b
Merge branch 'ClickHouse:master' into fixed_hints_db_name 2023-08-21 13:57:39 +03:00
Nikolay Degterinsky
4c606590a1
Fix tiny thing in Replicated database (#53496)
* Fix tiny thing in Replicated database

* empty commit

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-08-18 17:29:24 +03:00
Davit Vardanyan
ef2957cb91 Add: allow_experimental_usearch_index checks 2023-08-16 17:29:50 +04:00
Alexander Tokmakov
894ec8e0d0 less exceptions with runtime format string 2023-08-14 21:45:59 +02:00
yariks5s
31aa9f459e minor fixes 2023-08-14 09:35:29 +00:00
Alexey Milovidov
a55f9eae84 Merge branch 'master' of github.com:ClickHouse/ClickHouse into allow-creating-system-tables-at-startup 2023-08-11 14:45:03 +02:00
Yarik Briukhovetskyi
a6f89c0546
Added suggestions for mistyped names for db and tables with different… (#49801)
* Added suggestions for mistyped names for db and tables with different scenarios commented

* fixed bugs

* fixed style check

* fixed errors

* fixed errors

* fixed error with exceptions

* fixed exceptions

* fixed exceptions

* fixed exceptions

* added test and fixed bugs

* fixed style check

* fixed style check

* fixed style check

* fixed check black

* Update test.py

* Fixed server crash

* Fixed server crash and style check

* Fixed style check

* Fixed style check

* Fixed style check

* Fixed bugs with drop_db

* fixed fast test

* added tests

* fixed style check

* fixed style check

* fixed bug with lock_db

* fixed bug with lock_db and fixed reviews

* fixed bug with lock_db and fixed reviews

* fixed style check

* fixed fast test

* fixed fast test

* revert to fd582a2

* revert to fd582a2

* Removed unused parameters

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Remove unused parameters

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* resolved arguments issue in assertDatabaseExists

* fixing fast test

* fixed fast test

* fixed stateless test for default db

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Fixing tests.

* resolved problem with mutex

* Fixed mutex in assertDatabaseExists

* changes about assertDatabaseExists

* fixed bugs with file types

* fixed string types

* fixed fast test

* fixed mutex

* fixed mutex

* fixed style check

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update src/Interpreters/DatabaseCatalog.cpp

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* fixed build

* added -unlocked versions of functions

* Revert "fixed build"

This reverts commit 8ce961be21.

* Revert "fixed build"

This reverts commit 8ce961be21.

* changed usage of assertDatabaseExistsUnlocked()

* fixed style check

* style check

* style check

* Revert "style check"

This reverts commit 28a9ee85a0.

* Merge branch 'master' into hints-for-wrong-db-or-table-name

* Changed AssertDatabaseExists and unified exception output

* resolved proposed changes and modified tests

* Revert "resolved proposed changes and modified tests"

This reverts commit d45337d65c.

* resolved requested changes

* fixed tests

* fixed tests

* fixed check black

* Update include brackets

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>

* Update suggested changes

* Update suggested changes

* Fixed style check

* Added test to analyzer_integration_broken

* Update DatabaseCatalog.cpp

* Update test.py

* fixed test

* Revert "fixed test"

This reverts commit ca6d4c17c8.

* fixed test

* Revert "fixed test"

This reverts commit fe6d0d9c86, reversing
changes made to 22f4496704.

* Update test.py

* fixed black check

* Update test.py

* fixed long_log_tinylog_deadlock_race

* Update DatabaseCatalog.cpp

* Update test.py

* style

* Update DatabaseCatalog.cpp

* Fixed test

* implemented for IDatabase

* Style check

* removed const_cast

* Update DatabaseCatalog.h

* Update DatabaseCatalog.h

* Update DatabaseCatalog.cpp

* Update DatabaseCatalog.cpp

* Added db name to hints

* Update 00002_log_and_exception_messages_formatting.sql

* Update 00002_log_and_exception_messages_formatting.sql

---------

Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-08-11 13:24:16 +03:00
Alexey Milovidov
736ff1c127 Merge branch 'master' into allow-creating-system-tables-at-startup 2023-08-11 01:25:49 +02:00
Alexander Tokmakov
48ed54e822
Allow experimantal features when recovering Replicated db replica (#53167)
* allow experimantal features when recovering Replicated db replica

* Automatic style fix

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2023-08-09 14:35:50 +03:00
Alexey Milovidov
74a4c9755c Don not produce warning if a system table was created on startup 2023-08-07 02:26:23 +02:00
kssenii
4b8b78f220 Revert "Merge pull request #53044 from ClickHouse/revert-52155-database-filesystem-remove-catch"
This reverts commit e71f20891f, reversing
changes made to aa9ab58994.
2023-08-04 12:41:55 +02:00
Alexander Tokmakov
0b312f541a
Revert "Remove try/catch from DatabaseFilesystem" 2023-08-04 13:29:28 +03:00
Kseniia Sumarokova
af610062ec
Merge pull request #52962 from canhld94/fix_mysql_password_leak
Fix password leak in show create mysql table
2023-08-04 10:57:59 +02:00
Alexey Milovidov
95f5d2f37f
Merge pull request #52155 from ClickHouse/database-filesystem-remove-catch
Remove try/catch from DatabaseFilesystem
2023-08-03 23:02:01 +03:00
Alexander Tokmakov
141a3df727 fix 2023-08-03 12:35:14 +02:00
Duc Canh Le
cc7f771093 Fix for postgres as well 2023-08-03 09:15:45 +00:00