Commit Graph

14 Commits

Author SHA1 Message Date
Antonio Andelic
e64436fef3 Fix typos with new codespell 2022-09-02 08:54:48 +00:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.

As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.

In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).

(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
Azat Khuzhin
8485abd52b Remove unbundled lz4 support 2022-01-20 08:47:16 +03:00
Filatenkov Artur
c23fe5baf6
Improve codec for encr 19896 (#27476)
* change syntax of encrypted command

* commit all encrypted changes

* correct encryption

* correct config for test

* add tests and correct code style and typos

* correct test

* fix unbundled build

* add log warning messages

* improve code according to review comments

* correct nonce

* correct errors found by fuzzing

* improve codec AES_128_GCM_SIV. Add AES_256_GCM_SIV. Add sections for last in tests. Improve documentation

* Update CompressionCodecEncrypted.h

* Update 01683_codec_encrypted.sql

* correct compression factory after changes in master

* correct behavior with wrong key in data

* correct fuzzer

* add connection for fuzzer with fix for compression_encrypted

* refactor code

* add load from config with throwing errors on server start

* fix typos and check style

* Update Server.cpp

* correct loading and reading

* refactor code. fix uninitialized value

* refactor code

* move defines from server to cpp file

* correct build

* remove repeated code

* correct namespace

* fix code style
2021-09-13 11:25:36 +03:00
Nikita Mikhaylov
28d70dae43 Deleted printing exception message 2021-08-25 20:58:53 +00:00
Nikita Mikhaylov
923d6759c0 Fix style 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
02e097a262 Fix tests 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
43fb3098ae Deleted some unneded changes 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
08fbab09b0 Fix some issues 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
2c09533c83 lower a binary size for compression fuzzers 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
ad4966f6d2 better 2021-08-25 15:40:56 +00:00
Nikita Mikhaylov
e63da5969f First blood 2021-08-25 15:40:15 +00:00
Nikita Mikhaylov
80ebc6ccea Done 2021-08-22 15:09:49 +00:00
Nikita Mikhaylov
3cd689c168 Moved fuzzers to another directory 2021-08-21 02:27:27 +00:00