Commit Graph

1329 Commits

Author SHA1 Message Date
Robert Schulze
1942ea6f29
Remove further legacy compiler support from poco 2023-02-14 22:07:38 +00:00
Robert Schulze
144005319d
Remove MSVC support from poco 2023-02-14 22:05:27 +00:00
Robert Schulze
acf3185366
Merge pull request #46259 from ClickHouse/rs/fix-poco-style
Run clang-format over poco
2023-02-14 22:52:02 +01:00
Robert Schulze
61e315f30d
Merge pull request #45520 from ClibMouse/z-build-0120
s390x build support
2023-02-14 10:01:38 +01:00
Alexey Milovidov
f57ba896c8
Merge pull request #46181 from saitama951/master-sanjam
IBM's s390x architecture: Issue #2053 - conversion of 256 bit to 128 bit
2023-02-14 09:34:17 +03:00
Suzy Wang
e140bed3ea
Merge branch 'master' into z-build-0120 2023-02-13 09:06:48 -05:00
Robert Schulze
9f4ffc95ce
Fix non-self-contained headers 2023-02-13 09:34:24 +00:00
Robert Schulze
e30ca4e376
Run clang-format over poco Data 2023-02-13 09:34:12 +00:00
Robert Schulze
e6b93b9150
Remove unused poco AIX patch 2023-02-13 09:24:30 +00:00
Robert Schulze
d3bcfbb2a5
Run clang-format over poco Foundation Mongo Net NetSSL_OpenSSL Util 2023-02-13 09:22:33 +00:00
Robert Schulze
c73a8bded3
Run clang-format over poco JSON Redis Crypto 2023-02-13 09:20:48 +00:00
Robert Schulze
fc7c90cd94
Run clang-format over poco xml 2023-02-13 09:00:23 +00:00
Jordi Villar
331662b1a7
Fix macOs compilation due to sprintf 2023-02-11 13:20:56 +01:00
Alexey Milovidov
17d325c407
Merge pull request #46163 from DimasKovas/fix_precise_exp_10_license_notice
Remove excessive license notices from preciseExp10.cpp
2023-02-11 06:05:23 +03:00
Robert Schulze
38b6f89d68
Fix FreeBSD build 2023-02-10 13:28:06 +00:00
Robert Schulze
81e943c7f8
More spelling fixes 2023-02-10 11:20:48 +00:00
Robert Schulze
06e1293909
Fix duplicate includes in poco 2023-02-10 10:50:18 +00:00
Robert Schulze
8144c28c3b
Fix spelling 2023-02-10 10:49:55 +00:00
Robert Schulze
d44c6dd1b3
Merge pull request #46133 from ClickHouse/rs/fix-warnings-in-poco
Stricter warnings + fix whitespaces in poco
2023-02-10 11:46:33 +01:00
Suzy Wang
64313d7020
Merge branch 'master' into z-build-0120 2023-02-09 14:49:22 -05:00
Robert Schulze
1c553a2201
Fix ARM and PPC builds 2023-02-09 09:58:27 +00:00
Alexey Milovidov
4c7f30ef56
Update preciseExp10.cpp 2023-02-09 11:55:28 +03:00
Dmitrii Kovalkov
78446b46d9 Return note about function name in preciseExp10.h 2023-02-09 07:29:51 +03:00
Alexey Milovidov
8392b35d50 Speed up countDigits 2023-02-09 04:39:12 +01:00
Alexander Tokmakov
8101b044fa
Merge pull request #46091 from azat/sanity-assertions
Sanity assertions for closing file descriptors
2023-02-09 01:02:03 +03:00
Robert Schulze
28ddee7b58
More warning exclusions in poco odbc 2023-02-08 18:34:56 +00:00
sanjam
e8965543c3 Issue #2053 - conversion of 256 bit to 128 bit 2023-02-08 18:29:13 +00:00
Robert Schulze
74b892c0b9
Fix FreeBSD build 2023-02-08 15:40:49 +00:00
Robert Schulze
53f8ee85e5
Fix warnings in poco odbc 2023-02-08 15:30:05 +00:00
Dmitrii Kovalkov
fbea504ea1 Remove excessive license notices from preciseExp10.cpp 2023-02-08 16:12:21 +03:00
Robert Schulze
537a697f65
Fix whitespaces 2023-02-08 11:36:52 +00:00
Robert Schulze
65cbfdf5c6
Fix warnings in poco json 2023-02-08 11:26:36 +00:00
Robert Schulze
64afe8be0b
Fix warnings in poco xml 2023-02-08 11:26:36 +00:00
Robert Schulze
1838c8912a
Fix warnings in poco netssl_openssl 2023-02-08 11:26:36 +00:00
Robert Schulze
353ef8b451
Fix warnings in poco mongodb 2023-02-08 11:26:36 +00:00
Robert Schulze
4ee6ac8dec
Fix warnings in poco utils 2023-02-08 11:26:36 +00:00
Robert Schulze
c0ca2db7ab
Fix warnings in poco data 2023-02-08 11:26:36 +00:00
Robert Schulze
b0f2c98940
Fix warnings in poco net 2023-02-08 11:26:36 +00:00
Robert Schulze
3a339f8b02
Fix warnings in poco crypto 2023-02-08 11:23:51 +00:00
Robert Schulze
8dd0a465f5
Fix warnings in poco redis 2023-02-08 11:22:07 +00:00
Robert Schulze
ba15cf834d
Fix warnings in poco foundation 2023-02-08 11:22:05 +00:00
Robert Schulze
f002698e09
More fine-granular warning relaxation 2023-02-08 11:21:59 +00:00
Robert Schulze
b79ead9c84
Move poco to base/poco/ (#46075)
* Replicate poco into base/poco/

* De-register poco submodule

* Build poco from ClickHouse

* Exclude poco from stylecheck

* Exclude poco from whitespace check

* Exclude poco from typo check

* Remove x bit from sources/headers (the style check complained)

* Exclude poco from duplicate include check

* Fix fasttest

* Remove contrib/poco-cmake/*

* Simplify poco build descriptions

* Remove poco stuff not used by ClickHouse

* Glob poco sources

* Exclude poco from clang-tidy
2023-02-08 12:04:11 +01:00
Azat Khuzhin
a88903f276 Do not execute expressions inside chassert() in release builds (with sizeof() trick)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:39:16 +01:00
Azat Khuzhin
ec171c1732 Improve abortOnFailedAssertion() usage from chassert()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 13:03:47 +01:00
Azat Khuzhin
fc48f89b76 Improve chassert() macro to suppress warning in release builds
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:17 +01:00
Suzy Wang
716d2c4ffb Update as suggested 2023-02-02 20:41:06 +00:00
Suzy Wang
19d26828a0 s390x build support 2023-01-20 21:16:55 +00:00
serxa
b1407b1070 fix TSA support 2023-01-10 01:19:42 +00:00
serxa
d561f66419 more TSA support 2023-01-09 16:48:39 +00:00
Yakov Olkhovskiy
7a5a36cbed
Merge branch 'master' into refactoring-ip-types 2023-01-04 11:11:06 -05:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code? 2023-01-03 18:51:16 +00:00
Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types 2023-01-02 21:58:53 +03:00
Nikita Mikhaylov
ffaff7167b
Fix flaky tests (#44690) 2022-12-29 14:32:10 +01:00
Azat Khuzhin
b7f92454bf Move LineReader/ReplxxLineReader out from base
This will simplify linking dependencies, and anyway this classes are not
base in any sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
83cad3625b Remove unused setTerminalEcho()
It had been replaced with readpassphrase in #5092

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
4d17510fca Use already written part of the query for fuzzy search (pass to skim)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-26 14:52:38 +01:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types 2022-12-21 23:56:24 -05:00
Azat Khuzhin
cf0e0436be skim: do not panic if terminal is not available
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
082f57c40d clickhouse-client: rebind original non-fuzzy search to C-T
I decided to bind fuzzy to a regular C-R, so that everyone will notice
it, and keep an old behaviour for expect tests, or if someone do not
need fuzzy search (or want blasignly fast search, since skim is slightly
slower).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
82aaad61aa Integrate skim into the client/local
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.

P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC. But anyway
this will be resolved in a different way, but separatelly.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:41 +01:00
Azat Khuzhin
67fa185611
Revert "Builtin skim" 2022-12-14 17:17:19 +03:00
Alexey Milovidov
df17d1b71b
Merge branch 'master' into builtin-skim 2022-12-13 03:33:42 +03:00
Azat Khuzhin
9ed6aa0be1 Fix -Wshorten-64-to-32 on FreeBSD
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-12 08:05:28 +01:00
Azat Khuzhin
de58e9c02d Integrate skim into the client/local
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.

P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:52:00 +01:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support 2022-12-09 20:21:22 -05:00
Yakov Olkhovskiy
0641066183
Merge branch 'master' into refactoring-ip-types 2022-12-08 11:12:05 -05:00
Antonio Andelic
b068119d27
Merge pull request #43498 from azat/client/improve-fuzzy-search
Improve fuzzy search in clickhouse-client/clickhouse-local
2022-12-08 14:07:52 +01:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support 2022-12-08 07:40:43 -05:00
Boris Kuschel
623f23f55d OpenSSL cmake changes 2022-12-07 13:22:46 -05:00
Robert Schulze
3c1a721da4
Merge branch 'master' into hlee-s390x-wide-int-order 2022-12-04 18:47:00 +01:00
Yakov Olkhovskiy
77266ea754 cleanup 2022-11-29 17:34:16 +00:00
Yakov Olkhovskiy
b47cb522b5 revert StrongTypedef and fix test instead 2022-11-28 23:33:47 +00:00
Yakov Olkhovskiy
770b520ded
Merge branch 'master' into refactoring-ip-types 2022-11-28 08:50:19 -05:00
Robert Schulze
a00a020cfb
Merge pull request #42847 from ClibMouse/s390x_bit_cast
s390x datetime64 conversion fix
2022-11-28 11:45:43 +01:00
Yakov Olkhovskiy
c47f13afd5 explicit conversion for StrongTypedef 2022-11-26 03:36:01 +00:00
Azat Khuzhin
7a9adbc285 Escape shell arguments for fzf/skim
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 20:15:04 +01:00
Azat Khuzhin
59e647077d Improve fuzzy search in clickhouse-client/clickhouse-local
I found few difference in sk/fzf and after this patch I think that it
should behave better.

So the following commands will be used by default:
- fzf --read0 --tac --tiebreak=index --height=30%
- sk --read0 --tac --tiebreak=-score --height=30%

Those two more or less allows true fuzzy reserve search.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:44:07 +01:00
Azat Khuzhin
14d4980e26 Fix repainting of the client prompt after fuzzy search
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:42:39 +01:00
Yakov Olkhovskiy
ac4b050644 style fix 2022-11-22 13:10:33 +00:00
Yakov Olkhovskiy
988b030bfd bug fix, refactoring IPv6 to struct with overridden comparison 2022-11-22 12:57:19 +00:00
Suzy Wang
60119a97f7 fix build error 2022-11-17 20:38:22 -08:00
HarryLeeIBM
0133444433 Fix byte order issue of wide integer for s390x 2022-11-14 10:47:32 -08:00
Yakov Olkhovskiy
9aeebf3bdf
Merge branch 'master' into refactoring-ip-types 2022-11-14 09:21:54 -05:00
Yakov Olkhovskiy
4d144be39c replace domain IP types (IPv4, IPv6) with native 2022-11-14 14:17:17 +00:00
Suzy Wang
f624143532 fix typo 2022-11-10 12:42:38 -08:00
Suzy Wang
84a8c02d78 Update typo and rm whitespaces 2022-11-10 12:32:40 -08:00
Raúl Marín
aaf8cc6ca8 Revert "Add global flags to base/ libraries"
This reverts commit 43e065c18e.
2022-11-10 11:32:27 +01:00
Suzy Wang
73e5cd91c8 rm unnecessary include 2022-11-09 13:59:34 -08:00
Raúl Marín
39f4120655 Fix broken build 2022-11-09 13:21:59 +01:00
Raúl Marín
43e065c18e Add global flags to base/ libraries 2022-11-09 11:24:20 +01:00
Suzy Wang
ba868801fa Update as suggested 2022-11-08 20:51:35 -08:00
Raúl Marín
050f3ca7cf Fix msan warning 2022-11-08 17:25:03 +01:00
Alexander Tokmakov
fc77d53db1
Merge pull request #43009 from azat/fix-tsan
Fix TSan errors (correctly ignore _exit interception)
2022-11-07 22:20:53 +03:00
Alexander Tokmakov
b4ecbbf224
Update safeExit.cpp 2022-11-07 21:07:09 +03:00
Azat Khuzhin
d6bfbeb95f Fix TSan errors (correctly ignore _exit interception)
Because safeExit() does not includes header with defines, it does not
know about THREAD_SANITIZER.

And it also fixes Azure blob storage, actually everything is fine with
the sdk itself, the problem is only in TSan that intercepts _exit() and
report leak, even thoug that tread will be joined later.

Refs: #23056 (#23616)
Fixes: #38474
Closes: #42640
Fixes: #42638
Fixes: #34988
Cc: @alexey-milovidov, @tavplubix

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-07 16:10:35 +01:00
Amos Bird
4c2b3de93d
Fix msan error 2022-11-04 22:08:14 +08:00
Amos Bird
a89e847514
Fix getauxval for sanitizer builds 2022-11-04 22:08:13 +08:00
Suzy Wang
9560306cdb Update fix 2022-11-03 09:29:15 -07:00
Suzy Wang
80c4d27a89 reverse columnVector change and update new fix 2022-11-02 07:15:00 -07:00
Azat Khuzhin
4eeb7337ed Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
Conflicts:
- src/Common/intExp.h
- src/Functions/DateTimeTransforms.h
- src/Functions/FunctionsConversion.h
2022-10-21 22:51:56 +02:00
Azat Khuzhin
1e739791a4 Fix type error in itoa (wrong static_cast<>)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
0625a866f0 Add a note about incorrect wide_integer with Decimal
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
7b28a80ad7 Fix -Wshorten-64-to-32 for amd64sse2 build
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Alexey Milovidov
445487e073 Merge branch 'master' into add-test-658 2022-10-20 23:55:15 +02:00
Sema Checherinda
52f57cd1ee
Merge pull request #42080 from azat/client-fuzzy-history
Avoid adding extra new line after using fuzzy history search
2022-10-12 10:50:26 +02:00
Alexey Milovidov
8a066b5eef Fix test 2022-10-11 01:28:36 +02:00
Alexander Tokmakov
ff03181d31
Update safeExit.cpp 2022-10-10 15:01:03 +03:00
Alexey Milovidov
69a3ddb5cb
Merge pull request #42128 from Algunenano/tsa_build
Fix build without TSA
2022-10-09 03:11:47 +03:00
Alexander Tokmakov
8b44e11430 fix 2022-10-08 16:10:46 +02:00
Alexander Tokmakov
4175f8cde6 abort instead of __builtin_unreachable in debug builds 2022-10-07 21:49:08 +02:00
Alexander Tokmakov
1a1a20587e
Update defines.h 2022-10-07 21:26:09 +03:00
Raúl Marín
5d9c4a39c0 Update comment 2022-10-07 14:06:28 +02:00
Raúl Marín
62599e3901 Simpler macro 2022-10-07 11:14:35 +02:00
Raúl Marín
6b0ad85640 Fix build without TSA 2022-10-06 16:26:48 +02:00
Azat Khuzhin
e9d4d15c0d Add more comments for skim/fzf compatibility
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-05 09:59:48 +02:00
Azat Khuzhin
6e7114128b Avoid adding extra new line after using fuzzy history search
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-05 09:59:48 +02:00
BoloniniD
55c79230b3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-29 23:53:25 +03:00
Azat Khuzhin
8cc53a48ae clickhouse-client: tune fzf/sk options to be a real reverse search
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
d0f14e1255 clickhouse-client: proper support of vfork() w/o dlsym() in musl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
aaa36e2b25 clickhouse-client: add support of sk (fzf-like in rust)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
58b61d8207 clickhouse-client: add interactive history search with fzf-like utility
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
6acdeb84be clickhouse-client: refactor editor execution
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Nikita Mikhaylov
e897816572
Evict stale DNS entries from cache in case of network errors (#41707) 2022-09-25 14:06:13 +02:00
BoloniniD
55fcb98f29 Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-19 21:53:14 +03:00
BoloniniD
5b4fb4bf66
Merge branch 'master' into BLAKE3 2022-09-18 23:14:37 +03:00
Alexey Milovidov
5c75a7d661 Fix error 2022-09-18 09:20:48 +02:00
Alexey Milovidov
35cce03125 Remove dlopen 2022-09-17 03:02:34 +02:00
BoloniniD
452ef4435b Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-16 20:05:56 +03:00
BoloniniD
0df426d329 Corrosion fixes + review fixes 2022-09-16 00:05:21 +03:00
Azat Khuzhin
569b4bb631 Add ability to automatically comment SQL queries in clickhouse-client/local
This is like Alt-# in readline, it is useful when you need to look
something else, and need to save current query/command somewhere, and
commented lin the history is a good option.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-12 21:57:21 +02:00
Alexey Milovidov
2aedd41023
Remove strange code (#40195)
* Remove strange code

* Even more code removal

* Fix style

* Remove even more code

* Simplify code by making it slower

* Attempt to do something

* Attempt to do something

* Well do something with this horrible trash

* Add a test
2022-09-12 16:29:23 +02:00
Alexey Milovidov
33635e015d Fix style 2022-09-11 06:11:02 +02:00
Alexey Milovidov
fa62c7e982 Fix half of trash 2022-09-10 04:08:16 +02:00
BoloniniD
e8bcbcd016
Merge branch 'master' into BLAKE3 2022-09-09 11:48:31 +03:00
BoloniniD
c08b41b611 Clean files and compatibility code 2022-09-08 09:34:59 +03:00
BoloniniD
069fbdd7c5 Fix broken builds 2022-09-05 20:56:03 +03:00
BoloniniD
69588bcebf Added statx to glibc_compatibility 2022-09-04 20:21:13 +03:00
Ilya Golshtein
74561b40ae stylecheck renewed 2022-09-02 17:42:18 +03:00
Antonio Andelic
e64436fef3 Fix typos with new codespell 2022-09-02 08:54:48 +00:00
BoloniniD
cba94e106f Remove posix_spawn for now, add execvpe impl 2022-09-01 20:36:47 +03:00
Robert Schulze
bfa67ffc8c
Update base/base/itoa.h
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-01 10:31:34 +02:00
Robert Schulze
d43f4e6317
fix: typo 2022-08-31 10:57:27 +00:00
Robert Schulze
cedf75ed5e
Enable clang-tidy for headers
clang-tidy now also checks code in header files. Because the analyzer
finds tons of issues, activate the check only for directory "base/" (see
file ".clang-tidy"). All other directories, in particular "src/" are
left to future work.

While many findings were fixed, some were not (and suppressed instead).
Reasons for this include: a) the file is 1:1 copypaste of a 3rd-party
lib (e.g. pcg_extras.h) and fixing stuff would make upgrades/fixes more
difficult b) a fix would have broken lots of using code
2022-08-31 10:48:15 +00:00
BoloniniD
8e6dcf18df Add posix_spawn for posix_file_actions_ 2022-08-30 20:18:08 +03:00
BoloniniD
cb32fa4512 Add all posix_spawn_file_actions_ functions 2022-08-30 21:03:45 +03:00
Alexander Tokmakov
44c6c85f75
Merge pull request #40756 from ClickHouse/libuv_update
Merging #39398
2022-08-30 14:38:50 +03:00
Suzy Wang
cad4eeb891 Correct __dup3() to dup3() 2022-08-28 18:03:07 -07:00
BoloniniD
14216d1dc0 Move statx to glibc-compatibility 2022-08-28 16:40:10 +03:00