Commit Graph

58741 Commits

Author SHA1 Message Date
Nikolai Kochetov
46df67d1de Fix infinite query duration in case of cyclic aliases. 2024-06-11 09:07:03 +00:00
vdimir
f9b7d18743
Merge pull request #64060 from ZhiguoZh/20240517-low-cardinality-opt
Analyzer: Optimize resolution of in(LowCardinality, ConstantSet)
2024-06-11 08:59:55 +00:00
Nikolai Kochetov
68e4be0302
Merge pull request #64695 from ClickHouse/fix-early-const-folding-analyzer
Fix early constant folding for isNull/isNotNul and analyzer.
2024-06-11 08:35:57 +00:00
Nikolai Kochetov
a6fa799396 Fix other tests. 2024-06-11 08:22:11 +00:00
Kseniia Sumarokova
2c0a1ce918
Merge pull request #64574 from ClickHouse/named-collecitons-in-keeper
Named collections in keeper
2024-06-11 07:53:10 +00:00
Antonio Andelic
c9e5fb663c
Merge pull request #65040 from ClickHouse/update-comment-async-metrics
Improve comment about AsynchronousMetrics
2024-06-11 07:31:12 +00:00
Antonio Andelic
5e907a5fb9 Merge branch 'master' into fix-gwp-asan 2024-06-11 09:12:20 +02:00
Nikolay Degterinsky
83c762146b
Merge pull request #65031 from evillique/fix-modify-comment-parameterized-views
Fix ALTER MODIFY COMMENT in parameterized VIEWs
2024-06-11 06:12:53 +00:00
kevinyhzou
727b75780c Merge branch 'master' into improve_greatest_least_nullable_type 2024-06-11 09:42:57 +08:00
Zhiguo Zhou
76a7989399
Merge branch 'ClickHouse:master' into 20240517-low-cardinality-opt 2024-06-11 09:33:36 +08:00
Sema Checherinda
f52ca21db0
Merge pull request #63857 from ClickHouse/chesema-less-backoff-timeout
S3: reduce retires time for queries, increase retries count for backups
2024-06-11 00:25:46 +00:00
Igor Nikonov
1599f774f8 Merge remote-tracking branch 'origin/master' into pr-plan-rewrite 2024-06-10 20:09:44 +00:00
Nikolai Kochetov
3bcb32c719 Fixing another test. 2024-06-10 17:52:46 +00:00
Anton Popov
e796530b54 Merge remote-tracking branch 'upstream/master' into HEAD 2024-06-10 17:52:39 +00:00
Nikolai Kochetov
20d673a206 Fix more tests. 2024-06-10 17:02:26 +00:00
Robert Schulze
a482b3efea
Merge remote-tracking branch 'rschu1ze/master' into stabilize-row-ordering 2024-06-10 16:53:19 +00:00
Alexander Tokmakov
4f39c36408
Merge pull request #64312 from ClickHouse/all_replica_groups_cluster
Add clusters with replicas from all replica groups
2024-06-10 15:55:35 +00:00
Nikolai Kochetov
a8b1b11ee6 Fixing test. 2024-06-10 15:55:00 +00:00
Nikolai Kochetov
33766797c1 Refactor query plan prewhere optimization for Merge 2024-06-10 15:37:40 +00:00
Arthur Passos
f026cc43cd safe guard around no proxy strings 2024-06-10 11:17:10 -03:00
Raúl Marín
2f42ace740 Merge remote-tracking branch 'blessed/master' into allow_experimental_join_condition 2024-06-10 15:38:10 +02:00
Antonio Andelic
e849b21cba Increase even more 2024-06-10 15:15:44 +02:00
vdimir
4cb53e9513
Revert "Revert "Fix duplicating Delete events in blob_storage_log"" 2024-06-10 14:46:39 +02:00
János Benjamin Antal
69bacef5d4
Merge branch 'master' into adapting-parquet-block-size 2024-06-10 14:43:49 +02:00
Kseniia Sumarokova
9a55cdf77c
Merge pull request #64947 from ilejn/time_virtual_col
Add _time virtual column to file alike storages
2024-06-10 12:14:46 +00:00
Raúl Marín
d9e6d4662c
Merge pull request #64967 from Algunenano/fix_multi_if_short_circuit
Fix bug in short circuit evaluation
2024-06-10 11:58:43 +00:00
Raúl Marín
4926d28709
Merge pull request #64804 from Algunenano/simplify_03023_zeros_generate_random_with_limit_progress_bar
Improve progress report on zeros_mt and generateRandom
2024-06-10 11:57:15 +00:00
Alexander Gololobov
2056ed8ee8 Capture weak_ptr for safety 2024-06-10 13:54:46 +02:00
Alexander Tokmakov
132aa996a3
Revert "Fix duplicating Delete events in blob_storage_log" 2024-06-10 13:49:39 +02:00
kssenii
4c629bcfb3 Review fixes 2024-06-10 13:48:26 +02:00
Nikolai Kochetov
6baae1d1c8 Merge branch 'master' into fix-early-const-folding-analyzer 2024-06-10 11:21:13 +00:00
kssenii
571ddb66df Merge remote-tracking branch 'origin/master' into named-collecitons-in-keeper 2024-06-10 13:17:32 +02:00
Antonio Andelic
c2c5992434 Merge branch 'master' into fix-gwp-asan 2024-06-10 12:50:08 +02:00
Antonio Andelic
af08c2bc13 Increase default sample rate 2024-06-10 12:50:02 +02:00
Antonio Andelic
fdfc547163 Add useful comment 2024-06-10 12:48:32 +02:00
vdimir
a87e8b4214
Merge branch 'master' into 20240517-low-cardinality-opt 2024-06-10 12:01:37 +02:00
vdimir
a8019ee8b9
Merge pull request #64924 from ClickHouse/vdimir/blob_storage_log_minor_fixes
Fix duplicating Delete events in blob_storage_log
2024-06-10 09:52:16 +00:00
Antonio Andelic
25fa5d87f3
Merge pull request #64896 from ClickHouse/fix-global-trace-collector
Fix global trace collector
2024-06-10 09:09:07 +00:00
vdimir
416bb6fd1f
Merge branch 'master' into allow_experimental_join_condition 2024-06-10 11:02:03 +02:00
SmitaRKulkarni
b49322de32
Merge pull request #63160 from ClickHouse/Azure_fix_stateless_tests
Fix flaky stateless test with azure
2024-06-10 08:34:07 +00:00
Robert Schulze
1cd61b804d
Fix build 2024-06-10 07:52:55 +00:00
Robert Schulze
25fd51e5bc
Mark row order optimization non-experimental 2024-06-10 07:51:22 +00:00
Robert Schulze
ccdaf6f5a4
Restrict to MergeTree 2024-06-10 07:50:04 +00:00
Robert Schulze
ee94d68cb9
Less aggressive logging 2024-06-10 07:49:27 +00:00
Antonio Andelic
ee46c82dc2 Merge branch 'master' into fix-gwp-asan 2024-06-10 09:39:13 +02:00
Antonio Andelic
0f6f86314f Better code 2024-06-10 09:37:52 +02:00
Nikolay Degterinsky
982b1e4102 Merge remote-tracking branch 'upstream/master' into fix-modify-comment-parameterized-views 2024-06-10 01:45:36 +00:00
Nikolay Degterinsky
5e679a33e1 Fix 2024-06-10 01:43:27 +00:00
Yarik Briukhovetskyi
7997ce850c
include storageview 2024-06-10 01:12:44 +02:00
Nikolay Degterinsky
dfc4184d7f Fix ALTER MODIFY COMMENT in parameterized VIEWs 2024-06-09 19:44:27 +00:00
Alexey Milovidov
e7caad8d05
Merge pull request #64952 from ClickHouse/strange-num
Fix error message (it was strange)
2024-06-09 06:32:22 +02:00
Alexey Milovidov
873964b882
Merge pull request #63788 from ClickHouse/show-create-system-tables
Use right comments for system tables
2024-06-08 06:34:04 +02:00
Nikita Mikhaylov
33cac00011
Make a setting not important 2024-06-07 19:39:48 +02:00
Alexey Milovidov
c33b39f61e
Merge pull request #64856 from azat/rocksdb-logging
Handle logs from rocksdb by ClickHouse internal logging (and enable debug rocksdb logging on CI)
2024-06-07 19:24:20 +02:00
Sergei Trifonov
686d6d676a
Merge pull request #64969 from ClickHouse/revert-64423-precise-memtracking
Revert "Add dynamic untracked memory limits for more precise memory tracking"
2024-06-07 16:51:36 +00:00
Alexey Milovidov
95e3adf976
Merge pull request #62519 from ClickHouse/linestring
Add support for `LineString` geometry type
2024-06-07 18:38:27 +02:00
Nikita Mikhaylov
756ac16170 Merge branch 'master' of github.com:ClickHouse/ClickHouse into show-create-system-tables 2024-06-07 18:00:33 +02:00
Arthur Passos
48de600770 unify environment proxy set] 2024-06-07 10:47:54 -03:00
Arthur Passos
2b200b5661 modify match everything regex 2024-06-07 10:03:07 -03:00
Raúl Marín
b04fb116a5 Compiler happy. Developer unhappy 2024-06-07 15:01:54 +02:00
alesapin
368d827dc6
Merge pull request #64918 from ClickHouse/disable_transactions
Disable transactions for unsupported storages even for materialized v…
2024-06-07 12:59:58 +00:00
Robert Schulze
5c7f600d74
Merge pull request #64798 from arenadata/ADQM-1892
Support non-const scale arguments in rounding functions
2024-06-07 12:41:36 +00:00
Antonio Andelic
b1d6c73208
Merge pull request #64604 from ClibMouse/parallel_replicas_custom_key_range_min_max_setting
Allow users to specify a custom range for the range filter when using parallel replicas with dynamic shards
2024-06-07 12:26:30 +00:00
Ilya Golshtein
f77b6096c4 time_virtual_col: st_mtime, not st_mtim, because of darwin 2024-06-07 12:14:21 +00:00
Nikolai Kochetov
a96b7781c3
Merge pull request #64855 from ClickHouse/fix-filter-push-down-duplicate-names
Avoid duplicating names for new inputs of ActionsDAG::split result.
2024-06-07 12:10:32 +00:00
Sergei Trifonov
2d9ac2e816
Revert "Add dynamic untracked memory limits for more precise memory tracking" 2024-06-07 14:03:56 +02:00
alesapin
a9da369bb5
Merge pull request #64858 from ClickHouse/fix_segfault_for_super_rare_case
Fix segfault for a very tricky case
2024-06-07 11:26:10 +00:00
Raúl Marín
078f5f4ee0 Fix bug in short circuit evaluation 2024-06-07 13:10:12 +02:00
Nikolai Kochetov
2131877819 Fixing other tests. 2024-06-07 10:44:59 +00:00
Nikolai Kochetov
7f98893da0
Merge pull request #64793 from ClickHouse/remove-aliases-from-filter-cond
Remove aliases from fiter condition.
2024-06-07 10:09:14 +00:00
Antonio Andelic
bd986ce1da Merge branch 'master' into fix-global-trace-collector 2024-06-07 08:22:53 +02:00
Antonio Andelic
ee019596ca Merge branch 'master' into fix-gwp-asan 2024-06-07 08:22:37 +02:00
Mikhail Gorshkov
b98eca1e60 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-1892 2024-06-07 06:03:23 +00:00
LiuNeng
6d20d66081
Merge branch 'master' into adapting-parquet-block-size 2024-06-07 11:00:45 +08:00
Alexey Milovidov
05ea297c0d Fix error message (it was strange) 2024-06-07 03:47:35 +02:00
Alexey Milovidov
2da27f4dee
Merge pull request #64923 from amosbird/fix-64885
Fix tupleConcat of two empty tuples
2024-06-07 01:53:02 +02:00
Ilya Golshtein
258b1f9559 time_virtual_col: tests, doc, small refactoring 2024-06-06 21:00:47 +00:00
Arthur Passos
bd0ef01ffd try to fix ut 2024-06-06 16:45:34 -03:00
Raúl Marín
d36bf5bac8 Compiler complains 2024-06-06 21:40:24 +02:00
Alexey Milovidov
645d3041ce
Merge pull request #64563 from ClickHouse/shrek
Fix writing ORC statistics for unsigned types
2024-06-06 21:14:42 +02:00
Alexey Milovidov
e421c741bf
Merge pull request #64756 from Blargian/utf8_compute_fix
`UTF8::computeWidth` should skip ANSI escape sequences (fix)
2024-06-06 21:13:08 +02:00
Sergei Trifonov
9ec1306016
Merge pull request #64423 from ClickHouse/precise-memtracking
Add dynamic untracked memory limits for more precise memory tracking
2024-06-06 18:37:31 +00:00
Raúl Marín
ae01d9ef9b
Merge pull request #64766 from Algunenano/fix_duplicate_order_by
Fix OrderByLimitByDuplicateEliminationVisitor across subqueries
2024-06-06 18:03:34 +00:00
Nikolay Degterinsky
82e6de5e0a
Merge pull request #64919 from k-morozov/add_logs
additional log for cleanupDetachedTables
2024-06-06 17:53:29 +00:00
Joshua Hildred
21294013f2 Update SettingsChangesHistory 2024-06-06 10:03:52 -07:00
Arthur Passos
e0898b117f Merge branch 'master' into no_proxy_support 2024-06-06 13:47:04 -03:00
kssenii
a2c3c215f5 More user friendly 2024-06-06 18:43:45 +02:00
Nikolai Kochetov
8216e14ac2
Merge pull request #64801 from ClickHouse/fix-arr-join-distr-nested
Fix distributed array join by nested
2024-06-06 16:24:19 +00:00
Anton Popov
0279dc7c39 Merge remote-tracking branch 'upstream/master' into HEAD 2024-06-06 16:08:39 +00:00
vdimir
1881107f07
fix build 2024-06-06 16:04:46 +00:00
Igor Nikonov
20283d3588 Merge remote-tracking branch 'origin/master' into pr-plan-rewrite 2024-06-06 16:04:31 +00:00
Igor Nikonov
ad2d397962 Use supportsReplication() 2024-06-06 16:03:58 +00:00
Raúl Marín
81fe4c4894 Fix number of stream decision 2024-06-06 17:59:16 +02:00
vdimir
38d45a6bc9
Verbose message for errors on inserting to system log 2024-06-06 15:49:14 +00:00
vdimir
4ba025c3ba
Fix duplicating Delete events in blob_storage_log 2024-06-06 15:48:36 +00:00
Azat Khuzhin
833f031721 Handle logs from rocksdb by ClickHouse internal logging
Someone may not know about /path/to/rocksdb/LOG, and besides it requires
an access to data dir, instead of logs dir.

v2: fix use-after-free due to destruction order (https://s3.amazonaws.com/clickhouse-test-reports/64856/8cefc1a1ba5ddfdda033694a14e1f1847d497092/stateless_tests__asan__[2_4]/stderr.log)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-06-06 17:47:39 +02:00
Azat Khuzhin
15317b5b50 Fix possible loss of "Query was cancelled" message in client
Previously "Query was cancelled" had been printed only on new blocks, so
if no new blocks will be arrived, then it will not print this message,
and this is indeed why 03023_zeros_generate_random_with_limit_progress_bar
was flaky [1]:

    2024-06-05 16:21:22 expect: does "\u258e\u001b[0m                    \u001b[2m(0.9 CPU)\u001b[0m 4%\u001b[K^C\r\u001b[1;31m\u2198\u001b[0m Progress: 404.74 thousand rows, 404.74 KB (806.77 thousand rows/s., 806.77 KB/s.) \u001b[0;32m\u2588\u258e\u001b[0m                    \u001b[2m(2.0 CPU)\u001b[0m 4%\u001b[K\r\u001b[KCancelling query.\r\n                                                                                                                        \r\u001b[1;32m\u2193\u001b[0m Progress: 404.74 thousand rows, 404.74 KB (806.15 thousand rows/s., 806.15 KB/s.) \u001b[0;32m\u2588\u258e\u001b[0m                    \u001b[2m(2.0 CPU)\u001b[0m 4%\u001b[K" (spawn_id exp4) match glob pattern "Query was cancelled."? no
    2024-06-05 16:21:22
    2024-06-05 16:21:22 [KOk.
    2024-06-05 16:21:22 , result:

As you can see it printed "Cancelling query" and "Ok" but not
"Query was cancelled" due to this.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/61973/6cfd5b2165970a65a551117fe58e4b9d22237b8c/stateless_tests__tsan__s3_storage__[1_5].html

A bit hackish with all this bool flags, but I guess it is OK.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-06-06 17:47:08 +02:00
Amos Bird
dd9b15daf5
Fix tupleConcat of two empty tuples 2024-06-06 23:43:14 +08:00
alesapin
1c3cfbcb41 Merge remote-tracking branch 'origin/master' into disable_transactions 2024-06-06 17:36:18 +02:00
Alexey Milovidov
afba7bb4ed
Merge pull request #64883 from ClickHouse/fancy-quotes-fix
A tiny fix for fancy quotes
2024-06-06 17:35:00 +02:00