Antonio Andelic
c0ff486ada
Merge branch 'master' into keeper-batch-flushes
2023-08-07 06:20:41 +00:00
Antonio Andelic
5cb856d167
Try batching multiple flush requests in Keeper
2023-08-04 11:53:22 +00:00
Vitaly Baranov
552331fd54
Use the same default paths for clickhouse_keeper (symlink) as for clickhouse_keeper (executable),
...
i.e. "/var/lib/clickhouse-keeper/.."
2023-08-04 13:38:21 +02:00
Anton Popov
92cb5e9ae3
Merge pull request #52687 from alkorgun/fix-named-collections-on-cluster-23.7
...
Fix named collections on cluster 23.7
2023-08-03 14:50:28 +02:00
Antonio Andelic
a6a495a767
Merge branch 'master' into fix-keeper-reductant-lock
2023-07-31 19:53:25 +02:00
Antonio Andelic
a473dc4b51
Wait for response
2023-07-31 09:24:06 +00:00
Илья Коргун
bcc41fbc2f
Fix reference to a local binding declared in an enclosing function
2023-07-27 10:46:35 +03:00
Alexey Milovidov
21382afa2b
Check for punctuation
2023-07-25 06:10:04 +02:00
Antonio Andelic
7b03f3277e
Try fix session on close test
2023-07-24 17:59:50 +02:00
Antonio Andelic
73155cf562
Merge branch 'master' into fix-keeper-reductant-lock
2023-07-24 10:17:35 +02:00
Antonio Andelic
10c2d5dade
Merge branch 'master' into feature/keeper-dyn-reconf
2023-07-21 13:24:18 +02:00
Antonio Andelic
4a47040763
Merge pull request #52358 from ClickHouse/fix-keeper-apply-snapshot
...
Fix `apply_snapshot` in Keeper
2023-07-21 12:52:12 +02:00
Antonio Andelic
f997adfe27
Retry if sessions not closed because missing leader
2023-07-20 14:02:55 +00:00
Antonio Andelic
a24bf14450
Use correct ZXID
2023-07-20 10:44:44 +00:00
Antonio Andelic
0c86df519f
Fix unspported disks in Keeper
2023-07-19 12:41:25 +00:00
Antonio Andelic
61dc020b4d
Merge branch 'master' into feature/keeper-dyn-reconf
2023-07-17 12:50:17 +02:00
Antonio Andelic
9677cc5e2b
Apply suggestions from code review
2023-07-17 12:50:02 +02:00
frinkr
e1abdd0419
atomic exchange simplified
2023-07-17 10:51:24 +08:00
frinkr
6dceedd721
Merge branch 'ClickHouse:master' into fix-keeper-reductant-lock
2023-07-17 10:21:05 +08:00
Azat Khuzhin
6abdde12ca
Print Zxid in keeper stat command in hex (so as ZooKeeper)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-14 21:17:09 +02:00
Alexey Milovidov
b1d1918607
Merge branch 'master' into retry
2023-07-08 03:08:48 +03:00
Alexey Milovidov
685f2949b7
Revert "Fix build"
2023-07-07 02:53:13 +03:00
Alexey Milovidov
c47b32b17a
Fix build
2023-07-07 01:52:18 +02:00
Alexey Milovidov
48eb30de51
Fix build
2023-07-07 01:42:29 +02:00
Mike Kot
5302b478a4
proper reconfig batch handling
2023-07-07 00:20:54 +03:00
Mike Kot
bafcc3afdc
remove reconfig in process flag as it's useless
2023-07-07 00:20:54 +03:00
Mike Kot
c46b125d0a
review fixes
2023-07-07 00:20:54 +03:00
Mike Kot
2f0cd05497
handle leader removal corner cases
2023-07-07 00:20:54 +03:00
Mike Kot
1bef6fc76c
process reconfig in keeper dispatcher
2023-07-07 00:20:54 +03:00
Mike Kot
297d566600
acl check
2023-07-07 00:20:54 +03:00
Mike Kot
b4f750ed66
review fixes
2023-07-07 00:20:54 +03:00
Mike Kot
8b6376005a
"reconfig" support for CH Keeper
2023-07-07 00:20:54 +03:00
frinkr
36fbc22b16
Merge branch 'master' into fix-keeper-reductant-lock
2023-07-04 18:04:08 +08:00
Jiang Yuqing
f443a00d14
KeeperDispatcher: remove reductant lock as the ConcurrentBoundedQueue is thread-safe
2023-07-04 17:58:04 +08:00
Antonio Andelic
2058b1346e
Merge branch 'master' into keeper-with-disks
2023-06-30 13:22:33 +00:00
Antonio Andelic
eff1cc0e5d
Remove unused errorcode
2023-06-28 10:20:33 +02:00
Antonio Andelic
be852d554b
Use magic_enum for values
2023-06-28 07:45:20 +00:00
Antonio Andelic
efbe01b6bb
Merge branch 'master' into keeper-add-api-version-config
2023-06-27 10:11:04 +00:00
Alexey Milovidov
7407330130
Merge branch 'master' into retry
2023-06-23 08:18:18 +03:00
Michael Kolupaev
4a570a05c9
Decrease default timeouts for S3 and HTTP requests
2023-06-21 18:08:50 +00:00
Sema Checherinda
1cb02e2710
do call finalize for all buffers
2023-06-16 16:38:18 +02:00
Antonio Andelic
4ac090b122
Fix tests
2023-06-13 11:01:44 +00:00
Antonio Andelic
6f1c486537
Fix build
2023-06-13 10:25:53 +02:00
Antonio Andelic
25f08f8d19
Remove duplicate include
2023-06-12 15:35:44 +02:00
Antonio Andelic
cb3ac81110
Merge branch 'master' into keeper-with-disks
2023-06-12 15:14:24 +02:00
Antonio Andelic
a7e6264d56
Add backward compatibility
2023-06-12 13:12:05 +00:00
Antonio Andelic
b634012feb
Add feature flags for Keeper API
2023-06-12 10:57:03 +00:00
Antonio Andelic
91a4b6e331
Merge branch 'master' into keeper-add-api-version-config
2023-06-12 07:10:58 +00:00
Antonio Andelic
b8b70d78e1
Build fix
2023-06-09 13:34:27 +00:00
Antonio Andelic
07582d56f3
Add config for pinning api version
2023-06-09 13:18:13 +00:00
Antonio Andelic
ab8365630b
Reject logs containing unknown operation
2023-06-09 10:10:40 +00:00
Antonio Andelic
f4d182ed67
Merge branch 'master' into keeper-operation-create-if-not-exists
2023-06-06 09:19:35 +02:00
Antonio Andelic
ece96f54e9
Fix tests
2023-06-05 09:47:58 +00:00
Antonio Andelic
c4873027c3
Merge branch 'master' into keeper-with-disks
2023-06-05 07:08:33 +00:00
Alexey Milovidov
bed19aa792
Merge pull request #50483 from ClickHouse/fix-keeper-snapshot-install
...
Keeper fix: apply uncommitted state after snapshot install
2023-06-05 04:39:33 +03:00
Antonio Andelic
47966c4e81
Finalize bufferg
2023-06-02 14:10:52 +00:00
Antonio Andelic
336c9d7136
Apply uncommitted state after snapshot deser
2023-06-02 13:31:14 +00:00
Antonio Andelic
ffd4f7f196
Add better support for state disks
2023-06-01 14:39:01 +00:00
Antonio Andelic
e8442b7a88
Add finalize calls
2023-06-01 12:54:00 +00:00
frinkr
c9d0d217f5
fix Keeper deadlock on exception when preprocessing requests
2023-06-01 09:57:42 +08:00
Konstantin Bogdanov
b61ffe3ff7
Merge checks
2023-06-01 03:22:40 +02:00
Konstantin Bogdanov
3a3539b996
Style fix
2023-06-01 03:22:40 +02:00
Konstantin Bogdanov
203276dfcc
Use storage.uncommited_state
2023-06-01 03:22:39 +02:00
Konstantin Bogdanov
965f7850f8
Cleanup
2023-06-01 03:22:39 +02:00
Konstantin Bogdanov
f84fdb7f10
Increment Keeper API version
2023-06-01 03:22:39 +02:00
Konstantin Bogdanov
b53f36369e
Remove new request object
2023-06-01 03:22:39 +02:00
Konstantin Bogdanov
0d6561ee77
Prototype
2023-06-01 03:22:23 +02:00
Antonio Andelic
21aba94909
Add support for latest snapshot disk
2023-05-30 13:22:40 +00:00
Antonio Andelic
67746bfff2
Merge branch 'master' into keeper-with-disks
2023-05-30 09:50:12 +00:00
Raúl Marín
1ae1f1273a
Avoid clang 15 crash
2023-05-29 11:40:45 +02:00
Antonio Andelic
0740bfbe4b
Better disks moving
2023-05-26 14:31:09 +00:00
Antonio Andelic
a9569478e6
fix typo
2023-05-26 13:09:09 +02:00
Antonio Andelic
8a2a63a7bd
Merge branch 'master' into keeper-with-disks
2023-05-26 10:48:41 +00:00
Antonio Andelic
3d98e591ba
Handle backwards compatibility
2023-05-26 10:46:18 +00:00
Antonio Andelic
767193caf5
Merge branch 'master' into keeper-log-improvements
2023-05-26 07:35:36 +00:00
Antonio Andelic
6a8a21e09a
Add test for s3 disk restore
2023-05-25 16:01:40 +00:00
Antonio Andelic
bb77441acb
Add support for old storage disks
2023-05-25 13:31:11 +00:00
Antonio Andelic
f519aa4613
Calculate size
2023-05-25 11:23:03 +00:00
Antonio Andelic
4483602c50
Remove double initialization
2023-05-25 08:52:14 +00:00
Antonio Andelic
7e68f61df1
Fix snapshot recovery
2023-05-25 08:43:11 +00:00
Antonio Andelic
092cf99147
Fix build
2023-05-24 13:45:14 +00:00
Antonio Andelic
fa3fb49d33
Merge branch 'master' into keeper-with-disks
2023-05-24 09:04:47 +00:00
Antonio Andelic
5db2160762
Fix build
2023-05-24 09:04:12 +00:00
Antonio Andelic
161afea266
Add support for changelog
2023-05-24 07:43:57 +00:00
kssenii
295fe3b228
Merge remote-tracking branch 'upstream/master' into abstract-async-prefetched-buffer
2023-05-22 20:01:38 +02:00
kssenii
c4d862a16f
Make async reader work with any impl
2023-05-22 19:54:04 +02:00
Antonio Andelic
bde2cf96b1
Better
2023-05-22 12:24:16 +00:00
alesapin
cc3897a84a
Merge pull request #50033 from kssenii/disk-object-storage-minor-changes
...
Get rid of indirect write buffer in object storages
2023-05-22 14:08:17 +02:00
Antonio Andelic
dc31396035
Merge branch 'master' into keeper-with-disks
2023-05-22 08:10:24 +00:00
kssenii
3e42ee7f2b
Get rid of finalize callback in object storages
2023-05-19 17:29:37 +02:00
Antonio Andelic
9c3b17fa18
Remove whitespace
2023-05-19 13:00:51 +02:00
Antonio Andelic
e46476dba2
Update src/Coordination/Changelog.cpp
...
Co-authored-by: alesapin <alesapin@clickhouse.com>
2023-05-19 12:44:20 +02:00
Antonio Andelic
6e468b29e8
Check return value of ftruncate
2023-05-19 10:15:06 +00:00
Antonio Andelic
bf6afd27a6
build with disks
2023-05-18 07:39:22 +00:00
Antonio Andelic
465123fa1b
Merge branch 'master' into keeper-with-disks
2023-05-16 08:07:06 +00:00
Azat Khuzhin
665545ec45
Fix "reference to local binding" after fixes for clang-17
...
Follow-up for: #49851 (cc @alexey-milovidov)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-15 12:45:20 +02:00
Alexey Milovidov
5a44dc26e7
Fixes for clang-17
2023-05-13 02:57:31 +02:00
Antonio Andelic
bb8b9dc9c3
Merge branch 'master' into keeper-log-improvements
2023-05-05 11:57:14 +00:00
alesapin
9456eb59fd
Merge pull request #48466 from ClickHouse/keeper-correctly-handle-snapshots
...
Correctly handle concurrent snapshots in Keeper
2023-05-04 19:16:00 +02:00
johanngan
731823b873
Add support for SSE-KMS configuration with S3
...
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html
Similar to the server_side_encryption_customer_key_base64 option for
configuring SSE-C with S3, add the following settings to configure
SSE-KMS on a per-endpoint/disk basis:
- server_side_encryption_kms_key_id
- server_side_encryption_kms_encryption_context
- server_side_encryption_kms_bucket_key_enabled
2023-05-03 21:35:38 -05:00
Antonio Andelic
b8b7a362b2
Merge branch 'master' into keeper-correctly-handle-snapshots
2023-05-03 13:51:09 +02:00
Antonio Andelic
78ecfac8d5
Merge branch 'master' into keeper-log-improvements
2023-05-03 08:31:21 +00:00
Antonio Andelic
dce61d7321
Merge branch 'master' into keeper-log-improvements
2023-05-02 11:14:48 +00:00
Antonio Andelic
f695040a19
Merge pull request #48897 from ClickHouse/keeper-check-not-exists
...
Add `CheckNotExists` request to Keeper
2023-05-02 13:14:22 +02:00
Raúl Marín
f0e045bb3d
Merge remote-tracking branch 'blessed/master' into arenita
2023-04-24 10:42:56 +02:00
Alexey Milovidov
530b764953
Fix IBM
2023-04-21 12:38:45 +02:00
Antonio Andelic
d500a5637d
Cache large requests
2023-04-21 09:43:04 +00:00
Antonio Andelic
b52646c555
Eliminate double log serializing
2023-04-21 08:20:35 +00:00
Antonio Andelic
58e9b56fcb
Fix CheckNotExists
2023-04-19 09:06:20 +00:00
Antonio Andelic
fb16623d48
Add CheckNotExists request to Keeper
2023-04-18 14:45:24 +00:00
Raúl Marín
2b70e08f23
Don't count unreserved bytes in Arenas as read_bytes
2023-04-13 12:43:24 +02:00
Antonio Andelic
b30aff06d8
Merge pull request #48595 from aalexfvk/alexfvk/fix_create_not_auth_problem
...
Fix bug in Keeper when a node is not created with scheme `auth` in ACL sometimes.
2023-04-11 14:41:37 +02:00
Aleksei Filatov
dd2364361c
Update src/Coordination/tests/gtest_coordination.cpp
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2023-04-11 10:45:30 +03:00
Azat Khuzhin
79b83c4fd2
Remove superfluous includes of logger_userful.h from headers
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 17:59:30 +02:00
Aleksei Filatov
e8bf96d126
Add unit tests
2023-04-10 13:02:43 +03:00
Aleksei Filatov
000c2b5b91
Correct FixupACL for auth scheme
2023-04-10 13:02:31 +03:00
Azat Khuzhin
011480924a
Use forward declaration of ThreadPool
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 11:25:35 +02:00
Antonio Andelic
88f77c686d
Correctly handle concurrent snapshots
2023-04-06 15:40:05 +00:00
Antonio Andelic
e982f2a67a
Merge branch 'master' into enable-env-credentials-default
2023-03-31 09:11:01 +00:00
Antonio Andelic
44e95aa65f
Merge branch 'master' into nosign-keyword-for-s3
2023-03-29 11:10:03 +00:00
Antonio Andelic
160aa186bb
Add support for NOSIGN keyword and no_sign_request config
2023-03-28 07:05:35 +00:00
Antonio Andelic
79e22d13fb
small fix
2023-03-27 07:41:31 +00:00
Antonio Andelic
f355bc5342
Merge branch 'master' into more-batching-keeper
2023-03-27 07:28:17 +00:00
Antonio Andelic
6c3765c8b6
Small fix
2023-03-24 20:40:45 +00:00
Antonio Andelic
f353561204
Avoid breaking batches with read requests
2023-03-24 14:37:40 +00:00
Alexander Gololobov
afe3af230f
Limit keeper request batching by size in bytes
2023-03-24 14:41:09 +01:00
Antonio Andelic
51416da818
Merge branch 'master' into enable-env-credentials-default
2023-03-13 10:20:21 +00:00
Antonio Andelic
a170a909a4
Add expiration window for S3 credentials
2023-03-10 10:06:32 +00:00
Antonio Andelic
83a3243758
Merge pull request #47065 from ClickHouse/debug-keeper
...
Fix Keeper with `force_sync = false`
2023-03-10 09:27:13 +01:00
Antonio Andelic
5bc21538e5
Enable use_environment_credentials by default
2023-03-09 10:31:55 +00:00
Antonio Andelic
0ad436aa2c
Revert debug changes
2023-03-09 08:07:59 +00:00
Antonio Andelic
b4061d8aa4
Add logs
2023-03-08 13:06:10 +00:00
Mike Kot
9920a52c51
use std::lerp, constexpr hex.h
2023-03-07 22:50:17 +00:00
Antonio Andelic
dd4db9132a
Merge branch 'master' into debug-keeper
2023-03-07 13:15:05 +01:00
Antonio Andelic
c38d820d0f
Add 4LW for cleaning resource
2023-03-05 16:57:18 +00:00
Antonio Andelic
cd4100cb19
Merge branch 'master' into fix-data-size
2023-03-03 15:33:43 +01:00
Antonio Andelic
fdcb5b784f
Merge branch 'master' into debug-keeper
2023-03-03 13:45:13 +01:00
Robert Schulze
740aeaba1f
Apply some CTAD
2023-03-02 13:36:47 +00:00
Antonio Andelic
6ebee202bd
Flush buffer when no sync
2023-03-01 14:47:15 +00:00
Antonio Andelic
c797122dbe
Better
2023-03-01 08:45:50 +00:00
Antonio Andelic
6e28406751
Merge branch 'master' into fix-data-size
2023-02-28 20:09:29 +00:00
Alexey Milovidov
d8cda3dbb8
Remove PVS-Studio
2023-02-19 23:30:05 +01:00
Alexander Tokmakov
e96340e183
Merge pull request #46410 from ClickHouse/fix_noisy_log_messages
...
Fix noisy log messages
2023-02-15 01:22:42 +03:00
Alexander Tokmakov
1bf3735ca9
fix noisy log messages
2023-02-14 15:33:27 +01:00
Sema Checherinda
9bef1bec28
Merge pull request #46274 from aiven-sal/aiven-sal/keeper
...
coordination: do not allow election_timeout_lower_bound_ms > election_timeout_upper_bound_ms
2023-02-14 12:44:04 +01:00
Sema Checherinda
5882f3878f
except zero values election_timeout
2023-02-13 12:22:08 +01:00
Salvatore Mesoraca
fff2c09b87
coordination: do not allow election_timeout_lower_bound_ms > election_timeout_upper_bound_ms
2023-02-13 10:09:45 +01:00
Antonio Andelic
f96d480563
Merge branch 'master' into add-support-for-settings-alias
2023-02-09 16:07:45 +01:00
Azat Khuzhin
8cc41b7f41
Check return value of ::close()
...
Note, that according close(2), EINTR should not be retriable for close()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Antonio Andelic
b11458f142
Fix erase
2023-02-07 07:51:22 +00:00