Commit Graph

82357 Commits

Author SHA1 Message Date
Nikolai Kochetov
9b2998c639 Review fixes. 2022-01-26 18:08:01 +00:00
Nikolai Kochetov
a8171269a1 Review fixes. 2022-01-26 17:55:24 +00:00
Raúl Marín
5a59d976dd CurrentlyExecuting: Require mutex usage explicitly 2022-01-26 18:44:35 +01:00
zvonand
1384f9e89d moved common code out of template 2022-01-26 20:15:34 +03:00
HarryLeeIBM
d656da1506 Issue 7334: also remove one unnecessary test 2022-01-26 10:43:45 -05:00
Mikhail f. Shiryaev
662444fe13
Merge pull request #33963 from pkit/fix_chown_squash
docker: fix root squashed data dirs
2022-01-26 16:13:38 +01:00
alesapin
289a51b61d
Merge pull request #33905 from zhongyuankai/fix_same_disk_path
Fix disk using the same path
2022-01-26 17:38:08 +03:00
Mikhail f. Shiryaev
22eddff0d5
Add a comment about broken logic for skipping checks 2022-01-26 15:30:59 +01:00
Mikhail f. Shiryaev
462e95d0fa
Replace labels_from_ip by pr_event_from_api 2022-01-26 15:03:30 +01:00
Kruglov Pavel
057001714f
Update 02182_format_and_schema_from_stdin.sh 2022-01-26 16:53:51 +03:00
mergify[bot]
f978ca276d
Merge branch 'master' into fix-orc 2022-01-26 13:12:34 +00:00
Mikhail f. Shiryaev
6fa6588cb5
Add info about body for a failed check 2022-01-26 14:03:01 +01:00
Constantine Peresypkin
f5787ff0a9 docker: fix root squashed data dirs
if we use some root squashed volume mappings in docker
uid=0 is actually uid=nobody
thus FS operations with uid=0 will fail miserably
and overall it's a strange idea to create dirs under root when
DO_NOT_CHOWN is in effect...
2022-01-26 14:29:27 +02:00
Kruglov Pavel
662ea9d024
Merge pull request #33927 from kitaisreal/range-hashed-dictionary-refactoring
RangeHashedDictionary refactoring
2022-01-26 15:26:57 +03:00
Mikhail f. Shiryaev
99e0ce1ab8
Add get_with_retries helper to build_download_helper.py 2022-01-26 13:20:08 +01:00
Nikolai Kochetov
efaed154d2
Update src/Disks/IDisk.h
Co-authored-by: alesapin <alesapin@clickhouse.com>
2022-01-26 14:58:38 +03:00
Mikhail f. Shiryaev
7cde981531
Apply black formatter to build_download_helper.py 2022-01-26 12:10:20 +01:00
Mikhail f. Shiryaev
1ecee3aa8e
Apply black formatter to pr_info 2022-01-26 12:09:35 +01:00
alexey-milovidov
0a112bcf61
Update StringSearcher.h 2022-01-26 13:45:26 +03:00
Azat Khuzhin
08f4f45fd9 Fix Context leak (recursive context reference) in StorageSQLite
CI founds after LSan had been fixed [1]:

    01889_sqlite_read_write:                                                [ FAIL ] 8.32 sec. - return code: 1

    =================================================================
    ==20649==ERROR: LeakSanitizer: detected memory leaks

    Indirect leak of 1968 byte(s) in 1 object(s) allocated from:
        0 0xc5c1ffd in operator new(unsigned long) (/usr/bin/clickhouse+0xc5c1ffd)
        1 0x25e32d0d in std::__1::__unique_if<DB::StorageInMemoryMetadata>::__unique_single std::__1::make_unique<DB::StorageInMemoryMetadata, DB::StorageInMemoryMetadata const&>(DB::StorageInMemoryMetadata c>
        2 0x25e32d0d in DB::IStorage::setInMemoryMetadata(DB::StorageInMemoryMetadata const&) obj-x86_64-linux-gnu/../src/Storages/IStorage.h:194:22
        3 0x29bdee98 in DB::StorageSQLite::StorageSQLite(DB::StorageID const&, std::__1::shared_ptr<sqlite3>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std:>
        4 0x25ee61d6 in std::__1::shared_ptr<DB::StorageSQLite> shared_ptr_helper<DB::StorageSQLite>::create<DB::StorageID, std::__1::shared_ptr<sqlite3> const&, std::__1::basic_string<char, std::__1::char_tr>
        5 0x25ee61d6 in DB::TableFunctionSQLite::executeImpl(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1:>

    SUMMARY: AddressSanitizer: 171256 byte(s) leaked in 130 allocation(s).

  [1]: https://github.com/ClickHouse/ClickHouse/runs/4929706698?check_suite_focus=true

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-26 12:56:27 +03:00
Azat Khuzhin
0fe1f070fa Fix getauxval() in glibc-compatibility
getauxval() from glibc-compatibility did not work always correctly:

- it does not work after setenv(), and this breaks vsyscalls,
  like sched_getcpu() [1] (and BaseDaemon.cpp always set TZ if timezone
  is defined, which is true for CI [2]).

  [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1163404
  [2]: https://github.com/ClickHouse/ClickHouse/pull/32928#issuecomment-1015762717

- another think that is definitely broken is LSan (Leak Sanitizer), it
  relies on worked getauxval() but it does not work if __environ is not
  initialized yet (there is even a commit about this).

  And because of, at least, one leak had been introduced [3]:

    [3]: https://github.com/ClickHouse/ClickHouse/pull/33840

Fix this by using /proc/self/auxv.

And let's see how many issues will LSan find...

I've verified this patch manually by printing AT_BASE and compared it
with output of LD_SHOW_AUXV.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-26 12:56:27 +03:00
zhangxiao871
1bd74dda63 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2022-01-26 17:40:32 +08:00
zhangxiao871
20b669f330 Supports all types of SYSTEM query ON CLUSTER clause. 2022-01-26 17:40:00 +08:00
zvonand
3879137994 Merge branch 'master' of github.com:ClickHouse/ClickHouse into issue_14648 2022-01-26 12:33:21 +03:00
mergify[bot]
1c0af06011
Merge branch 'master' into PF202201261620 2022-01-26 08:32:38 +00:00
cnmade
532c3b98ef Translate zh/faq/general/mapreduce: translate adjust 2022-01-26 16:30:30 +08:00
tavplubix
9e91a9dfd1
Merge pull request #33429 from zzsmdfj/MaterializeMySQL_support_set_and_other_dataType
MaterializeMySQL support SET YEAR TIME GEOMETRY dataType
2022-01-26 11:29:46 +03:00
cnmade
f8b3f76104 Translate zh/faq/general/mapreduce: remove bak file 2022-01-26 16:27:42 +08:00
cnmade
bb1760537b Translate zh/faq/general/mapreduce: translate to zh 2022-01-26 16:27:14 +08:00
cnmade
57658a1654 Translate zh/faq/general/mapreduce: reimport file 2022-01-26 16:22:03 +08:00
cnmade
fa894f4041 Translate zh/faq/general/mapreduce: remove bak 2022-01-26 16:21:06 +08:00
mergify[bot]
d6c9c61cff
Merge branch 'master' into PF202201261010 2022-01-26 08:11:15 +00:00
alesapin
677a7f1133
Merge pull request #33990 from ClickHouse/cancel-lambda
Cancel lambda
2022-01-26 10:51:21 +03:00
cnmade
56939cedfb Translate zh/faq/general/index: remove bak 2022-01-26 10:16:24 +08:00
cnmade
2136a33733 Translate zh/faq/general/index: translate to zh 2022-01-26 10:15:59 +08:00
cnmade
c689dec7ad Translate zh/faq/general/index: reimport file 2022-01-26 10:05:21 +08:00
cnmade
dc52dc2f45 Translate zh/faq/general/index: rename old to bak 2022-01-26 10:03:23 +08:00
Anton Popov
9a34f195bd add comments 2022-01-26 02:24:22 +03:00
Maksim Kita
43604a2e8f Fixed tests 2022-01-25 21:56:29 +00:00
Maksim Kita
bf768a94e8
Merge pull request #33971 from Avogar/fix-ipv6
Fix parsing IPv6 from query parameter and fix IPv6 to string conversion
2022-01-25 22:45:11 +01:00
mergify[bot]
8b9940f295
Merge branch 'master' into patch-6 2022-01-25 21:43:43 +00:00
Maksim Kita
2c7a5e4d4e
Merge pull request #33967 from cnmade/PF202201250933
Translate to zh: use-case/time-serial: remove bak file
2022-01-25 22:24:23 +01:00
alesapin
0105f7e0bc
Merge pull request #33988 from ClickHouse/keeper_and_access
Fix clickhouse server start when replicated access storage depend on keeper
2022-01-25 22:54:43 +03:00
alexey-milovidov
0d6032f0fe
Merge pull request #33962 from ClickHouse/cpp-expr-script
add c++expr script for C++ one-liners
2022-01-25 22:50:18 +03:00
mergify[bot]
00d728a9d2
Merge branch 'master' into PF202201250933 2022-01-25 18:56:50 +00:00
HarryLeeIBM
8b24688afb Issue 7334: Fixed utf8 string case-insensitive searching issue 2022-01-25 13:56:05 -05:00
Nikolai Kochetov
2e88319b72 Fix integration tests. 2022-01-25 18:48:28 +00:00
Mikhail f. Shiryaev
62ddfbe4ab
Use workflow names instead of ID 2022-01-25 18:32:13 +01:00
Mikhail f. Shiryaev
604af8d3b8
Apply black to cancel lambda 2022-01-25 18:28:17 +01:00
Maksim Kita
0cc8b9462b
Merge pull request #33977 from vitlibar/fix-checking-access-for-system-command
Fix checking access for the SYSTEM command.
2022-01-25 17:07:36 +01:00