Azat Khuzhin
326d51c3fb
Prohibit send_metadata for s3_plain disks
...
send_metadata changes the filenames (includes revision), while
s3_plain do not care about this, and expect that the file name
will not be changed.
So during initialization s3_plain will do some basic checks and will
write file clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515, but instead
r0000000000000000000000000000000000000000000000000000000000000001-file-clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515
will be written, later read will not find the file and it will fail:
Application: Code: 33. DB::Exception: Cannot read all data. Bytes read: 0. Bytes expected: 4.: While checking access for disk s3_plain: Cannot attach table `system`.`crash_log` ...
And besides, send_metadata does not make sense for s3_plain.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-11 18:34:23 +02:00
Dmitry Kardymon
2eccead2d4
Fix const(Nullable) case, add test
2023-07-11 16:27:28 +00:00
Zhiguo Zhou
b0fb96c8b6
Inline SipHash::get128(char *)
...
The SipHash-128 values of the strings are calculated and stored in
a set when the UniqExact aggregate function is applied to a Column-
String, as the following snippet shows:
StringRef value = column.getDataAt(row_num);
UInt128 key;
SipHash hash;
hash.update(value.data, value.size);
hash.get128(key);
The implementation of SipHash requires an internal 8-byte buffer,
current_word (or current_bytes), for holding the input data in the
cross function calls of SipHash::update and SipHash::get128. But,
in the above situation, where the update and get128 only take place
once, the copy of input data to the buffer is unnecessary.
With get128 inlined, the compiler could optimize the code as a whole
and reduce the unexpected memory operations, and as a result, the
query performance is improved.
2023-07-11 23:17:55 +08:00
Mike Kot
d0f81fb1cd
fix
2023-07-11 13:33:07 +00:00
Amos Bird
a33b90c648
Projection & optimize_group_by_function_keys
2023-07-11 21:11:28 +08:00
Amos Bird
1739bb306a
Projection & optimize_aggregators_of_group_by_keys
...
Fix projection with optimize_aggregators_of_group_by_keys = true
2023-07-11 21:11:27 +08:00
Yarik Briukhovetskyi
9afafa9554
Merge branch 'master' into add-index-bytes-to-system-parts
2023-07-11 14:51:46 +02:00
Mike Kot
da3de04470
fix
2023-07-11 12:27:23 +00:00
Alexey Gerasimchuck
49c1beb870
Used timeout function instead of undefined clickhouse_client_loop_timeout in functional tests ( #51923 )
...
* removed undefined clickhouse_client_loop_timeout
* test fix and improvement
* Changes after review iteration
2023-07-11 15:25:30 +03:00
Mike Kot
3e8906e5a2
fix build for non-ssl systems
2023-07-11 12:23:10 +00:00
Mike Kot
471e5a056d
fix
2023-07-11 10:40:55 +00:00
Alexander Gololobov
9757e272b9
Check number of rows in the reader instead
2023-07-11 12:24:16 +02:00
Alexander Gololobov
6d712f595a
Make sure that remote query has non-zero columns
2023-07-11 12:24:16 +02:00
Mike Kot
23e3c57a6a
reload certificates for Keeper
2023-07-11 10:13:30 +00:00
Mike Kot
062b1c464c
watch for certificate file updates in configreloader
2023-07-11 10:04:43 +00:00
Ilya Yatsishin
627e924a1b
Merge pull request #51696 from CheSema/write-to-finalized
...
fix write to finalized buffer
2023-07-11 11:48:49 +02:00
Nikolai Kochetov
ab6356f9bc
Merge branch 'master' into vdimir/fix_race_in_remove_objects
2023-07-11 11:22:04 +02:00
xiao
bc16531876
Update CompletedPipelineExecutor.cpp
2023-07-11 17:01:56 +08:00
Dmitry Novik
ee2392bf8e
Merge remote-tracking branch 'origin/master' into analyzer-integration-tests
2023-07-11 08:55:31 +00:00
Han Fei
2ab41ed665
Merge pull request #51291 from arenadata/ADQM-868
...
Millisecond and microsecond support in date_diff / age functions
2023-07-11 10:48:57 +02:00
Robert Schulze
521c993eff
Merge branch 'master' into jaccard_similarity
2023-07-11 10:36:18 +02:00
Dmitry Kardymon
7a308206a9
Merge remote-tracking branch 'origin/master' into Support-range-nullable
2023-07-11 08:28:47 +00:00
Dmitry Kardymon
362473bb4a
Merge remote-tracking branch 'origin/master' into ADQM-974
2023-07-11 08:28:18 +00:00
Dmitry Kardymon
6d7e98590e
Merge remote-tracking branch 'origin/master' into ADQM-976
2023-07-11 08:27:36 +00:00
Dmitry Kardymon
44550d8cdd
Merge remote-tracking branch 'origin/master' into ADQM-868
2023-07-11 08:27:01 +00:00
Dmitry Kardymon
2edb529a93
Merge remote-tracking branch 'origin/master' into Fix-formatDateTime-with-fractional-negative-datetime64
2023-07-11 08:26:07 +00:00
Kruglov Pavel
2492f1bb78
Merge pull request #51273 from arenadata/ADQM-870
...
Added input_format_csv_allow_variable_number_of_columns options
2023-07-11 10:00:40 +02:00
Alexey Gerasimchuck
800807c8a2
Merge branch 'master' into ADQM-970
2023-07-11 16:02:31 +10:00
Alexey Gerasimchuck
8f882b270e
Merge branch 'master' into ADQM-956
2023-07-11 16:02:14 +10:00
vdimir
bd5f393515
Always remove blobs in MetadataStorageFromPlainObjectStorageTransaction::unlinkMetadata
2023-07-11 05:14:39 +00:00
Victor Krasnov
e592c7c353
Fix integration tests - recover clickhouse_stay_alive_command lost by incomplete copy-paste
2023-07-11 10:32:33 +08:00
DanRoscigno
bea58a2780
Docs: added two methods for user profile
2023-07-10 17:21:37 -04:00
ltrk2
9a74b97184
Improve naming
2023-07-10 13:51:49 -04:00
Alexey Milovidov
ba267f05c9
Update DataTypeInterval.cpp
2023-07-10 13:51:49 -04:00
Alexey Milovidov
8b3848affe
Update DataTypeInterval.cpp
2023-07-10 13:51:49 -04:00
Alexey Milovidov
c2514279e4
Update settings.md
2023-07-10 13:51:49 -04:00
ltrk2
54c7e6504f
Fix style issues
2023-07-10 13:51:49 -04:00
ltrk2
2d2debe3ce
Introduce a separate setting for interval output formatting
2023-07-10 13:51:49 -04:00
ltrk2
b673aa8e6b
Use the dialect configuration
2023-07-10 13:51:49 -04:00
ltrk2
b5cef61ef3
Refactor solution to improve extensibility
2023-07-10 13:51:49 -04:00
ltrk2
748c7fe04e
Refactor functional tests using Jinja2
2023-07-10 13:51:49 -04:00
ltrk2
522b9ebf8c
Implement KQL-style formatting for Interval
2023-07-10 13:51:49 -04:00
Dmitry Kardymon
cfe846c2ec
Merge remote-tracking branch 'origin/master' into Support-range-nullable
2023-07-10 13:29:21 +00:00
Dmitry Kardymon
f12ccd76ef
Merge remote-tracking branch 'origin/master' into ADQM-974
2023-07-10 13:28:45 +00:00
Dmitry Kardymon
0cd4b753d6
Merge remote-tracking branch 'origin/master' into ADQM-976
2023-07-10 13:27:45 +00:00
Dmitry Kardymon
3237169c9a
Merge remote-tracking branch 'origin/master' into ADQM-868
2023-07-10 13:24:17 +00:00
Dmitry Kardymon
973c96c7ab
Merge remote-tracking branch 'origin/master' into Fix-formatDateTime-with-fractional-negative-datetime64
2023-07-10 13:22:26 +00:00
Dmitry Kardymon
385a210fee
Merge remote-tracking branch 'origin/master' into ADQM-870
2023-07-10 13:19:21 +00:00
Sema Checherinda
9aef39a788
Merge pull request #51320 from CheSema/less-logs-2
...
decrease log level, make logs shorter
2023-07-10 11:07:39 +02:00
lgbo
344bc05156
wip: reserve hash table size ( #50875 )
2023-07-10 10:44:01 +02:00
