Commit Graph

12487 Commits

Author SHA1 Message Date
Alexey Milovidov
28e03f5781 Merge branch 'master' into fix-ibm 2023-04-23 06:01:41 +02:00
凌涛
08e81d0a52
Merge branch 'master' into feature/support_settings_allow_suspicious_indices 2023-04-23 10:08:00 +08:00
Nikita Taranov
d99c227b0d impl 2023-04-22 21:13:23 +00:00
kssenii
6054fc4c99 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-22 17:17:19 +02:00
kssenii
1fbaaf0445 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-22 17:14:50 +02:00
kssenii
e0eb88f9bc Fix clang-tidy 2023-04-22 17:02:17 +02:00
kssenii
475a893be3 Fix, add assertions 2023-04-21 21:52:17 +02:00
Kseniia Sumarokova
bd748045ad
Fix typo 2023-04-21 18:54:23 +02:00
Yakov Olkhovskiy
334b052879
Merge pull request #48873 from ClickHouse/fix-window-view-schedule
Fix unnecessary multiple rescheduling in StorageWindowView
2023-04-21 08:34:25 -04:00
Alexey Milovidov
bd64a4a6fc
Merge pull request #48904 from ClickHouse/fix_set_withzk_and_analyzer
Fix segfault when set is not built yet
2023-04-21 15:14:23 +03:00
Michael Lex
5f218353ed Add comment to explain why it's safe to assume format version 1 2023-04-21 14:01:38 +02:00
kssenii
e58c16318f Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-21 12:49:40 +02:00
robot-clickhouse-ci-1
32ac001448
Merge pull request #48838 from amosbird/issue_48735
Fix key condition on duplicate primary keys
2023-04-21 12:46:50 +02:00
Alexey Milovidov
252c755323 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-ibm 2023-04-21 12:39:13 +02:00
Alexey Milovidov
530b764953 Fix IBM 2023-04-21 12:38:45 +02:00
kssenii
0ccc3afe74 Fix 2023-04-21 12:26:28 +02:00
凌涛
797d5bbfe7 modify code 2023-04-21 18:08:14 +08:00
凌涛
de18bf72b4 modify code 2023-04-21 17:27:26 +08:00
Alexey Milovidov
8a92eb0cf1
Update src/Storages/IStorage.h 2023-04-21 11:50:07 +03:00
Kruglov Pavel
9749448eb0
Merge pull request #47229 from Avogar/non-blocking-connect
Improve async reading from socket
2023-04-21 10:38:50 +02:00
kssenii
88784568dc Better 2023-04-20 23:24:04 +02:00
kssenii
6edb61015d Fix style check 2023-04-20 19:35:49 +02:00
kssenii
0a34f3bcea Merge remote-tracking branch 'upstream/master' into randomize-fs-read-settings 2023-04-20 19:04:01 +02:00
kssenii
6552ec6afc Small improvement 2023-04-20 18:15:09 +02:00
Yakov Olkhovskiy
d34ee81be6 use Poco::Timestamp() instead of std::time 2023-04-20 14:36:54 +00:00
kssenii
59211c490a More correct accounting of limits 2023-04-20 15:43:14 +02:00
alesapin
d8e6c6ab88
Merge pull request #48731 from ClickHouse/limit_mutations_per_entry
Limit the number of mutations commands per `MUTATE_PART` entry
2023-04-20 15:05:46 +02:00
kssenii
ec1370b2ed Fix 2023-04-20 14:46:10 +02:00
Han Fei
6805edf9e6
Merge pull request #48850 from sichenzhao/add_alias_for_parts_name
add aliases for parts name and names
2023-04-20 13:04:11 +02:00
Vladimir C
ad516d2349
Merge pull request #48795 from ClickHouse/vdimir/fix-cluster-discovery-47176 2023-04-20 11:56:07 +02:00
Kseniia Sumarokova
9e481f5faa
Merge pull request #48845 from kssenii/fix-data-race-in-rabbitmq
Fix data race in StorageRabbitMQ
2023-04-20 11:43:18 +02:00
vdimir
d6416a1321 Store clusters from ClusterDiscovery in separate map 2023-04-19 16:44:54 +02:00
kssenii
323caae3c0 Fix 2023-04-19 16:29:38 +02:00
Kruglov Pavel
2ad161d2b7
Merge branch 'master' into non-blocking-connect 2023-04-19 13:39:40 +02:00
larryluogit
5fc7a489ae
Merge branch 'master' into noParquet 2023-04-18 21:17:00 -04:00
Igor Nikonov
d5eb65b5ea Remove redundant narrowPipe() 2023-04-18 22:41:28 +00:00
Igor Nikonov
2455334009 Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages 2023-04-18 21:42:51 +00:00
Alexander Gololobov
f7fe747ddc Fix segfault 2023-04-18 16:30:58 +02:00
kssenii
16b027ed0c Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-18 16:25:08 +02:00
kssenii
59459cb287 Fix test 2023-04-18 15:54:36 +02:00
Anton Popov
c06b580890
Merge pull request #48844 from CheSema/wait_loading_parts
fix the race wait loading parts
2023-04-18 14:58:20 +02:00
kssenii
67d695580a Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-18 12:42:25 +02:00
Larry Luo
b929547ab2 fix build without parquet 2023-04-17 21:37:32 -07:00
凌涛
a975211185 add more tests 2023-04-18 10:26:35 +08:00
Yakov Olkhovskiy
55389def04
use Poco::Timestamp() instead of std::time 2023-04-17 19:29:02 -04:00
Nikita Mikhaylov
c04d632373 Fix style 2023-04-18 00:22:52 +02:00
Alexander Gololobov
ba5ca15c40
Merge pull request #46835 from ClickHouse/reduce_mem_in_mutation_with_subquery
Reduce memory consumption by mutations with big subqueries used with IN
2023-04-17 23:55:08 +02:00
Robert Schulze
d658305554
Merge pull request #47693 from azat/stringstream-INT_MAX
Fix crash for uploading parts which size is greater then INT_MAX to S3
2023-04-17 23:08:56 +02:00
alesapin
ca8f3a10b0
Update src/Storages/StorageReplicatedMergeTree.cpp 2023-04-17 20:20:39 +02:00
kssenii
cd25d61795 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-17 19:47:43 +02:00
robot-clickhouse-ci-2
45f4a5f74c
Merge pull request #47964 from ClickHouse/fast-parquet
Read Parquet files faster
2023-04-17 19:27:38 +02:00
kssenii
1322ad53b8 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-17 18:22:21 +02:00
Michael Lex
51c9ae05fb Fix unexpected part name error when trying to drop a ignored detache partition with zero copy replication
Before this fix, the integration test failed with this error

E           Code: 233. DB::Exception: Received from 172.22.0.9:9000. DB::Exception: Unexpected part name: ignored_all_0_0_0 for format version: 1. Stack trace:
E
E           0. /home/ubuntu/clickhouse/contrib/llvm-project/libcxx/include/exception:134: std::exception::capture() @ 0x19bc7d02 in /usr/bin/clickhouse
E           1. /home/ubuntu/clickhouse/contrib/llvm-project/libcxx/include/exception:112: std::exception::exception[abi:v15000]() @ 0x19bc7ccd in /usr/bin/clickhouse
E           2. /home/ubuntu/clickhouse/base/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(String const&, int) @ 0x3194fae0 in /usr/bin/clickhouse
E           3. /home/ubuntu/clickhouse/src/Common/Exception.cpp:89: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x2268ae6e in /usr/bin/clickhouse
E           4. /home/ubuntu/clickhouse/src/Common/Exception.h:54: DB::Exception::Exception(String&&, int, bool) @ 0x19bbb00a in /usr/bin/clickhouse
E           5. /home/ubuntu/clickhouse/src/Common/Exception.h:81: DB::Exception::Exception<String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&>(int, FormatStringHelperImpl<std::type_identity<String const&>::type, std::type_identity<StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&>::type>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>&) @ 0x2c4f318c in /usr/bin/clickhouse
E           6. /home/ubuntu/clickhouse/src/Storages/MergeTree/MergeTreePartInfo.cpp:23: DB::MergeTreePartInfo::fromPartName(String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x2c4f0867 in /usr/bin/clickhouse
E           7. /home/ubuntu/clickhouse/src/Storages/StorageReplicatedMergeTree.cpp:8305: DB::(anonymous namespace)::getParentLockedBlobs(std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, String const&, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>, Poco::Logger*) @ 0x2bca90f7 in /usr/bin/clickhouse
2023-04-17 15:57:41 +00:00
kssenii
b77e9c1ef0 Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-17 16:44:10 +02:00
kssenii
d2c73a5522 Better 2023-04-17 16:41:21 +02:00
Sichen Zhao
eb4c26d81f add aliases for parts name and names 2023-04-17 13:18:40 +00:00
凌涛
d1a14900ea remove unused h 2023-04-17 20:26:31 +08:00
凌涛
7ed4c413e3 add settings allow_suspicious_indices 2023-04-17 20:23:19 +08:00
kssenii
0b62354261 Fix data race, refactor 2023-04-17 13:40:53 +02:00
Amos Bird
97d27c87a6
Fix key condition on duplicate primary keys
Fix key condition usage when encountering duplicate primary keys. This can happen in projections. This bug was introduced in https://github.com/ClickHouse/ClickHouse/pull/45686.

This PR is also an optimization because we don't need to create unused FieldRefs anymore.
2023-04-17 19:13:42 +08:00
Sema Checherinda
daa55ae0d2 fix the race wait loading parts 2023-04-17 13:01:28 +02:00
Kseniia Sumarokova
8bc0a3a899
Merge pull request #48759 from kssenii/fix-mysql-named-collection
Fix some settings of mysql dictionary with named collection
2023-04-17 11:18:04 +02:00
Azat Khuzhin
f5c3f3a4ab Remove quirk for s3_max_single_part_upload_size (when it exceed INT_MAX)
Reverts: #48816
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-17 10:49:55 +02:00
Michael Kolupaev
473f212c82 Hopefully fix assertion failure in CachedOnDiskReadBufferFromFile 2023-04-17 04:58:32 +00:00
Michael Kolupaev
87be78e6de Better 2023-04-17 04:58:32 +00:00
Michael Kolupaev
e133633359 Parallel decoding with one row group per thread 2023-04-17 04:58:32 +00:00
Michael Kolupaev
683077890f Highly questionable refactoring (getInputMultistream() nonsense) 2023-04-17 04:58:32 +00:00
Michael Kolupaev
2d4fe85513 Something 2023-04-17 04:58:32 +00:00
Kseniia Sumarokova
54f660bd4f
Merge pull request #48805 from kssenii/simplify-cache-factory
Simplify FileCacheFactory
2023-04-16 19:47:01 +02:00
robot-ch-test-poll1
69cac0a788
Merge pull request #48816 from ClickHouse/fix-s3
Prevent a bug in AWS S3
2023-04-16 14:46:02 +02:00
Alexey Milovidov
8e0b1eae69
Update StorageS3Settings.cpp 2023-04-16 08:53:52 +03:00
Igor Nikonov
908ad29106 Do not parallelize output for zeroes() 2023-04-15 22:14:18 +00:00
Alexey Milovidov
1174f4dcbe Prevent a bug in AWS S3 2023-04-15 23:56:49 +02:00
Alexey Milovidov
7f620bf852 Fix double whitespace in exception message 2023-04-15 23:54:10 +02:00
kssenii
0517de58d1 Simplify FileCacheFactory 2023-04-15 16:15:20 +02:00
Igor Nikonov
8603807b57 Use generic way to parallelize output for file()
+ disable parallelization for storage Null
2023-04-15 12:35:24 +00:00
Igor Nikonov
60dbb7b406 Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages 2023-04-14 20:11:51 +00:00
Igor Nikonov
9e92c26d53 Fix test_storage_mysql/test.py::test_settings_connection_wait_timeout 2023-04-14 20:10:57 +00:00
Alexander Gololobov
a7b05589b6 Caches for multiple mutations 2023-04-14 16:12:19 +02:00
Alexander Gololobov
7a381e9232 Added enable_sharing_sets_for_mutations setting 2023-04-14 16:12:18 +02:00
Alexander Gololobov
633aaa73aa Use use_index_for_in_with_subqueries_max_values setting to limit sizes of sets used in KeyCondition 2023-04-14 16:12:18 +02:00
Alexander Gololobov
28d0cc974a Cleanups 2023-04-14 16:12:18 +02:00
Alexander Gololobov
adbe87e9d3 Fixes 2023-04-14 16:12:18 +02:00
Alexander Gololobov
0b9579bfb8 Reworked, testing 2023-04-14 16:12:18 +02:00
Alexander Gololobov
02876ed87d Share PreparedSet-s between task of the same mutation to reduce mem usage 2023-04-14 16:12:18 +02:00
Dmitry Novik
352a240a20
Merge pull request #47984 from ClickHouse/optimize-compilation
Optimize compilation
2023-04-14 15:34:46 +02:00
Alexander Tokmakov
de9dc2b0b3
Merge branch 'master' into limit_mutations_per_entry 2023-04-14 15:19:08 +03:00
Igor Nikonov
7c84dc48c6 Better way to define for which storage output is parallelized 2023-04-14 12:00:02 +00:00
Kseniia Sumarokova
9eee7c72fe
Merge pull request #47307 from kssenii/better-tests-for-data-lakes
deltalake/iceberg/hudi improvements
2023-04-14 12:13:17 +02:00
Kseniia Sumarokova
6a0d9a37ce
Merge branch 'master' into fix-mysql-named-collection 2023-04-14 12:03:51 +02:00
Igor Nikonov
267cd097bf
Merge pull request #48729 from ClickHouse/fix-memory-order-in-number_mt
Fix memory order in number_mt
2023-04-13 23:57:36 +02:00
Kseniia Sumarokova
54518bf928
Merge branch 'master' into better-tests-for-data-lakes 2023-04-13 23:45:12 +02:00
Igor Nikonov
fa6346008a Merge remote-tracking branch 'origin/master' into parallel-processing-from-storages 2023-04-13 20:55:18 +00:00
Igor Nikonov
fcd2eaea72 Disable 'Dictionary' storage due to count() can return incorrect result
see test_dictionaries_redis/test_long.py::test_redis_dict_long
2023-04-13 20:23:59 +00:00
Robert Schulze
43b8cbc50c
Merge pull request #48737 from ClickHouse/rs/fix-wshadow
Remove `-Wshadow` suppression which leaked into global namespace
2023-04-13 21:18:50 +02:00
Alexander Tokmakov
af1bf08663
Revert "Add MemoryTracker for the background tasks" 2023-04-13 21:05:02 +03:00
kssenii
ad48e1d010 Fox 2023-04-13 19:36:25 +02:00
Alexander Tokmakov
8d207e8752 Merge branch 'master' into limit_mutations_per_entry 2023-04-13 18:13:44 +02:00
Dmitry Novik
5cc9b46f78 Merge remote-tracking branch 'origin/master' into optimize-compilation 2023-04-13 16:04:09 +02:00
kssenii
6f53784f22 Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes 2023-04-13 15:56:40 +02:00